[edk2-devel] [PATCH edk2 v1 0/1] Fix a infrequent issue in variable

2020-06-28 Thread Ming Huang via groups.io
https://bugzilla.tianocore.org/show_bug.cgi?id=2667 Ming Huang (1): MdeModulePkg/Variable: Move FindVariable after AutoUpdateLangVariable MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 26 ++-- 1 file changed, 13 insertions(+), 13 deletions(-) -- 2.8.1 -=-=-=-=-=-

[edk2-devel] [PATCH edk2 v1 1/1] MdeModulePkg/Variable: Move FindVariable after AutoUpdateLangVariable

2020-06-28 Thread Ming Huang via groups.io
When occur reclaim in AutoUpdateLangVariable(), the CurrPtr of Variable is invalid. The State will be update with wrong position after UpdateVariable in this situation and two valid PlatformLang or Lang variables will exist. BmForEachVariable() will enter endless loop while exist two valid Platform

Re: [edk2-devel] [PATCH] MdeModulePkg/PartitionDxe: Seperate the Udf handler

2020-06-28 Thread Gao, Zhichao
> -Original Message- > From: Ni, Ray > Sent: Monday, June 29, 2020 10:42 AM > To: Gao, Zhichao ; Laszlo Ersek ; > devel@edk2.groups.io > Cc: Wu, Hao A ; Wang, Jian J ; > Gao, Liming > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/PartitionDxe: Seperate the Udf > handler > > > > > --

Re: [edk2-devel] [RFC edk2 v1 0/1] Fix a infrequent issue in variable

2020-06-28 Thread Ming Huang via groups.io
Hi Guomin, Ok, I will send patch out today. Thanks, Ming 在 2020/6/29 11:03, Jiang, Guomin 写道: > Hi Huang, > > Could you send the normal patch rather than RFC? > > Best Regards > Guomin > >> -Original Message- >> From: devel@edk2.groups.io On Behalf Of Ming >> Huang >> Sent: Monday, M

Re: [edk2-devel] [PATCH] FmpDevicePkg: Enhance capsule verification with secure boot keys

2020-06-28 Thread Guomin Jiang
I think it have some vulnerability, the case as below. 1. Untrusted End User enroll the new DB key -> sign the untrusted device firmware -> flash the untrusted device firmware -> the system will become unsafe. I think the end user is untrusted and we need to make sure only few person can have

Re: [edk2-devel] [RFC edk2 v1 0/1] Fix a infrequent issue in variable

2020-06-28 Thread Guomin Jiang
Hi Huang, Could you send the normal patch rather than RFC? Best Regards Guomin > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ming > Huang > Sent: Monday, May 25, 2020 7:34 PM > To: devel@edk2.groups.io; Wang, Jian J ; Wu, Hao A > ; Gao, Liming > Cc: lidongz...@huawei.c

Re: [edk2-devel] [PATCH] MdeModulePkg/PartitionDxe: Seperate the Udf handler

2020-06-28 Thread Ni, Ray
> -Original Message- > From: Gao, Zhichao > Sent: Monday, June 29, 2020 9:47 AM > To: Laszlo Ersek ; Ni, Ray ; > devel@edk2.groups.io > Cc: Wu, Hao A ; Wang, Jian J ; > Gao, Liming > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/PartitionDxe: Seperate the > Udf handler > > Hi Laszlo,

Re: [edk2-devel] [PATCH v3 01/15] PcAtChipsetPkg: Add MMIO Support to RTC driver

2020-06-28 Thread Guomin Jiang
Hi Ard, When build MinPlatform, it will show Edk2Platforms/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c:34:1: error: conflicting types for ‘GetPciSegmentInfo’ Could you confirm it? Thanks Guomin > -Original Message- > From: devel@edk2.grou

Re: [edk2-devel] [patch V2] MdeModulePkg/DisplayEngine: Add Debug message to show mismatch menu info

2020-06-28 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Bi, Dandan > Sent: Sunday, June 28, 2020 10:17 AM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Dong, Eric ; > Laszlo Ersek > Subject: [patch V2] MdeModulePkg/DisplayEngine: Add Debug message to > show mismatch menu info > > REF: htt

Re: [edk2-devel] [PATCH] MdeModulePkg/PartitionDxe: Seperate the Udf handler

2020-06-28 Thread Gao, Zhichao
Hi Laszlo, Sorry, I didn't put the detail info about the issue. Let me descript here. The issue is not only for Red Hat. I found it with ubuntu 18.02 amd64 and Fedora-20-x86_64 ISO image as well. I didn't view all the linux iso images. Here is the issue: Using USB CD ROM with the linux ISO DVD.

Re: [edk2-devel] [PATCH v4 13/17] PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml: Add configuration for Ecc check

2020-06-28 Thread Guomin Jiang
Good work. Reviewed-by: Guomin Jiang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Zhang, > Shenglei > Sent: Monday, June 15, 2020 4:49 PM > To: devel@edk2.groups.io > Cc: Ni, Ray > Subject: [edk2-devel] [PATCH v4 13/17] > PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml: Add con

Re: [edk2-devel] [PATCH v4 08/17] FatPkg/FatPkg.ci.yaml: Add configuration for Ecc check

2020-06-28 Thread Guomin Jiang
Good work. Reviewed-by: Guomin Jiang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Zhang, > Shenglei > Sent: Monday, June 15, 2020 4:49 PM > To: devel@edk2.groups.io > Cc: Ni, Ray > Subject: [edk2-devel] [PATCH v4 08/17] FatPkg/FatPkg.ci.yaml: Add > configuration for E

Re: [edk2-devel] [PATCH v4 09/17] FmpDevicePkg/FmpDevicePkg.ci.yaml: Add configuration for Ecc check

2020-06-28 Thread Guomin Jiang
Good work. Reviewed-by: Guomin Jiang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Zhang, > Shenglei > Sent: Monday, June 15, 2020 4:49 PM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Kinney, Michael D > > Subject: [edk2-devel] [PATCH v4 09/17] > FmpDevicePkg/FmpDevi

Re: [edk2-devel] [PATCH v4 06/17] CryptoPkg/CryptoPkg.ci.yaml: Add configuration for Ecc check

2020-06-28 Thread Guomin Jiang
Good work. Reviewed-by: Guomin Jiang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Zhang, > Shenglei > Sent: Monday, June 15, 2020 4:49 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Lu, XiaoyuX > > Subject: [edk2-devel] [PATCH v4 06/17] CryptoPkg/CryptoPkg.ci.yaml

Re: [edk2-devel] [PATCH 1/1] IntelFsp2Pkg/Tools/GenCfgOpt.py: Fix a bug about parse macro

2020-06-28 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Tan, Ming > Sent: Sunday, June 28, 2020 2:54 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [PATCH 1/1] IntelFsp2Pkg/Tools/GenCfgOpt.py: Fix a bug about parse > macro > > REF: ht

Re: [edk2-devel] [PATCH] IntelFsp2Pkg/FspSecCore: Use UefiCpuLib.

2020-06-28 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Dong, Eric > Sent: Saturday, June 27, 2020 9:52 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [PATCH] IntelFsp2Pkg/FspSecCore: Use UefiCpuLib. > > REF: https://bugzilla.tianocor

Re: [edk2-devel] [PATCH] BaseTools/build.py: Exit with 1 when AutoGen error occurred

2020-06-28 Thread Yuwei Chen
Reivewed-by: Yuwei Chen > -Original Message- > From: devel@edk2.groups.io On Behalf Of Irene > Park > Sent: Wednesday, June 3, 2020 5:59 AM > To: devel@edk2.groups.io > Cc: Irene Park > Subject: [edk2-devel] [PATCH] BaseTools/build.py: Exit with 1 when AutoGen > error occurred > > From:

Re: [edk2-devel] [PATCH v3 0/4] Compile AML bytecode array into OBJ file

2020-06-28 Thread PierreGondois
Hello Bob, The PR729 didn't pass the PatchCheck for the patch adding the LF line endings to the script in BaseTools/BinWrappers/PosixLike, this is for the patch named "BaseTools: Rename AmlToHex script to AmlToC" (cf the following link: https://dev.azure.com/tianocore/edk2-ci/_build/results?buil

Re: [edk2-devel] [PATCH v6 1/4] PcAtChipsetPkg: PcAtChipsetPkg.dsc add UefiCpuLib LibraryClass

2020-06-28 Thread Dong, Eric
Hi Guomin, Laszlo & Garrett, Because both UefiCpuLib and FspSecCoreT / FspSecCoreM both define InitializeFloatingPointUnits API. So this build issue been reported. I have submit a patch to remove InitializeFloatingPointUnits in FspSecCoreT / FspSecCoreM, https://edk2.groups.io/g/devel/message/6

Re: [edk2-devel] [PATCH v6 1/4] PcAtChipsetPkg: PcAtChipsetPkg.dsc add UefiCpuLib LibraryClass

2020-06-28 Thread Guomin Jiang
Hi Laszlo, The step to reproduce as below: 1. add below change diff --git a/IntelFsp2Pkg/IntelFsp2Pkg.dsc b/IntelFsp2Pkg/IntelFsp2Pkg.dsc index 26cd3da43c3f..d43cb5be6472 100644 --- a/IntelFsp2Pkg/IntelFsp2Pkg.dsc +++ b/IntelFsp2Pkg/IntelFsp2Pkg.dsc @@ -62,7 +62,10 @@ [Components] IntelFsp2Pkg/

Re: [edk2-devel] [PATCH v3 0/4] Compile AML bytecode array into OBJ file

2020-06-28 Thread Bob Feng
Hi Pierre, I met a problem when I push your patch set. If I change the CRLF to a unix format EOL, the patch can't pass PatchCheck.py. If I don't change the CRLF, The build on Linux will fail. So I can't make the patch set pass the CI. Could you share me how did you do to make your PR 729 pass?

Re: [edk2-devel] [PATCH V2] MdePkg: Add Serial Terminal Device Type Guid

2020-06-28 Thread Zhiguang Liu
Hi Oleksiy, If you build OVMF with your code change, it will report one error: error 3000: Invalid GUID value format gEfiSerialTerminalDeviceTypeGuid = { 0x6AD9A60F, 0x5815, 0x4C7C, { 0x08A, 0x10, 0x50, 0x53, 0xD2, 0xBF, 0x7A, 0x1B }} ( = ) This is because you use "0x08A" instead of "0x