Hi, Michael
This patch looks good. While I have a little format suggestion: the Bugzilla
link "https://bugzilla.tianocore.org/show_bug.cgi?id=2797"; could be written as
"REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2797";.
Reviewed-by: Yuwei Chen
Thanks,
Yuwei
> -Original Message--
Reviewed-by: Eric Dong
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Tan,
> Ming
> Sent: Monday, June 15, 2020 10:04 AM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH 1/1 v2] MdeModulePkg/StatusCodeHandler:
> do not output \n\r for string data
>
> REF: https:
Reviewed-by: Eric Dong
> -Original Message-
> From: Tan, Ming
> Sent: Friday, June 12, 2020 11:41 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Gao, Liming
> Subject: [PATCH v6] Features/Intel/BeepDebugFeaturePkg: add it.
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2792
Reviewed-by: Eric Dong
> -Original Message-
> From: Tan, Ming
> Sent: Friday, June 12, 2020 11:41 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Gao, Liming
> Subject: [PATCH v3] Features/Intel/PostCodeDebugFeaturePkg: add it.
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2780
The timezone of following cities should be updated:
Istanbul: UTC+3
Novosibirsk: UTC+7
Georgetown (Guyana): UTC-4
Signed-off-by: Dorapika Wu
Reviewed-by: Zhichao Gao
---
.../UefiShellLevel2CommandsLib.uni | 12 +
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2787
When output string data through serial port, will not ouput \n\r now.
Caller can output several data in one line, and output \n\r when needed.
Signed-off-by: Ming Tan
---
V2: Make it as a standalone patch.
.../Universal/StatusCodeHandler/
> May I suggest that we start with variable support on the secure side? It
> should be quite straight-forward to expose part of the secure NOR flash
> bank via the existing MM stack for variable services that I ported to
> SynQuacer last year.
>
Thank you for your comment, I will check the secure
https://bugzilla.tianocore.org/show_bug.cgi?id=2801
Add the UT_EXPECT_ASSERT_FAILURE(FunctionCall, Status) macro
to the UnitTestLib that can be used to check if a function
under test triggers an ASSERT() condition. If an ASSERT()
condition is triggered, then the macro returns. If the
ASSERT() co
https://bugzilla.tianocore.org/show_bug.cgi?id=2800
Add a new version of BaseLib that is safe for use from host based
unit test applications. Host based unit test applications may need
to provide implementations of some BaseLib functions that provide
simple emulation to exercise the code under te
https://bugzilla.tianocore.org/show_bug.cgi?id=2804
Optionally enable a feature to support source level debug of a
host based unit test. By default, this feature is disabled.
Exceptions are caught by the unit test framework and are
interpreted as a test failure.
When a unit test is under develop
https://bugzilla.tianocore.org/show_bug.cgi?id=2801
Add UnitTestDebugAssertLib that provides the UnitTestDebugAssert()
service and the gUnitTestExpectAssertFailureJumpBuffer global
variable. This NULL library is linked against all host and target
unit test builds. This guarantees that the UnitTe
https://bugzilla.tianocore.org/show_bug.cgi?id=2797
https://bugzilla.tianocore.org/show_bug.cgi?id=2798
https://bugzilla.tianocore.org/show_bug.cgi?id=2799
https://bugzilla.tianocore.org/show_bug.cgi?id=2800
https://bugzilla.tianocore.org/show_bug.cgi?id=2801
https://bugzilla.tianocore.org/show_bug
https://bugzilla.tianocore.org/show_bug.cgi?id=2806
Update the log messages generated in target mode to use
FileName instead of FunctionName. FunctionName is an empty
string so the log messages generated do not provide enough
information to know the source of a unit test failure.
Using FileName
https://bugzilla.tianocore.org/show_bug.cgi?id=2801
Update DebugLib.h _ASSERT() macro to check if unit testing
is enabled and call UnitTestDebugAssert() instead of
DebugAssert() so the an ASSERT() condition that is triggered
by a function under test can be handled by the Unit Test
Framework.
If E
https://bugzilla.tianocore.org/show_bug.cgi?id=2801
The default DebugLib for target mode was DebugLibNull. This
library instance disables all ASSERT() and DEBUG() macros
which removes the ability to write unit tests that check for
ASSERT() behaviors.
The DebugLib is changed to PeiDxeDebugLibRepo
https://bugzilla.tianocore.org/show_bug.cgi?id=2800
https://bugzilla.tianocore.org/show_bug.cgi?id=2799
https://bugzilla.tianocore.org/show_bug.cgi?id=2798
Update the default unit test library mappings to use the
library instances from the MdePkg that are safe for host
based unit tests.
Cc: Sean
https://bugzilla.tianocore.org/show_bug.cgi?id=2801
Add samples using UT_EXPECT_ASSERT_FAILURE() for both positive
test cases where the ASSERT() is triggered and detected correctly
and negative test cases where an ASSERT() is never triggered.
These new test cases also generate passing test result
https://bugzilla.tianocore.org/show_bug.cgi?id=2799
The services in CacheMaintenanceLib usually generate exceptions in a
unit test host application. Provide a Null instance that can be safely
used.
This Null instance can also be used as a template for implementing
new instances of CacheMaintenan
https://bugzilla.tianocore.org/show_bug.cgi?id=2803
The UEFI Specification defines the minimum stack size before
ExitBootServices() to be 128KB. When running a host based unit
test, there may be additional stack overhead from the host
application environment and cmocka.
Update the build flags to
https://bugzilla.tianocore.org/show_bug.cgi?id=2805
If a unit test fails with an exception or an assert, then the
CmockaUnitTestFunctionRunner() is terminated and the logic
that follows the invocation of the unit test is skipped. This
currently skips the logic that prints log messages.
Move the
https://bugzilla.tianocore.org/show_bug.cgi?id=2797
Update HOST_APPLICATION module type to use NULL library instances.
Cc: Bob Feng
Cc: Liming Gao
Cc: Sean Brogan
Cc: Bret Barkelew
Cc: Jiewen Yao
Signed-off-by: Michael D Kinney
---
BaseTools/Source/Python/Workspace/WorkspaceCommon.py | 4 +
https://bugzilla.tianocore.org/show_bug.cgi?id=2800
Break out the IA32/X64 GCC inline functions that can not be used
in a unit test host application into their own source file. This
does not make any changes to the BaseLib library instance. This
is in preparation for a new BaseLib instances that
https://bugzilla.tianocore.org/show_bug.cgi?id=2798
The services in CpuLib usually generate exceptions in a unit test
host application. Provide a Null instance that can be safely used.
This Null instance can also be used as a template for implementing
new instances of CpuLib.
Cc: Liming Gao
Cc
Acked-by: Jiewen Yao
I hope GCC expert can review this and double confirm.
Thank you
Yao Jiewen
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Ard
> Biesheuvel
> Sent: Wednesday, June 10, 2020 4:18 PM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Kinney, Michael D
>
Acked-by: Jiewen Yao
I hope ARM expert can review this to double confirm.
Thank you
Yao Jiewen
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Ard
> Biesheuvel
> Sent: Wednesday, June 10, 2020 4:18 PM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Kinney, Michael D
>
Reviewed-by: Jiewen Yao
> -Original Message-
> From: Ard Biesheuvel
> Sent: Wednesday, June 10, 2020 4:18 PM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Kinney, Michael D
> ; Gao, Liming ; Yao,
> Jiewen ; Sami Mujawar ;
> Ilias Apalodimas
> Subject: [PATCH 3/5] StandaloneMmPkg/Cor
Reviewed-by: Jiewen Yao
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Ard
> Biesheuvel
> Sent: Wednesday, June 10, 2020 4:18 PM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Kinney, Michael D
> ; Gao, Liming ; Yao,
> Jiewen ; Sami Mujawar ;
> Ilias Apalodimas
> Subj
27 matches
Mail list logo
