Re: [edk2-devel] [PATCH edk2-platforms 01/16] Silicon/NXP/NxpQoriqLs.dec: Add PCIe related PCDs.

On 5/24/20 8:31 PM, Wasim Khan (OSS) wrote: -Original Message- From: Ard Biesheuvel Sent: Friday, May 22, 2020 2:42 PM To: Wasim Khan (OSS) ; devel@edk2.groups.io; Meenakshi Aggarwal ; Vabhav Sharma ; Varun Sethi ; l...@nuviainc.com; j...@solid-run.com Cc: Wasim Khan Subject: Re: [PA

Re: [edk2-devel] [edk2][PATCH 1/1] NetworkPkg/HttpBootDxe: handle servers which may FIN after file sizing in HttpBootLoadFile

Hi Maciej, Thanks for your analysis. The way I see it, there are many people out there expecting HttpBoot to work with the Python server - which without manual hacking is HTTP/1.0 and not HTTP/1.1. I think it's fine to reject 1.0 but then HttpBoot should explicitly reject 1.0 with an appropria

Re: [edk2-devel] OVMF gdb seems to require "stone knives and bearskins" to debug code?

I may not have the full context here... actually, I'm sure I don't. I am incidentally the original author of the DebugPkg python script[1], but if I understood correctly, it was picked up by a number of different folks over the years and possibly evolved separately... I certainly don't remember

Re: [edk2-devel] [PATCH 3/3] OvmfwPkg: Don't exclude XCODE Modules

> On May 25, 2020, at 12:31 PM, Laszlo Ersek wrote: > > Hi Andrew, > > On 05/24/20 23:20, Andrew Fish via groups.io wrote: >> With this BZ getting fixed we no longer need to special case XCODE. >> >> Cc: Ard Biesheuvel >> Cc: Jiewen Yao >> Cc: Jordan Justen >> Cc: Phili

Re: [edk2-devel] OVMF gdb seems to require "stone knives and bearskins" to debug code?

> On May 25, 2020, at 7:19 PM, Rebecca Cran wrote: > > On 5/24/20 9:30 PM, Andrew Fish via groups.io wrote: > >> I could open source an lldb symbolication Python script and I'm happy to >> explain the common logic to some one to make it easier to port this lldb >> command [3] to gdb. The c

Re: [edk2-devel] OVMF gdb seems to require "stone knives and bearskins" to debug code?

On 5/24/20 9:30 PM, Andrew Fish via groups.io wrote: I could open source an lldb symbolication Python script and I'm happy to explain the common logic to some one to make it easier to port this  lldb command [3] to gdb. The command can load symbols for any address that is located in a loaded P

[edk2-devel] Upcoming Event: TianoCore Bug Triage - APAC / NAMO - Tue, 05/26/2020 6:30pm-7:30pm #cal-reminder

*Reminder:* TianoCore Bug Triage - APAC / NAMO *When:* Tuesday, 26 May 2020, 6:30pm to 7:30pm, (GMT-07:00) America/Los Angeles *Where:* https://bluejeans.com/889357567?src=join_info View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=816009 ) *Organizer:* Brian Richardson brian.richar

Re: [edk2-devel] [PATCH v3 00/14] Add the VariablePolicy feature

Hi Kubacki, I am reviewing the patch series, I will need 2 weeks to review it and will comment it after review it. Best Regards Guomin > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Friday, May 22, 2020 6:43 AM > To: devel@edk2.groups.io > Cc:

Re: [edk2-devel] [RFC edk2 v1 1/1] MdeModulePkg/Variable: Move FindVariable after AutoUpdateLangVariable

Hi Huangming, I am taking the bugzilla and I am sorry that I haven't provide you with productive comment. I am still busy until August. I just want to know that: 1. Have you verified that the symptom will disappear after invoked FindVariable() function? 2. Is it your suggestion that the FindVa

Re: [edk2-devel] Updating to latest EDK2 and now get NMAKE: fatal error U1073: Don't know how to make.. on some items?

Hi David, I saw the below error, but those file can be found in my local repo, build: : warning: Module MetaFile [Sources] is missing local header! Local Header: c:\edk\edk2-libc\stdlib\libc\gdtoa\gdtoaimp.h not found in c:\edk\edk2-libc\StdLib\LibC\gdtoa\gdtoa.inf build: : warning: Module Me

Re: [edk2-devel] Updating to latest EDK2 and now get NMAKE: fatal error U1073: Don't know how to make.. on some items?

> On May 25, 2020, at 1:51 PM, Michael D Kinney > wrote: > > Hi David, > > You do need to update to latest tools_def.txt, target.txt, and > build_rules.txt. > Which means delete those files in Conf/ and rerun edksetup.bat/edksetup.sh to copy them over from BaseTools/Conf/*.template files th

Re: [edk2-devel] OVMF gdb seems to require "stone knives and bearskins" to debug code?

> On May 25, 2020, at 12:15 PM, Laszlo Ersek wrote: > > (+Rebecca, +Andrei) > > On 05/25/20 05:30, Andrew Fish via groups.io wrote: >> The full Star Trek quote from Spock is: " I am endeavoring, ma'am, to >> construct a mnemonic memory circuit using stone knives and bearskins.", but >> I r

Re: [edk2-devel] Updating to latest EDK2 and now get NMAKE: fatal error U1073: Don't know how to make.. on some items?

Hi David, You do need to update to latest tools_def.txt, target.txt, and build_rules.txt. I also recommend you use VS2015, 2017, or VS2019 and let us know what issues you see after these 2 changes. Mike From: devel@edk2.groups.io On Behalf Of David F. Sent: Monday, May 25, 2020 12:56 AM To: d

Re: [edk2-devel] [PATCH 3/3] OvmfwPkg: Don't exclude XCODE Modules

Hi Andrew, On 05/24/20 23:20, Andrew Fish via groups.io wrote: > With this BZ getting fixed we no longer need to special case XCODE. > > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Philippe Mathieu-Daudé > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=557 > Signed-off-

Re: [edk2-devel] OVMF gdb seems to require "stone knives and bearskins" to debug code?

(+Rebecca, +Andrei) On 05/25/20 05:30, Andrew Fish via groups.io wrote: > The full Star Trek quote from Spock is: " I am endeavoring, ma'am, to > construct a mnemonic memory circuit using stone knives and bearskins.", but I > ran across this [1], and it felt like "stone knives and bearskins." v

Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

> On May 25, 2020, at 11:10 AM, Laszlo Ersek wrote: > > Hi Andrew, > > On 05/25/20 06:09, Andrew Fish wrote: > >> I also found I had to Bing/Google to find the detailed instructions I >> needed as a developer, as the Wiki seems to assume you just know the >> Linux kernel patch process. That

[edk2-devel] [PATCH edk2-platforms 1/1] Silicon/SynQuacer: use correct argument count for _EVT ACPI method

The _EVT method on the ACPI0013 Generic Event device takes a single argument. Even though we are not interested in its value (given that there is only one interrupt source), we still have to declare the prototype correctly, or the OS might complain and refuse to call it. Signed-off-by: Ard Biesheu

Re: [edk2-devel] [FIXUPS edk2-platforms 0/3] SbsaQemu layout changes and minor cleanup

Thank you Leif. Looks good to me. Reviewed-by: Radoslaw Biernacki sob., 23 maj 2020 o 01:39 Leif Lindholm napisał(a): > > The SbsaQemu platform port has been in flight for a long time now, > so to facilitate getting it merged, here is a set of proposed layout > changes and minor tweaks that I w

Re: [edk2-devel] [PATCH edk2-platforms 09/16] Silicon/NXP: Implement PciSegmentLib for PCIe Layerscape Controller

> -Original Message- > From: Jon Nettleton > Sent: Monday, May 25, 2020 10:00 AM > To: Wasim Khan (OSS) > Cc: Ard Biesheuvel ; devel@edk2.groups.io; > Meenakshi Aggarwal ; Vabhav Sharma > ; Varun Sethi ; > l...@nuviainc.com > Subject: Re: [PATCH edk2-platforms 09/16] Silicon/NXP: Implem

[edk2-devel] [RFC edk2 v1 0/1] Fix a infrequent issue in variable

https://bugzilla.tianocore.org/show_bug.cgi?id=2667 Ming Huang (1): MdeModulePkg/Variable: Move FindVariable after AutoUpdateLangVariable MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 26 ++-- 1 file changed, 13 insertions(+), 13 deletions(-) -- 2.8.1 -=-=-=-=-=-=

[edk2-devel] [RFC edk2 v1 1/1] MdeModulePkg/Variable: Move FindVariable after AutoUpdateLangVariable

When occur reclaim in AutoUpdateLangVariable(), the CurrPtr of Variable is invalid. The State will be update with wrong position after UpdateVariable in this situation and two valid PlatformLang or Lang variables will exist. BmForEachVariable() will enter endless loop while exist two valid Platform

[edk2-devel] Updating to latest EDK2 and now get NMAKE: fatal error U1073: Don't know how to make.. on some items?

Hi, I haven't updated the edk2 in quite a while, I went ahead and did it tonight, stdlib was removed so I had to move stuff around.  Where I used to have C:\EDK2, I now have C:\EDK\EDK2 and C:\EDK\EDK2-CLIB.   My private directory is still under C:\EDK\EDK2\Acme.   After figuring out how to get

[edk2-devel] BuildTools Broken

Last night through the forums I sent a problem with NMAKE U1073 trying to build. Some things built fine, but not others. I think my original message with all the details is still awaiting moderation. To follow up on that. I simply renamed BaseTools and restored the other one I had before updatin

Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

Hi Andrew, On 05/25/20 06:09, Andrew Fish wrote: > I also found I had to Bing/Google to find the detailed instructions I > needed as a developer, as the Wiki seems to assume you just know the > Linux kernel patch process. That feels like an area we can improve. (apologies if I've lost context; p

Re: [EXTERNAL] Re: [edk2-devel] [PATCH v3 05/14] OvmfPkg: Add VariablePolicy engine to OvmfPkg platform

Hi Bret, On 05/23/20 00:35, Bret Barkelew wrote: > 'Maybe you entirely missed my message that I posted in response to > version 2 of this specific patch (i.e. you may have fully missed the > message I link at the top). That could be the case because I mentioned > "OvmfXen.dsc" under the v2 blurb a

Re: [edk2-devel] Hard Feature Freeze starts now for edk2-stable202005

Hi Bret, On 05/22/20 17:11, Bret Barkelew wrote: > We’d like to ask that this patch be considered for the stable tag: > [PATCH v1 1/1] UnitTestFrameworkPkg/UnitTestResultReportLib: Use > AsciiStrnCpyS() > https://bugzilla.tianocore.org/show_bug.cgi?id=2721 > > The patch was reviewed prior to the

Re: [edk2-devel] [PATCH v8 36/46] OvmfPkg/ResetVector: Add support for a 32-bit SEV check

Tom, On 05/19/20 23:51, Lendacky, Thomas wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 > > During BSP startup, the reset vector code will issue a CPUID instruction > while in 32-bit mode. When running as an SEV-ES guest, this will trigger > a #VC exception. > > Add exception han

Re: [edk2-devel] [PATCH v8 34/46] OvmfPkg: Reserve a page in memory for the SEV-ES usage

On 05/19/20 23:51, Lendacky, Thomas wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 > > Reserve a fixed area of memory for SEV-ES use and set a fixed PCD, > PcdSevEsWorkAreaBase, to this value. > > This area will be used by SEV-ES support for two purposes: > 1. Communicating th

Re: [edk2-devel] [PATCH v8 31/46] OvmfPkg: Create GHCB pages for use during Pei and Dxe phase

On 05/19/20 23:50, Lendacky, Thomas wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 > > Allocate memory for the GHCB pages and the per-CPU variable pages during > SEV initialization for use during Pei and Dxe phases. The GHCB page(s) > must be shared pages, so clear the encryption

Re: [edk2-devel] [PATCH v8 29/46] OvmfPkg: Create a GHCB page for use during Sec phase

On 05/19/20 23:50, Lendacky, Thomas wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 > > A GHCB page is needed during the Sec phase, so this new page must be > created. Since the #VC exception handler routines assume that a per-CPU > variable area is immediately after the GHCB, thi

Re: [edk2-devel] [PATCH v8 26/46] OvmfPkg/VmgExitLib: Add support for DR7 Read/Write NAE events

On 05/19/20 23:50, Lendacky, Thomas wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 > > Under SEV-ES, a DR7 read or write intercept generates a #VC exception. > The #VC handler must provide special support to the guest for this. On > a DR7 write, the #VC handler must cache the val

Re: [edk2-devel] [PATCH 1/1] BaseTools: Turn on Link Time Optimization (LTO) for XCOODE

On 5/25/20 4:38 AM, Andrew Fish via groups.io wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1202 > > Turn on LTO for XCODE. Typo "XCOODE" in subject. If you want to keep it, I wont object :) > > We need to pass -object_path_lto to the linker to keep source > level debugging worki

Re: [edk2-devel] [FIXUPS edk2-platforms 0/3] SbsaQemu layout changes and minor cleanup

On 5/23/20 1:39 AM, Leif Lindholm wrote: > The SbsaQemu platform port has been in flight for a long time now, > so to facilitate getting it merged, here is a set of proposed layout > changes and minor tweaks that I would prefer to have included. > > I also propose changing the commit message as fo

Re: [edk2-devel] [FIXUPS edk2-platforms 1/3] Silicon/Qemu: mirror Platform layout

On 5/23/20 1:39 AM, Leif Lindholm wrote: > Platform/Qemu is empty, apart from the SbsaQemu dirctory, which holds Typo dirctory -> directory. > SbsaQemu.dsc and SbsaQemu.fdf. Silicon/Qemu held Drivers, Library and > a file called SbsaQemuPkg.dec. Move them all into a subdirectory called > SbsaQemu

Re: [edk2-devel] [edk2][PATCH 1/1] NetworkPkg/HttpBootDxe: handle servers which may FIN after file sizing in HttpBootLoadFile

Copying my comments from Bugzilla: I have gone through the Wireshark trace that you have provided. It seems to be all clear now and the approach to the issue must change. HttpBootDxe supports HTTP 1.1 and assumes that the HTTP session stays persistent (single TCP connection for multiple reques

Re: [edk2-devel] [edk2][PATCH 1/1] HttpBoot: handle servers which may FIN after file sizing in HttpBootLoadFile

Copying my comments from Bugzilla: I have gone through the Wireshark trace that you have provided. It seems to be all clear now and the approach to the issue must change. HttpBootDxe supports HTTP 1.1 and assumes that the HTTP session stays persistent (single TCP connection for multiple reques