Re: [edk2-devel] [PATCH V6 12/13] CryptoPkg/opensslconf.h: Covert the file ending to dos format

2020-05-17 Thread Xiaoyu Lu
Hi Zhicao, Library/Include/openssl/opensslconf.h is generated by OpenSSL and copied by process_files.pl. I think it should be changed through process_files.pl. Thanks, Xiaoyu > -Original Message- > From: Gao, Zhichao > Sent: Friday, May 15, 2020 12:40 PM > To: devel@edk2.gro

Re: [EXTERNAL] Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

2020-05-17 Thread Rebecca Cran
On 5/15/20 1:34 AM, Laszlo Ersek wrote: On 05/14/20 23:26, Bret Barkelew via groups.io wrote: It’s code management for the Instagram generation I find this an extremely good characterization! And, I find the fact soul-destroying. I was working on a web project recently, and apparently pe

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Fixed submodule attribute in pin files

2020-05-17 Thread Nate DeSimone
Pushed: 4d8b3dbe > -Original Message- > From: devel@edk2.groups.io On Behalf Of Bjorge, > Erik C > Sent: Saturday, May 16, 2020 5:37 PM > To: devel@edk2.groups.io > Cc: Desimone, Ashley E ; Desimone, > Nathaniel L ; Pandya, Puja > ; Bret Barkelew ; > Agyeman, Prince > Subject: [edk2-deve

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Fixed submodule attribute in pin files

2020-05-17 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: devel@edk2.groups.io On Behalf Of Bjorge, > Erik C > Sent: Saturday, May 16, 2020 5:37 PM > To: devel@edk2.groups.io > Cc: Desimone, Ashley E ; Desimone, > Nathaniel L ; Pandya, Puja > ; Bret Barkelew ; > Agyeman, Prince > Subject:

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Pass a ManifestXML to find_project_in_all_indices

2020-05-17 Thread Nate DeSimone
Pushed: 66daf5ee > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ashley E > Desimone > Sent: Friday, May 15, 2020 5:19 PM > To: devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Pandya, Puja > ; Bjorge, Erik C ; Bret > Barkelew ; Agyeman, Prince > > Subject: [edk2-devel]

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Pass a ManifestXML to find_project_in_all_indices

2020-05-17 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ashley E > Desimone > Sent: Friday, May 15, 2020 5:19 PM > To: devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Pandya, Puja > ; Bjorge, Erik C ; Bret > Barkelew ; Agyeman, Prince > > Subject: [e

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Improve clone error handling.

2020-05-17 Thread Nate DeSimone
Pushed: f8ded3c3 > -Original Message- > From: Desimone, Ashley E > Sent: Friday, May 15, 2020 4:44 PM > To: devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Pandya, Puja > ; Bjorge, Erik C ; Bret > Barkelew ; Agyeman, Prince > > Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Improve

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Improve clone error handling.

2020-05-17 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Desimone, Ashley E > Sent: Friday, May 15, 2020 4:44 PM > To: devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Pandya, Puja > ; Bjorge, Erik C ; Bret > Barkelew ; Agyeman, Prince > > Subject: [edk2-staging/EdkRepo] [PATCH] EdkRep

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 0/2] Manifest parser line ending cleanup and small bug fixes

2020-05-17 Thread Nate DeSimone
Pushed: 8934d383~..c438460f > -Original Message- > From: Bjorge, Erik C > Sent: Friday, May 15, 2020 2:43 PM > To: devel@edk2.groups.io > Cc: Desimone, Ashley E ; Desimone, > Nathaniel L ; Pandya, Puja > ; Bret Barkelew ; > Agyeman, Prince > Subject: [edk2-staging/EdkRepo] [PATCH v1 0/2]

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 0/2] Manifest parser line ending cleanup and small bug fixes

2020-05-17 Thread Nate DeSimone
For the series... Reviewed-by: Nate DeSimone > -Original Message- > From: Bjorge, Erik C > Sent: Friday, May 15, 2020 2:43 PM > To: devel@edk2.groups.io > Cc: Desimone, Ashley E ; Desimone, > Nathaniel L ; Pandya, Puja > ; Bret Barkelew ; > Agyeman, Prince > Subject: [edk2-staging/EdkR

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH V2] EdkRepo: Only process the checkout command if a valid combo is used

2020-05-17 Thread Nate DeSimone
Pushed: 102fd2e2 > -Original Message- > From: Desimone, Ashley E > Sent: Thursday, May 14, 2020 5:30 PM > To: devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Pandya, Puja > ; Bjorge, Erik C ; Bret > Barkelew ; Agyeman, Prince > > Subject: [edk2-staging/EdkRepo] [PATCH V2] EdkRepo: Onl

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH V2] EdkRepo: Only process the checkout command if a valid combo is used

2020-05-17 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Desimone, Ashley E > Sent: Thursday, May 14, 2020 5:30 PM > To: devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Pandya, Puja > ; Bjorge, Erik C ; Bret > Barkelew ; Agyeman, Prince > > Subject: [edk2-staging/EdkRepo] [PATCH V2] E

Re: [edk2-devel] [PATCH] Edk2-Platform/Maintainers.txt: Add Eric as Reviewer for MinPlatformPkg.

2020-05-17 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Dong, Eric > Sent: Friday, May 15, 2020 12:53 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > > Subject: [PATCH] Edk2-Platform/Maintainers.txt: Add Eric as Reviewer for > MinPlatformPkg. > > Signed-off-b

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Fixed incorrect commit template warnings

2020-05-17 Thread Bjorge, Erik C
The repo name was being passed in instead of the path the repo. This caused all commit templates to be flagged as warnings. Cc: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman Cc: Erik Bjorge Signed-off-by: Erik Bjorge --- edkrepo/commands/sync_com

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Silicon/Socionext/SynQuacer: use Generic Event Device for power button

2020-05-17 Thread Ard Biesheuvel
On 5/15/20 10:00 PM, Andrei Warkentin wrote: I've not tested this, but it looks good. You wouldn't happen to have a capsule handy that I or others could try? BTW I have incorporated this patch and the NetSec ones I sent out yesterday (to fix the annoying 5s freeze at boot) here: http://sna