Yes that looks better.
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Samer
> El-Haj-Mahmoud
> Sent: Thursday, May 14, 2020 11:55 PM
> To: Ni, Ray ; devel@edk2.groups.io; Kinney, Michael D
>
> Cc: Leif Lindholm ; Ard Biesheuvel
> Subject: Re: [edk2-devel] [edk2-platfor
Oleksiy:
When create PR, I find some issue in this patch. The same issue is also in
SignedCapsulePkg. Because original comments from Xu Wei6, I would like Wei to
provide the updated patch for MdeModulePkg and SignedCapsulePkg.
Thanks
Liming
> -Original Message-
> From: Oleksiy Yakovlev
I just realized my solution doesn't cover some scenarios:
1. SMM
2. S3 boot path
3. CapsuleX64
If we want to hook #29 in all scenarios, your way
directly modifying CpuExceptionHandlerLib is the
easiest way because RegisterInterruptHandler() is supported
only in DXE/SMM case.
There is no way to use
sure I will.
> -Original Message-
> From: Gao, Liming
> Sent: Friday, May 15, 2020 12:57 PM
> To: Ni, Ray ; devel@edk2.groups.io; oleks...@ami.com
> Cc: Kinney, Michael D ; fel...@ami.com;
> rob...@ami.com
> Subject: RE: [edk2-devel] [PATCH 5/5] MdePkg: Update structures for
> MpService
Ray:
I see
https://github.com/tianocore/edk2-staging/commit/2409b787fa196780e0fd101b2ad706575f82e2fc
also includes the code change in UefiCpuPkg/Library/MpInitLib/MpLib.c. The
change has passed review.
Can you send the separate patch for the change in UefiCpuPkg?
Thanks
Liming
> -Ori
Agreed. Responsibility to verify the commit message when squashing is always
something to be aware of.
With Github, the one who presses the “Close and Merge” (or whatever it’s
called) button has the final say on the title and message. We can play with
approaches to how the squash merge would wo
Reviewed-by: Jian J Wang
Regards,
Jian
> -Original Message-
> From: Gao, Zhichao
> Sent: Friday, May 15, 2020 12:40 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Lu, XiaoyuX ;
> Fu, Siyuan ; Kinney, Michael D
> ; Yao, Jiewen ; Gao,
> Liming
> Subject: [PATCH V6 12/13] CryptoPkg/
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898
Convert file ending of the crypto created openssl config file -
opensslconf.h from '\n' to '\r\n' to make align the line ending and
pass the patch check.
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Siyuan Fu
Cc: Michael D Kinney
Cc: Jiewen Yao
C
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898
The binary is totally changed, so update the Crypto Version to 7:
1. Retire below deprecated function:
MD4, ARC4, TDES, AES ECB MODE, HMAC MD5, HMAC SHA1
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Siyuan Fu
Cc: Michael D Kinney
Cc: Jiewen Yao
C
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898
HMAC MD5 is not secure any longer.
Remove the HMAC MD5 support from edk2.
Change the HMAC MD5 field name in EDKII_CRYPTO_PROTOCOL to indicate the
function is unsupported any longer.
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Siyuan Fu
Cc: Michael
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898
HMAC SHA1 is not secure any longer.
Remove the HMAC SHA1 support from edk2.
Change the HMAC SHA1 field name in EDKII_CRYPTO_PROTOCOL to indicate the
function is unsupported any longer.
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Siyuan Fu
Cc: Mich
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898
ARC4 is not secure any longer.
Remove the ARC4 support from edk2.
Change the ARC4 field name in EDKII_CRYPTO_PROTOCOL to indicate the
function is unsupported any longer.
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Siyuan Fu
Cc: Michael D Kinney
C
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898
This patch is create by adding the setting "no_des" of
process_files.pl and running it thru perl.
It would remove the TDES from OpensslLib.
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Siyuan Fu
Cc: Michael D Kinney
Cc: Jiewen Yao
Cc: Philippe Ma
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898
Add a internal worker function to indicate the deprecated functions.
It would print out debug messages and asserts to inform the consumer
they are using a deprecated function.
Change the Name of BaseCryptLibServciceNotEnabled to correct spel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898
MD4 is not secure any longer.
Remove the MD4 support from edk2.
Change the MD4 field name in EDKII_CRYPTO_PROTOCOL to indicate the
function is unsupported any longer.
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Siyuan Fu
Cc: Michael D Kinney
Cc:
Retire below deprecated functions:
MD4, ARC4, TDES, AES ECB MODE, HMAC MD5, HMAC SHA1.
V2:
Seprate the MD5 and SHA1 changes to other patch set.
Change the deprecated function wrapper implementatuion in
EDKII_CRYPTO_PROTOCOL to call a dummy function to print debug
message and assert.
V3:
Remove th
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898
This patch is create by adding the setting "no_rc4" of
process_files.pl and running it thru perl.
It would remove the ARC4 from OpensslLib.
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Siyuan Fu
Cc: Michael D Kinney
Cc: Jiewen Yao
Cc: Philippe Ma
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898
Add the unrequired aes_ecb files in process_files.pl and run it
thru perl.
It would remove the unrequired aes_ecb files from OpensslLib inf.
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Siyuan Fu
Cc: Michael D Kinney
Cc: Jiewen Yao
Cc: Philippe M
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898
This patch is create by adding the setting "no_md4" of
process_files.pl and running it thru perl.
It would remove the MD4 from OpensslLib.
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Siyuan Fu
Cc: Michael D Kinney
Cc: Jiewen Yao
Cc: Philippe Mat
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898
TDES is not secure any longer.
Remove the Tdes support from edk2.
Change the Tdes field name in EDKII_CRYPTO_PROTOCOL to indicate the
function is unsupported any longer.
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Siyuan Fu
Cc: Michael D Kinney
C
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898
Aes Ecb mode is not secure any longer.
Remove the Aes Ecb mode support from edk2.
Change the Aes Ecb mode field name in EDKII_CRYPTO_PROTOCOL to indicate the
function is unsupported any longer.
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Siyuan Fu
Reviewed-by: Liming Gao
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Xu, Wei6
> Sent: Friday, May 15, 2020 9:51 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Gao, Liming
> ; Sean Brogan
>
> Subject: [edk2-devel] [PATCH V4 0/5] FmpDevicePkg: Move capsule depe
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2696
This library provides services to evaluate Fmp capsule dependency
expression, validate dependency expression and get dependency
from firmware image.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Sean Brogan
Signed-off-by: Wei6 Xu
Reviewed-by:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2696
* This library class provides platform specific services to support
dependency check during updating firmware image. Platform can perform
dependency check in platform specific manner by implementing its own
FmpDependencyCheckLib.
* Add FmpDe
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2696
* Add unit tests for EvaluateDependency API in FmpDependencyLib.
* Add Test/FmpDeviceHostPkgTest.dsc to build host based unit test.
* Update FmpDevicePkg.dsc to build target based unit test.
* Update FmpDevicePkg.ci.yaml to build and run hos
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2696
This library provides firmware device specific services to support
saving dependency to firmware device and getting dependency from
firmware device.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Sean Brogan
Signed-off-by: Wei6 Xu
Reviewed-by:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2696
Remove the orginal Fmp Capsule Dependency implement, and use new
FmpDependencyLib, FmpDependencyCheckLib and FmpDependencyDeviceLib
APIs instead.
A platform can perform the dependency check in a platform specific
manner by implementing its o
v4:
- Remove the CONST in ValidateDependency API to keep APIs common.
v3:
- Refine description and comments of API: EvaluateDependency(),
GetFmpDependency(), CheckFmpDependency().
- Remove the check on the dependencies coming from other FMP instances.
v2:
- Remove API GetDependencySize in FmpDepe
Bret,
If the original submission is a single patch, and the code review
generates changes that are added as additional patches for review,
but the intent in the end is still a single patch, then squashing
them all at the end is correct.
Using the GitHub feature to squash them is a challenge becau
Reviewed-by: Michael D Kinney
Mike
> -Original Message-
> From: michael.kuba...@outlook.com
>
> Sent: Tuesday, April 21, 2020 11:35 AM
> To: devel@edk2.groups.io
> Cc: Bret Barkelew ; Sean
> Brogan ; Kinney, Michael D
>
> Subject: [PATCH v1 2/2]
> UnitTestFrameworkPkg/UnitTestLib: Upda
To keep api common please remove the CONST in ValidateDependency
function (header and c file). With that change my review applies to the
whole series.
After this stable tag it would be great to work on some documentation
for FmpDxe. This driver was already complex and has now got even more
Signed-off-by: Ashley E Desimone
Cc: Nate DeSimone
Cc: Puja Pandya
Cc: Erik Bjorge
Cc: Bret Barkelew
Cc: Prince Agyeman
---
edkrepo/commands/checkout_command.py | 20 +---
edkrepo/commands/humble/checkout_humble.py | 10 ++
2 files changed, 23 insertions(+), 7 d
Hi Ashley,
Please update the copyright year on checkout_command.py
Also, please see additional comments inline.
Thanks,
Nate
> -Original Message-
> From: Desimone, Ashley E
> Sent: Wednesday, May 13, 2020 3:33 PM
> To: devel@edk2.groups.io
> Cc: Desimone, Nathaniel L ; Pandya, Puja
> ;
BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//Groups.io Inc//Groups.io Calendar//EN
METHOD:CANCELLED
CALSCALE:GREGORIAN
BEGIN:VEVENT
UID:a96o.1589500755615437001.r...@groups.io
DTSTAMP:20200515T52Z
ORGANIZER;CN=devel@edk2.groups.io Group:mailto:devel@edk2.groups.io
DTSTART:20200514T16Z
DTEND:202005
Pushed: 78a9765d
> -Original Message-
> From: Desimone, Ashley E
> Sent: Tuesday, May 12, 2020 11:45 AM
> To: devel@edk2.groups.io
> Cc: Desimone, Nathaniel L ; Pandya, Puja
> ; Bjorge, Erik C ; Bret
> Barkelew ; Agyeman, Prince
>
> Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Update
Pushed: 589dbc0a
> -Original Message-
> From: Desimone, Ashley E
> Sent: Monday, May 11, 2020 10:18 AM
> To: devel@edk2.groups.io
> Cc: Desimone, Nathaniel L ; Pandya, Puja
> ; Bjorge, Erik C ; Bret
> Barkelew ; Agyeman, Prince
>
> Subject: [edk2-staging/EdkRepo] [PATCH V2] EdkRepo: Add
Reviewed-by: Nate DeSimone
> -Original Message-
> From: Desimone, Ashley E
> Sent: Tuesday, May 12, 2020 11:45 AM
> To: devel@edk2.groups.io
> Cc: Desimone, Nathaniel L ; Pandya, Puja
> ; Bjorge, Erik C ; Bret
> Barkelew ; Agyeman, Prince
>
> Subject: [edk2-staging/EdkRepo] [PATCH] EdkR
Reviewed-by: Nate DeSimone
> -Original Message-
> From: Desimone, Ashley E
> Sent: Monday, May 11, 2020 10:18 AM
> To: devel@edk2.groups.io
> Cc: Desimone, Nathaniel L ; Pandya, Puja
> ; Bjorge, Erik C ; Bret
> Barkelew ; Agyeman, Prince
>
> Subject: [edk2-staging/EdkRepo] [PATCH V2] Ed
Reviewed-by: Michael D Kinney
Mike
> -Original Message-
> From: Jiang, Guomin
> Sent: Monday, April 13, 2020 6:33 PM
> To: devel@edk2.groups.io
> Cc: kuqin ; Kinney, Michael D
> ; Sean Brogan
> ; Bret Barkelew
>
> Subject: [PATCH v2] UnitTestFrameworkPkg/UnitTestLib:
> Correct dereferr
Pushed: 4ae181e1
> -Original Message-
> From: Desimone, Ashley E
> Sent: Monday, May 11, 2020 9:20 AM
> To: devel@edk2.groups.io
> Cc: Desimone, Nathaniel L ; Pandya, Puja
> ; Bjorge, Erik C ; Bret
> Barkelew ; Agyeman, Prince
>
> Subject: [edk2-staging/EdkRepo] [PATCH V2] EdkRepo: Updat
Reviewed-by: Nate DeSimone
> -Original Message-
> From: Desimone, Ashley E
> Sent: Monday, May 11, 2020 9:20 AM
> To: devel@edk2.groups.io
> Cc: Desimone, Nathaniel L ; Pandya, Puja
> ; Bjorge, Erik C ; Bret
> Barkelew ; Agyeman, Prince
>
> Subject: [edk2-staging/EdkRepo] [PATCH V2] Edk
v3:
- Refine description and comments of API: EvaluateDependency(),
GetFmpDependency(), CheckFmpDependency().
- Remove the check on the dependencies coming from other FMP instances.
v2:
- Remove API GetDependencySize in FmpDependencyLib.
- Correct comments in FmpDependencyLib unit test; Correct th
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2696
* This library class provides platform specific services to support
dependency check during updating firmware image. Platform can perform
dependency check in platform specific manner by implementing its own
FmpDependencyCheckLib.
* Add FmpDe
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2696
This library provides firmware device specific services to support
saving dependency to firmware device and getting dependency from
firmware device.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Sean Brogan
Signed-off-by: Wei6 Xu
---
FmpDevi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2696
Remove the orginal Fmp Capsule Dependency implement, and use new
FmpDependencyLib, FmpDependencyCheckLib and FmpDependencyDeviceLib
APIs instead.
A platform can perform the dependency check in a platform specific
manner by implementing its o
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2696
* Add unit tests for EvaluateDependency API in FmpDependencyLib.
* Add Test/FmpDeviceHostPkgTest.dsc to build host based unit test.
* Update FmpDevicePkg.dsc to build target based unit test.
* Update FmpDevicePkg.ci.yaml to build and run hos
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2696
This library provides services to evaluate Fmp capsule dependency
expression, validate dependency expression and get dependency
from firmware image.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Sean Brogan
Signed-off-by: Wei6 Xu
---
FmpDevi
On 5/14/20 3:26 PM, Bret Barkelew via groups.io wrote:
I feel like this process is a good compromise. It’s not perfect (frankly, I’m a
fan of enforced squash merges, which can maintain bisectability if managed
well), but it allows for rapid iteration, ease of contribution, and approaches
the
I feel like this process is a good compromise. It’s not perfect (frankly, I’m a
fan of enforced squash merges, which can maintain bisectability if managed
well), but it allows for rapid iteration, ease of contribution, and approaches
the workflow that many who have never used email to maintain a
Reviewed-by: Erik Bjorge
-Original Message-
From: Desimone, Ashley E
Sent: Monday, May 11, 2020 9:20 AM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Pandya, Puja
; Bjorge, Erik C ; Bret
Barkelew ; Agyeman, Prince
Subject: [edk2-staging/EdkRepo] [PATCH V2] EdkRepo: Update lis
Leif, Ray,
I have not seen any discussion on this thread since March(!)...
Please see my comments below.
> -Original Message-
> From: r...@edk2.groups.io On Behalf Of Ni, Ray via
> Groups.Io
> Sent: Wednesday, March 25, 2020 1:15 AM
> To: r...@edk2.groups.io; l...@nuviainc.com; devel@e
Add bitmask to structure which gives a binary-inspectable mechanism to
determine if a capsule contains an authentication section or depex section.
(UEFI 2.8 errata a, mantis 2026)
Signed-off-by: Oleksiy Yakovlev
Reviewed-by: Liming Gao
---
MdePkg/Include/Guid/FmpCapsule.h | 11 ++-
1 f
Define Guid & data structure for EFI_RT_PROPERTIES_TABLE, designed
to be published by a platform if it no longer supports all EFI
runtime services once ExitBootServices() has been called by the OS.
(UEFI 2.8 errata a, mantis 2049)
Signed-off-by: Oleksiy Yakovlev
Reviewed-by: Liming Gao
---
Mde
Some OUT parameters in the specification were mistakenly marked as IN OUT.
"IN OUT" replaced with "OUT" in the following interfaces
EFI_BOOT_SERVICES.GetMemoryMap():MemoryMap
EFI_BOOT_SERVICES.LocateHandleBuffer():NoHandles
EFI_SIMPLE_POINTER_PROTOCOL.GetState():State
EFI_ABSOLUTE_POINTER_PROTOCOL
Add SEA, SEI, and PEI CPER Notification types defined in UEFI 2.8 errata a.
(UEFI 2.8 errata a, mantis 2026)
Signed-off-by: Oleksiy Yakovlev
Reviewed-by: Liming Gao
---
MdePkg/Include/Guid/Cper.h | 15 +++
MdePkg/MdePkg.dec | 9 +
2 files changed, 24 insertions(+)
Add bitmask to structure which gives a binary-inspectable mechanism to
determine if a capsule contains an authentication section or depex section.
(UEFI 2.8 errata a, mantis 2026)
Signed-off-by: Oleksiy Yakovlev
Reviewed-by: Wei6 Xu
Reviewed-by: Chao Zhang
---
.../RecoveryModuleLoadPei/Recove
Add bitmask to structure which gives a binary-inspectable mechanism to
determine if a capsule contains an authentication section or depex section.
(UEFI 2.8 errata a, mantis 2026)
Signed-off-by: Oleksiy Yakovlev
Reviewed-by: Wei6 Xu
---
MdeModulePkg/Application/CapsuleApp/CapsuleDump.c | 7 +
Following patches add/update structures/definitions, that were
introduced/modified by UEFI Spec v.2.8 errata a from Feb 14.
Oleksiy Yakovlev (6):
MdePkg: Add new CPER Notification types
MdePkg: Fix OUT parameters marked as IN OUT
MdePkg: Add EFI_RT_PROPERTIES_TABLE
MdePkg: Add FMP Capsule
On 5/14/20 8:59 PM, Vitaly Cheptsov via groups.io wrote:
Mike,
The code you posted may inflict undefined behaviour is not valid C for
several reasons. The compiler is free to do whatever it desires. Please
refer to ISO/IEC 9899 for more details.
If applications cast raw pointers to typed poi
Mike,
The code you posted may inflict undefined behaviour is not valid C for several
reasons. The compiler is free to do whatever it desires. Please refer to
ISO/IEC 9899 for more details.
If applications cast raw pointers to typed pointers without checking their
alignment, well, god bless the
> On May 14, 2020, at 12:47 PM, Sean wrote:.
>
> Is there interest in setting it up to "consume" edk2 as is rather than be a
> fork?
I’m not sure if we’ll switch to having edk2 be a submodule, but I intend to
keep master be the same as upstream master, and regularly integrate changes
into
Rebecca,
I think hosting open platforms outside the tianocore org is great too.
This gives the maintainers even more freedom to run their own project
and this scenario is actually how nearly all edk2 consumers do it.
Today, edk2 just doesn't have the infrastructure to allow them to report
bac
On 5/14/20 11:48 AM, Sean Brogan wrote:
Adding another platform to a core repository that might or might not
work at any given time is a burden to all core contributors and
doesn't bring value to the core project.
The direction I would like to see is a new repo created at
github.com/tianocor
On 5/14/20 8:10 AM, Ni, Ray wrote:
> Tom,
Hi Ray,
> I just discussed with original CPU owner Jeff and went through how IDT is
> setup in the boot flow.
> Here is what I think you can do to avoid modifying the CpuExceptionHandlerLib.
> 1. SecPlatformMain() modifies IDT[29] to point to your VC han
Vitaly,
Why do you think there is no way to craft an odd address
without memory corruption.
UINT8 ByteArray[100];
CHAR16 *String
String = (CHAR16 *)(&Array[3]);
The reason I raised the question of these other ASSERT()s
is that I thought the use case was using these safe string
APIs from a U
I really don't agree with this direction.
Adding another platform to a core repository that might or might not
work at any given time is a burden to all core contributors and doesn't
bring value to the core project.
The direction I would like to see is a new repo created at
github.com/tianoc
Mike,
Firstly, NULL check and odd-address checks are essentially different things:
— NULL address is basically «no object», «optional argument» (e.g. failed
allocation).
— Odd address is memory corruption, as there is no way to craft such address
anyhow else.
For this reason the implementation i
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054
Runtime checks returned via status return code should not work as
assertions to permit parsing not trusted data with SafeString
interfaces.
CC: Andrew Fish
CC: Ard Biesheuvel
CC: Bret Barkelew
CC: Brian J. Johnson
CC: Chasel Chiu
CC: J
CC: Andrew Fish
CC: Ard Biesheuvel
CC: Bret Barkelew
CC: Brian J. Johnson
CC: Chasel Chiu
CC: Jordan Justen
CC: Laszlo Ersek
CC: Leif Lindholm
CC: Liming Gao
CC: Marvin Häuser
CC: Mike Kinney
CC: Vincent Zimmer
CC: Zhichao Gao
V7 addressed review comments (only documentation changes).
On 5/14/20 6:05 PM, Laszlo Ersek wrote:
On 05/14/20 14:17, Ard Biesheuvel wrote:
On 5/14/20 2:12 PM, Laszlo Ersek wrote:
On 05/14/20 11:29, Ard Biesheuvel wrote:
On 5/14/20 10:40 AM, Sami Mujawar wrote:
Kvmtool is a virtual machine manager that enables
hosting KVM guests. It essentially provi
On 5/14/20 11:22 AM, Ard Biesheuvel wrote:
Hi Sami,
On 5/14/20 10:40 AM, Sami Mujawar wrote:
Some device drivers perform copy operations on
device memory, e.g. device drivers for a Flash
device. On some architectures unaligned access
to device memory regions is not permitted. To
add to this if
On 05/14/20 15:48, Roman Bolshakov wrote:
> OVMF booting stops with the assert if built with Xcode on macOS:
>
> Loading driver at 0x0001FAB8000 EntryPoint=0x0001FABF249
> LinuxInitrdDynamicShellCommand.efi
> InstallProtocolInterface: BC62157E-3E33-4FEC-9920-2D3B36D750DF 1F218398
> ProtectUe
You don't need do more. I will help merge this patch set.
> -Original Message-
> From: Robert Phelps
> Sent: Friday, May 15, 2020 12:36 AM
> To: Gao, Liming ; devel@edk2.groups.io; Oleksiy
> Yakovlev
> Cc: Kinney, Michael D ; Felix Polyudov
>
> Subject: RE: [edk2-devel] [PATCH v2 0/5
Why preserve the ASSERT()s for an a Unicode strings
that are not aligned in a 16-bit boundary?
This is essentially the same as an invalid pointer value
just like NULL. If NULL pointer returns an error code,
shouldn't and invalid pointer value?
Thanks,
Mike
> -Original Message-
> From:
Sami,
This does not seem right to me.
BaseMemoryLib is for memory operations.
IoLib for I/O port and MMIO operations.
The IoLib already supports aligned buffer read/write
APIs for MMIO. Why can’t the exiting IoLib APIs be
used for this use case.
MmioReadBuffer8()
MmioReadBuffer16()
Mmio
Sami,
Can the combination of BasePciLibPciExpress and BasePciExpressLib
be used for this use case?
Mike
> -Original Message-
> From: Sami Mujawar
> Sent: Thursday, May 14, 2020 1:40 AM
> To: devel@edk2.groups.io
> Cc: Sami Mujawar ;
> ard.biesheu...@arm.com; l...@nuviainc.com; Kinney,
>
> On May 14, 2020, at 4:24 AM, Laszlo Ersek wrote:
>
> - The community not having any human resources permanently dedicated to
> bhyve regressions (testing, review, and post factum fixing) is fine, as
> long as the bhyve stakeholders can live with a matching frequency of
> regressions.
Yes, I
On 05/14/20 14:17, Ard Biesheuvel wrote:
> On 5/14/20 2:12 PM, Laszlo Ersek wrote:
>> On 05/14/20 11:29, Ard Biesheuvel wrote:
>>> On 5/14/20 10:40 AM, Sami Mujawar wrote:
Kvmtool is a virtual machine manager that enables
hosting KVM guests. It essentially provides an
emulated platfo
Any consensus on this? I can just rename AsixPkg.dsc/fdf to Asix.dsc/fdf (with
a matching PLATFORM_NAME ) if that is more consistent
> -Original Message-
> From: Ni, Ray
> Sent: Monday, May 11, 2020 1:18 AM
> To: Samer El-Haj-Mahmoud ;
> devel@edk2.groups.io; Kinney, Michael D
> Cc: Le
Leif,
Thanks for the review. Most of these are cosmetic changes that I will take care
of in v2. There are a couple that may require some experiments to figure out
what works and what breaks.
> -Original Message-
> From: Leif Lindholm
> Sent: Tuesday, May 12, 2020 9:23 AM
> To: Samer
> -Original Message-
> From: Leif Lindholm
> Sent: Tuesday, May 12, 2020 9:03 AM
> To: Samer El-Haj-Mahmoud
> Cc: devel@edk2.groups.io; Ray Ni ; Ard Biesheuvel
> ; Michael D Kinney
>
> Subject: Re: [edk2-platform][PATCH v1 3/4] Silicon/AsixPkg: Add ASIX
> Ax88179 driver
>
> On Sun, May
OVMF booting stops with the assert if built with Xcode on macOS:
Loading driver at 0x0001FAB8000 EntryPoint=0x0001FABF249
LinuxInitrdDynamicShellCommand.efi
InstallProtocolInterface: BC62157E-3E33-4FEC-9920-2D3B36D750DF 1F218398
ProtectUefiImageCommon - 0x1F218140
- 0x1FAB8000 -
There was a mistake in all previous v here.
I took it from original ECR and misted correction.
Now it is up to spec.
Regards, Oleksiy.
-Original Message-
From: Jiang, Guomin [mailto:guomin.ji...@intel.com]
Sent: Wednesday, May 13, 2020 11:43 PM
To: devel@edk2.groups.io; Oleksiy Yakovlev
C
Hi Ray,
I read your comment from gitk.
I understand why you changed them to 1998 and 2097.
May I know why we don't read the Century value from CMOS in the beginning?
Some boards does not support? Or the RTC address may be different for
different boards?
Regards
Kai Yau
-Original Messa
Hi,
The current logic has two limitations:
1. it has to be 100 years apart (already mentioned in DEC file)
2. the century numbers have to be same in order to work. (19XX, 20XX will not
work) (20xx, 21xx will not work)
Since now is 2020, the value has to be 2000, 2099. But BIOS developers does no
On Wed, May 13, 2020 at 12:23:33PM +0200, Laszlo Ersek wrote:
> On 05/12/20 22:58, Roman Bolshakov wrote:
> > OVMF booting stops with the assert if built with Xcode on macOS:
> >
> > Loading driver at 0x0001FAB8000 EntryPoint=0x0001FABF249
> > LinuxInitrdDynamicShellCommand.efi
> > InstallPro
BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//Groups.io Inc//Groups.io Calendar//EN
METHOD:CANCELLED
CALSCALE:GREGORIAN
BEGIN:VEVENT
UID:g7lq.1578029159272351097.u...@groups.io
DTSTAMP:20200514T133840Z
ORGANIZER;CN=Ray Ni:mailto:ray...@intel.com
DTSTART:20200515T013000Z
DTEND:20200515T023000Z
SUMMARY:Tiano
On 05/14/20 11:25, Vitaly Cheptsov wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054
>
> Runtime checks returned via status return code should not work as
> assertions to permit parsing not trusted data with SafeString
> interfaces.
>
> CC: Andrew Fish
> CC: Ard Biesheuvel
> CC:
> -Original Message-
> From: Leif Lindholm
> Sent: Tuesday, May 12, 2020 7:15 AM
> To: Ard Biesheuvel
> Cc: Samer El-Haj-Mahmoud ;
> devel@edk2.groups.io; Ray Ni ; Michael D Kinney
>
> Subject: Re: [edk2-platform][PATCH v1 0/4] Update ASIX USB Networking
> drivers
>
> On Mon, May 11,
Hi Phil,
Not sure why this old 2019 patch suddenly appeared in your review inbox,
but this was integrated last year as
https://github.com/tianocore/edk2/commit/64a17fadcb79e2ce40524abb88a6863f47cbc0c7
Regards,
/Pete
On 2020.05.14 08:45, Philippe Mathieu-Daudé wrote:
Hi Pete,
On 2/4/19 1:4
Tom,
I just discussed with original CPU owner Jeff and went through how IDT is setup
in the boot flow.
Here is what I think you can do to avoid modifying the CpuExceptionHandlerLib.
1. SecPlatformMain() modifies IDT[29] to point to your VC handler. This step
helps to build the VC handler in whole
Thanks Nate! I have resolved below issues and pushed:
f2cdb268ef04eeec51948b5d81eeca5cab5ed9af
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Thursday, May 14, 2020 1:06 PM
> To: devel@edk2.groups.io; Chiu, Chasel
> Cc: Ma, Maurice ; Zeng, Star
> Subject: RE: [edk2-devel]
On 05/14/20 10:40, Sami Mujawar wrote:
> Kvmtool is a virtual machine manager that can be used
> to launch guest partitions. It additionally emulates
> some hardware components e.g. RTC, CFI etc. essentially
> providing an emulated virtual platform for a guest
> operating system (OS) to run.
>
> A
On 05/14/20 10:40, Sami Mujawar wrote:
> NorFlashDxe must use aligned MMIO accesses to
> read data from flash as this is device memory.
>
> The AlignedCopyMem() in NorFlashDxe was used to
> copy the flash data which prevented unaligned
> access to device memory. However, the compiler
> could optim
On 05/14/20 10:40, Sami Mujawar wrote:
> Kvmtool is a virtual machine manager that enables hosting
> KVM guests. Kvmtool emulates certain devices like serial
> port, RTC, etc. essentially providing an emulated platform.
>
> This patch adds support for kvmtool emulated platform.
>
> Following is a
On 05/14/20 14:12, Laszlo Ersek wrote:
> On 05/14/20 11:29, Ard Biesheuvel wrote:
>> On 5/14/20 10:40 AM, Sami Mujawar wrote:
>>> Kvmtool is a virtual machine manager that enables
>>> hosting KVM guests. It essentially provides an
>>> emulated platform for guest operating systems.
>>>
>>> Kvmtool h
On 05/14/20 11:32, Ard Biesheuvel wrote:
> On 5/14/20 10:40 AM, Sami Mujawar wrote:
>> Kvmtool places the base address of the CFI flash in
>> the device tree it passes to UEFI. This library
>> parses the kvmtool device tree to read the CFI base
>> address and initialise the PCDs use by the NOR flas
On 5/14/20 2:12 PM, Laszlo Ersek wrote:
On 05/14/20 11:29, Ard Biesheuvel wrote:
On 5/14/20 10:40 AM, Sami Mujawar wrote:
Kvmtool is a virtual machine manager that enables
hosting KVM guests. It essentially provides an
emulated platform for guest operating systems.
Kvmtool hands of a device tr
On 05/14/20 10:40, Sami Mujawar wrote:
> Kvmtool is a virtual machine manager that enables
> hosting KVM guests. Kvmtool allows to vary the
> hardware configuration of the emulated platform
> it provides to the guest partition. It provides
> the current hardware configuration to the firmware
> by h
On 05/14/20 11:29, Ard Biesheuvel wrote:
> On 5/14/20 10:40 AM, Sami Mujawar wrote:
>> Kvmtool is a virtual machine manager that enables
>> hosting KVM guests. It essentially provides an
>> emulated platform for guest operating systems.
>>
>> Kvmtool hands of a device tree containing the
>> current
1 - 100 of 151 matches
Mail list logo
