[edk2-devel] [edk2-staging/EdkRepo] [PATCH V2] EdkRepo: Add source_manifest_repo argument to edkrepo_command.py

2020-05-01 Thread Ashley E Desimone
Add a common definition of the source_manifest_repo argument to edkrepo_command.py to enable selection of the correct source global manifest repository by commands. Signed-off-by: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Erik Bjorge Cc: Bret Barkelew Cc: Prince Agyeman --- ed

Re: [EXTERNAL] [edk2-devel] [PATCH 4/4] UefiCpuPkg/CpuExceptionHandler: Revert binary patching in standard CpuExceptionHandlerLib

2020-05-01 Thread Bret Barkelew via groups.io
Acked-by: Bret Barkelew - Bret From: devel@edk2.groups.io on behalf of Lendacky, Thomas via groups.io Sent: Friday, May 1, 2020 1:17:41 PM To: devel@edk2.groups.io Cc: Jordan Justen ; Laszlo Ersek ; Ard Biesheuvel ; Liming Gao ; Eric Dong ; Ray Ni ; Brijes

[edk2-devel] [edk2-staging/EdkRepo] [PATCH 0/2] EdkRepo: Remove duplicate function definitions

2020-05-01 Thread Ashley E Desimone
Remove the duplicate definition of functions in common_repo_functions.py and update imports to use the definitions in workspace_maintenance.py. Signed-off-by: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Erik Bjorge Cc: Bret Barkelew Cc: Prince Agyeman Ashley E Desimone (2): Ed

[edk2-devel] [edk2-staging/EdkRepo] [PATCH 2/2] EdkRepo: Remove duplicate definitions of case_insensitive_single_match and case_insensitive_equal

2020-05-01 Thread Ashley E Desimone
Remove duplicate definitions of and update imports of case_insensitive_single_match and case_insensitive_equal to point to the definitions in workspace_maintenance.py Signed-off-by: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Erik Bjorge Cc: Bret Barkelew Cc: Prince Agyeman ---

[edk2-devel] [edk2-staging/EdkRepo] [PATCH 1/2] EdkRepo: Remove duplicate definition of generate_name_for_obsolete_backup

2020-05-01 Thread Ashley E Desimone
Remove the duplicate definition of generate_name_for_obsolete_backup from common_repo_functions.py and update imports to use the definition in workspace_maintenance.py Signed-off-by: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Erik Bjorge Cc: Bret Barkelew Cc: Prince Agyeman ---

[edk2-devel] [PATCH 1/4] UefiCpuPkg/CpuExceptionHandler: Make XCODE5 changes toolchain specific

2020-05-01 Thread Lendacky, Thomas
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2340 Commit 2db0ccc2d7fe ("UefiCpuPkg: Update CpuExceptionHandlerLib pass XCODE5 tool chain") introduced binary patching into the exception handling support. CPU exception handling is allowed during SEC and this results in binary patching of flash

[edk2-devel] [PATCH 0/4] XCODE5 toolchain binary patching fix

2020-05-01 Thread Lendacky, Thomas
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2340 Commit 2db0ccc2d7fe ("UefiCpuPkg: Update CpuExceptionHandlerLib pass XCODE5 tool chain") introduced binary patching in the ExceptionHandlerAsm.nasm in order to support the XCODE5 toolchain. However, the CpuExceptionHandlerLib can be used du

[edk2-devel] [PATCH 4/4] UefiCpuPkg/CpuExceptionHandler: Revert binary patching in standard CpuExceptionHandlerLib

2020-05-01 Thread Lendacky, Thomas
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2340 Now that an XCODE5 specific CpuExceptionHandlerLib library is in place, revert the changes made to the ExceptionHandlerAsm.nasm in commit 2db0ccc2d7fe ("UefiCpuPkg: Update CpuExceptionHandlerLib pass XCODE5 tool chain") so that binary patchin

[edk2-devel] [PATCH 3/4] OvmfPkg: Use toolchain appropriate CpuExceptionHandlerLib

2020-05-01 Thread Lendacky, Thomas
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2340 Use the XCODE5 CpuExceptionHandlerLib library in place of the standard library when building with the XCODE5 toolchain. The XCODE5 version of the library performs binary patching and should only be used when building with the XCODE5 toolchain

[edk2-devel] [PATCH 2/4] UefiPayloadPkg: Use toolchain appropriate CpuExceptionHandlerLib

2020-05-01 Thread Lendacky, Thomas
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2340 Use the XCODE5 CpuExceptionHandlerLib library in place of the standard library when building with the XCODE5 toolchain. The XCODE5 version of the library performs binary patching and should only be used when building with the XCODE5 toolchain

[edk2-devel] [PATCH 1/1] BaseTools: add repo name option to SetupGit.py

2020-05-01 Thread Rebecca Cran
Allow users who didn't clone one of the TianoCore repos from a canonical URL to specify the name of the repo (edk2, edk2-platforms or edk2-non-osi) when running SetupGit.py to allow them to configure their repo properly. The new option is: -n repo, --name repo set the repo name to configure fo

[edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add source_manifest_repo argument to edkrepo_command.py

2020-05-01 Thread Ashley E Desimone
Add a common definition of the source_manifest_repo argument to edkrepo_command.py to enable selection of the correct source global manifest repository by commands. Signed-off-by: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Erik Bjorge Cc: Bret Barkelew Cc: Prince Agyeman --- ed

Re: [edk2-devel] [edk2-non-osi][PATCH 1/1] RPi: delete device tree binaries

2020-05-01 Thread Ard Biesheuvel
On 5/1/20 12:54 PM, Pete Batard wrote: Reviewed-by: Pete Batard Pushed as 4703c83d7312..dc4afd066ca5 Thanks, -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#58517): https://edk2.groups.io/g/devel/message/58517 Mute This Topic: https

Re: [edk2-devel] [edk2-platforms][PATCH 0/2] Rip out "internal DTB" support in FdtDxe

2020-05-01 Thread Ard Biesheuvel
On 4/30/20 11:16 PM, Andrei Warkentin wrote: Dear all, This patch set removes the internal (embedded) DTB support from Pi 3 and Pi 4 platforms, since these platforms should *always* be using the devicetree passed by the VideoCore firmware. Andrei Warkentin (2): RPi: rip out FdtDxe logic to u

Re: [edk2-devel] [edk2-platforms][PATCH 1/2] RPi: rip out FdtDxe logic to use internal DTB

2020-05-01 Thread Ard Biesheuvel
On 5/1/20 6:56 PM, Andrei Warkentin wrote: Hi folks, I added that specific line more as a safeguard in case the depex ever changes, as I wasn't comfortable with code that relied on an external factor to have defined behavior. I don't have a strong position on it. If you want it to go, I'll s

Re: [edk2-devel] [edk2-platforms][PATCH 1/2] RPi: rip out FdtDxe logic to use internal DTB

2020-05-01 Thread Andrei Warkentin
Hi folks, I added that specific line more as a safeguard in case the depex ever changes, as I wasn't comfortable with code that relied on an external factor to have defined behavior. I don't have a strong position on it. If you want it to go, I'll send an update. A

Re: [edk2-devel] [PATCH v1 1/1] INF Spec: Add file dependency to [Sources] syntax

2020-05-01 Thread PierreGondois
Hello Bob, Would one of the 2 solutions detailed in the last message fit? Just a thought: to allow building ASL files before C files, an ordering must be done somewhere. Either it shall be hard-coded into the build system, either it shall be possible for people to modify it. In the latter case, t

Re: [edk2-devel] [edk2-platforms][PATCH 1/2] RPi: rip out FdtDxe logic to use internal DTB

2020-05-01 Thread Pete Batard
On 2020.05.01 16:13, Ard Biesheuvel wrote: On 5/1/20 5:11 PM, Pete Batard wrote: On 2020.05.01 14:19, Ard Biesheuvel wrote: On 4/30/20 11:16 PM, Andrei Warkentin wrote: Initially, FdtDxe used an internal (embedded in UEFI) FDT, because it was neither understood how to consume the one loaded by

Re: [edk2-devel] [edk2-platforms][PATCH 1/2] RPi: rip out FdtDxe logic to use internal DTB

2020-05-01 Thread Ard Biesheuvel
On 5/1/20 5:11 PM, Pete Batard wrote: On 2020.05.01 14:19, Ard Biesheuvel wrote: On 4/30/20 11:16 PM, Andrei Warkentin wrote: Initially, FdtDxe used an internal (embedded in UEFI) FDT, because it was neither understood how to consume the one loaded by the VideoCore firmware, nor understood just

Re: [edk2-devel] [edk2-platforms][PATCH 1/2] RPi: rip out FdtDxe logic to use internal DTB

2020-05-01 Thread Pete Batard
On 2020.05.01 14:19, Ard Biesheuvel wrote: On 4/30/20 11:16 PM, Andrei Warkentin wrote: Initially, FdtDxe used an internal (embedded in UEFI) FDT, because it was neither understood how to consume the one loaded by the VideoCore firmware, nor understood just how important it is to use the DTB pro

Re: [edk2-devel] [edk2-platforms][PATCH 1/2] RPi: rip out FdtDxe logic to use internal DTB

2020-05-01 Thread Ard Biesheuvel
On 4/30/20 11:16 PM, Andrei Warkentin wrote: Initially, FdtDxe used an internal (embedded in UEFI) FDT, because it was neither understood how to consume the one loaded by the VideoCore firmware, nor understood just how important it is to use the DTB provided by config.txt. Embedding the DT was a

Re: [edk2-devel] [PATCH v1 0/3] Check if required ACPI tables are installed

2020-05-01 Thread Krzysztof Koch
Hi Zhichao, Any idea when this patch set will get merged? Kind regards, Krzysztof -Original Message- From: devel@edk2.groups.io On Behalf Of Gao, Zhichao via groups.io Sent: Friday, April 17, 2020 8:20 To: Krzysztof Koch ; devel@edk2.groups.io; Ni, Ray Cc: Sami Mujawar ; Matteo Carl

Re: [edk2-devel] [edk2-non-osi][PATCH 1/1] RPi: delete device tree binaries

2020-05-01 Thread Pete Batard
On 2020.04.30 22:18, Andrei Warkentin wrote: These are unnecessary, because we've ripped out FdtDxe logic to use internal devicetree. We are mandating that devicetree must come from the VideoCore firmware (driven by config.txt) [ this must be applied only after the FdtDxe patch removing support

Re: [edk2-devel] [edk2-platforms][PATCH 2/2] RPi: remove any mention of an "internal DTB"

2020-05-01 Thread Pete Batard
On 2020.04.30 22:16, Andrei Warkentin wrote: For Pi 3 and Pi 4, since the relevant functionality is gone from FdtDxe. Signed-off-by: Andrei Warkentin --- Platform/RaspberryPi/RPi3/Readme.md | 3 +-- Platform/RaspberryPi/RPi4/Readme.md | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-

Re: [edk2-devel] [edk2-platforms][PATCH 1/2] RPi: rip out FdtDxe logic to use internal DTB

2020-05-01 Thread Pete Batard
Two non-blocking minor remarks inline: On 2020.04.30 22:16, Andrei Warkentin wrote: Initially, FdtDxe used an internal (embedded in UEFI) FDT, because it was neither understood how to consume the one loaded by the VideoCore firmware, nor understood just how important it is to use the DTB provide

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] RPi3: minor doc fix

2020-05-01 Thread Ard Biesheuvel
On 5/1/20 12:29 PM, Pete Batard wrote: On 2020.05.01 11:27, Ard Biesheuvel wrote: On 5/1/20 11:43 AM, Pete Batard wrote: On 2020.04.30 20:24, Andrei Warkentin wrote: Matches the new reality around FDT support (edk2-platform patches). Signed-off-by: Andrei Warkentin ---   Platform/RaspberryPi

Re: [edk2-devel] [edk2-platforms][PATCH 0/2] Fixing FDT handling on Pi 3

2020-05-01 Thread Ard Biesheuvel
On 4/30/20 9:18 PM, Andrei Warkentin wrote: Dear all, This patch set finishes what I started with the Pi 4 fix for the regression seen with newer VideoCore firmware, where a device tree passed via config.txt would not be detected by UEFI. This makes VPU-passed FDT work again on Pi 3 variants. T

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] RPi3: minor doc fix

2020-05-01 Thread Pete Batard
On 2020.05.01 11:27, Ard Biesheuvel wrote: On 5/1/20 11:43 AM, Pete Batard wrote: On 2020.04.30 20:24, Andrei Warkentin wrote: Matches the new reality around FDT support (edk2-platform patches). Signed-off-by: Andrei Warkentin ---   Platform/RaspberryPi/RPi3/TrustedFirmware/Readme.md | 4 +++-

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] RPi3: minor doc fix

2020-05-01 Thread Ard Biesheuvel
On 5/1/20 11:43 AM, Pete Batard wrote: On 2020.04.30 20:24, Andrei Warkentin wrote: Matches the new reality around FDT support (edk2-platform patches). Signed-off-by: Andrei Warkentin ---   Platform/RaspberryPi/RPi3/TrustedFirmware/Readme.md | 4 +++-   1 file changed, 3 insertions(+), 1 deleti

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] RPi3: minor doc fix

2020-05-01 Thread Pete Batard
On 2020.04.30 20:24, Andrei Warkentin wrote: Matches the new reality around FDT support (edk2-platform patches). Signed-off-by: Andrei Warkentin --- Platform/RaspberryPi/RPi3/TrustedFirmware/Readme.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Platform/RaspberryPi

Re: [edk2-devel] [edk2-platforms][PATCH 2/2] RPi: update Pi3 and Pi4 readmes with correct info on FDT handling

2020-05-01 Thread Pete Batard
On 2020.04.30 20:19, Andrei Warkentin wrote: Now that Pi 3 FDT handling is fixed, let's update the docs. Furthermore, let's simplify - be proscriptive about the minimal supported config.txt configuration. Also, fix some factual mistakes: - device_tree= override is not mandatory when device_tree_a

Re: [edk2-devel] [edk2-platforms][PATCH 1/2] RPi3/RPi4: fix RPi 3 VPU-passed FDT handling by unifying with RPi4 implementation

2020-05-01 Thread Pete Batard
On 2020.04.30 20:19, Andrei Warkentin wrote: A rev-up of start.elf VPU firmware meant that the previous scheme of loading the DTB over top of RPI_EFI.FD no longer works - the DT is now loaded way before the armstub, so any overlap means the DT is overridden. This change re-arranges a few items i