[edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add hash of edkrepo.cfg for commit afb9d871 to sha_data.cfg

Needed to enable config file upgrades Signed-off-by: Nate DeSimone Cc: Ashley DeSimone Cc: Puja Pandya Cc: Erik Bjorge Cc: Prince Agyeman Cc: Bret Barkelew Cc: Philippe Mathieu-Daude --- edkrepo_installer/sha_data.cfg| 3 ++- edkrepo_installer/sha_data_README.txt | 6 ++ 2 file

Re: [edk2-devel] [EXTERNAL] Re: [PATCH v1 0/9] Add the VariablePolicy feature

Jiewen, Thanks (as always 😉) for the feedback! I’ll consider how best to address this and provide an update later this week after some others have had a chance to look at it. - Bret From: Michael Kubacki Sent: Monday, April 13, 2020 10:17 AM To: Yao, Jiewen<

Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

UEFI spec allows using float operation so asking module developers avoid using float may not make sense. Even UefiCpuPkg\Library\BaseUefiCpuLib\ provides routine to initialize float support for X86. Given ARM already uses NULL library class mechanism to supply the compiler stub, I prefer X86 align

Re: [edk2-devel] [PATCH 0/8] CryptoPkg: Retire the deprecate function

Hi All, Thanks for the comments. Here is the summary and the change I plan to do. Anything incorrect or lacking, please help to point out: 1. do not use the #if in c code: Using the pcd to assert and return error status in the deprecated function. 2. remove the hmac_sha1 and hmac_md5 as there

[edk2-devel] [PATCH v3] UefiCpuPkg/PiSmmCpuDxeSmm: Improve the performance of GetFreeToken()

Today's GetFreeToken() runs at the algorithm complexity of O(n) where n is the size of the token list. The change introduces a new global variable FirstFreeToken and it always points to the first free token. So the algorithm complexity of GetFreeToken() decreases from O(n) to O(1). The improvemen

Re: [edk2-devel] [PATCH] UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer.

Hi Guomin, Could you please point me to the proposed change? Thanks, Kun From: Jiang, Guomin Sent: Wednesday, April 8, 2020 6:30 PM To: Sean Brogan ; devel@edk2.groups.io Cc: Kun Qin Subject: [EXTERNAL] RE: [edk2-devel] [PATCH] UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer. Hi

[edk2-devel] [PATCH v2] UefiCpuPkg/PiSmmCpuDxeSmm: Improve the performance of GetFreeToken()

Today's GetFreeToken() runs at the algorithm complexity of O(n) where n is the size of the token list. The change introduces a new global variable FirstFreeToken and it always points to the first free token. So the algorithm complexity of GetFreeToken() decreases from O(n) to O(1). The improvemen

Re: [edk2-devel] [PATCH] UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer.

Hi Guomin, Thanks for point the commit below to me. I agree that the change is functionally the same, and I am also with Sean that the local variable seems redundant. But is there other reason we used this local variable in the first place? I thought the first implementation

Re: [edk2-devel] [PATCH v1 1/1] .python/SpellCheck: Increase SpellCheck plugin max failures

Reviewed-by: Shenglei Zhang > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Michael Kubacki > Sent: Friday, April 10, 2020 5:31 AM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Bret Barkelew > ; Gao, Liming ; > Kinney, Michael D ; Sean Broga

Re: [edk2-devel] [EXTERNAL] [PATCH] UnitTestFrameworkPkg/UnitTestLib: Remove FrameworkHandle parameter

Reviewed-by: Bret Barkelew - Bret From: Guomin Jiang Sent: Monday, April 13, 2020 6:53 PM To: devel@edk2.groups.io Cc: Bret Barkelew; Kinney, Michael D; Liming Gao<

[edk2-devel] [PATCH] UnitTestFrameworkPkg/UnitTestLib: Remove FrameworkHandle parameter

From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2612 Remove the FrameworkHandle parameter from the SaveFrameworkState interface in UnitTestLib Cc: Michael D Kinney Cc: Liming Gao Cc: Sean Brogan Cc: Bret Barkelew Signed-off-by: Guomin Jiang --- MdePkg/Include/Libra

[edk2-devel] [PATCH v2] UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer

From: kuqin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2609 SavedState is not sticky, copied pointer update will not change source pointer Cc: Michael D Kinney Cc: Sean Brogan Cc: Bret Barkelew Signed-off-by: Guomin Jiang --- UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c

[edk2-devel] Upcoming Event: TianoCore Bug Triage - APAC / NAMO - Wed, 04/15/2020 9:30am-10:30am #cal-reminder

*Reminder:* TianoCore Bug Triage - APAC / NAMO *When:* Wednesday, 15 April 2020, 9:30am to 10:30am, (GMT+08:00) Asia/Chongqing *Where:* https://zoom.com.cn/j/493235016 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=758252 ) *Organizer:* Brian Richardson brian.richard...@intel.com

Re: [edk2-devel] [PATCH v1 0/9] Add the VariablePolicy feature

Hi Michael and Bret, First of all, Great Work! One thing I noticed is that this change will require 2 new LibraryClasses to be added to every platform .dsc file. However, these changes have not been made to OvmfPkg, EmulatorPkg, RaspberryPi, or any of the MinPlatform *OpenBoardPkgs in edk2-pla

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Update combo displayed in shell after checkout

Reviewed-by: Ashley DeSimone -Original Message- From: Desimone, Nathaniel L Sent: Saturday, April 11, 2020 5:27 PM To: devel@edk2.groups.io Cc: Desimone, Ashley E ; Pandya, Puja ; Bjorge, Erik C ; Agyeman, Prince ; Bret Barkelew ; Philippe Mathieu-Daude Subject: [edk2-staging/EdkRep

Re: [edk2-devel] [PATCH v1 0/9] Add the VariablePolicy feature

This particular series was Bret's work so I'll let him speak to it. Thanks, Michael On 4/10/2020 7:24 PM, Yao, Jiewen wrote: Hi Michael Thanks for the work. I remember the feedback before that I have concern on having an API to *DisableVariablePolicy*, and I prefer we have a way to disable th

Re: [edk2-devel] BaseTools Win32 binaries repo hasn't been updated for over a year

Yes. It is stopped. Please see https://edk2.groups.io/g/devel/message/29436 > -Original Message- > From: Rebecca Cran > Sent: Monday, April 13, 2020 12:22 PM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming > Subject: BaseTools Win32 binaries repo hasn't been updated for over a

Re: [edk2-devel] [edk2-platforms][PATCH v3 1/9] Platform/ARM/SgiPkg: create individual

Hi Ard , > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ard > Biesheuvel via Groups.Io > Sent: 31 March 2020 16:13 > To: Aditya Angadi > Cc: edk2-devel-groups-io ; Vijayenthiran > Subramaniam ; Leif Lindholm > > Subject: Re: [edk2-devel] [edk2-platforms][PATCH v3 1/9] >

Re: [edk2-devel] [edk2-platform][PATCH v1 0/3] Platform/RaspberryPi : Switch to common GraphicsConsoleDxe

On 4/11/20 5:56 PM, Samer El-Haj-Mahmoud via groups.io wrote: Switch RaspberryPi from using a private GraphicsConsoleDxe to the common GraphicsConsoleDxe in MdeModulePkg. Samer El-Haj-Mahmoud (3): Platform/RaspberryPi/RPi4: Switch to common GraphicsConsoleDxe Platform/RaspberryPi/RPi3: Swi