Re: [edk2-devel] [PATCH] UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer.

2020-04-12 Thread Guomin Jiang
Hi Qin, Refer https://github.com/guominjia/edk2/commit/eed5154853f6522e6150b9cff16d24e0c88ad3cc Best Regards guomin From: Kun Qin Sent: Friday, April 10, 2020 3:18 PM To: Jiang, Guomin ; Sean Brogan ; devel@edk2.groups.io Subject: RE: [edk2-devel] [PATCH] UnitTestFrameworkPkg/UnitTestLib: Cor

Re: [edk2-devel] [PATCH v2 23/28] NXP/LS1043aRdbPkg/ArmPlatformLib: Use Allocate pool

2020-04-12 Thread Pankaj Bansal
Hi Ard, > > > > > > I don't object to this as such (although one comment), but what is the > > > purpose of this change? > > > > > > My comment is that most other platforms use AllocatePages for this. So > > > this is diverging from the norm. > > > > I referred ArmVirtPkg/Library/QemuVirtMemInfoLi

Re: [edk2-devel] [PATCH v2] MdeModulePkg/RegularExpressionDxe: Make oniguruma a submodule in edk2.

2020-04-12 Thread Zhang, Shenglei
Hi all, With this patch checked in, you may meet build failure with MdeModulePkg. Because the components in oniguruma can’t be found. Please try command " git submodule update --init" to check out the source code before you build the package. Thanks, Shenglei > -Original Message- > Fr

Re: [edk2-devel] [PATCH V4] BaseTools:Add the spare space FV image size checker

2020-04-12 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Monday, April 13, 2020 11:04 AM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C ; Fan, ZhijuX Subject: [PATCH V4] BaseTools:Add the spare space FV image size checker REF:https://bugzilla.tianocore.org/show_bug.cgi

[edk2-devel] BaseTools Win32 binaries repo hasn't been updated for over a year

2020-04-12 Thread Rebecca Cran
Should the BaseTools Win32 repo still work against edk2 master? I just noticed it hasn't been updated for over a year and no longer works, since GenFfs has new options. https://github.com/tianocore/tianocore.github.io/wiki/Edk2-buildtools says: "Prebuilt Windows tools are available at https

[edk2-devel] [PATCH V4] BaseTools:Add the spare space FV image size checker

2020-04-12 Thread Fan, ZhijuX
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2654 If FV is placed in FD region, its FV image size is fixed. When FV image size exceeds it, it will trig the build break. To alert the developer to adjust FV image size earlier, I request to add new checker for the the spare FV space. When the s

Re: [edk2-devel] [PATCH v2 07/28] Silicon/NXP: Implement SerialUartClockLib

2020-04-12 Thread Pankaj Bansal
> > --- > > .../SerialUartClockLib/SerialUartClockLib.c | 27 +++ > > .../SerialUartClockLib/SerialUartClockLib.inf | 26 ++ > > I requested after the initial submission that you "either follow the > manual git setup steps from > https://github.com/tianocore/tiano

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Update Edk2ToolsBuild.py to use multiple threads on Linux

2020-04-12 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael Kubacki > Sent: Friday, April 3, 2020 1:05 AM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming > Subject: [edk2-devel] [PATCH v1 1/1] BaseTools: Update Edk2ToolsBuild.py to > use mu

Re: [edk2-devel] [PATCH] MdeModulePkg/DeviceManagerUiLib: connect all before creating menu page

2020-04-12 Thread Ard Biesheuvel
On 4/12/20 9:55 AM, Bi, Dandan wrote: Hi Ard, It seems that the root cause is the 'Network Device List' in the device manager menu is crated before EfiBootManagerConnectAll () is called in UiEntry function. If we choose to add the EfiBootManagerConnectAll() in DeviceManagerUiLib with this patc

Re: [edk2-devel] [PATCH] MdeModulePkg/DeviceManagerUiLib: connect all before creating menu page

2020-04-12 Thread Hot Tian
EfiBootManagerConnectAll is kind of BDS policy. Should it be controlled by Ui App or Ui Lib? Thanks, Hot -Original Message- From: devel@edk2.groups.io On Behalf Of Dandan Bi Sent: Sunday, April 12, 2020 15:56 To: devel@edk2.groups.io; ard.biesheu...@arm.com; ler...@redhat.com Cc: Gao, Z

Re: [edk2-devel] [PATCH] MdeModulePkg/DeviceManagerUiLib: connect all before creating menu page

2020-04-12 Thread Dandan Bi
Hi Ard, It seems that the root cause is the 'Network Device List' in the device manager menu is crated before EfiBootManagerConnectAll () is called in UiEntry function. If we choose to add the EfiBootManagerConnectAll() in DeviceManagerUiLib with this patch, could we don't call the EfiBootManage