Re: [edk2-devel] Debug UEFI Event

2020-04-03 Thread Andrew Fish via groups.io
Stanley, There is not much to debug with EFI events and that is why there are not a lot of DEBUG_EVENT DEBUG prints. The only thing that can block your event is for the current TPL level being >= to the TPL level of your event, but that also blocks all forward progress in EFI. Usually the pro

[edk2-devel] Debug UEFI Event

2020-04-03 Thread Stanley Gan
I have an event callback function not called. So, I want to track event execution in UEFI. There is a "DEBUG_EVENT" debug level in EDKII. But no module in EDKII actually use this debug level. I add some debug print in "CoreCreateEventInternal" and "CoredispatchEventNotifies",it cause TPL ASSERT. Ca

[edk2-devel] debug UEFI Event

2020-04-03 Thread Stanley Gan
I have an event callback function not called. So, I want to track event execution in UEFI. There is a "DEBUG_EVENT" debug level in EDKII. But no module in EDKII actually use this debug level. I add some debug print in "CoreCreateEventInternal" and "CoredispatchEventNotifies",it cause TPL ASSERT. Ca

[edk2-devel] [edk2-staging/EdkRepo] [PATCH V2 3/3] EdkRepo: Add command completion setup to Windows installer

2020-04-03 Thread Nate DeSimone
Add configuration of command completion scripts to the Windows installer. This enables edkrepo command completions to work "out of box" on Git for Windows by adding the edkrepo command completions scripts to the Git for Windows /etc/profile.d directory Cc: Ashley DeSimone Cc: Puja Pandya Cc: Eri

[edk2-devel] [edk2-staging/EdkRepo] [PATCH V2 2/3] EdkRepo: Add command completion setup to install.py

2020-04-03 Thread Nate DeSimone
Add configuration of command completion scripts to install.py This enables edkrepo command completions to work "out of box" on most Linux systems by appending to the user's .bashrc and .zshrc startup scripts inclusion of the EdkRepo command completion scripts. Cc: Ashley DeSimone Cc: Puja Pandya

[edk2-devel] [edk2-staging/EdkRepo] [PATCH V2 0/3] EdkRepo: Command completion in bash/zsh

2020-04-03 Thread Nate DeSimone
Changes since V1: - Now uses the new combinations_in_manifest() function introduced by Erik's patch series. This patch series adds command completions (also referred to as [TAB] completions) to EdkRepo. It also adds the currently checked out branch combination to the command prompt. This is

[edk2-devel] [edk2-staging/EdkRepo] [PATCH V2 1/3] EdkRepo: Generate command completion scripts

2020-04-03 Thread Nate DeSimone
Adds code to edkrepo_cli.py to generate a bash/zsh compatible command completion script. Add a new command_completion_edkrepo.py script which is callable by the shell when needed for dynamic completion data. For example, providing completion for "edkrepo checkout" requires the shell to know the li

[edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Checkout command is broken

2020-04-03 Thread Nate DeSimone
Fixes a bug where function call to combinations_in_manifest() was missing a required parameter. Signed-off-by: Nate DeSimone Cc: Ashley DeSimone Cc: Puja Pandya Cc: Erik Bjorge Cc: Prince Agyeman Cc: Bret Barkelew Cc: Philippe Mathieu-Daude --- edkrepo/common/common_repo_functions.py | 2 +

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 0/7] Adding support for archiving branch combos

2020-04-03 Thread Nate DeSimone
Pushed: https://github.com/tianocore/edk2-staging/compare/d1cc427f...eaa400ac -Original Message- From: devel@edk2.groups.io On Behalf Of Bjorge, Erik C Sent: Tuesday, March 31, 2020 3:42 PM To: devel@edk2.groups.io Subject: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 0/7] Adding support

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Allow pin file to be checked out when combo is not in project manifest

2020-04-03 Thread Nate DeSimone
Pushed: https://github.com/tianocore/edk2-staging/commit/1c768b9f -Original Message- From: Desimone, Ashley E Sent: Tuesday, March 31, 2020 5:51 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja ; Bjorge, Erik C ; Bret Barkelew ; Agyeman, Prince Subject: [edk2-stag

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Improve state tracking when checking out pin files

2020-04-03 Thread Nate DeSimone
Pushed: https://github.com/tianocore/edk2-staging/commit/e5d9630e -Original Message- From: devel@edk2.groups.io On Behalf Of Desimone, Ashley E Sent: Tuesday, March 31, 2020 2:00 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja ; Bjorge, Erik C ; Bret Barkelew ; Agy

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH V1 3/3] EdkRepo: Add command completion setup to Windows installer

2020-04-03 Thread Ashley E Desimone
Reviewed-by: Ashley DeSimone -Original Message- From: Desimone, Nathaniel L Sent: Wednesday, April 1, 2020 3:35 PM To: devel@edk2.groups.io Cc: Desimone, Ashley E ; Pandya, Puja ; Bjorge, Erik C ; Agyeman, Prince ; Bret Barkelew ; Philippe Mathieu-Daude Subject: [edk2-staging/EdkRep

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH V1 2/3] EdkRepo: Add command completion setup to install.py

2020-04-03 Thread Ashley E Desimone
Reviewed-by: Ashley DeSimone -Original Message- From: Desimone, Nathaniel L Sent: Wednesday, April 1, 2020 3:35 PM To: devel@edk2.groups.io Cc: Desimone, Ashley E ; Pandya, Puja ; Bjorge, Erik C ; Agyeman, Prince ; Bret Barkelew ; Philippe Mathieu-Daude Subject: [edk2-staging/EdkRep

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH V1 1/3] EdkRepo: Generate command completion scripts

2020-04-03 Thread Ashley E Desimone
The following section will need to be updated to take into account Erik's recent addition of support for archived combinations. +def checkout(parsed_args, config): +manifest = get_workspace_manifest() +print(' '.join([c.name for c in manifest.combinations])) Thanks, Ashley -Origin

[edk2-devel] [PATCH 5/7] MdePkg: Bootable NVDIMM namespaces

2020-04-03 Thread Oleksiy Yakovlev
Privided a mechanism for UEFI FW to identify and hand off bootable NVDIMM namespaces to the OS by standardizing the EFI device path. EFI device path for physical NVDIMM devices changed from an ACPI _ADR device to an ACPI NVDIMM device for correctness. (UEFI 2.8 mantis 1858) Signed-off-by: Oleksiy

[edk2-devel] [PATCH 3/7] MdePkg: REST style formset

2020-04-03 Thread Oleksiy Yakovlev
New ClassGuid EFI_HII_REST_STYLE_FORMSET_GUID is defined. A formset with this class GUID indicates all the questions in the formset support REST style operation and can be exposed to a REST service point. In question level, a new flag EFI_IFR_FLAG_REST_STYLE is defined. An Opcode with this flag

[edk2-devel] [PATCH 0/7] Add defenitions introduced in UEFI 2.8

2020-04-03 Thread Oleksiy Yakovlev
Following patches add/update structures/defenitions, that was introduced/modified by UEFI Spec v.2.8. Oleksiy Yakovlev (7): MdePkg: Extend SERIAL_IO with DeviceTypeGuid (UEFI 2.8 mantis 1832) BaseTools: REST style formset (UEFI 2.8 mantis 1853) MdePkg: REST style formset (UEFI 2.8 mantis 1

[edk2-devel] [PATCH 6/7] MdePkg: Add UEFI Spec Revision 2.8

2020-04-03 Thread Oleksiy Yakovlev
Added entrie in the EFI_SYSTEM_TABLE related definitions section, to signify UEFI 2.8 spec revision. (UEFI 2.8 mantis 1926) Signed-off-by: Oleksiy Yakovlev --- MdePkg/Include/Uefi/UefiSpec.h | 1 + 1 file changed, 1 insertion(+) diff --git a/MdePkg/Include/Uefi/UefiSpec.h b/MdePkg/Include/Uefi

[edk2-devel] [PATCH 7/7] MdePkg: UEFI JSON Capsule Support

2020-04-03 Thread Oleksiy Yakovlev
Added Guids and structures, that defines the work flow to perform capsule update using JSON objects. (UEFI 2.8 mantis 1935) Signed-off-by: Oleksiy Yakovlev --- MdePkg/Include/Guid/CapsuleReport.h | 32 +++- MdePkg/Include/Guid/JsonCapsule.h | 99 + M

[edk2-devel] [PATCH 1/7] MdePkg: Extend SERIAL_IO with DeviceTypeGuid

2020-04-03 Thread Oleksiy Yakovlev
EFI_SERIAL_IO_PROTOCOL_REVISION incremented to 0x00010001 and CONST EFI_GUID *DeviceTypeGuid field added to the protocol structure. (UEFI 2.8 mantis 1832) Signed-off-by: Oleksiy Yakovlev --- MdePkg/Include/Protocol/SerialIo.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/

[edk2-devel] [PATCH 4/7] BaseTools: Bootable NVDIMM namespaces

2020-04-03 Thread Oleksiy Yakovlev
Privided a mechanism for UEFI FW to identify and hand off bootable NVDIMM namespaces to the OS by standardizing the EFI device path. EFI device path for physical NVDIMM devices changed from an ACPI _ADR device to an ACPI NVDIMM device for correctness. (UEFI 2.8 mantis 1858) Signed-off-by: Oleksiy

[edk2-devel] [PATCH 2/7] BaseTools: REST style formset

2020-04-03 Thread Oleksiy Yakovlev
New ClassGuid EFI_HII_REST_STYLE_FORMSET_GUID is defined. A formset with this class GUID indicates all the questions in the formset support REST style operation and can be exposed to a REST service point. In question level, a new flag EFI_IFR_FLAG_REST_STYLE is defined. An Opcode with this flag

[edk2-devel] [PATCH v1 1/1] BaseTools: Remove deprecated Visual Studio Option

2020-04-03 Thread Sami Mujawar
The VS2017 compiler reports 'warning D9035 : option 'Gm' has been deprecated and will be removed in a future release' The documentation for the 'Gm' option at https://docs.microsoft.com/en-us/cpp/build/reference/gm-enable-minimal-rebuild?view=vs-2019 indicates that this option can be safely remove

[edk2-devel] [PATCH edk2-platforms v1 1/1] Platform/ARM: Fix uninitialized variable in RunAxf

2020-04-03 Thread Sami Mujawar
RunAxf is a shell command used for running an Axf file. The ShellDynCmdRunAxfHandler() loads an ELF file or one processed by the Flashloader. It calls the appropriate loaders to load the file in memory and to obtain the entry point address. The first argument to RunAxfPivot() is the entry point ad

Re: [edk2-devel] [PATCH v2] NetworkPkg/Ip6Dxe: Fix ASSERT logic in Ip6ProcessRouterAdvertise()

2020-04-03 Thread Maciej Rabeda
Hey Jiaxin! Thanks for the review, I have already merged this patch based on Siyuan's review and Laszlo's test :) Also, big thank you for handling the HTTP static IP thread. - Maciej On 03-Apr-20 09:21, Wu, Jiaxin wrote: Reviewed-by: Jiaxin Wu -Original Message- From: Maciej Rabe

[edk2-devel] [PATCH 1/1] ArmPkg: rename misleading local #define in CpuDxe

2020-04-03 Thread Leif Lindholm
The local #define TT_ATTR_INDX_INVALID is used as a local error code in the AArch64 implementation, but is misleadingly named to match the definitions in ArmPkg/Include/Chipset/AArch64Mmu.h. Rename it INVALID_ENTRY to reduce confusion and improve readability. Signed-off-by: Leif Lindholm --- Ar

Re: [edk2-devel] [PATCH v1 0/3] Check if required ACPI tables are installed

2020-04-03 Thread Sami Mujawar
For this patch series. Reviewed-by: Sami Mujawar Regards, Sami Mujawar -Original Message- From: Krzysztof Koch Sent: 25 March 2020 09:39 AM To: devel@edk2.groups.io Cc: ray...@intel.com; zhichao@intel.com; Sami Mujawar ; Matteo Carlini ; Laura Moretta ; nd Subject: [PATCH v1 0

Re: [edk2-devel] [PATCH] ArmVirtPkg/FdtPciHostBridgeLib: add extra roots for Arm.

2020-04-03 Thread miaoyubo
> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, April 2, 2020 9:52 PM > To: miaoyubo ; ard.biesheu...@linaro.org; > l...@nuviainc.com > Cc: devel@edk2.groups.io; Xiexiangyou > Subject: Re: [PATCH] ArmVirtPkg/FdtPciHostBridgeLib: add extra roots for

[edk2-devel] [PATCH 1/1] EmbeddedPkg/MmcDxe: Added MaxBlock Transfer Limit 65535 in R/W.

2020-04-03 Thread Gaurav Jain
Moved BlockCount calculation below BufferSize Validation checks. First Ensure Buffersize is Not Zero and multiple of Media BlockSize. then calculate BlockCount and perform Block checks. Corrected BlockCount calculation, as BufferSize is multiple of BlockSize, So adding (BlockSize-1) bytes to Buffe

Re: [edk2-devel] [PATCH V3 1/2] MdePkg-IndustryStandard: CXL 1.1 Base Specification registers

2020-04-03 Thread Liming Gao
Reviewed-by: Liming Gao -Original Message- From: Javeed, Ashraf Sent: 2020年3月31日 10:03 To: devel@edk2.groups.io Cc: Kinney, Michael D ; Gao, Liming Subject: [PATCH V3 1/2] MdePkg-IndustryStandard: CXL 1.1 Base Specification registers BZ: https://bugzilla.tianocore.org/show_bug.cgi?

Re: [edk2-devel] [PATCH V3 2/2] MdePkg-IndustryStandard: Main header for all versions of CXL registers

2020-04-03 Thread Liming Gao
Reviewed-by: Liming Gao -Original Message- From: devel@edk2.groups.io On Behalf Of Javeed, Ashraf Sent: 2020年3月31日 10:03 To: devel@edk2.groups.io Cc: Kinney, Michael D ; Gao, Liming Subject: [edk2-devel] [PATCH V3 2/2] MdePkg-IndustryStandard: Main header for all versions of CXL regi

Re: [edk2-devel] [PATCH v2] NetworkPkg/Ip6Dxe: Fix ASSERT logic in Ip6ProcessRouterAdvertise()

2020-04-03 Thread Wu, Jiaxin
Reviewed-by: Jiaxin Wu > -Original Message- > From: Maciej Rabeda > Sent: Thursday, April 2, 2020 5:15 PM > To: devel@edk2.groups.io > Cc: Wu, Jiaxin ; Fu, Siyuan ; > Laszlo Ersek > Subject: [PATCH v2] NetworkPkg/Ip6Dxe: Fix ASSERT logic in > Ip6ProcessRouterAdvertise() > > REF: https