On Mon, 30 Mar 2020 at 01:16, Sean via Groups.Io
wrote:
>
> Ard/Laszlo or anyone familiar with QEMU.
>
> I read up on the ovmf readme and the qemu wiki but still have a few issues i
> am hoping for quick/easy answers.
>
> 1. How do i programmatically exit the emulator. Seems like uefi shell >
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2644
Need to add LogoFeaturePkg to TemporaryBuildWorkaround because
OpenBoard still includes TemporaryBuildWorkaround for building BIOS.
Cc: Dandan Bi
Cc: Liming Gao
Cc: Eric Dong
Cc: Ray Ni
Signed-off-by: Heng Luo
---
Features/Intel/Adva
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2644
Add all pathes of feature domains to package path in build_bios.py.
Cc: Dandan Bi
Cc: Liming Gao
Cc: Eric Dong
Cc: Ray Ni
Signed-off-by: Heng Luo
---
Platform/Intel/build_bios.py | 7 ++-
1 file changed, 6 insertions(+), 1 deletio
*** BLURB HERE ***
Heng Luo (3):
Platform/Intel: Add all pathes of feature domains to package path
Features/Intel: Add LogoFeaturePkg to TemporaryBuildWorkaround
Features/Intel: Correct wrong codes and remove unnecessary codes
Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/Tem
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2644
Correct wrong codes and remove unnecessary codes in LogoFeaturePkg.
Cc: Dandan Bi
Cc: Liming Gao
Cc: Eric Dong
Cc: Ray Ni
Signed-off-by: Heng Luo
---
Features/Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc | 9
-
OK, I will send the separated patches.
Best Regards
Heng
> -Original Message-
> From: Ni, Ray
> Sent: Monday, March 30, 2020 12:38 PM
> To: Luo, Heng ; devel@edk2.groups.io
> Cc: Bi, Dandan ; Gao, Liming ;
> Dong, Eric
> Subject: RE: [PATCH] Fix build error of OpenBoard caused by change
Heng,
Can you please separate the patch to 3 so each patch fixes one issue
specifically?
I am fine with one Bugzilla to cover the 3 issues.
Thanks,
Ray
> -Original Message-
> From: Luo, Heng
> Sent: Monday, March 30, 2020 12:30 PM
> To: devel@edk2.groups.io
> Cc: Bi, Dandan ; Gao, Limi
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2644
1. Add all pathes of feature domains to package path.
2. Add LogoFeaturePkg to TemporaryBuildWorkaround.
3. Correct wrong codes and remove unnecessary codes in LogoFeaturePkg
Cc: Dandan Bi
Cc: Liming Gao
Cc: Eric Dong
Cc: Ray Ni
Signed-
Reviewed-by: Jian J Wang
Regards,
Jian
> -Original Message-
> From: michael.kuba...@outlook.com
> Sent: Saturday, March 28, 2020 5:56 AM
> To: devel@edk2.groups.io
> Cc: Bret Barkelew ; Gao, Liming
> ; Kinney, Michael D ;
> Wang, Jian J ; Wu, Hao A
> Subject: [PATCH v3 2/3] MdeModulePk
Reviewed-by: Jian J Wang
Regards,
Jian
> -Original Message-
> From: michael.kuba...@outlook.com
> Sent: Saturday, March 28, 2020 5:56 AM
> To: devel@edk2.groups.io
> Cc: Bret Barkelew ; Gao, Liming
> ; Kinney, Michael D ;
> Wang, Jian J ; Wu, Hao A
> Subject: [PATCH v3 1/3] MdeModule
Thanks Vitaly.
I have confirmed this patch can reduce image size.
Reviewed-by: Zhiguang Liu
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Vitaly Cheptsov
> Sent: Friday, March 27, 2020 6:46 PM
> To: devel@edk2.groups.io
> Cc: Gao, Liming
Jiewen,
Same as you. I prefer update version (#1) for adding API, and change
protocol GUID (#2)for deprecate unsecure API.
Best Regards
Siyuan
> -Original Message-
> From: Yao, Jiewen
> Sent: 2020年3月30日 10:47
> To: Fu, Siyuan ; Kinney, Michael D
> ; devel@edk2.groups.io; Gao, Zhichao
Thanks Siyuan.
Good, then I think we are aligned.
I agree with you that it is bad example because the neither version nor GUID is
updated.
We can have at least two options here:
1) Update version
We can change old API to be "VOID *Reserved" or "UNSUPPORT_FUNC Reserved" in
the EDKII_CRYPTO_PROTO
Hi, Jiewen
I agree with all the strategy you listed for the Modulization FW update, and
Mike's
for compatibility maintenance. While I have a little different understanding
about
"permanent binary compatibility". Mainly about what kind of "compatibility" we
have to provide.
I don't think "com
Reviewed-by: Zhiguang Liu
> -Original Message-
> From: Zurcher, Christopher J
> Sent: Thursday, March 26, 2020 3:34 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Wang, Jian J
> ; Gao, Liming ; Liu, Zhiguang
>
> Subject: [PATCH v2 1/1] MdePkg/UefiScsiLib: Set FUA bit for synchro
> On Mar 29, 2020, at 4:16 PM, Sean via Groups.Io
> wrote:
>
> Ard/Laszlo or anyone familiar with QEMU.
>
> I read up on the ovmf readme and the qemu wiki but still have a few issues i
> am hoping for quick/easy answers.
>
> 1. How do i programmatically exit the emulator. Seems like uefi
Hi Jian, Hao,
Could you please help review this change?
Thanks
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of GuoMinJ
Sent: Thursday, March 26, 2020 2:11 PM
To: devel@edk2.groups.io; newexplor...@gmail.com; GuoMinJ via Groups.Io
Cc: Wang, Jian J ; Wu, Hao A
Subject: Re:
Hi Pankaj,
I know your consideration.
My consideration is that we provide an interface, it should be better for user,
it not, the user won't use it and if no nobody use it, why provide it?
In other word, the effort for copying the SerialPortLib and the effort for
implementing SerialUartClockLib
> -Original Message-
> From: Wu, Hao A
> Sent: Friday, March 27, 2020 8:48 AM
> To: devel@edk2.groups.io; newexplor...@gmail.com
> Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Remove
> gEfiFormBrowserExProtocolGuid Protocol Guid
>
> > -Original Message-
> > From: devel@edk2.grou
Ard/Laszlo or anyone familiar with QEMU.
I read up on the ovmf readme and the qemu wiki but still have a few issues i am
hoping for quick/easy answers.
1. How do i programmatically exit the emulator. Seems like uefi shell > reset
just reboots. Other ideas?
2. Is there an easy way to map a lo
This patch series fixes issues reported in the SRAT generator by the
VS2017 compiler with the static analysis option enabled.
The changes can be seen at:
https://github.com/samimujawar/edk2/tree/702_srat_vs2017_compile_warning_v1
Sami Mujawar (2):
DynamicTablesPkg: SRAT: Fix entry points
Dyna
On enabling the /analyse option the VS2017 compiler
reports: warning C6001: Using uninitialized memory.
This warning is reported for the Status variable in
AddGenericInitiatorAffinity() as it is not initialised
to a default value. This condition is only valid if
GenInitAffCount is equal to 0. Sinc
VS2017 reports 'warning C4028: formal parameter 2 different
from declaration' for the library constructor and destructor
interfaces for the SRAT Generator modules.
Remove the CONST qualifier for the SystemTable pointer (the
second parameter to the constructor/destructor/DXE Entry
point) to make it
Hi Aditya,
On Wed, Mar 25, 2020 at 4:23 PM Aditya Angadi wrote:
>
> This patch series adds support for Arm's RD-Daniel platform. There are two
> configurations of this platform being added in this series - Config-M and
> Config-XLR. RD-Daniel is the next Arm's reference design subsystem.
>
> The
The Dynamic Tables Factory protocol has an erroneous
EFIAPI calling convention macro in the function
pointer declaration.
Remove the erroneous EFIAPI calling convention macro
from the interface declarations.
Signed-off-by: Sami Mujawar
Reviewed-by: Alexei Fedorov
Reviewed-by: Philippe Mathieu-D
The VS2017 compiler reports 'warning C4244: '=': conversion from
'const UINT32' to 'UINT8', possible loss of data' when the ACPI
table revision field is being updated.
The width of the revision field in the EFI_ACPI_DESCRIPTION_HEADER
struct is 8-bit wide. Therefore, to fix the above warning make
The VS2017 compiler reports 'warning C4366: The result of
the unary '&' operator may be unaligned' if an address of
an unaligned structure member is passed as an argument to
a function.
Fix this warning by using local variables in place of
unaligned structure members.
Signed-off-by: Sami Mujawar
Add build option STATIC_ANALYSIS to enable VS2017 static
code analysis.
Signed-off-by: Sami Mujawar
Reviewed-by: Alexei Fedorov
---
Notes:
v2:
Splitting patch series and re-submitting DynamicTablesPkg [SAMI]
patches from https://edk2.groups.io/g/devel/message/46261
Dynamic
The VS2017 compiler reports 'warning C4267: '=': conversion from
'size_t' to 'UINT16', possible loss of data'.
The sizeof() operator is used to calculate the size of the
GT Block structure. The length field in the GT Block structure
is 16-bit wide. Since the return type of sizeof() operator
is siz
Removing GT Block frame count check from AddGTBlockTimerFrames()
as this is already validated in BuildGtdtTable().
Signed-off-by: Sami Mujawar
Reviewed-by: Alexei Fedorov
---
Notes:
v2:
Splitting patch series and re-submitting DynamicTablesPkg [SAMI]
patches from https://edk
The length field for the Processor Hierarchy node structure is
8-bit wide while the number of private resource field is 32-bit
wide. Therefore, the GetProcHierarchyNodeSize() returns the size
as a 32-bit value.
The VS2017 compiler reports 'warning C4244: '=': conversion from
'UINT32' to 'UINT8', p
The VS2017 compiler reports 'warning C4267: 'return': conversion
from 'size_t' to 'UINT32', possible loss of data' for a number of
functions that compute the IORT node length. Similarly, it reports
warnings for IORT node length field assignments as the length
field is 16-bit wide.
This patch adds
On enabling the /analyse option the VS2017 compiler
reports: warning C6001: Using uninitialized memory.
This warning is reported as some variables that were
being logged were uninitialised. To fix this, moved
the logging code after the variables being logged are
initialised.
Signed-off-by: Sami M
The ArmBootArch field of the FADT table is 16-bit wide. The
VS2017 compiler reports 'warning C4244: '=': conversion from
'UINT32' to 'UINT16', possible loss of data' when assigning the
CM_ARM_BOOT_ARCH_INFO.BootArchFlags value as the width of this
field in CM_ARM_BOOT_ARCH_INFO is 32-bit wide.
To
The VS2017 compiler reports 'error C2016: C requires that
a struct or union has at least one member' for the struct
CM_ARM_CPU_INFO.
Remove struct CM_ARM_CPU_INFO as this is not in use.
Signed-off-by: Sami Mujawar
Reviewed-by: Alexei Fedorov
---
Notes:
v2:
Splitting patch series and
On enabling the /analyse option the VS2017 compiler
reports: warning C6001: Using uninitialized memory.
This warning is reported as some variables that were
being logged were uninitialised. To fix this, moved
the logging code after the variables being logged are
initialised.
Signed-off-by: Sami M
The VS2017 compiler reports 'warning C4244: '=': conversion
from 'UINT16' to 'UINT8', possible loss of data' for the
SPCR InterfaceType field assignment.
The SPCR InterfaceType field uses the same encoding as that
of the DBG2 table Port Subtype field. However SPCR.InterfaceType
is 8-bit while the
VS2017 reports 'warning C4028: formal parameter 2 different
from declaration' for the library constructor and destructor
interfaces for the Generator modules. VS2017 compiler also
reports similar warnings for the DXE entry points.
Remove the CONST qualifier for the SystemTable pointer (the
second
The ARM DCC serial port subtype is an option that is
supported by the DBG2 generator. However, the serial
port initialisation should only be done for PL011/SBSA
compatible UARTs.
Add check to conditionally initialise the serial port.
Signed-off-by: Sami Mujawar
Reviewed-by: Alexei Fedorov
Revie
The edk2 BaseTools report a warning if a local header file
is not listed under the [Sources] section in the INF file.
Add header files to the [Sources] section in the respective
INF files to fix the warnings.
Signed-off-by: Sami Mujawar
Reviewed-by: Alexei Fedorov
Reviewed-by: Philippe Mathieu-
This patch series:
- fixes warnings reported by the VS2017 compiler
- adds an option to enable VS2017 static code
analysis
- fixes warnings reported by the edk2 build
system
The issues fixed in this series were identified
by building DynamicTablesPkg/DynamicTablesPkg.dsc
using the VS
Building OVMF for X64 with secure boot enabled on VS2019 results in
the following error:
d:\a\1\s\OvmfPkg\Library\GenericQemuLoadImageLib\GenericQemuLoadImageLib.c(154):
error C2220: the following warning is treated as an error
d:\a\1\s\OvmfPkg\Library\GenericQemuLoadImageLib\GenericQemu
Currently memory protection attributes are not working with XCODE5
and CLANGPDB (Xen only) due to misaligned sections.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2642
Requesting for merge in edk2-stable202005.
Vitaly Cheptsov (1):
OvmfPkg: Fix SMM/RT driver section alignment for XCODE
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2642
This patch resolves the problem of using memory protection
attributes when OVMF firmware is compiled with XCODE5 and CLANGPDB.
CC: Andrew Fish
CC: Laszlo Ersek
CC: Marvin Häuser
Signed-off-by: Vitaly Cheptsov
---
OvmfPkg/OvmfPkgIa32.ds
> On 28 Mar 2020, at 23:00, Liran Alon wrote:
>
> Hi,
>
> This series adds driver support for VMware PVSCSI controller.
>
> This controller is supported by VMware and QEMU. This work is part of
> the more general agenda of enhancing OVMF boot device support to have
> feature parity with SeaB
On Sat, 28 Mar 2020 at 22:47, Sean via Groups.Io
wrote:
>
> Ard,
> I agree. How would we do this with AARCH64? I don't believe azure devops
> pipelines has a native AARCH64 platform available. I briefly looked over
> ArmVirtPkg but not sure where to start. OVMF readme only talks about
> ia32
46 matches
Mail list logo
