Re: [EXTERNAL] [edk2-devel] Information about the VMs used to do EDK2 CI?

2020-03-20 Thread Rebecca Cran
Thanks! It was the singe-threaded part that I was interested in. But also, it sounds like for more complex/in-depth testing such as running QEMU to do runtime validation and regression-testing of OVMF etc. we'll want to set up our own agents, since the hosted ones are relatively restrictive. -- R

Re: [EXTERNAL] [edk2-devel] Information about the VMs used to do EDK2 CI?

2020-03-20 Thread Bret Barkelew via Groups.Io
CI runs on the DevOps pool for ubuntu-latest and windows-latest, respectively… https://github.com/tianocore/edk2/blob/0c8ea9fe1adbbee230ee0c68f28b68ca2b0534bc/.azurepipelines/Ubuntu-GCC5.yml#L16 https://github.com/tianocore/edk2/blob/0c8ea9fe1adbbee230ee0c68f28b68ca2b0534bc/.azurepipelines/Windows-

[edk2-devel] Information about the VMs used to do EDK2 CI?

2020-03-20 Thread Rebecca Cran
I was wondering if it might be possible to get information about the VMs used to run EDK2 CI? For example I noticed the Edk2ToolsBuild.py script doesn't try and build BaseTools in parallel, causing it to take 45 seconds - whereas it takes around 10 when run with "make -j4" and 6 with "make -j16".

Re: [edk2-devel] [edk2/master PATCH RISC-V CI v2 3/5] BaseTools: Enable RISC-V architecture for RISC-V EDK2 CI.

2020-03-20 Thread Rebecca Cran
On 2020-03-09 03:53, Abner Chang wrote: > @@ -83,3 +90,27 @@ class LinuxGcc5ToolChain(IUefiBuildPlugin): > return -2 > > return 0 > + > +def _check_riscv64(self): > +# check to see if full path already configured > +if > shell_environment.GetEnvironment(

Re: [edk2-devel] [PATCH 1/4] EdkRepo: Installer should remove obsolete dependencies

2020-03-20 Thread Bret Barkelew via Groups.Io
Spiffy. Agreed; thanks for the background. My only other concern would be the function name and if some future developer thought that was permission to add other modules to it. Then again, maybe I’m just bikeshedding. Feel free to ignore. - Bret From: Desimone, Ashley E

Re: [edk2-devel] [PATCH 1/4] EdkRepo: Installer should remove obsolete dependencies

2020-03-20 Thread Desimone, Ashley E
Thanks for the explanation. Reviewed-by: Ashley DeSimone From: Desimone, Nathaniel L Sent: Thursday, March 19, 2020 2:01 PM To: Bret Barkelew ; Desimone, Ashley E ; devel@edk2.groups.io Cc: Pandya, Puja ; Bjorge, Erik C Subject: Re: [PATCH 1/4] EdkRepo: Installer should remove obsolete depen

Re: [edk2-devel] CLANGPDB binary debugging

2020-03-20 Thread Andrew Fish via Groups.Io
> On Mar 20, 2020, at 8:13 AM, Vitaly Cheptsov wrote: > > Hello, > > We noticed that the original bugzilla, which intended to add new LLVM > toolchain support[1], also wanted to bring ELF format support with DWARF > debugging information. For some reason this did not make its way into EDK II

Re: [edk2-devel] [PATCH V1] MdePkg-IndustryStandard: CXL 1.1 Base Specification registers

2020-03-20 Thread Michael D Kinney
It can be a separate patch. Mike > -Original Message- > From: Javeed, Ashraf > Sent: Friday, March 20, 2020 9:41 AM > To: Kinney, Michael D ; > devel@edk2.groups.io > Cc: Gao, Liming > Subject: RE: [PATCH V1] MdePkg-IndustryStandard: CXL > 1.1 Base Specification registers > > Mike, >

Re: [edk2-devel] [PATCH V1] MdePkg-IndustryStandard: CXL 1.1 Base Specification registers

2020-03-20 Thread Javeed, Ashraf
Mike, I thought I shall add the Cxl.h when the CXL 2.0 spec is approved from its review; but I agree with you that it is better to add the Cxl.h now, rather than later. Is it OK to separate patch for Cxl.h or do I have resend the patch with the new header? Thanks Ashraf > -Original Messag

Re: [edk2-devel] [PATCH V1] MdePkg-IndustryStandard: CXL 1.1 Base Specification registers

2020-03-20 Thread Michael D Kinney
Ashraf, Do we also want to add Cxl.h that includes Cxl11.h to match what is done for other industry standard spec include files when there are multiple versions of the spec over time? The idea is that a module that needs CXL related definitions would include Cxl.h and as new CXL specs are releas

[edk2-devel] CLANGPDB binary debugging

2020-03-20 Thread Vitaly Cheptsov
Hello, We noticed that the original bugzilla, which intended to add new LLVM toolchain support[1], also wanted to bring ELF format support with DWARF debugging information. For some reason this did not make its way into EDK II, and we are currently wondering, how can one debug binaries built wi

[edk2-devel] [PATCH V1] MdePkg-IndustryStandard: CXL 1.1 Base Specification registers

2020-03-20 Thread Javeed, Ashraf
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2611 Register definitions from chapter 7 of CXL Base Specification Rev.1.1 are ported into the new Cxl11.h. Since CXL uses the underlying PCIe technology for interconnect, it uses the PCIe Extended Capability DVSEC structures for its Flex Bus regi

Re: [edk2-devel] [PATCH] EmulatorPkg/WinHost: Add EFI_BUFFER_TOO_SMALL for return status.

2020-03-20 Thread Ni, Ray
Guomin, It's OK to do a partial read. There is no requirement for a single read that returns all the file content back to caller. Some comments to your commit message: Besides, the commit message is too simple. It should indicate what was wrong in the code and what's your expected behavior. The B

Re: [EXTERNAL] RE: [edk2-devel] [PATCH v2 3/3] MdeModulePkg: Use CopyMem instead of GUID assignment

2020-03-20 Thread Ni, Ray
Leif, I didn’t realized tool supports a global NULL library class usage. I now found this https://bugzilla.tianocore.org/show_bug.cgi?id=645. Thanks for the education😊 Thanks, Ray From: Leif Lindholm Sent: Thursday, March 12, 2020 9:54 PM To: Ni, Ray Cc: devel@edk2.groups.io; daniel.schae...

[edk2-devel] [PATCH] EmulatorPkg/WinHost: Add EFI_BUFFER_TOO_SMALL for return status.

2020-03-20 Thread Guomin Jiang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2605 I think it is necessary that check the buffer size before ReadFile, it will inform the caller that they should provide more buffer. Cc: Jordan Justen Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Guomin Jiang --- EmulatorPkg/Win/Host/WinFi

[edk2-devel] [PATCH] EmulatorPkg/WinHost: Add link flags for VS2019 tool chains.

2020-03-20 Thread Jiang, Guomin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2604 The link flags for VS2019 is absent and result the build fail. Cc: Jordan Justen Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Guomin Jiang --- EmulatorPkg/Win/Host/WinHost.inf | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Emulator

Re: [edk2-devel] [PATCH 1/1] BaseTools:Fix build tools print traceback info issue

2020-03-20 Thread Bob Feng
Zhiju, Please update the Bugzilla status. -Original Message- From: Fan, ZhijuX Sent: Friday, March 20, 2020 11:58 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming ; Fan, ZhijuX Subject: [PATCH 1/1] BaseTools:Fix build tools print traceback info issue REF: https://bugzilla.tian