Re: [edk2-devel] [PATCH v2 3/3] MdeModulePkg: Use CopyMem instead of GUID assignment

> -Original Message- > From: Leif Lindholm [mailto:l...@nuviainc.com] > Sent: Friday, March 13, 2020 5:20 AM > To: devel@edk2.groups.io; ler...@redhat.com > Cc: Chang, Abner (HPS SW/FW Technologist) ; > Schaefer, Daniel (DualStudy) ; Chen, Gilbert > ; af...@apple.com; michael.d.kin...@intel

Re: [edk2-devel] [PATCH v2 3/3] MdeModulePkg: Use CopyMem instead of GUID assignment

> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Leif Lindholm > Sent: Thursday, March 12, 2020 10:57 PM > To: Chang, Abner (HPS SW/FW Technologist) > Cc: Schaefer, Daniel (DualStudy) ; > devel@edk2.groups.io; Chen, Gilbert ; > af...@apple.c

Re: [edk2-devel] [PATCH] Features/Intel/Readme.md: Document meaning of "Complete" for features

Isaac, Thanks for the comments. Reply in below. > -Original Message- > From: Oram, Isaac W > Sent: Thursday, March 12, 2020 11:29 PM > To: Ray Ni ; devel@edk2.groups.io > Cc: Ni, Ray ; Dong, Eric ; Chan, Amy > ; Chaganty, Rangasai > V > Subject: RE: [PATCH] Features/Intel/Readme.md: Doc

[edk2-devel] [edk2-staging/Smbios34] ShellPkg/SmbiosView: Add DDR5 support

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2352 Refer to SMBIOS 3.4 spec, add new memory device type - DDR5 and LPDDR5 support for the shell command "smbiosview". Cc: Ray Ni Signed-off-by: Zhichao Gao --- .../UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c| 8 1 file c

[edk2-devel] [PATCH 0/2] OvmfPkg: miscellaneous readability improvements

Repo: https://pagure.io/lersek/edk2.git Branch: ovmfpkg_misc_readability Implement two suggestions from Leif, from the [edk2-devel] [PATCH 0/5] OvmfPkg: improve SMM comms security with adaptive MemoryTypeInformation https://edk2.groups.io/g/devel/message/55726 20200310222739.26717-1-le

[edk2-devel] [PATCH 1/2] OvmfPkg/PlatformPei: explain EFI_MEMORY_TYPE_INFORMATION page counts

Add a code comment that explains the nature of the NumberOfPages field values. Including this kind of historical information was suggested by Leif in (alternative link: <20200312104006.GB23627@bivouac.eciton.net">http://mid.mail-archive.com/20200312104

[edk2-devel] [PATCH 2/2] OvmfPkg: give more telling names to some FDF include files

Leif suggested that FDF include files should preferably refer with their names to the FDF file sections from which they are included. Therefore - rename "OvmfPkg.fdf.inc" to "OvmfPkgDefines.fdf.inc" (included from the [Defines] section), - rename "DecomprScratchEnd.fdf.inc" to "FvmainCompactSc

Re: [edk2-devel] [PATCH 3/5] OvmfPkg: set fixed FlashNvStorage base addresses with -D SMM_REQUIRE

On 03/12/20 15:20, Leif Lindholm wrote: > On Wed, Mar 11, 2020 at 17:41:04 +0100, Laszlo Ersek wrote: A recent example of this was my request for NetworkPkg to expose its include snippets header-less, for DSC files. Please see the "!include NetworkPkg/..." directives in the OVMF DSC

Re: [edk2-devel] github PRs keep breaking for me

Laszlo, I understand your frustration. Let's work on resolving these issues. What browser are you using? I would like the reproduce that issue and report to GitHub. Do you a screen shot where the labels button is not visibe? Did you use the same branch name or a new branch name with the sam

Re: [edk2-devel] [PATCH 5/5] OvmfPkg: improve SMM comms security with adaptive MemoryTypeInformation

On 03/12/20 11:40, Leif Lindholm wrote: > On Thu, Mar 12, 2020 at 01:30:10 +0100, Laszlo Ersek wrote: >> On 03/11/20 20:36, Leif Lindholm wrote: >>> On Wed, Mar 11, 2020 at 17:22:47 +0100, Laszlo Ersek wrote: >> +STATIC EFI_MEMORY_TYPE_INFORMATION mDefaultMemoryTypeInformation[] = { >> + {

Re: [edk2-devel] [PATCH v2 3/3] MdeModulePkg: Use CopyMem instead of GUID assignment

On Thu, Mar 12, 2020 at 20:42:52 +0100, Laszlo Ersek wrote: > On 03/12/20 15:44, Leif Lindholm wrote: > > And what would you propose we do the next time the RISC-V toolchain > > generates a memcpy call based on some other completely valid change to > > core code? > > We could choose to enable the

[edk2-devel] github PRs keep breaking for me

Hi Mike, (1) github stopped supporting my browser. I can no longer apply the push label using my current browser. The "hub" cmdline utility does not seem to support adding just a label to an existing PR. (2) github closed my PR as a personal build (due to lack of the "push" label), and now it eve

Re: [edk2-devel] [PATCH v2 3/3] MdeModulePkg: Use CopyMem instead of GUID assignment

On Thu, Mar 12, 2020 at 20:36:04 +0100, Laszlo Ersek wrote: > On 03/12/20 15:03, Leif Lindholm wrote: > > +Ard, Laszlo. > > > > I think it would make sense to move it to MdeModulePkg (or MdePkg) and > > rename it BaseCompilerIntrinsicsLib (it *is* a BASE library). > > > > As I alluded in my reply

Re: [edk2-devel] [PATCH v2 3/3] MdeModulePkg: Use CopyMem instead of GUID assignment

> On Mar 12, 2020, at 12:36 PM, Laszlo Ersek wrote: > > On 03/12/20 15:03, Leif Lindholm wrote: >> +Ard, Laszlo. >> >> I think it would make sense to move it to MdeModulePkg (or MdePkg) and >> rename it BaseCompilerIntrinsicsLib (it *is* a BASE library). >> >> As I alluded in my reply to Ray

Re: [edk2-devel] [PATCH v2 3/3] MdeModulePkg: Use CopyMem instead of GUID assignment

On 03/12/20 15:44, Leif Lindholm wrote: > And what would you propose we do the next time the RISC-V toolchain > generates a memcpy call based on some other completely valid change to > core code? We could choose to enable the intrinsics library for RISC-V at that point. IIUC, the CreateDeviceMana

Re: [edk2-devel] [PATCH v2 3/3] MdeModulePkg: Use CopyMem instead of GUID assignment

On 03/12/20 15:03, Leif Lindholm wrote: > +Ard, Laszlo. > > I think it would make sense to move it to MdeModulePkg (or MdePkg) and > rename it BaseCompilerIntrinsicsLib (it *is* a BASE library). > > As I alluded in my reply to Ray - x86 also have this problem, but to a > lesser extent, and ended

Re: [edk2-devel] Extend TianoCore Bug Triage - APAC / NAMO Meeting from 0.5 hour to 1 hour

That conflicts for me for the first 30 minutes Kevin D Davis Security Strategist Insyde Software Phone: 503-310- > On Mar 12, 2020, at 9:29 AM, Gao, Liming wrote: > >  > Hi, all > Recently, regular TianoCore Bug Triage meeting has no enough time to review > and discuss the existing bug

Re: [edk2-devel] [PATCH] Features/Intel/Readme.md: Document meaning of "Complete" for features

Ray, I don't think that this is a desirable rule. I want to create feature packages that bundle frequently used together existing capabilities. See the NetworkFeaturePkg for an example. I also want to make feature packages for the USB stack, debug capabilities, and the like that are often ag

Re: [edk2-devel] [PATCH v2 3/3] MdeModulePkg: Use CopyMem instead of GUID assignment

For clarity, I'm suggesting *I* take care of moving this into a generic Intrinsics handling lib, and that HPE take care of including and using it. I'm also not suggesting we revert the CopyMem patch before that is complete. On Thu, Mar 12, 2020 at 14:44:52 +, Leif Lindholm wrote: > And what w

Re: [edk2-devel] [PATCH v2 3/3] MdeModulePkg: Use CopyMem instead of GUID assignment

And what would you propose we do the next time the RISC-V toolchain generates a memcpy call based on some other completely valid change to core code? Doing this de-risks the RISC-V upstreaming effort. It's also a trivial move/rename opetation - the only question is where the library should live an

[edk2-devel] [edk2-platforms][PATCH 3/8] Platform/ARM/SgiPkg: move common platform description to SSDT

Move common platform description entries in platfrom specific DSDT to a SSDT that can be reused on all SGI/RD platforms. Signed-off-by: Aditya Angadi --- .../ARM/SgiPkg/AcpiTables/RdE1Edge/Dsdt.asl | 70 +-- .../SgiPkg/AcpiTables/RdE1EdgeAcpiTables.inf | 3 +- .../ARM/SgiPkg/Acpi

[edk2-devel] [edk2-platforms][PATCH 5/8] Platform/ARM/SgiPkg: Add ACPI tables for Rd-Daniel Config-M

Add Madt and Dsdt ACPI tables for RD-Daniel Config-M platform. Signed-off-by: Aditya Angadi --- .../SgiPkg/AcpiTables/RdDanielCfgM/Dsdt.asl | 118 +++ .../SgiPkg/AcpiTables/RdDanielCfgM/Madt.aslc | 134 ++ .../AcpiTables/RdDanielCfgMAcpiTables.inf | 63 +++

[edk2-devel] [edk2-platforms][PATCH 2/8] Platform/ARM/SgiPkg: move the GIC related ACPI helper macros

Move the ACPI helper macros defines related to GIC structure, distributor, redistributor and ITS to SgiAcpiHeader.h as these are common across ARM SGI/RD platforms. Signed-off-by: Aditya Angadi --- .../ARM/SgiPkg/AcpiTables/RdE1Edge/Madt.aslc | 68 +- .../ARM/SgiPkg/AcpiTables/R

[edk2-devel] [edk2-platforms][PATCH 4/8] Platform/ARM/SgiPkg: remove PcdCoreCount and PcdClusterCount

The number of CPUs depend on the SGI/RD platform. So instead of defining a Fixed PCD to specify the value of core and cluster count, let each platform define these values. Signed-off-by: Aditya Angadi --- Platform/ARM/SgiPkg/AcpiTables/RdE1Edge/Madt.aslc| 7 ++- .../ARM/SgiPkg/AcpiTable

[edk2-devel] [edk2-platforms][PATCH 6/8] Platform/ARM/Sgi: Add initial support for RD-Daniel Config-M platform

Add information in the SGI platform descriptor HOB to pick the correct ACPI table to install for RD-Daniel Config-M Signed-off-by: Aditya Angadi --- .../SgiPkg/Drivers/PlatformDxe/PlatformDxe.c | 5 +++ .../Drivers/PlatformDxe/PlatformDxe.inf | 1 + Platform/ARM/SgiPkg/Include/SgiPlatfo

[edk2-devel] [edk2-platforms][PATCH 7/8] Platform/ARM/SgiPkg: add ACPI tables for RD-Daniel Config-XLR

RD-Daniel Config-XLR is a platform in which four identical chips are connected via a high speed CCIX link. Add Madt and Dsdt tables for the same. Signed-off-by: Aditya Angadi --- .../SgiPkg/AcpiTables/RdDanielCfgXlr/Dsdt.asl | 125 +++ .../AcpiTables/RdDanielCfgXlr/Madt.aslc |

[edk2-devel] [edk2-platforms][PATCH 0/8] Add platform support for RD-Daniel

This patch series adds support for Arm's RD-Daniel platform. There are two configurations of this platform being added in this series - Config-M and Config-XLR. RD-Daniel is the next Arm's reference design subsystem. The first four patches consolidate the code in SgiPkg in preparation for adding s

[edk2-devel] [edk2-platforms][PATCH 8/8] Platform/ARM/Sgi: Add initial support for RD-Daniel Config-XLR platform

For RD-Daniel Config-XLR, use multichip mode information from the SGI platform descriptor HOB to pick the correct ACPI table to be installed. Signed-off-by: Aditya Angadi --- Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c | 5 + Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.in

[edk2-devel] [edk2-platforms][PATCH 1/8] Platform/ARM/SgiPkg: Create individual Platform Description File

From: Vijayenthiran Subramaniam In preparation for adding support for Reference Design (RD) platforms that have different base addresses for GIC distributor or redistributor, create individual platform description files for all SGI/RD platforms and move GIC related base addresses from the common

Re: [edk2-devel] [PATCH v2 3/3] MdeModulePkg: Use CopyMem instead of GUID assignment

I don't prefer to do this at this moment, Leif. I have no problem if we create a BZ for this and create BaseCompilerIntrinsicsLib in MdeModulePkg, but please don't bind it with RISC-V EDK2 port. You know my concern pretty well, we can't hold those RISC-V patches on hands like forever and address

[edk2-devel] Extend TianoCore Bug Triage - APAC / NAMO Meeting from 0.5 hour to 1 hour

Hi, all Recently, regular TianoCore Bug Triage meeting has no enough time to review and discuss the existing bugzillas. I would propose to extend this meeting from 0.5 hour to 1 hour. Now, Bug Triage, Tiano Design and Community meeting are all in one day. I have met some conflict to those meet

Re: [edk2-devel] [PATCH 3/5] OvmfPkg: set fixed FlashNvStorage base addresses with -D SMM_REQUIRE

On Wed, Mar 11, 2020 at 17:41:04 +0100, Laszlo Ersek wrote: > >> A recent example of this was my request for NetworkPkg to expose its > >> include snippets header-less, for DSC files. Please see the "!include > >> NetworkPkg/..." directives in the OVMF DSC files; those are also by > >> design heade

Re: [edk2-devel] [PATCH v2 3/3] MdeModulePkg: Use CopyMem instead of GUID assignment

+Ard, Laszlo. I think it would make sense to move it to MdeModulePkg (or MdePkg) and rename it BaseCompilerIntrinsicsLib (it *is* a BASE library). As I alluded in my reply to Ray - x86 also have this problem, but to a lesser extent, and ended up creating library functions to call instead of using

Re: [EXTERNAL] RE: [edk2-devel] [PATCH v2 3/3] MdeModulePkg: Use CopyMem instead of GUID assignment

Hi Ray, On Thu, Mar 12, 2020 at 12:21 PM Ni, Ray wrote: > Does CompilerIntrinsicsLib exist because GCC doesn't support to disable intrinsic? It is not possible to disable all intrinsics on 32-bit ARM, and it's not necessarily desirable to do so for AArch64 (so I don't think it's implemented). N

[edk2-devel] [edk2-platforms][PATCH 4/8] Platform/ARM/SgiPkg: remove PcdCoreCount and PcdClusterCount

The number of CPUs depend on the SGI/RD platform. So instead of defining a Fixed PCD to specify the value of core and cluster count, let each platform define these values. Change-Id: Ieb872616aa37a1a977f99d9ffd3fe4c761ae4e39 Signed-off-by: Aditya Angadi --- Platform/ARM/SgiPkg/AcpiTables/RdE1Edg

[edk2-devel] [edk2-platforms][PATCH 1/8] Platform/ARM/SgiPkg: Create individual Platform Description File

From: Vijayenthiran Subramaniam In preparation for adding support for Reference Design (RD) platforms that have different base addresses for GIC distributor or redistributor, create individual platform description files for all SGI/RD platforms and move GIC related base addresses from the common

[edk2-devel] [edk2-platforms][PATCH 0/8] Add platform support for RD-Daniel

This patch series adds support for Arm's RD-Daniel platform. There are two configurations of this platform being added in this series - Config-M and Config-XLR. RD-Daniel is the next Arm's reference design subsystem. The first four patches consolidate the code in SgiPkg in preparation for adding s

[edk2-devel] [edk2-platforms][PATCH 6/8] Platform/ARM/Sgi: Add initial support for RD-Daniel Config-M platform

Add information in the SGI platform descriptor HOB to pick the correct ACPI table to install for RD-Daniel Config-M Change-Id: I6f16b71527e1ec13511917b6cb3a46a9458e88cc Signed-off-by: Aditya Angadi --- .../SgiPkg/Drivers/PlatformDxe/PlatformDxe.c | 5 +++ .../Drivers/PlatformDxe/PlatformDxe.in

[edk2-devel] [edk2-platforms][PATCH 7/8] Platform/ARM/SgiPkg: add ACPI tables for RD-Daniel Config-XLR

RD-Daniel Config-XLR is a platform in which four identical chips are connected via a high speed CCIX link. Add Madt and Dsdt tables for the same. Change-Id: I5bcaa5863f38cd36a4ef1524ce460a9033303d34 Signed-off-by: Aditya Angadi --- .../SgiPkg/AcpiTables/RdDanielCfgXlr/Dsdt.asl | 125

[edk2-devel] [edk2-platforms][PATCH 2/8] Platform/ARM/SgiPkg: move the GIC related ACPI helper macros

Move the ACPI helper macros defines related to GIC structure, distributor, redistributor and ITS to SgiAcpiHeader.h as these are common across ARM SGI/RD platforms. Change-Id: I9bed6753e30e344b0eff7bd3d0e2290c8b8a46f0 Signed-off-by: Aditya Angadi --- .../ARM/SgiPkg/AcpiTables/RdE1Edge/Madt.aslc

[edk2-devel] [edk2-platforms][PATCH 5/8] Platform/ARM/SgiPkg: Add ACPI tables for Rd-Daniel Config-M

Add Madt and Dsdt ACPI tables for RD-Daniel Config-M platform. Change-Id: I82f0eaaae6bb4cd515e04ed0a6f8a039c63cf557 Signed-off-by: Aditya Angadi --- .../SgiPkg/AcpiTables/RdDanielCfgM/Dsdt.asl | 118 +++ .../SgiPkg/AcpiTables/RdDanielCfgM/Madt.aslc | 134 ++ .../Ac

[edk2-devel] [edk2-platforms][PATCH 3/8] Platform/ARM/SgiPkg: move common platform description to SSDT

Move common platform description entries in platfrom specific DSDT to a SSDT that can be reused on all SGI/RD platforms. Change-Id: I958298ffc0f454db52728276a3ae6b92b144e544 Signed-off-by: Aditya Angadi --- .../ARM/SgiPkg/AcpiTables/RdE1Edge/Dsdt.asl | 70 +-- .../SgiPkg/AcpiTables

[edk2-devel] [edk2-platforms][PATCH 8/8] Platform/ARM/Sgi: Add initial support for RD-Daniel Config-XLR platform

For RD-Daniel Config-XLR, use multichip mode information from the SGI platform descriptor HOB to pick the correct ACPI table to be installed. Change-Id: Ide397344a064a267333aed5e0b58499ee8f8439c Signed-off-by: Aditya Angadi --- Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c | 5 + P

Re: [edk2-devel] [PATCH v2 3/3] MdeModulePkg: Use CopyMem instead of GUID assignment

Hi Leif, you're right. If I revert my commit and include NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf without making any changes to it, the build succeeds. What do others think? (cc Michael, Pete, Andrew, Ard, who have made changes to this module) Is this a big hack or s

Re: [edk2-devel] [PATCH v2 3/3] MdeModulePkg: Use CopyMem instead of GUID assignment

Leif, Does CompilerIntrinsicsLib exist because GCC doesn't support to disable intrinsic? How does the linker find the CompilerInstrinsicsLib in linking phase? Thanks, Ray > -Original Message- > From: devel@edk2.groups.io On Behalf Of Leif > Lindholm > Sent: Thursday, March 12, 2020 6:55

Re: [edk2-devel] [PATCH v2 3/3] MdeModulePkg: Use CopyMem instead of GUID assignment

Hi Daniel, There is nothing wrong with this patch that just went in (and I should have called out sooner if I wanted to stop it), but I think a better solution is to implement a RISC-V variant of ArmPkg/Library/CompilerIntrinsicsLib/. It is perfectly valid for the compiler to generate memcpy call

Re: [edk2-devel] [PATCH 5/5] OvmfPkg: improve SMM comms security with adaptive MemoryTypeInformation

On Thu, Mar 12, 2020 at 01:30:10 +0100, Laszlo Ersek wrote: > On 03/11/20 20:36, Leif Lindholm wrote: > > On Wed, Mar 11, 2020 at 17:22:47 +0100, Laszlo Ersek wrote: > +STATIC EFI_MEMORY_TYPE_INFORMATION mDefaultMemoryTypeInformation[] = { > + { EfiACPIMemoryNVS, 0x004 }, > +

Re: [edk2-devel] [patch v2] OvmfPkg: Fix build failure with VS2015 tool chain

Hello Liming, (adding Michael) On 03/12/20 05:30, Liming Gao wrote: > warning C4244: '=': conversion from 'UINTN' to 'UINT32', possible loss of data > With this fix, OvmfIa32, OvmfX64 and OvmfIa32X64 can pass build. > > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Signed-off-by: Liming Gao > --- >

Re: [edk2-devel] [edk2/master PATCH RISC-V CI Code Changes v1 01/11] FatPkg: Add RISC-V architecture for EDK2 CI.

Reviewed-by: Ray Ni > -Original Message- > From: devel@edk2.groups.io On Behalf Of Abner Chang > Sent: Friday, March 6, 2020 1:36 PM > To: devel@edk2.groups.io > Cc: abner.ch...@hpe.com; Ni, Ray ; Leif Lindholm > ; Gilbert Chen > ; Daniel Schaefer > Subject: [edk2-devel] [edk2/master P