On 02/26/20 20:05, Ard Biesheuvel wrote:
> Introduce a boolean PCD that tells us whether TPM support is enabled
> in the build, and if it is, record the TPM base address in the existing
> routine that traverses the device tree in the platform PEIM.
>
> If a TPM is found, install the gOvmfTpmDiscov
The series has been pushed as 9227724a..c6ed9b2d
-Original Message-
From: devel@edk2.groups.io On Behalf Of Agyeman, Prince
Sent: Tuesday, February 25, 2020 4:28 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
Subject: [edk2-devel] [edk2-platforms] [PATCH v4 0/4] Ad
Pushed:
https://github.com/tianocore/edk2-platforms/commit/974ddebcf191e32c5eb2f52e5ef85423f4de9819
-Original Message-
From: Shindo, Miki
Sent: Friday, February 21, 2020 5:38 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Chiu, Chasel
; Desimone, Nathaniel L
; Agyeman, Prince
Reviewed-by: Nate DeSimone
-Original Message-
From: Shindo, Miki
Sent: Friday, February 21, 2020 5:38 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Chiu, Chasel
; Desimone, Nathaniel L
; Agyeman, Prince
Subject: [edk2-platforms: PATCH] MinPlatformPkg/PeiReportFvLib: Install
Mike:
Current solution is to define the flexible structure array with zero. This
style is supported by VS/GCC/CLANG compiler. StructurePcd also uses this
solution (here is my example
https://github.com/lgao4/edk2/blob/StructurePcd/TestPkg/Include/Guid/Test2.h#L32).
Edk2 also have the similar
Liming,
This does not make sense. Those compilers
should support C99 flexible array members.
Structured PCDs also require use of flexible
array members.
We need to make sure the compiler flags for
those tool chain are correct to support flexible
array members.
Mike
> -Original Message
Mike:
I find this issue on GCC5 tool chain tag with GCC 5.5 and CLANGPDB tool chain
tag with CLANG 9.0.0
Thanks
Liming
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Michael D
> Kinney
> Sent: Thursday, February 27, 2020 1:54 PM
> To: Gao, Liming ; devel@edk2.groups.io
Leo and all,
I replied in https://bugzilla.tianocore.org/show_bug.cgi?id=2556 for a more
general question about how uCode is used in AMD processors.
Because this package recently exposed a new interface ShadowMicrocodePpi, I try
to involve Leo in the review from AMD uCode's needs.
Thanks,
Ray
Which GCC and CLANG tool chain tags?
Flexible array member is a standard C feature
documented in C99.
Mike
> -Original Message-
> From: Gao, Liming
> Sent: Wednesday, February 26, 2020 9:38 PM
> To: Kinney, Michael D ;
> devel@edk2.groups.io; Fu, Siyuan
> Cc: Ni, Ray ; Chaganty, Rangas
Mike:
I find GCC and CLANG will report the error for the empty struct.
d:\allpkg\edk2-platforms\Silicon\Intel\IntelSiliconPkg\Include\Guid/MicrocodeShadowInfoHob.h:61:11:
error: flexible array member 'MicrocodeAddressInFlash' not allowed in
otherwise empty struct
UINT64 MicrocodeAddressInF
What compiler does not like the flexible array
member syntax [].
Mike
> -Original Message-
> From: devel@edk2.groups.io On
> Behalf Of Siyuan, Fu
> Sent: Wednesday, February 26, 2020 5:58 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Chaganty, Rangasai V
> ; Gao, Liming
>
> Subject: [ed
Reviewed-by: Ray Ni
> -Original Message-
> From: Fu, Siyuan
> Sent: Thursday, February 27, 2020 9:58 AM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Chaganty, Rangasai V
> ; Gao, Liming
>
> Subject: [Patch] IntelSiliconPkg/ShadowMicrocodePei: Fix GCC build error.
>
> This patch fixes co
For the patch series...
Reviewed-by: Nate DeSimone
-Original Message-
From: devel@edk2.groups.io On Behalf Of Agyeman, Prince
Sent: Tuesday, February 25, 2020 4:28 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
Subject: [edk2-devel] [edk2-platforms] [PATCH v4 0/4
Hi Pankaj,
Assuming that your other patch (https://edk2.groups.io/g/devel/message/54629)
is approved and merged to edk2, this patch looks good at least for the Intel
platforms.
Once https://edk2.groups.io/g/devel/message/54629 is merged...
Reviewed-by: Nate DeSimone
-Original Message
> -Original Message-
> From: Leif Lindholm [mailto:l...@nuviainc.com]
> Sent: Wednesday, February 26, 2020 8:01 PM
> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
>
> Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 0/2] Fix
> MdeModulePkg and MdePkg
>
> On
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Agyeman, Prince
> Sent: Wednesday, February 26, 2020 8:28 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
>
> Subject: [edk2-platforms] [PATCH v4 4/4]
> WhiskeylakeOpenBoardPkg/UpXtreme: Add DSC and build f
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Agyeman, Prince
> Sent: Wednesday, February 26, 2020 8:28 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
>
> Subject: [edk2-platforms] [PATCH v4 1/4]
> WhiskeylakeOpenBoardPkg/WhiskeylakeURvp: Remove Boar
Reviewed-by: Chasel Chiu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Agyeman,
> Prince
> Sent: Wednesday, February 26, 2020 8:28 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
>
> Subject: [edk2-devel] [edk2-platforms] [PATCH v4 2/4]
> Whis
Reviewed-by: Liming Gao
> -Original Message-
> From: Fu, Siyuan
> Sent: Thursday, February 27, 2020 9:58 AM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Chaganty, Rangasai V
> ; Gao, Liming
> Subject: [Patch] IntelSiliconPkg/ShadowMicrocodePei: Fix GCC build error.
>
> This patch fixes
This patch fixes compiler error introduced by commit
b0099a39bd.
BZ: https://tianocore.acgmultimedia.com/show_bug.cgi?id=2449
Cc: Ray Ni
Cc: Rangasai V Chaganty
Cc: Liming Gao
Signed-off-by: Siyuan Fu
---
.../Feature/ShadowMicrocode/ShadowMicrocodePei.c| 2 +-
.../Intel/IntelS
Hi Prince,
This is fixing VS2017 build issues, so should be able to refer to the same BZ:
https://bugzilla.tianocore.org/show_bug.cgi?id=2408
You may update BZ to mention about additional missing GUID build failure that
will be addressed too.
Thanks,
Chasel
> -Original Message-
> Fr
Reviewed-by: Nate DeSimone
-Original Message-
From: Agyeman, Prince
Sent: Tuesday, February 25, 2020 4:59 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
Subject: [edk2-platforms] [PATCH 2/2] CoffeelakeSiliconPkg: Add Missing Library
REF: https://bugzilla.tianoco
Reviewed-by: Nate DeSimone
-Original Message-
From: Agyeman, Prince
Sent: Tuesday, February 25, 2020 4:59 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
Subject: [edk2-platforms] [PATCH 1/2] CoffeelakeSiliconPkg: Add Missing GUID
Added missing GUID gEfiMemoryTyp
Hi Chasel,
Since this is the SiliconPkg, not a PlatformPkg I don't think the advanced
feature requirements apply as broadly. Since this same code is also in
KabylakeSiliconPkg I think Prince's fix is fine.
Thanks,
Nate
-Original Message-
From: Chiu, Chasel
Sent: Wednesday, February 2
Once a hot-added CPU finishes the SMBASE relocation, we need to pen it in
a HLT loop. Add the NASM implementation (with just a handful of
instructions, but much documentation), and some C language helper
functions.
Cc: Ard Biesheuvel
Cc: Igor Mammedov
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Micha
Set "PcdCpuHotPlugSupport" to TRUE, when OVMF is built with SMM_REQUIRE.
Consequences:
(1) In PiCpuSmmEntry() [UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c],
resources are allocated and populated in advance for all possible
(i.e., potentially hot-added) processors, rather than only the
p
During normal boot, CpuS3DataDxe allocates
- an empty CPU_REGISTER_TABLE entry in the
"ACPI_CPU_DATA.PreSmmInitRegisterTable" array, and
- an empty CPU_REGISTER_TABLE entry in the "ACPI_CPU_DATA.RegisterTable"
array,
for every CPU whose APIC ID CpuS3DataDxe can learn.
Currently EFI_MP_SERVI
With the help of the Post-SMM Pen and the SMBASE relocation functions
added in the previous patches, we can now complete the root MMI handler
for CPU hotplug.
In the driver's entry point function:
- allocate the pen (in a reserved page in normal RAM),
- install the default ("first") SMI handler
With "PcdCpuSmmEnableBspElection" set to FALSE, PiSmmCpuDxeSmm always
considers the processor with index 0 to be the SMM Monarch (a.k.a. the SMM
BSP). The SMM Monarch handles the SMI for real, while the other CPUs wait
in their SMM loops.
In a subsequent patch, we want to set "PcdCpuHotPlugSupport
Sort the [Packages], [LibraryClasses], and [Pcd] sections in the INF file.
Pad the usage notes (CONSUMES, PRODUCES) in the [Pcd] section.
Sort the Library #includes in the C file.
This patch is functionally a no-op.
Cc: Ard Biesheuvel
Cc: Igor Mammedov
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Mi
Call QemuCpuhpCollectApicIds() in the root MMI handler. The APIC IDs of
the hotplugged CPUs will be used for several purposes in subsequent
patches.
For calling QemuCpuhpCollectApicIds(), pre-allocate both of its output
arrays "PluggedApicIds" and "ToUnplugApicIds" in the driver's entry point
func
Implement the First SMI Handler for hot-added CPUs, in NASM.
Add the interfacing C-language function that the SMM Monarch calls. This
function launches and coordinates SMBASE relocation for a hot-added CPU.
Cc: Ard Biesheuvel
Cc: Igor Mammedov
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Michael Kinn
Add a handful of simple functions for accessing QEMU's hotplug registers
more conveniently. These functions thinly wrap some of the registers
described in "docs/specs/acpi_cpu_hotplug.txt" in the QEMU tree. The
functions hang (by design) if they encounter an internal failure.
Cc: Ard Biesheuvel
C
The @file comments in UefiCpuPkg/CpuS3DataDxe say,
[...] It also only supports the number of CPUs reported by the MP
Services Protocol, so this module does not support hot plug CPUs. This
module can be copied into a CPU specific package and customized if these
additional features are requ
QEMU commit 3a61c8db9d25 ("acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command",
2020-01-22) introduced a new command in the modern CPU hotplug register
block that lets the firmware query the arch-specific IDs (on IA32/X64: the
APIC IDs) of CPUs. Add a macro for this command value, because we'll need
it l
Add a new SMM driver skeleton that registers a root SMI handler, and
checks if the SMI control value (written to 0xB2) indicates a CPU hotplug
SMI.
QEMU's ACPI payload will cause the OS to raise a broadcast SMI when a CPU
hotplug event occurs, namely by writing value 4 to IO Port 0xB2. In other
wo
The "ACPI_CPU_DATA.NumberOfCpus" field is specified as follows, in
"UefiCpuPkg/Include/AcpiCpuData.h" (rewrapped for this commit message):
//
// The number of CPUs. If a platform does not support hot plug CPUs,
// then this is the number of CPUs detected when the platform is booted,
// re
Clone the Null instance of SmmCpuPlatformHookLib from UefiCpuPkg to
OvmfPkg. In this patch, customize the lib instance only with the following
no-op steps:
- Replace Null/NULL references in filenames and comments with Qemu/QEMU
references.
- Update copyright notices.
- Clean up and rewrap commen
In the CoreStartImage() function [MdeModulePkg/Core/Dxe/Image/Image.c], if
the image entry point returns a failure code, then the DXE Core logs a
helpful DEBUG_ERROR message, with the following format string:
"Error: Image at %11p start failed: %r\n"
Do similarly in the SMM Core (update the mes
Add a function that collects the APIC IDs of CPUs that have just been
hot-plugged, or are about to be hot-unplugged.
Pending events are only located and never cleared; QEMU's AML needs the
firmware to leave the status bits intact in the hotplug register block.
Cc: Ard Biesheuvel
Cc: Igor Mammedo
Supersedes: <20200223172537.28464-1-ler...@redhat.com>
Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1512
Repo: https://github.com/lersek/edk2.git
Branch: vcpu_hotplug_smm_bz_1512_v2
V1 was posted at:
* [edk2-devel] [PATCH 00/16]
OvmfPkg: support VCPU hotplug with -D SMM_
On Wed, 26 Feb 2020 at 21:32, Brian J. Johnson wrote:
>
> On 2/26/20 1:43 PM, Ard Biesheuvel wrote:
> > This is the UEFI counterpart to my Linux series which generalizes
> > mixed mode support into a feature that requires very little internal
> > knowledge about the architecture specifics of booti
On 02/24/20 10:10, Laszlo Ersek wrote:
> Overnight I managed to think up an attack, from the OS, against the
> "SmmVacated" byte (the last byte of the reserved page, i.e. the last
> byte of the Post-SMM Pen).
>
> Here's how:
>
> There are three CPUs being hotplugged in one SMI, CPU#1..CPU#3. The
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, February 26, 2020 12:45 PM
> To: Duran, Leo ; Ni, Ray ;
> devel@edk2.groups.io; Wu, Hao A ; Fu, Siyuan
>
> Cc: Dong, Eric
> Subject: Re: [edk2-devel] [PATCH 0/2] UefiCpuPkg/Library: Fix bug in
> MpI
On 2/26/20 1:43 PM, Ard Biesheuvel wrote:
This is the UEFI counterpart to my Linux series which generalizes
mixed mode support into a feature that requires very little internal
knowledge about the architecture specifics of booting Linux on the
part of the bootloader or firmware.
Instead, we add
Add a new 'initrd' command to the UEFI Shell that allows any file that is
accessible to the shell to be registered as the initrd that is returned
when Linux's EFI stub loader invokes the LoadFile2 protocol on its special
vendor media device path.
Signed-off-by: Ard Biesheuvel
---
OvmfPkg/LinuxIn
Add LINUX_EFI_INITRD_MEDIA_GUID to our collection of GUID definitions,
it can be used in a media device path to specify a Linux style initrd
that can be loaded by the OS using the LoadFile2 protocol.
Signed-off-by: Ard Biesheuvel
Reviewed-by: Laszlo Ersek
---
OvmfPkg/Include/Guid/LinuxEfiInitrd
Add the 'initrd' dynamic shell command to the build so we can load
Linux initrds straight from the shell using the new generic protocol,
which does not rely on initrd= being passed on the command line.
Signed-off-by: Ard Biesheuvel
Reviewed-by: Laszlo Ersek
---
OvmfPkg/OvmfPkgIa32.dsc| 4 ++
Add the 'initrd' dynamic shell command to the build so we can load
Linux initrds straight from the shell using the new generic protocol,
which does not rely on initrd= being passed on the command line.
Signed-off-by: Ard Biesheuvel
Reviewed-by: Laszlo Ersek
---
ArmVirtPkg/ArmVirt.dsc.inc
This is the UEFI counterpart to my Linux series which generalizes
mixed mode support into a feature that requires very little internal
knowledge about the architecture specifics of booting Linux on the
part of the bootloader or firmware.
Instead, we add a .compat PE/COFF header containing an array
This is tagged as a v2 since it is a followup to a couple of patches [0][1]
that have already been sent to the list.
This series is part of my effort to define a generic EFI boot protocol for
Linux, i.e,. one that is the same across all different architectures that
are able to boot Linux from EFI,
EDK2's implementation of the LoadImage() boot service permits non-native
binaries to be loaded (i.e., X64 images on IA32 firmware), but any
attempts to start such an image using StartImage() will return
EFI_UNSUPPORTED.
The integration of the PE/COFF emulator protocol into the DXE core
deviates sl
Enable the TPM2 support module in the DXE phase, and the associated
libraries and PCDs that it requires. This will be wired into the
measured boot support code in a subsequent patch.
Note that Tcg2Dxe.inf is added to ArmVirtQemuFvMain.fdf.inc, which
is shared with other platforms in ArmVirtPkg, bu
Implement a ArmVirtPkg specific version of the PSCI ResetSystemLib that
is usable in the PEI phase, as the existing one relies on the FDT client
protocol, making it unsuitable.
Note that accessing the device tree passed by QEMU via its initial base
address is guaranteed to be safe at any time duri
Wire up the various existing pieces so that we can implement measured
boot on ArmVirtQemu based on the TPM support in QEMU, just like it has
been implemented for x86 in OvmfPkg.
The main difference is that on ARM, we first need to discover the TPM base
address from the device tree provided by QEMU
Incorporate the PEI components and the associated library class
resolutions and PCD declarations to enable TPM2 support in the
PEI phase.
Signed-off-by: Ard Biesheuvel
---
ArmVirtPkg/ArmVirtQemu.dsc | 20
ArmVirtPkg/ArmVirtQemu.fdf | 2 ++
2 files changed, 22 insertions(+)
As a first step in gradually adding TPM2 support to ArmVirtQemu, add
the TPM2_ENABLE configurable to the [Defines] section, and if it is
set, add the ResetSystem PEIM to the build, along with the library
class references that we will need to support it:
- wire ArmVirtPsciResetSystemPeiLib into the
We currently include PcdLib.h in PlatformPeiLib, without declaring
this dependency in its .INF description. Since all the PCDs we use
resolve to fixed type in practice, this does not really matter at
the moment, but since we will be adding dynamic PCD references in
a subsequent patch, let's make th
Now that all the TPM2 related plumbing is in place, we can add the
final piece that performs the measurements of loaded images into
the appropriate PCRs.
Signed-off-by: Ard Biesheuvel
---
ArmVirtPkg/ArmVirtQemu.dsc | 3 +++
1 file changed, 3 insertions(+)
diff --git a/ArmVirtPkg/ArmVirtQemu.dsc
Enable the DXE phase component that publishes the HII pages and
associated logic to enable TPM2 parameters to be configured by
the user via the setup menu.
Signed-off-by: Ard Biesheuvel
---
ArmVirtPkg/ArmVirtQemu.dsc | 9 +
ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 3 +++
2 files
Introduce a boolean PCD that tells us whether TPM support is enabled
in the build, and if it is, record the TPM base address in the existing
routine that traverses the device tree in the platform PEIM.
If a TPM is found, install the gOvmfTpmDiscoveredPpiGuid signalling PPI
that will unlock the dis
On ARM systems, the TPM does not live at a fixed address, and so we
need the platform to discover it first. So introduce a PPI that signals
that the TPM address has been discovered and recorded in the appropriate
PCD, and make Tcg2ConfigPei depex on it when built for ARM or AARCH64.
Reviewed-by: L
This series adds driver support for:
- LSI53C1030
- SAS1068
- SAS1068E
These controllers are widely supported by QEMU, VirtualBox and VMWare. This work
is part of the more general agenda of enhancing OVMF boot device support to have
feature parity with SeaBIOS.
We have also developed support for
The controller supports up to 8 targets (Not reported by the
controller, but based on the implementation of the virtual device),
report them in GetNextTarget and GetNextTargetLun. The firmware will
then try to communicate with them and create a block device for each
one that responds.
Support for
Laszlo, et al,
I suppose the same can be said about the actual "PlatformId"... it should be a
single/global read, correct?
But I'd prefer not tackling that in this patch-set (I'll defer to someone that
may want to take that on as an optimization/clean-up.).
Leo.
> -Original Message-
>
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, February 26, 2020 11:25 AM
> To: Duran, Leo ; Gao, Liming ;
> devel@edk2.groups.io; Ni, Ray ; Wu, Hao A
> ; Fu, Siyuan
> Cc: Dong, Eric ; l...@nuviainc.com; Kinney, Michael D
> ; af...@apple.com
> Su
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, February 26, 2020 11:21 AM
> To: Duran, Leo ; Ni, Ray ;
> devel@edk2.groups.io; Wu, Hao A ; Fu, Siyuan
>
> Cc: Dong, Eric
> Subject: Re: [edk2-devel] [PATCH 0/2] UefiCpuPkg/Library: Fix bug in
> MpI
Machines should be able to boot after this commit. Tested with different Linux
distributions (Ubuntu, CentOS) and different Windows versions (Windows 7,
Windows 10, Server 2016).
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2390
Contributed-under: TianoCore Contribution Agreement 1.1
Signed
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2390
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Nikita Leshenko
Reviewed-by: Konrad Rzeszutek Wilk
Reviewed-by: Aaron Young
Reviewed-by: Liran Alon
---
OvmfPkg/MptScsiDxe/MptScsi.c | 13 -
1 file change
Enable the IO Space and Bus Mastering and restore the original values
when the device is stopped. This is a standard procedure in PCI
drivers.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2390
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Nikita Leshenko
Reviewed-b
In order to probe and connect to the MptScsi device we need this
protocol. Currently it does nothing.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2390
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Nikita Leshenko
Reviewed-by: Konrad Rzeszutek Wilk
Reviewed-by: Aa
Used to identify the individual disks in the hardware tree
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2390
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Nikita Leshenko
Reviewed-by: Konrad Rzeszutek Wilk
Reviewed-by: Aaron Young
Reviewed-by: Liran Alon
---
Ov
The MptScsiControllerSupported function is called on handles passed in
by the ConnectController() boot service and if the handle is the
lsi53c1030 controller the function would return success. A successful
return value will attach our driver to the device.
Ref: https://bugzilla.tianocore.org/show_
Install Component Name protocols to have a nice display name for the
driver in places such as UEFI shell.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2390
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Nikita Leshenko
Reviewed-by: Konrad Rzeszutek Wilk
Reviewed-by
This will give us an exclusive access to the PciIo of this device
after it was started and until is will be stopped.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2390
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Nikita Leshenko
Reviewed-by: Konrad Rzeszutek Wilk
In preparation for implementing LSI Fusion MPT SCSI devices, create a
basic scaffolding for a driver.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2390
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Nikita Leshenko
Reviewed-by: Konrad Rzeszutek Wilk
Reviewed-by: Aa
Reset and send the IO controller initialization request. The reply is
read back to complete the doorbell function but it isn't useful to us
because it doesn't contain relevant data or status codes.
See "LSI53C1030 PCI-X to Dual Channel Ultra320 SCSI Multifunction
Controller" technical manual for m
Support dynamic insertion and removal of the protocol
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2390
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Nikita Leshenko
Reviewed-by: Konrad Rzeszutek Wilk
Reviewed-by: Aaron Young
Reviewed-by: Liran Alon
---
OvmfPkg
Support for multiple targets will be implemented in a later commit in
this series.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2390
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Nikita Leshenko
Reviewed-by: Konrad Rzeszutek Wilk
Reviewed-by: Aaron Young
Reviewed
On 02/26/20 17:39, Duran, Leo wrote:
>
>
>> -Original Message-
>> From: Laszlo Ersek [mailto:ler...@redhat.com]
>> Sent: Wednesday, February 26, 2020 11:21 AM
>> To: Duran, Leo ; Ni, Ray ;
>> devel@edk2.groups.io; Wu, Hao A ; Fu, Siyuan
>>
>> Cc: Dong, Eric
>> Subject: Re: [edk2-devel]
On 02/24/20 18:17, Laszlo Ersek wrote:
> In edk2 commit 333f32ec23dd, QemuVideoDxe gained support for QEMU's
> "secondary-vga" device model (originally introduced in QEMU commit
> 63e3e24db2e9).
>
> In QEMU commit 765c94290863, the "bochs-display" device was introduced,
> which would work with Qem
> -Original Message-
> From: Dong, Eric [mailto:eric.d...@intel.com]
> Sent: Wednesday, February 26, 2020 12:06 AM
> To: Duran, Leo ; devel@edk2.groups.io
> Cc: Ni, Ray ; Laszlo Ersek
> Subject: RE: [PATCH 1/2] UefiCpuPkg: LocalApicLib: Export
> StandardSignatureIsAuthenticAMD function
From: Marc-André Lureau
Mirrors TPM 2.0 commit 4672a4892867 ("OvmfPkg: include Tcg2Pei
module", 2018-03-09).
Signed-off-by: Marc-André Lureau
Reviewed-by: Laszlo Ersek
---
OvmfPkg/OvmfPkgIa32.dsc| 1 +
OvmfPkg/OvmfPkgIa32.fdf| 1 +
OvmfPkg/OvmfPkgIa32X64.dsc | 1 +
OvmfPkg/OvmfPkgIa32
From: Marc-André Lureau
Complement commit 6cf1880fb5b ("OvmfPkg: add customized Tcg2ConfigPei
clone", 2018-03-09) by detecting TPM 1.2 devices.
Since Tpm12RequestUseTpm() returns success on any TPM interface,
(including FIFO & CRB which are TPM 2.0), try to send a GetTicks TPM
1.2 command to pro
From: Marc-André Lureau
Hi,
The following patches add basic TPM 1.2 support for Ovmf/QEMU.
Tested successfully Win10 with TIS/TPM 1.2 & CRB/TPM 2.0 passthrough,
and emulated CRB/TPM 2.0.
Git branch: https://github.com/elmarco/edk2.git tpm1
v4:
- misc style changes
- drop "OvmfPkg: add TCG C
> -Original Message-
> From: Gao, Liming [mailto:liming@intel.com]
> Sent: Wednesday, February 26, 2020 3:56 AM
> To: devel@edk2.groups.io; Ni, Ray ; Laszlo Ersek
> ; Duran, Leo ; Wu, Hao A
> ; Fu, Siyuan
> Cc: Dong, Eric ; l...@nuviainc.com; Kinney, Michael D
> ; af...@apple.com; G
From: Marc-André Lureau
Mirrors TPM 2.0 commit 0c0a50d6b3ff ("OvmfPkg: include Tcg2Dxe
module", 2018-03-09).
Signed-off-by: Marc-André Lureau
Reviewed-by: Laszlo Ersek
---
OvmfPkg/OvmfPkgIa32.dsc| 5 +
OvmfPkg/OvmfPkgIa32.fdf| 1 +
OvmfPkg/OvmfPkgIa32X64.dsc | 5 +
OvmfPkg/Ovm
BTW,
I also considered adding a flag to CPU_MP_DATA to make the usage of PlatformId
a bit more explicit.
E.g., something like CpuMpData->CpuData[ProcessorNumber].IsValidPlatformId...
So the init code would look like this:
//
// NOTE: PlatformId is not relevant on AMD platforms.
//
if (S
From: Marc-André Lureau
A following patch is going to use the same configuration for TPM1.2
and TPM2.0, and it's simpler to support both than variable
configurations.
Signed-off-by: Marc-André Lureau
Reviewed-by: Laszlo Ersek
---
OvmfPkg/OvmfPkgIa32.dsc| 24
OvmfP
> -Original Message-
> From: Ni, Ray [mailto:ray...@intel.com]
> Sent: Wednesday, February 26, 2020 2:57 AM
> To: Laszlo Ersek ; devel@edk2.groups.io; Duran, Leo
> ; Wu, Hao A ; Fu, Siyuan
>
> Cc: Dong, Eric
> Subject: RE: [edk2-devel] [PATCH 0/2] UefiCpuPkg/Library: Fix bug in
> MpIni
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, February 26, 2020 5:13 AM
> To: devel@edk2.groups.io; eric.d...@intel.com; Duran, Leo
>
> Cc: Ni, Ray
> Subject: Re: [edk2-devel] [PATCH 1/2] UefiCpuPkg: LocalApicLib: Export
> StandardSignatureIsAu
From: Marc-André Lureau
Mirrors TPM 2.0 commit d5a002aba0aa ("OvmfPkg: plug
DxeTpm2MeasureBootLib into SecurityStubDxe", 2018-03-09)
Signed-off-by: Marc-André Lureau
Reviewed-by: Laszlo Ersek
---
OvmfPkg/OvmfPkgIa32.dsc| 1 +
OvmfPkg/OvmfPkgIa32X64.dsc | 1 +
OvmfPkg/OvmfPkgX64.dsc |
Hi Chasel,
No specific BZ was filed for the missing GUID issue, though reported on this
mailing list.
Thanks
Prince
-Original Message-
From: devel@edk2.groups.io On Behalf Of Chiu, Chasel
Sent: Wednesday, February 26, 2020 1:16 AM
To: Agyeman, Prince ; devel@edk2.groups.io
Cc: Desimon
Hi Leo,
On 02/26/20 16:11, Duran, Leo wrote:
>
>
>> -Original Message-
>> From: Gao, Liming [mailto:liming@intel.com]
>> Sent: Wednesday, February 26, 2020 3:56 AM
>> To: devel@edk2.groups.io; Ni, Ray ; Laszlo Ersek
>> ; Duran, Leo ; Wu, Hao A
>> ; Fu, Siyuan
>> Cc: Dong, Eric ; l..
On 02/26/20 16:46, Duran, Leo wrote:
> BTW,
>
> I also considered adding a flag to CPU_MP_DATA to make the usage of
> PlatformId a bit more explicit.
> E.g., something like CpuMpData->CpuData[ProcessorNumber].IsValidPlatformId...
> So the init code would look like this:
>
> //
> // NOTE: Pl
On 02/26/20 16:03, Duran, Leo wrote:
>
>
>> -Original Message-
>> From: Laszlo Ersek [mailto:ler...@redhat.com]
>> Sent: Wednesday, February 26, 2020 5:13 AM
>> To: devel@edk2.groups.io; eric.d...@intel.com; Duran, Leo
>>
>> Cc: Ni, Ray
>> Subject: Re: [edk2-devel] [PATCH 1/2] UefiCpuPk
Hi
On Wed, Feb 26, 2020 at 11:46 AM Laszlo Ersek wrote:
>
> Hi,
>
> On 02/26/20 10:34, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > Matches TPM 2.0 commit 3103389043bd ("OvmfPkg: Add TCG2 Configuration
> > menu to the Device Manager menu", 2019-02-11).
> >
> > Signed-of
On 2/25/20 11:02 PM, Laszlo Ersek wrote:
On 02/25/20 21:51, Philippe Mathieu-Daudé wrote:
Hi Laszlo,
On 2/24/20 6:17 PM, Laszlo Ersek wrote:
In edk2 commit 333f32ec23dd, QemuVideoDxe gained support for QEMU's
"secondary-vga" device model (originally introduced in QEMU commit
63e3e24db2e9).
In
On 2/26/20 4:34 AM, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
Complement commit 6cf1880fb5b ("OvmfPkg: add customized Tcg2ConfigPei
clone", 2018-03-09) by detecting TPM 1.2 devices.
Since Tpm12RequestUseTpm() returns success on any TPM interface,
(including FIFO & CRB which ar
Suspiciously, ArmLib's INF does not contain a [LibraryClasses]
section at all, but it turns out that all the library includes
it contains (except for ArmLib.h itself) are actually bogus so
let's just drop all of them. While at it, replace with
the more accurate for a BASE type module, and put the
1 - 100 of 142 matches
Mail list logo
