Re: [edk2-devel] [edk2-platforms: PATCH] MinPlatformPkg/PeiReportFvLib: Install FvFspT in PeiReportFvLib

2020-02-24 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Shindo, Miki Sent: Friday, February 21, 2020 5:38 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Chiu, Chasel ; Desimone, Nathaniel L ; Agyeman, Prince Subject: [edk2-platforms: PATCH] MinPlatformPkg/PeiReportFvLib: Install F

Re: [edk2-devel] [edk2-platforms: PATCH] MinPlatformPkg/PeiReportFvLib: Install FvFspT in PeiReportFvLib

2020-02-24 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Shindo, Miki > Sent: Saturday, February 22, 2020 9:38 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Agyeman, Prince > > Subject: [edk2-platforms: PATCH] MinPlatformPkg/PeiRepo

[edk2-devel] [PATCH v3 1/1] MdeModulePkg/Pci: Fixed Asserts in SCT PCIIO Protocol Test.

2020-02-24 Thread Gaurav Jain
ASSERT in PollMem_Conf, CopyMem_Conf, SetBarAttributes_Conf Conformance Test. SCT Test expect return as Invalid Parameter or Unsupported. Added Checks for Function Parameters. return Invalid or Unsupported if Check fails. Added Checks in PciIoPollIo(), PciIoIoRead() PciIoIoWrite() Signed-off-by:

[edk2-devel] [PATCH] CryptoPkg: ECC issue.

2020-02-24 Thread GuoMinJ
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2552 Some issue is reported by ECC tool, correct it. Signed-off-by: GuoMinJ --- .../Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c | 9 + CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf | 2 +- 2 files changed, 10 insert

[edk2-devel] [PATCH] UefiCpuPkg: ECC issue.

2020-02-24 Thread GuoMinJ
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2553 The comment haven't indicate the output attribute. Signed-off-by: GuoMinJ --- UefiCpuPkg/Library/MpInitLib/DxeMpLib.c | 2 +- UefiCpuPkg/Library/MpInitLib/MpLib.h| 2 +- UefiCpuPkg/Library/MpInitLib/PeiMpLib.c | 2 +- 3 files changed,

Re: [edk2-devel] [PATCH edk2-stable202002] OvmfPkg/QemuVideoDxe: unbreak "secondary-vga" and "bochs-display" support

2020-02-24 Thread Ard Biesheuvel
On Mon, 24 Feb 2020 at 18:17, Laszlo Ersek wrote: > > In edk2 commit 333f32ec23dd, QemuVideoDxe gained support for QEMU's > "secondary-vga" device model (originally introduced in QEMU commit > 63e3e24db2e9). > > In QEMU commit 765c94290863, the "bochs-display" device was introduced, > which would

[edk2-devel] [PATCH edk2-stable202002] OvmfPkg/QemuVideoDxe: unbreak "secondary-vga" and "bochs-display" support

2020-02-24 Thread Laszlo Ersek
In edk2 commit 333f32ec23dd, QemuVideoDxe gained support for QEMU's "secondary-vga" device model (originally introduced in QEMU commit 63e3e24db2e9). In QEMU commit 765c94290863, the "bochs-display" device was introduced, which would work with QemuVideoDxe out of the box, reusing the "secondary-vg

Re: [edk2-devel] [PATCH 00/16] OvmfPkg: support VCPU hotplug with -D SMM_REQUIRE

2020-02-24 Thread Ard Biesheuvel
On Sun, 23 Feb 2020 at 18:25, Laszlo Ersek wrote: > > Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1512 > Repo: https://github.com/lersek/edk2.git > Branch: vcpu_hotplug_smm_bz_1512 > > This series implements VCPU hotplug with SMM for OVMF, i.e., when OVMF > is built with "-D SMM

Re: [edk2-devel] A problem with live migration of UEFI virtual machines

2020-02-24 Thread Daniel P . Berrangé
On Tue, Feb 11, 2020 at 05:39:59PM +, Alex Bennée wrote: > > wuchenye1995 writes: > > > Hi all, > >We found a problem with live migration of UEFI virtual machines due to > > size of OVMF.fd changes. > >Specifically, the size of OVMF.fd in edk with low version such as > > edk-2.0-25

Re: [EXT] RE: [edk2-stable202002][edk2-devel] [PATCH v2 1/1] MdeModulePkg/Pci: Fixed Asserts in SCT PCIIO Protocol Test.

2020-02-24 Thread Wu, Hao A
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Gaurav Jain > Sent: Monday, February 24, 2020 4:43 PM > To: Wu, Hao A; devel@edk2.groups.io; Gao, Liming; af...@apple.com; > ler...@redhat.com; l...@nuviainc.com; Kinney, Michael D > Cc: Wang, Jia

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/SdMmcPciHcDxe: Send SEND_STATUS at lower frequency

2020-02-24 Thread Albecki, Mateusz
Hi, Yes I am fine with this change being pushed after the stable tag. Regarding the review comments - I will remove the EmmcIsFrequencySupportedOnBusTiming. When I first implemented it I thought that frequencies <26MHz are not supported on HS200/HS400 for some reason and I forgot to remove the

[edk2-devel] [edk2-platforms: PATCH] MinPlatformPkg/PeiReportFvLib: Install FvFspT in PeiReportFvLib

2020-02-24 Thread Miki Shindo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2410 TPM measurements in PEI runs on FV_INFO_PPI notification function. Currently FvFspT is not installed so it is not measured by TPM. This commit makes FvFspT installed by FV_INFO_PPI so the measurement would run for FvFspT. FvFspT code actuall

Re: [edk2-devel] [PATCH 12/16] OvmfPkg/CpuHotplugSmm: introduce First SMI Handler for hot-added CPUs

2020-02-24 Thread Laszlo Ersek
On 02/23/20 18:25, Laszlo Ersek wrote: > Implement the First SMI Handler for hot-added CPUs, in NASM. > > Add the interfacing C-language function that the SMM Monarch calls. This > function launches and coordinates SMBASE relocation for a hot-added CPU. > > Cc: Ard Biesheuvel > Cc: Igor Mammedov

Re: [EXT] RE: [edk2-stable202002][edk2-devel] [PATCH v2 1/1] MdeModulePkg/Pci: Fixed Asserts in SCT PCIIO Protocol Test.

2020-02-24 Thread Gaurav Jain
> -Original Message- > From: Wu, Hao A > Sent: Monday, February 24, 2020 1:56 PM > To: Gaurav Jain ; devel@edk2.groups.io; Gao, Liming > ; af...@apple.com; ler...@redhat.com; > l...@nuviainc.com; Kinney, Michael D > Cc: Wang, Jian J ; Ni, Ray ; Ard > Biesheuvel ; Pankaj Bansal > > Sub

Re: [EXT] RE: [edk2-stable202002][edk2-devel] [PATCH v2 1/1] MdeModulePkg/Pci: Fixed Asserts in SCT PCIIO Protocol Test.

2020-02-24 Thread Wu, Hao A
> -Original Message- > From: Gaurav Jain [mailto:gaurav.j...@nxp.com] > Sent: Monday, February 24, 2020 3:04 PM > To: Wu, Hao A; devel@edk2.groups.io; Gao, Liming; af...@apple.com; > ler...@redhat.com; l...@nuviainc.com; Kinney, Michael D > Cc: Wang, Jian J; Ni, Ray; Ard Biesheuvel; Pankaj