[edk2-devel] [PATCH] MdeModulePkg/Bus: Potential NULL pointer on Token

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2286 Token pointer may be NULL, it is should be check before use it. Signed-off-by: GuoMinJ --- MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo

[edk2-devel] Request to make CometlakeOpenBoardPkg Component at bugzilla database

Dear all, michael.d.kin...@intel.com As CometlakeOpenBoardPkg support is added at edk2-platforms\Platform\Intel, updates are posted at https://bugzilla.tianocore.org/show_bug.cgi?id=2280. Can you please help to add CometlakeOpenBoardPkg component at Bugzilla data base for future bug tracking su

Re: [edk2-devel] [PATCH] MdeModulePkg/SetupBrowserDxe: Fix IsZeroGuid() ASSERT.

No, I can have a dummy variable to work around this issue. Nickle -Original Message- From: Gao, Liming [mailto:liming@intel.com] Sent: Friday, February 21, 2020 10:23 AM To: Wang, Nickle (HPS SW) ; devel@edk2.groups.io; Bi, Dandan Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/Setu

Re: [edk2-devel] [PATCH] MdeModulePkg/SetupBrowserDxe: Fix IsZeroGuid() ASSERT.

Do you request to catch this fix into this edk2 stable tag 202002? > -Original Message- > From: Wang, Nickle (HPS SW) > Sent: Friday, February 21, 2020 10:21 AM > To: Gao, Liming ; devel@edk2.groups.io; Bi, Dandan > > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/SetupBrowserDxe: Fix

Re: [edk2-devel] [PATCH] MdeModulePkg/SetupBrowserDxe: Fix IsZeroGuid() ASSERT.

Hi Liming, Yes, I made a function and call GetIfrBinaryData() with NULL value to second parameter. Then I see system assert. Thanks, Nickle -Original Message- From: Gao, Liming [mailto:liming@intel.com] Sent: Thursday, February 20, 2020 10:20 PM To: devel@edk2.groups.io; Bi, Danda

Re: [edk2-devel] [PATCH v2] MdeModulePkg/SetupBrowserDxe: Fix IsZeroGuid() ASSERT.

Reviewed-by: Dandan Bi Thanks, Dandan > -Original Message- > From: Nickle Wang [mailto:nickle.w...@hpe.com] > Sent: Friday, February 21, 2020 9:57 AM > To: devel@edk2.groups.io; nickle.w...@hpe.com > Cc: Bi, Dandan > Subject: [PATCH v2] MdeModulePkg/SetupBrowserDxe: Fix IsZeroGuid() ASS

Re: [edk2-devel] [PATCH] MdeModulePkg/SetupBrowserDxe: Fix IsZeroGuid() ASSERT.

Hi Dandan, Thanks for your reminder. I update my patch and it passed BaseTools/Scripts/PatchCheck.py test. Nickle -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Dandan Bi Sent: Thursday, February 20, 2020 4:24 PM To: devel@edk2.groups.io; Wang,

[edk2-devel] [PATCH v2] MdeModulePkg/SetupBrowserDxe: Fix IsZeroGuid() ASSERT.

>From the function description of GetIfrBinaryData(), FormSetGuid can be NULL. However, FormSetGuid is passed to IsZeroGuid(). This causes exception when FormSetGuid is NULL. Signed-off-by: Nickle Wang --- MdeModulePkg/Universal/SetupBrowserDxe/Setup.c | 3 ++- 1 file changed, 2 insertions(+), 1

Re: [edk2-devel] [edk2-platforms][PATCH] Tools/FitGen: Update the UTILITY_MINOR_VERSION

The commit 67957909babe64ec70a44af360148809f2a6c707 misses the version update. I agree this change to match the update. Reviewed-by: Liming Gao > -Original Message- > From: Feng, YunhuaX > Sent: Friday, February 21, 2020 9:47 AM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Feng, Bob

[edk2-devel] [edk2-platforms][PATCH] Tools/FitGen: Update the UTILITY_MINOR_VERSION

Update the UTILITY_MINOR_VERSION from 59 to 60 Cc: Bob Feng Cc: Liming Gao Signed-off-by: Yunhua Feng --- Silicon/Intel/Tools/FitGen/FitGen.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Silicon/Intel/Tools/FitGen/FitGen.h b/Silicon/Intel/Tools/FitGen/FitGen.h index fdf

Re: [edk2-stable202002][edk2-devel] [PATCH v2 1/1] MdeModulePkg/Pci: Fixed Asserts in SCT PCIIO Protocol Test.

A couple of inline comments below. Please help to handle them in the next version of patch. With them addressed, Reviewed-by: Hao A Wu Hello Liming and Stewards, I would like to confirm with you for whether the patch should catch the upcoming stable tag. My personal take is that the patch is

[edk2-devel] Upcoming Event: TianoCore Design Meeting - APAC/NAMO - Fri, 02/21/2020 9:30am-10:30am #cal-reminder

*Reminder:* TianoCore Design Meeting - APAC/NAMO *When:* Friday, 21 February 2020, 9:30am to 10:30am, (GMT+08:00) Asia/Chongqing *Where:* BlueJeans Meeting View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=681238 ) *Organizer:* Ray Ni ray...@intel.com ( ray...@intel.com?subject=Re:

[edk2-devel] [edk2-platforms] [PATCH v3 0/4] Add Initial Support for UP Xtreme

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2191 This patch series add the initial Up Xtreme board support to the WhiskeylakeOpenBoardPkg V3 Changes: - Updated copyright year - Added function to increase cache code size - Uncommmented the GPIO group tier configuration - Updated S

[edk2-devel] [edk2-platforms] [PATCH v3 4/4] WhiskeylakeOpenBoardPkg/UpXtreme: Add DSC and build files

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2191 Adds the DSC and build files necessary to build the UpXtreme board instance. Key files = * build_config.cfg - Board-specific build configuration file. * OpenBoardPkg.dsc - The UpXtreme board description file. * OpenBoardPkgPcd.dsc -

[edk2-devel] [edk2-platforms] [PATCH v3 2/4] WhiskeylakeOpenBoardPkg: Add UpXtreme board ID

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2191 Co-authored-by: Michael Kubacki Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Prince Agyeman --- .../Intel/WhiskeylakeOpenBoardPkg/Include/PlatformBoardId.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Pla

[edk2-devel] [edk2-platforms] [PATCH v3 1/4] WhiskeylakeOpenBoardPkg/WhiskeylakeURvp: Remove BoardFuncInit

Removes BoardFuncInit related functionality in WhiskeylakeURvp. Co-authored-by: Michael Kubacki Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Prince Agyeman --- .../Library/BoardInitLib/BoardFunc.c | 19 .../Library/BoardInitLib/BoardFunc.h | 20 -

[edk2-devel] Upcoming Event: TianoCore Bug Triage - APAC / NAMO - Thu, 02/20/2020 5:00pm-5:30pm #cal-reminder

*Reminder:* TianoCore Bug Triage - APAC / NAMO *When:* Thursday, 20 February 2020, 5:00pm to 5:30pm, (GMT-08:00) America/Los Angeles *Where:* https://bluejeans.com/889357567?src=calendarLink View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=503284 ) *Organizer:* Brian Richardson b

Re: [EXTERNAL] [edk2-devel] [PATCH] UnitTestFrameworkPkg: Invalid index may be used.

Reviewed-by: Bret Barkelew - Bret From: devel@edk2.groups.io on behalf of GuoMinJ via Groups.Io Sent: Wednesday, February 19, 2020 5:41:56 PM To: devel@edk2.groups.io Cc: GuoMinJ Subject: [EXTERNAL] [edk2-devel] [PATCH] UnitTestFrameworkPkg: Invalid index m

Re: [edk2-devel] [PATCH 07/19] Silicon/NXP: remove not needed components

On Tue, Feb 11, 2020 at 07:24:04 +, Pankaj Bansal wrote: > > On Fri, Feb 07, 2020 at 18:13:16 +0530, Pankaj Bansal wrote: > > > We are changing the directory structure of code. > > > After PEI phase impelmentation this info would be put back into > > > appropriate location. > > > > The message

Re: [edk2-devel] [PATCH 08/19] Silicon/NXP: Remove unnecessary PCDs

On Tue, Feb 11, 2020 at 08:45:13 +, Pankaj Bansal wrote: > > -Original Message- > > From: Leif Lindholm > > Sent: Monday, February 10, 2020 11:02 PM > > To: Pankaj Bansal > > Cc: Meenakshi Aggarwal ; Michael D Kinney > > ; Varun Sethi ; > > devel@edk2.groups.io > > Subject: Re: [PATCH

Re: [edk2-devel] [PATCH 14/19] Silicon/NXP/LS1043A: Replce SocLib

On Thu, Feb 13, 2020 at 11:00:10 +, Pankaj Bansal wrote: > > You're talking about the ... bits that remain the same on migrating the > > processors from PPC to ARM? > > I am not sure if the concept of Chassis was there in PPC or not? > It's just the way the SOCs are designed. SOCs that are des

Re: [edk2-devel] A problem with live migration of UEFI virtual machines

* wuchenye1995 (wuchenye1...@gmail.com) wrote: > We found a problem with live migration of UEFI virtual machines due to size > of OVMF.fd changes. Specifically, the size of OVMF.fd in edk with low version such as edk-2.0-25 > is 2MB while the size of it in higher version such as edk-2.0-30 is >

Re: [edk2-devel] [PATCH] MdeModulePkg/SetupBrowserDxe: Fix IsZeroGuid() ASSERT.

Nickle: Is this a real issue found in production? Thanks Liming > -Original Message- > From: devel@edk2.groups.io On Behalf Of Dandan Bi > Sent: Thursday, February 20, 2020 4:24 PM > To: devel@edk2.groups.io; nickle.w...@hpe.com > Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/SetupBrow

Re: [edk2-devel] [PATCHv2 0/4] MdeModulePkg/SdMmcPciHcDxe: Refactor command processing

Hi, Github with test code: https://github.com/malbecki/edk2/tree/test_code_for_async This test code was used as is on Platform2 and it worked if I have only scheduled one request. On platform 1 I had to rebuild it a couple of times to make it read instead of writing when testing after reboot.

[edk2-devel] [PATCH edk2-platforms v2 1/1] Platform: Add SerialUartClockLib for all platforms

From: Pankaj Bansal BaseSerialPortLib16550 has been modified to use SerialUartClockLib. Therefore, add the default implementation of SerialUartClockLib for all the platforms using BaseSerialPortLib16550. Signed-off-by: Pankaj Bansal --- Notes: V2: - removed RaspberryPi3 and RaspberryPi

Re: [edk2-devel] [EXT] RE: [PATCH 1/1] MdeModulePkg/Pci: Fixed Asserts in SCT PCIIO Protocol Test.

> -Original Message- > From: Wu, Hao A > Sent: Wednesday, February 19, 2020 12:04 PM > To: Gaurav Jain ; devel@edk2.groups.io; Ard Biesheuvel > > Cc: Wang, Jian J ; Ni, Ray ; Pankaj > Bansal > Subject: [EXT] RE: [PATCH 1/1] MdeModulePkg/Pci: Fixed Asserts in SCT PCIIO > Protocol Test.

[edk2-devel] [PATCH v2 1/1] MdeModulePkg/Pci: Fixed Asserts in SCT PCIIO Protocol Test.

ASSERT in PollMem_Conf, CopyMem_Conf, SetBarAttributes_Conf Conformance Test. SCT Test expect return as Invalid Parameter or Unsupported. Added Checks for Function Parameters. return Invalid or Unsupported if Check fails. Added Checks in PciIoPollIo(), PciIoIoRead() PciIoIoWrite() Signed-off-by:

Re: [edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string constraint assertions

Hey Andrew, Thanks once again for your comments, mine are inline. Best regards, Marvin Am 20.02.2020 um 00:55 schrieb Andrew Fish: > > >> On Feb 17, 2020, at 12:26 AM, Marvin Häuser > > wrote: >> >> Good day Andrew, >> >> First of all, thank you very much for puttin

Re: [edk2-devel] [edk2-platforms] [PATCH V2 2/2] Enable build for CometlakeOpenBoardPkg

Reviewed-by: Sai Chaganty -Original Message- From: Esakkithevar, Kathappan Sent: Wednesday, February 19, 2020 3:56 AM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Chiu, Chasel ; Desimone, Nathaniel L ; Kethi Reddy, Deepika ; Agyeman, Prince Subject: [edk2-platforms] [PATCH V2

Re: [edk2-devel] [edk2-platforms] [PATCH V2 2/2] Enable build for CometlakeOpenBoardPkg

Reviewed-by: Chasel Chiu > -Original Message- > From: Esakkithevar, Kathappan > Sent: Wednesday, February 19, 2020 7:56 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Kethi Reddy, Deepika > ; Agyeman, Prince > > Subject: [edk2-pla

Re: [edk2-devel] [PATCH] MdeModulePkg/SetupBrowserDxe: Fix IsZeroGuid() ASSERT.

Thanks Nickle for the fix. One minor comment is that please pay attention to the format of commit message. Refer to https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format, Line length of commit message should be less than 76 characters when possible. Please address it when s