Minor comments - Please see inline
Thanks,
Sai
-Original Message-
From: Esakkithevar, Kathappan
Sent: Tuesday, February 18, 2020 6:54 AM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Chiu, Chasel
; Desimone, Nathaniel L
; Kethi Reddy, Deepika
; Agyeman, Prince
Subject: [edk2-p
On Wed, 19 Feb 2020 at 07:34, Wu, Hao A wrote:
>
> > -Original Message-
> > From: Gaurav Jain [mailto:gaurav.j...@nxp.com]
> > Sent: Thursday, January 30, 2020 4:18 PM
> > To: devel@edk2.groups.io
> > Cc: Wang, Jian J; Wu, Hao A; Ni, Ray; Pankaj Bansal; Gaurav Jain
> > Subject: [PATCH 1/1]
Reviewed-by: Sai Chaganty
-Original Message-
From: Esakkithevar, Kathappan
Sent: Tuesday, February 18, 2020 6:54 AM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Chiu, Chasel
; Desimone, Nathaniel L
; Kethi Reddy, Deepika
; Agyeman, Prince
Subject: [edk2-platforms] [PATCH V1 1
Hi Vitaly,
See the comment below:
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Vitaly
> Cheptsov via Groups.Io
> Sent: Monday, February 10, 2020 6:18 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH 1/1] ShellPkg: Add support for input with
> separately repo
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Esakkithevar, Kathappan
> Sent: Tuesday, February 18, 2020 10:54 PM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Kethi Reddy, Deepika
> ; Agyeman, Prince
>
> Subject: [edk2-plat
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Esakkithevar, Kathappan
> Sent: Tuesday, February 18, 2020 10:54 PM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Kethi Reddy, Deepika
> ; Agyeman, Prince
>
> Subject: [edk2-plat
> -Original Message-
> From: Gaurav Jain [mailto:gaurav.j...@nxp.com]
> Sent: Thursday, January 30, 2020 4:18 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J; Wu, Hao A; Ni, Ray; Pankaj Bansal; Gaurav Jain
> Subject: [PATCH 1/1] MdeModulePkg/Pci: Fixed Asserts in SCT PCIIO Protocol
> Test.
Hi Gao
> Gaurav:
> Does this patch catch to edk2 stable tag 202002?
Yes
> -Original Message-
> From: Gao, Liming
> Sent: Monday, February 17, 2020 2:15 PM
> To: devel@edk2.groups.io; Gaurav Jain ; Gao, Liming
>
> Cc: Wang, Jian J ; Wu, Hao A ;
> Ni, Ray ; Pankaj Bansal
> Subject: [EX
This patch seems be reviewed but not submitted. Hope it can be covered in Q1
stable tag.
Thanks,
Dandan
-Original Message-
From: devel@edk2.groups.io On Behalf Of Heinrich
Schuchardt
Sent: Thursday, September 12, 2019 2:34 PM
To: EDK II Development ; Bi, Dandan
Cc: Jin, Eric ; Supreeth
V6 Changes:
Add missing EFIAPI for ShadowMicrocode().
Check FIT table version and checksum before use.
Merge ShadowMicrocodePatchByFit() to ShadowMicrocode().
V5 Changes:
Add FIT address check to see if it's in valid firmware region.
V4 Changes:
Adjust EDKII_MICROCODE_SHADOW_INFO_HOB structure defi
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2280
This change adds the configuration to enable build for CometlakeURvp.
Also it updates Cometlake U Rvp details to the Readme.md.
Signed-off-by: Kathappan Esakkithevar
Cc: Sai Chaganty
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Deepika Kethi Re
Reviewed-by: Siyuan Fu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Wu,
> Jiaxin
> Sent: 2020年2月18日 13:52
> To: devel@edk2.groups.io
> Cc: Fu, Siyuan ; Maciej Rabeda
> ; Wu, Jiaxin
> Subject: [edk2-devel] [PATCH v3] NetworkPkg/Ip4Dxe: Check the received
> package lengt
Siyuan and Maciej:
Can you help review this patch? I would like to make CVE fix catch this
stable tag edk2 202002.
Thanks
Liming
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Wu, Jiaxin
> Sent: Tuesday, February 18, 2020 1:52 PM
> To: devel@edk2.groups.io
> Cc: Fu, Siy
Hi, Ray
The " Just one Type 0 entry in FIT " will be covered by below code when
calculating the microcode entry number. I will update the patch to address your
other comments. Thanks for the review.
//
// Calculate microcode entry number
//
MaxPatchNumber = 0;
for (Index = 0; Index <
Reviewed-by: Nate DeSimone
On Tue, Feb 18, 2020 at 02:53:42PM +, Esakkithevar, Kathappan wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2280
>
> Adds CPU model, SA Device ID, PCH SKU ID for Cometlake U V1.
>
> Key files
> =
> * CpuReg.h - Add CPU Family Model support.
>
Hi Kathappan,
Please see my feedback inline.
Thanks,
Nate
On Tue, Feb 18, 2020 at 02:53:43PM +, Esakkithevar, Kathappan wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2280
>
> This change adds the configuration to enable build for CometlakeURvp.
> Also it updates Cometlake U Rv
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2531
AllocatePool may fail and BinData may be invalid, check
it before use.
Signed-off-by: GuoMinJ
---
MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/MdePkg/Test/UnitTest/Library/Ba
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2530
The Suite pointer is used before check if it is valid,
correct it to check the validation before use.
Signed-off-by: GuoMinJ
---
UnitTestFrameworkPkg/Library/UnitTestLib/RunTests.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(
1. EFIAPI is missing for ShadowMicrocode()
2. What's the reason of creating a separate function ShadowMicrocodePatchByFit
()? Is that because you think this PEIM may support other uCode load mechanism
than FIT? If no, can you merge the *ByFit() to ShadowMicrocode()?
3. "Invalid FIT point" -> "Inv
Please add the the BZ link to the commit message as blow format:
--
Pkg/Module: message title
REF: BZ_Link
Commit message.
Signed-off-by: Name
--
With that done, Reviewed-by: Zhichao Gao
Thanks,
Zhichao
> -Original Message-
> From: devel@edk2.groups.io On Be
Reviewed-by: Nate DeSimone
On Thu, Feb 13, 2020 at 05:55:08PM +, Agyeman, Prince wrote:
> Removes BoardFuncInit related functionality in WhiskeylakeURvp.
>
> Co-authored-by: Michael Kubacki
> Cc: Chasel Chiu
> Cc: Nate DeSimone
> Signed-off-by: Prince Agyeman
> ---
> .../Library/BoardIn
Reviewed-by: Nate DeSimone
On Thu, Feb 13, 2020 at 05:55:09PM +, Agyeman, Prince wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2191
>
> Co-authored-by: Michael Kubacki
> Cc: Chasel Chiu
> Cc: Nate DeSimone
> Signed-off-by: Prince Agyeman
> ---
> .../Intel/WhiskeylakeOpenBo
Hi Prince,
Please update the copyright year on build.cfg.
Thanks,
Nate
On Thu, Feb 13, 2020 at 05:55:11PM +, Agyeman, Prince wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2191
>
> Adds the DSC and build files necessary to build the
> UpXtreme board instance.
>
> Key files
> =
Hi Laszlo,
I agree with your assessments.
One comment below.
Mike
> -Original Message-
> From: Laszlo Ersek
> Sent: Tuesday, February 18, 2020 12:04 PM
> To: Gao, Liming ; Guptha, Soumya
> K ; Kinney, Michael D
> ; l...@nuviainc.com;
> af...@apple.com
> Cc: devel@edk2.groups.io
> S
On Fri, Feb 14, 2020 at 19:11:29 +0530, Vijayenthiran Subramaniam wrote:
> Changes since v2:
> - Rename i to Idx in Patch 2/5
> - Retaining R-b in rest of the patches as there's no change
>
> Changes since v1:
> - Fix typo which caused build error
>
> This patch series adds support for RD-N1-Edge
Thank!
Builds fine with VS2015
From: Agyeman, Prince [mailto:prince.agye...@intel.com]
Sent: Friday, February 14, 2020 12:09 PM
To: devel@edk2.groups.io; Felix Polyudov
Cc: Kubacki, Michael A; Gao, Liming
Subject: RE: [edk2-devel] [edk2-platforms] Building a platform: which edk2
revision to choos
On 02/18/20 15:08, Gao, Liming wrote:
> Hi Stewards and all:
> I collect current patch lists in devel mail list. Those patch
> contributors request to add them for 201902 stable tag. Because we
> have enter into Soft Feature Freeze, I want to collect your feedback
> for them. If any patches
Hi Sean and Laszlo,
Great points. We should discuss with the community around the process and the
governance.
I will add these to our upcoming community meeting to brainstorm.
Thanks,
Soumya
-Original Message-
From: Laszlo Ersek
Sent: Friday, February 14, 2020 2:14 PM
To: devel@edk
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2280
This change adds the configuration to enable build for CometlakeURvp.
Also it updates Cometlake U Rvp details to the Readme.md.
Signed-off-by: Kathappan Esakkithevar
Cc: Sai Chaganty
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Deepika Kethi Re
V1:
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2280
CoffeelakeSiliconPkg: Cometlake V1 U specific support is added as below:
* CPU Family Model ID
* System Agent Device ID
* PCH SKU ID
Platform/Intel:
* Add global configuration to enable build option for CometlakeURvp.
* Also update Comet
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2280
Adds CPU model, SA Device ID, PCH SKU ID for Cometlake U V1.
Key files
=
* CpuReg.h - Add CPU Family Model support.
* SaRegsHostBridge.h - Add SA Device ID support.
* MrcInterface.h - Add CPU Family Model support in MRC.
* PchRegsLpc
Hi Stewards and all:
I collect current patch lists in devel mail list. Those patch contributors
request to add them for 201902 stable tag. Because we have enter into Soft
Feature Freeze, I want to collect your feedback for them. If any patches are
missing, please reply this mail to add them.
Sure,
Reviewed-by: Maciej Rabeda
On 18-Feb-20 11:34, Wu, Jiaxin wrote:
Siyuan & Maciej,
Could you give me Reviewed-by tag for this patch?
Thanks in advance.
Jiaxin
-Original Message-
From: Wu, Jiaxin
Sent: Thursday, February 6, 2020 1:56 PM
To: devel@edk2.groups.io
Cc: Maciej Rabe
Siyuan & Maciej,
Could you give me Reviewed-by tag for this patch?
Thanks in advance.
Jiaxin
> -Original Message-
> From: Wu, Jiaxin
> Sent: Thursday, February 6, 2020 1:56 PM
> To: devel@edk2.groups.io
> Cc: Maciej Rabeda ; Fu, Siyuan
> ; Wu, Jiaxin
> Subject: [PATCH v1] Maintainers.
34 matches
Mail list logo
