[edk2-devel] [PATCH] IntelSiliconPkg: Issue reported by ECC in edk2-platforms.

https://bugzilla.tianocore.org/show_bug.cgi?id=2518 ECC need '.' character at the end of line. Signed-off-by: GuoMinJ --- .../Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h | 6 +++--- .../Library/BaseConfigBlockLib/BaseConfigBlockLib.c | 6 +++--- 2 files changed, 6 insertions

Re: [edk2-devel] [PATCH v3] IntelSiliconPkg: FIT based shadow microcode PPI support.

Hi, Mike The FITPointer points to the FIT table address on flash (within top 16MB of 4GB). It's not a memory address and normally it's always large than the MemoryTop address in PHIT. So we couldn't use PHIT HOB to check the FIT pointer. Best Regards Siyuan > -Original Message- > Fro

[edk2-devel] Upcoming Event: TianoCore Design Meeting - APAC/NAMO - Fri, 02/21/2020 9:30am-10:30am #cal-reminder

*Reminder:* TianoCore Design Meeting - APAC/NAMO *When:* Friday, 21 February 2020, 9:30am to 10:30am, (GMT+08:00) Asia/Chongqing *Where:* BlueJeans Meeting View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=681238 ) *Organizer:* Ray Ni ray...@intel.com ( ray...@intel.com?subject=Re:

[edk2-devel] Upcoming Event: TianoCore Bug Triage - APAC / NAMO - Thu, 02/20/2020 5:00pm-5:30pm #cal-reminder

*Reminder:* TianoCore Bug Triage - APAC / NAMO *When:* Thursday, 20 February 2020, 5:00pm to 5:30pm, (GMT-08:00) America/Los Angeles *Where:* https://bluejeans.com/889357567?src=calendarLink View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=503284 ) *Organizer:* Brian Richardson b

Re: [edk2-devel] [PATCH v6 0/2] Enhancement and Fixes to BaseHashApiLib

Series Reviewed-by: Michael D Kinney Mike > -Original Message- > From: Sukerkar, Amol N > Sent: Saturday, February 15, 2020 11:51 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; > Yao, Jiewen ; Wang, Jian J > ; Agrawal, Sachin > ; Gao, Liming > > Subject: [PATCH v6 0/2] Enhanc

[edk2-devel] [PATCH v6 2/2] CryptoPkg/BaseHashApiLib: Change PcdHashApiLibPolicy type to FixedAtBuild

Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2511 This commit changes the PCD PcdHashApiLibPolicy to the type PcdsFixedAtBuild so as to be able to optimize away the unused hashing algorithms in HashApiLib instance used by a driver. Cc: Jiewen Yao Cc: Jian J Wang Cc: Michael D Kinney Sig

[edk2-devel] [PATCH v6 0/2] Enhancement and Fixes to BaseHashApiLib

This patch implements the fixes and enhancement to BaseHashApiLib in the following manner: - Remove reference to MD4 and MD5 hashing algorithms as they are deprecated; - Align the enumeration for hashing algorithmswith the one used in TPM 2.0 implementation defined in IndustryStandard/Tpm20.h;

[edk2-devel] [PATCH v6 1/2] CryptoPkg/BaseHashApiLib: Align BaseHashApiLib with TPM 2.0 Implementation

Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2511 This commit aligns the baseHashApiLib with TPM 2.0 Implementation as follows: - Remove reference to MD4 and MD5 algorithms as they are deprecated - Align the enumerations for hashing algoerithms with the one used in TPM 2.0 implementation

Re: [edk2-devel] [PATCH v4 0/2] Enhancement and Fixes to BaseHashApiLib

Thanks for the explanation, Mike! Also, I noticed during rebasing my original commit (BZ: 2151) that PcdSetxx does not work with PcdsFixedAtBuild anymore, which, should be by design. Please ignore patch v5 as patch v6 contains all the fixes. ~ Amol -Original Message- From: Kinney, Mich

Re: [edk2-devel] [PATCH v4 0/2] Enhancement and Fixes to BaseHashApiLib

Amol, FixedPcdGet32() does not apply to this use case. FixedPcdGet32() is usually only used when a PCD value is used to fill in a field of a structure in a global variable where the compiler requires a value instead of a variable or a function call. The general rule is to use PcdGet/Setxx() eve

Re: [edk2-devel] [PATCH v4 0/2] Enhancement and Fixes to BaseHashApiLib

Hi Mike, Yes, I just noticed and sent the patch with update 1 (build passed and worked with PcdGet16). I didn't notice the second change so I will make it as well in version 6. Question: There is a call FixedPcdGet32 as well. Would it be applicable in BaseHashApiLib? Thanks, Amol -Origin

[edk2-devel] [PATCH v5 1/2] CryptoPkg/BaseHashApiLib: Align BaseHashApiLib with TPM 2.0 Implementation

Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2511 This commit aligns the baseHashApiLib with TPM 2.0 Implementation as follows: - Remove reference to MD4 and MD5 algorithms as they are deprecated - Align the enumerations for hashing algoerithms with the one used in TPM 2.0 implementation

[edk2-devel] [PATCH v5 2/2] CryptoPkg/BaseHashApiLib: Change PcdHashApiLibPolicy type to FixedAtBuild

Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2511 This commit changes the PCD PcdHashApiLibPolicy to the type PcdsFixedAtBuild so as to be able to optimize away the unused hashing algorithms in HashApiLib instance used by a driver. Cc: Jiewen Yao Cc: Jian J Wang Cc: Michael D Kinney Sig

[edk2-devel] [PATCH v5 0/2] Enhancement and Fixes to BaseHashApiLib

This patch implements the fixes and enhancement to BaseHashApiLib in the following manner: - Remove reference to MD4 and MD5 hashing algorithms as they are deprecated; - Align the enumeration for hashing algorithmswith the one used in TPM 2.0 implementation defined in IndustryStandard/Tpm20.h;

Re: [edk2-devel] [PATCH v4 0/2] Enhancement and Fixes to BaseHashApiLib

Hi Amol, Thanks for the updates: There are a couple items remaining: 1) BaseHashApiLib needs to use PcdGet32() instead of PcdGet16() 2) The extra [PcdsFixedAtBuild] line needs to be removed from CryptoPkg.dec Thanks, Mike > -Original Message- > From: Sukerkar, Amol N > Sent: Friday,

Re: [edk2-devel] [PATCH v2 0/3] Ovmf: enable TPM 1.2

Hi Yao On Thu, Feb 13, 2020 at 2:51 PM Yao, Jiewen wrote: > > Hi Lureau > I don’t think we should expose the TPM Interface type via TpmCommandLib. > > That is the TPM device implementation. The TPM device might use TIS/FIFO/CRB, > but there might be also other type such as I2C, or fTPM implement

Re: [edk2-devel] [PATCH v2 0/3] Ovmf: enable TPM 1.2

For tpm/vtpm (uninitialized), I think you can set PcdTpmInitializationPolicy to 0 in the TPM detection module. As such, the TCG PEI will skip Startup() command. Please refer to SecurityPkg\Tcg\Tcg2Config\TpmDetection.c. I am not clear about the passthrough mode. Which module initializes the TPM ?

Re: [edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string constraint assertions

It seems that edk2.groups.io has hit the limits for message size due to quotation levels (?), so I send another copy of my previous message to have it visible from the web-interface. Andrew, It is ok, as we are all here for mutual benefit, no worries. But you are right

Re: [edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string constraint assertions