Re: [edk2-devel] [PATCH 04/19] Silicon/NXP: Remove DuartLib and use BaseSerialPortLib16550

2020-02-08 Thread Leif Lindholm
On Fri, Feb 07, 2020 at 18:13:13 +0530, Pankaj Bansal wrote: > UART in LS1043A conforms to ns16550 register set. so we can use the > SerialPortLib16550 from MdeModulePkg. 1) This patch adds a new library and deletes an existing one - those are two operationsand hence should be two patches. 2)

Re: [edk2-devel] [PATCH 03/19] NXP/LS1043aRdb: Move Soc specific components to soc files

2020-02-08 Thread Leif Lindholm
On Fri, Feb 07, 2020 at 18:13:12 +0530, Pankaj Bansal wrote: > Soc specific components ought to be part of Soc files and not > platform files. move the same to SOC files > > Signed-off-by: Pankaj Bansal > --- > Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc | 7 +-- > Platform/NXP/NxpQoriqLs.d

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platform/RPi4: Add ACPI entry for Genet network interface

2020-02-08 Thread Ard Biesheuvel
On Sat, 8 Feb 2020 at 15:19, Pete Batard wrote: > > On 2020.02.08 08:52, Ard Biesheuvel wrote: > > On Mon, 3 Feb 2020 at 13:40, Pete Batard wrote: > >> > >> The Raspberry Pi 4 platforms uses a Broadcom Genet network interface, for > >> which we need ACPI entries in order to make it usable under L

Re: [edk2-devel] [PATCH 02/19] Silicon/NXP: changes to use I2clib in i2cdxe

2020-02-08 Thread Leif Lindholm
On Fri, Feb 07, 2020 at 18:13:11 +0530, Pankaj Bansal wrote: > I2c lib contains the i2c controller functionality. this can be used > in I2c DXE driver to communicate with i2c devices. This is one patch. > There was a bug in I2C DXE implementation, which caused the Ds1307 RTC > device to issue two

Re: [edk2-devel] [PATCH 01/19] Silicon/NXP: Add I2c lib

2020-02-08 Thread Leif Lindholm
On Fri, Feb 07, 2020 at 18:13:10 +0530, Pankaj Bansal wrote: > I2c lib is going to be used in PrePeiCore sec module to get the > System clock information from devices connected to i2c (like fpga > or clcok generator) > > since we don't have support of DXE modules this early in boot stage, > move t

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platform/RPi4: Add ACPI entry for Genet network interface

2020-02-08 Thread Pete Batard
On 2020.02.08 08:52, Ard Biesheuvel wrote: On Mon, 3 Feb 2020 at 13:40, Pete Batard wrote: The Raspberry Pi 4 platforms uses a Broadcom Genet network interface, for which we need ACPI entries in order to make it usable under Linux. This patch adds these entries, including a max-dma-burst-size

Re: [edk2-devel] [edk2-platforms][PATCH v3 0/3] Platform/RPi4: Add Genet network driver stub

2020-02-08 Thread Pete Batard
Hi Ard, On 2020.02.08 08:50, Ard Biesheuvel wrote: On Mon, 3 Feb 2020 at 13:14, Pete Batard wrote: Changes from v2: * Remove #if (FixedPcdGet64 (PcdBcmGenetRegistersAddress) != 0) check Jeremy Linton (2): Silicon/Broadcom/Net: Add Genet stub driver to setup MAC Platform/RPi4: Enable Br

Re: [edk2-devel] [PATCH] ArmPlatformPkg/Ds5: Increase path length to 400

2020-02-08 Thread Ard Biesheuvel
On Fri, 7 Feb 2020 at 21:32, Jeff Brasen wrote: > > Increase length of path that can be read from system from 200 to 400 to > allow for longer build paths. > > Signed-off-by: Jeff Brasen Thanks Jeff Reviewed-by: Ard Biesheuvel Pushed to EDK2 master > --- > ArmPlatformPkg/Scripts/Ds5/firmwa

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platform/RPi4: Add ACPI entry for Genet network interface

2020-02-08 Thread Ard Biesheuvel
On Mon, 3 Feb 2020 at 13:40, Pete Batard wrote: > > The Raspberry Pi 4 platforms uses a Broadcom Genet network interface, for > which we need ACPI entries in order to make it usable under Linux. > > This patch adds these entries, including a max-dma-burst-size DSD attribute > aimed at simplifying

Re: [edk2-devel] [edk2-platforms][PATCH v3 0/3] Platform/RPi4: Add Genet network driver stub

2020-02-08 Thread Ard Biesheuvel
On Mon, 3 Feb 2020 at 13:14, Pete Batard wrote: > > Changes from v2: > * Remove #if (FixedPcdGet64 (PcdBcmGenetRegistersAddress) != 0) check > > Jeremy Linton (2): > Silicon/Broadcom/Net: Add Genet stub driver to setup MAC > Platform/RPi4: Enable Broadcom Genet stub driver > > Pete Batard (1):