Re: [edk2-devel] [edk2-staging/EdkRepo][PATCH v1] EdkRepo: Fixed execution of final_copy.py

2020-01-30 Thread Nate DeSimone
Reviewed-by: Nate DeSimone On 1/22/20, 1:55 PM, "devel@edk2.groups.io on behalf of Bjorge, Erik C" wrote: On Ubuntu the script final_copy.py was not able to run without prepending ./ to the script name. Signed-off-by: Erik Bjorge Cc: Nate DeSimone Cc: Ashley DeSimon

Re: [edk2-devel] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Fix FADT Parser

2020-01-30 Thread Gao, Zhichao
Actually I have no permission to create the pull request. I would help to send the patch to Ray and he would create the pull request. Thanks, Zhichao > -Original Message- > From: Ashish Singhal [mailto:ashishsin...@nvidia.com] > Sent: Tuesday, January 28, 2020 1:29 AM > To: Gao, Zhichao

Re: [edk2-devel] [PATCH v2 0/2] ShellPkg: Document the use of EFI_INVALID_PARAMETER by two functions

2020-01-30 Thread Gao, Zhichao
Hi, I have tried with the commit. It pass the check. Thanks, Zhichao > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Philippe Mathieu-Daudé > Sent: Tuesday, January 21, 2020 7:24 PM > To: Gao, Zhichao ; devel@edk2.groups.io > Cc: Ni, Ray >

[edk2-devel] [edk2-platforms][PATCH V1 1/1] Maintainers.txt: Remove Intel maintainer

2020-01-30 Thread Kubacki, Michael A
Removes Michael Kubacki as an Intel maintainer. Cc: Prince Agyeman Cc: Sai Chaganty Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Michael Kubacki --- Maintainers.txt | 6 -- 1 file changed, 6 deletions(-) diff --git a/Maintainers.txt b/Maintainers.txt index e97ea5b343

Re: [edk2-devel] [PATCH 00/11] SecurityPkg/DxeImageVerificationHandler: fix retval for "deny" policy

2020-01-30 Thread Michael D Kinney
Hi Laszlo, I have reviewed this patch series. All the patches look good. The detailed description of each change made it easy to review. Series Reviewed-by: Michael D Kinney I have one question about that is not directly related to this logic change. I see this logic that checks for invalid

Re: [edk2-devel] [PATCH] EmulatorPkg: TimerLib QueryPerformance functions

2020-01-30 Thread Michael D Kinney
Hi Derik, The Linux service clock_gettime() returns a structure with seconds and nanoseconds and you are retuning the number of nanoseconds from QueryPerformanceCounter(). Doesn't that imply that the rate of the performance counter is 1 ns? Does this allow you to remove the calibration code? Dep

Re: [edk2-devel] [Patch 3/5] CryptoPkg/Driver: Add Crypto PEIM, DXE, and SMM modules

2020-01-30 Thread Laszlo Ersek
On 01/30/20 18:10, Kinney, Michael D wrote: > 3) EDK II community defines a small number of profiles >for the PEI, DXE, SMM versions of these modules and >publishes released binaries for each profile. Platforms >integrate the published binary modules. This may >provide more serv

Re: [edk2-devel] [Patch 3/5] CryptoPkg/Driver: Add Crypto PEIM, DXE, and SMM modules

2020-01-30 Thread Michael D Kinney
Hi Laszlo, Great feedback. The reason I chose to use a Structured PCD is to provide maximum flexibility. I agree we should review the behavior in RELEASE builds when a call is made to a service that is disabled. Perhaps REPORT_STATUS_CODE would be a good option for a platform provide its own h

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg: acpiview: Validate ACPI table 'Length' field

2020-01-30 Thread Sami Mujawar
Reviewed-by: Sami Mujawar Regards, Sami Mujawar -Original Message- From: Krzysztof Koch Sent: 30 January 2020 16:20 To: devel@edk2.groups.io Cc: ray...@intel.com; zhichao@intel.com; Matteo Carlini ; Sami Mujawar ; nd Subject: [PATCH v1 1/1] ShellPkg: acpiview: Validate ACPI tabl

[edk2-devel] [PATCH v1 1/1] ShellPkg: acpiview: Validate ACPI table 'Length' field

2020-01-30 Thread Krzysztof Koch
Check if the ACPI table length, as reported in the ACPI table header, is big enough to fit at least the header itself. If not, report an error to the user and stop parsing the table in order to prevent buffer overruns. Signed-off-by: Krzysztof Koch --- Changes can be seet at: https://github.co

Re: [edk2-devel] Saving data structure at Pre EFI Initialization phase in memory to use it at DXE phase by some UEFI application?

2020-01-30 Thread sergestus
I've understood, thanks a lot! Sergey -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#53584): https://edk2.groups.io/g/devel/message/53584 Mute This Topic: https://groups.io/mt/70267536/21656 Group Owner: devel+ow...@edk2.groups.io Unsubsc

Re: [edk2-devel] [Xen-devel] [PATCH 4/5] OvmfPkg/XenPlatformPei: Calibrate APIC timer frequency

2020-01-30 Thread Andrew Cooper
On 30/01/2020 12:44, Anthony PERARD wrote: > On Thu, Jan 30, 2020 at 10:12:51AM +0100, Roger Pau Monné wrote: >> On Wed, Jan 29, 2020 at 12:12:34PM +, Anthony PERARD wrote: >>> + Parameters.domid = DOMID_SELF; >>> + Parameters.gpfn = (UINTN) PagePtr >> EFI_PAGE_SHIFT; >>> + ReturnCode = XenH

Re: [edk2-devel] Saving data structure at Pre EFI Initialization phase in memory to use it at DXE phase by some UEFI application?

2020-01-30 Thread Laszlo Ersek
On 01/30/20 13:57, serges...@yandex.ru wrote: > Thank you, may I just create a new GUID (sysHostGuid), Right, just get your own GUID with "uuidgen". > then call BuildGuidDataHob passing in it the sysHostGuid Yes. > and SYSHOST structure? Well, not exactly. It depends. If your SYSHOST structur

Re: [edk2-devel] [Patch 3/5] CryptoPkg/Driver: Add Crypto PEIM, DXE, and SMM modules

2020-01-30 Thread Laszlo Ersek
On 01/30/20 08:00, Michael D Kinney wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=2420 > > Based on the following package with changes to merge into > CryptoPkg. > > https://github.com/microsoft/mu_plus/tree/dev/201908/SharedCryptoPkg > > Add the CryptoPei, CryptoDxe, and CryptoSmm mod

Re: [edk2-devel] Saving data structure at Pre EFI Initialization phase in memory to use it at DXE phase by some UEFI application?

2020-01-30 Thread sergestus
Thank you, may I just create a new GUID (sysHostGuid), then call BuildGuidDataHob passing in it the sysHostGuid and SYSHOST structure? Will I be able to find the structure in the DXE phase looking up by the sysHostGuid? Thank you, Sergey -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all

Re: [edk2-devel] [PATCH 4/5] OvmfPkg/XenPlatformPei: Calibrate APIC timer frequency

2020-01-30 Thread Anthony PERARD
On Thu, Jan 30, 2020 at 10:12:51AM +0100, Roger Pau Monné wrote: > On Wed, Jan 29, 2020 at 12:12:34PM +, Anthony PERARD wrote: > > + Parameters.domid = DOMID_SELF; > > + Parameters.gpfn = (UINTN) PagePtr >> EFI_PAGE_SHIFT; > > + ReturnCode = XenHypercallMemoryOp (XENMEM_remove_from_physmap,

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg: acpiview: Remove duplicate ACPI structure size definitions

2020-01-30 Thread Sami Mujawar
Reviewed-by: Sami Mujawar Regards, Sami Mujawar -Original Message- From: Krzysztof Koch Sent: 30 January 2020 11:43 To: devel@edk2.groups.io Cc: ray...@intel.com; zhichao@intel.com; Matteo Carlini ; Sami Mujawar ; nd Subject: [PATCH v1 1/1] ShellPkg: acpiview: Remove duplicate A

[edk2-devel] [PATCH v1 1/1] ShellPkg: acpiview: Remove duplicate ACPI structure size definitions

2020-01-30 Thread Krzysztof Koch
Remove duplicate Generic Address Structure (GAS) and ACPI table header size definitions. Replace any dependencies with the definitions from Acpi63.h. AcpiParser.h redefines the size of Generic Address Structure (GAS) and the ACPI table header. The motivation is to 'minimise any reference to the ED

Re: [edk2-devel] [PATCH v1 1/1] MdePkg: Add PCCT table signature definition

2020-01-30 Thread Sami Mujawar
Reviewed-by: Sami Mujawar Regards, Sami Mujawar -Original Message- From: Krzysztof Koch Sent: 30 January 2020 11:14 To: devel@edk2.groups.io Cc: michael.d.kin...@intel.com; liming@intel.com; Matteo Carlini ; Sami Mujawar ; nd Subject: [PATCH v1 1/1] MdePkg: Add PCCT table signat

Re: [edk2-devel] Saving data structure at Pre EFI Initialization phase in memory to use it at DXE phase by some UEFI application?

2020-01-30 Thread Laszlo Ersek
On 01/30/20 12:03, serges...@yandex.ru wrote: > I need to use some code from PEIM driver in DXE phase. This code is > using the SYSHOST structure and I think it not easy to restore it > from HOBs becuase there are a lot of information. So I thought it > easy to save the structure completely in the

[edk2-devel] [PATCH v1 1/1] MdePkg: Add PCCT table signature definition

2020-01-30 Thread Krzysztof Koch
Acpi63.h contains definitions describing the Platform Communications Channel Table's (PCCT) structure. However, a macro for the table's signature is missing. This patch adds the definition of Platform Communications Channel Table's signature. References: - ACPI 6.3, January 2019, Section 14.1 Si

Re: [edk2-devel] Saving data structure at Pre EFI Initialization phase in memory to use it at DXE phase by some UEFI application?

2020-01-30 Thread sergestus
I need to use some code from PEIM driver in DXE phase. This code is using the SYSHOST structure and I think it not easy to restore it from HOBs becuase there are a lot of information. So I thought it easy to save the structure completely in the memory. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: Y

Re: [edk2-devel] [PATCH 3/5] OvmfPkg/IndustryStandard/Xen: Apply EDK2 coding style to XEN_VCPU_TIME_INFO

2020-01-30 Thread Anthony PERARD
On Wed, Jan 29, 2020 at 05:14:35PM +0100, Laszlo Ersek wrote: > On 01/29/20 13:12, Anthony PERARD wrote: > Assuming the OVMF platforms continue to build at this stage into the > series, and provided that (1) and (2) are fixed: I'll fix (1) and (2). I've build tests both OvmfXen and OvmfPkgX64, an

Re: [edk2-devel] Saving data structure at Pre EFI Initialization phase in memory to use it at DXE phase by some UEFI application?

2020-01-30 Thread Marvin Häuser
Hey, Are HOBs ("Hand-Off Blocks") what you are looking for? They are passed from PEI to DXE (see PI 1.6, 9.3 "Passing the Hand-Off Block (HOB) List"). Regards, Marvin Am 30.01.2020 um 10:51 schrieb serges...@yandex.ru: > Is it possible to save SYSHOST data structure at PEI phase in memory at >

[edk2-devel] Saving data structure at Pre EFI Initialization phase in memory to use it at DXE phase by some UEFI application?

2020-01-30 Thread sergestus
Is it possible to save SYSHOST data structure at PEI phase in memory at some default location to use it at DXE phase by some UEFI application? -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#53570): https://edk2.groups.io/g/devel/message/

Re: [edk2-devel] [tianocore-docs][PATCH V1 1/1] edk2-MinimumPlatformSpecification: Advanced Feature section updates

2020-01-30 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Kubacki, Michael A Sent: Tuesday, January 28, 2020 1:17 AM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Desimone, Nathaniel L Subject: [tianocore-docs][PATCH V1 1/1] edk2-MinimumPlatformSpecification: Advanced Feature section

Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg: Fixed Asserts in SCT Runtime Services test.

2020-01-30 Thread Ard Biesheuvel
On Thu, 30 Jan 2020 at 06:08, Gaurav Jain wrote: > > ASSERT in SetTime_Conf and SetWakeupTime_Conf Consistency Test. > SCT Test expect return as Invalid Parameter. > So removed ASSERT(). > This is not all this patch does. > Signed-off-by: Gaurav Jain > --- > EmbeddedPkg/RealTimeClockRuntimeDxe

Re: [edk2-devel] [PATCH 4/5] OvmfPkg/XenPlatformPei: Calibrate APIC timer frequency

2020-01-30 Thread Roger Pau Monné
On Wed, Jan 29, 2020 at 12:12:34PM +, Anthony PERARD wrote: > Calculate the frequency of the APIC timer that Xen provides. > > Even though the frequency is currently hard-coded, it isn't part of > the public ABI that Xen provides and thus may change at any time. OVMF > needs to determine the f

[edk2-devel] [PATCH 1/1] MdeModulePkg/Pci: Fixed Asserts in SCT PCIIO Protocol Test.

2020-01-30 Thread Gaurav Jain
ASSERT in CopyMem_Conf, PollMem_Conf, SetBarAttributes_Conf Conformance Test. SCT Test expect return as Invalid Parameter. So removed ASSERT(). Signed-off-by: Gaurav Jain --- .../NonDiscoverablePciDeviceIo.c | 20 --- 1 file changed, 17 insertions(+), 3 deletions(-)