Re: [edk2-devel] [PATCH v4 2/2] CryptoPkg/BaseHashLib: Implement Unified Hash Calculation API

2020-01-17 Thread Hot Tian
Edk2 is now using BSD-2-Clause-Patent license. +Copyright (c) 2009 - 2020, Intel Corporation. All rights reserved. +(C) Copyright 2016 Hewlett Packard Enterprise Development LP This +program and the accompanying materials are licensed and made available +under the terms and conditions of the BSD

[edk2-devel] [PATCH v4 0/2] CryptoPkg/BaseHashLib: Implement Unified Hash Calculation API

2020-01-17 Thread Sukerkar, Amol N
Currently, the UEFI drivers using the SHA/SM3 hashing algorithms use hard-coded API to calculate the hash, for instance, sha_256(...), etc. Since SHA384 and/or SM3_256 are being increasingly adopted for robustness, it becomes cumbersome to modify each driver that calls into hash calculating API. T

[edk2-devel] [PATCH v4 2/2] CryptoPkg/BaseHashLib: Implement Unified Hash Calculation API

2020-01-17 Thread Sukerkar, Amol N
This commit introduces a Unified Hash API to calculate hash using a hashing algorithm specified by the PCD, PcdSystemHashPolicy. This library interfaces with the various hashing API, such as, MD4, MD5, SHA1, SHA256, SHA512 and SM3_256 implemented in BaseCryptLib. The user can calculate the desired

[edk2-devel] [PATCH v4 1/2] CryptoPkg: Add CryptoPkg Token Space GUID

2020-01-17 Thread Sukerkar, Amol N
Added CryptoPkg Token Space GUID to be able to define PCDs. Cc: Jiewen Yao Cc: Jian J Wang Cc: Michael D Kinney Signed-off-by: Sukerkar, Amol N --- CryptoPkg/CryptoPkg.dec | 7 ++- CryptoPkg/Include/Guid/CryptoPkgTokenSpace.h | 19 +++ 2 files changed

Re: [edk2-devel] [PATCH edk2-platforms 2/2] Maintainers.txt: update email address for Leif Lindholm

2020-01-17 Thread Leif Lindholm
On Fri, Jan 17, 2020 at 05:42:35 +, Kinney, Michael D wrote: > Reviewed-by: Michael D Kinney Thanks! Pushed as 19c82dcb8d49. Expect this address to go permanently offline within the next week or so. / Leif > > -Original Message- > > From: Leif Lindholm > > Sent: Tuesday, Janu

Re: [edk2-devel] [Patch v5 21/22] .mergify: Add Mergify YML pull request rules configuration file

2020-01-17 Thread Leif Lindholm
Hi Mike, Many thanks for resolving! I'll try your other suggestions if this happens again in future. Best Regards, Leif On Fri, Jan 17, 2020 at 20:22:03 +, Kinney, Michael D wrote: > Hi Leif, > > I have not tried the mergify commands like that. I can investigate > further if we think we n

Re: [edk2-devel] [Patch v5 21/22] .mergify: Add Mergify YML pull request rules configuration file

2020-01-17 Thread Michael D Kinney
Hi Leif, I have not tried the mergify commands like that. I can investigate further if we think we need them. I saw that some of the Azure pipelines checks did not run. That Is what was blocking Mergify. Mergify was waiting for status. I did a Close and Re-open to re-trigger Azure Pipelines a

Re: [edk2-devel] [PATCH] BaseTools/Conf/gitattributes: fix "--function-context" for *.h and *.c

2020-01-17 Thread Leif Lindholm
Hi Laszlo, On Fri, Jan 17, 2020 at 19:09:22 +0100, Laszlo Ersek wrote: > On 01/17/20 14:05, Leif Lindholm wrote: > > On Fri, Jan 17, 2020 at 09:30:49 +0100, Laszlo Ersek wrote: > >> On 01/17/20 01:56, Gao, Liming wrote: > >>> Leif: > >>> .act is same to .aslc. There are no cases in open source.

Re: [edk2-devel] [Patch v5 21/22] .mergify: Add Mergify YML pull request rules configuration file

2020-01-17 Thread Leif Lindholm
Hi Mike (on-list), Embarassing to admit, but I hadn't tried to do my first mergify commit until the Maintainers.txt right now, and that isn't working as I expected. I tried to force a retry on https://github.com/tianocore/edk2/pull/307 (since I added the 'push' tag *after* submitting the github p

Re: [edk2-devel] [PATCH] BaseTools/Conf/gitattributes: fix "--function-context" for *.h and *.c

2020-01-17 Thread Laszlo Ersek
On 01/17/20 14:05, Leif Lindholm wrote: > On Fri, Jan 17, 2020 at 09:30:49 +0100, Laszlo Ersek wrote: >> On 01/17/20 01:56, Gao, Liming wrote: >>> Leif: >>> .act is same to .aslc. There are no cases in open source. >> >> How about this then: >> >> *.[Aa][Cc][Tt] diff=cpp >> *.[Aa][Ss][Ll][Cc

Re: [edk2-devel] [PATCH v2 1/1] BaseTools: Script for converting .aml to .hex

2020-01-17 Thread PierreGondois
The changes requested by Liming Gao in v1 have been made, Regards, Pierre -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#53368): https://edk2.groups.io/g/devel/message/53368 Mute This Topic: https://groups.io/mt/69846798/21656 Group Owne

[edk2-devel] [PATCH v2 1/1] BaseTools: Script for converting .aml to .hex

2020-01-17 Thread PierreGondois
From: Pierre Gondois The "-tc" option of the iasl compiler allows to generate a .hex file containing a C array storing AML bytecode. An online discussion suggested that this "-tc" option was specific to the iasl compiler and it shouldn't be relied on. This conversation is available at: https://e

Re: [edk2-devel] [PATCH v2 00/78] Fix a bunch of typos (part 1)

2020-01-17 Thread Philippe Mathieu-Daudé
Hello Jian and Hao, As you are listed as the maintainer, do you mind reviewing the following patches: MdeModulePkg: https://edk2.groups.io/g/devel/message/52743 https://edk2.groups.io/g/devel/message/52750 https://edk2.groups.io/g/devel/message/52751 If it is easier in your workflow you can r

Re: [edk2-devel] [PATCH v2 00/78] Fix a bunch of typos (part 1)

2020-01-17 Thread Philippe Mathieu-Daudé
Hello Ray, As you are listed as the maintainer, do you mind reviewing the following patches: EmulatorPkg: https://edk2.groups.io/g/devel/message/52739 https://edk2.groups.io/g/devel/message/52740 FatPkg: https://edk2.groups.io/g/devel/message/52741 MdeModulePkg: https://edk2.groups.io/g/deve

Re: [edk2-devel] [PATCH edk2-platforms] Silicon/SynQuacer/NetsecDxe: ignore DMA coherency at binding time

2020-01-17 Thread Ard Biesheuvel
On Fri, 17 Jan 2020 at 14:07, Leif Lindholm wrote: > > On Fri, Jan 17, 2020 at 12:16:51 +0100, Ard Biesheuvel wrote: > > Whether the Netsec driver is built to support coherent or non-coherent > > DMA is decided by the DmaLib library class resolution that is provided > > by the platform description

Re: [edk2-devel] [PATCH edk2-platforms] Silicon/SynQuacer/NetsecDxe: ignore DMA coherency at binding time

2020-01-17 Thread Leif Lindholm
On Fri, Jan 17, 2020 at 12:16:51 +0100, Ard Biesheuvel wrote: > Whether the Netsec driver is built to support coherent or non-coherent > DMA is decided by the DmaLib library class resolution that is provided > by the platform description, and there are various other places where > the platform need

Re: [edk2-devel] [PATCH] BaseTools/Conf/gitattributes: fix "--function-context" for *.h and *.c

2020-01-17 Thread Leif Lindholm
On Fri, Jan 17, 2020 at 09:30:49 +0100, Laszlo Ersek wrote: > On 01/17/20 01:56, Gao, Liming wrote: > > Leif: > > .act is same to .aslc. There are no cases in open source. > > How about this then: > > *.[Aa][Cc][Tt] diff=cpp > *.[Aa][Ss][Ll][Cc] diff=cpp > *.[CcHh] diff=cpp > *.[

Re: [edk2-devel] [PATCH v2] UefiCpuPkg/MpInitLib: Fix possible uninitialized 'InitFlag' field

2020-01-17 Thread Laszlo Ersek
On 01/17/20 12:35, Hao A Wu wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2474 > > Previous commit d786a17232: > UefiCpuPkg/MpInitLib: Reduce the size when loading microcode patches > > Removed the below assignments for the 'InitFlag' field of CPU_MP_DATA > structure in function MpI

Re: [edk2-devel] [PATCH v2] UefiCpuPkg/MpInitLib: Fix possible uninitialized 'InitFlag' field

2020-01-17 Thread Wu, Hao A
> -Original Message- > From: Wu, Hao A > Sent: Friday, January 17, 2020 7:35 PM > To: devel@edk2.groups.io > Cc: Wu, Hao A; Dong, Eric; Ni, Ray; Laszlo Ersek; Kinney, Michael D > Subject: [PATCH v2] UefiCpuPkg/MpInitLib: Fix possible uninitialized > 'InitFlag' field > > REF:https://bugzill

[edk2-devel] [PATCH v2] UefiCpuPkg/MpInitLib: Fix possible uninitialized 'InitFlag' field

2020-01-17 Thread Wu, Hao A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2474 Previous commit d786a17232: UefiCpuPkg/MpInitLib: Reduce the size when loading microcode patches Removed the below assignments for the 'InitFlag' field of CPU_MP_DATA structure in function MpInitLibInitialize() when APs are waken up to do so

[edk2-devel] [PATCH edk2-platforms] Silicon/SynQuacer/NetsecDxe: ignore DMA coherency at binding time

2020-01-17 Thread Ard Biesheuvel
Whether the Netsec driver is built to support coherent or non-coherent DMA is decided by the DmaLib library class resolution that is provided by the platform description, and there are various other places where the platform needs to be consistent with this (ACPI tables, device tree, platform drive

Re: [edk2-devel] [PATCH] SecurityPkg/TcgPhysicalPresenceLib: Replace the ASSERT with error code

2020-01-17 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Gao, Zhichao > Sent: Friday, January 17, 2020 4:09 PM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J ; > Zhang, Chao B > Subject: [PATCH] SecurityPkg/TcgPhysicalPresenceLib: Replace the ASSERT with > error code >

Re: [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: fix 2M->4K page splitting regression for PDEs

2020-01-17 Thread Laszlo Ersek
On 01/10/20 00:25, Laszlo Ersek wrote: > In commit 4eee0cc7cc0d ("UefiCpuPkg/PiSmmCpu: Enable 5 level paging when > CPU supports", 2019-07-12), the Page Directory Entry setting was regressed > (corrupted) when splitting a 2MB page to 512 4KB pages, in the > InitPaging() function. > > Consider the

[edk2-devel] Cancelled Event: TianoCore Design Meeting - APAC/NAMO - Friday, 24 January 2020 #cal-cancelled

2020-01-17 Thread devel@edk2.groups.io Calendar
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCEL CALSCALE:GREGORIAN BEGIN:VEVENT STATUS:CANCELLED UID:calendar.23...@groups.io DTSTAMP:20200117T091929Z ORGANIZER;CN=Ray Ni:mailto:ray...@intel.com DTSTART:20200124T013000Z DTEND:20200124T023000Z SUMMARY:TianoC

Re: [edk2-devel] [PATCH v1] UefiCpuPkg/MpInitLib: Fix possible uninitialized 'InitFlag' field

2020-01-17 Thread Wu, Hao A
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Laszlo Ersek > Sent: Friday, January 17, 2020 4:42 PM > To: Wu, Hao A; devel@edk2.groups.io > Cc: Dong, Eric; Ni, Ray; Kinney, Michael D > Subject: Re: [edk2-devel] [PATCH v1] UefiCpuPkg/MpInitLib

Re: [edk2-devel] [PATCH v1] UefiCpuPkg/MpInitLib: Fix possible uninitialized 'InitFlag' field

2020-01-17 Thread Laszlo Ersek
On 01/17/20 07:56, Hao A Wu wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2474 > > Previous commit d786a17232: > UefiCpuPkg/MpInitLib: Reduce the size when loading microcode patches > > Removed the below assignments for the 'InitFlag' field of CPU_MP_DATA > structure in function MpI

Re: [edk2-devel] [PATCH] BaseTools/Conf/gitattributes: fix "--function-context" for *.h and *.c

2020-01-17 Thread Laszlo Ersek
On 01/17/20 01:56, Gao, Liming wrote: > Leif: > .act is same to .aslc. There are no cases in open source. How about this then: *.[Aa][Cc][Tt] diff=cpp *.[Aa][Ss][Ll][Cc] diff=cpp *.[CcHh] diff=cpp *.[Cc][Cc] diff=cpp *.[Cc][Pp][Pp] diff=cpp Thanks, Laszlo -=-=-=-=-

Re: [edk2-devel] [PATCH v1] UefiCpuPkg/MpInitLib: Fix possible uninitialized 'InitFlag' field

2020-01-17 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: devel@edk2.groups.io On Behalf Of Wu, Hao > A > Sent: Friday, January 17, 2020 2:57 PM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Dong, Eric ; Ni, > Ray ; Laszlo Ersek ; Kinney, Michael > D > Subject: [edk2-devel] [PATCH v1] UefiCpuPkg/

Re: [edk2-devel] [PATCH] BaseTools/Conf/gitattributes: fix "--function-context" for *.h and *.c

2020-01-17 Thread Laszlo Ersek
On 01/17/20 01:22, Gao, Liming wrote: > Leif: > Vfr is not C style source file. It can't be regarded as C source > file. > > Laszlo: >Is there such support for the assembly file, such as .nasm? According to the gitattributes(5) manual, there doesn't seem to be a git-diff driver for assembl

Re: [edk2-devel] [PATCH 1/2] Maintainers.txt: update email address for Leif Lindholm

2020-01-17 Thread Laszlo Ersek
On 01/16/20 22:34, Leif Lindholm wrote: > On Thu, Jan 16, 2020 at 19:54:43 +0100, Philippe Mathieu-Daudé wrote: >>> Phil, would it make sense for us to ask Leif to post an update to >>> ".mailmap"? >>> >>> For example, what happens if we run "git shortlog" over a period that >>> contains patches au

[edk2-devel] [PATCH] SecurityPkg/TcgPhysicalPresenceLib: Replace the ASSERT with error code

2020-01-17 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2472 Replace the ASSERT with the error code return in the TpmPhysicalPresence and GetTpmCapability. Add missing error checking after call TpmPhysicalPresence in TcgPhysicalPresenceLibProcessRequest. Cc: Jiewen Yao Cc: Jian J Wang Cc: Chao Zhan

[edk2-devel] [PATCH] SecurityPkg/TcgPhysicalPresenceLib: Fix the operation of 11

2020-01-17 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2473 Refer to Physical Presence Interface Spec Page 37, the firmware may perform the PLATFORM RESET imediately after the TPM_PhysicalSetDeactivated = TRUE but that requires tracking the next command. Change the operation to match the spec. Cc: J