Re: [edk2-devel] [PATCH 0/5] remove EnterS3WithImmediateWake () from ResetSystemLib

On Tue, 7 Jan 2020 at 03:05, Ni, Ray wrote: > > Reviewed-by: Ray Ni > Series pushed, thanks all. > > -Original Message- > > From: Ard Biesheuvel > > Sent: Monday, January 6, 2020 11:13 PM > > To: devel@edk2.groups.io > > Cc: Ma, Maurice ; Dong, Guo > > ; You, Benjamin ; Ni, Ray > > ; G

Re: [edk2-devel] [RFC] BZ 2298 MdePkg/DevicePathLib merger or not

Ray, I prefer to merge these two lib instance into one folder and remove the duplicated code. I can change all the required change in open source repo. But not sure how many close source platforms would be affected. This action should make all the close platform owners aware of it and changing t

Re: [edk2-devel] [RFC] BZ 2298 MdePkg/DevicePathLib merger or not

Zhichao, What's your recommendation regarding this? Back to your 2nd question, drivers/applications consuming UefiDevicePathLibOptionalDevicePathProtocol can firstly use the firmware built-in from-text and to-text conversion, then use its own conversion logic if the firmware doesn't contain buil

[edk2-devel] [Patch] UefiCpuPkg: Add microcode flash address to EDKII microcode patch HOB.

This patch adds the original microcode flash address to EDKII microcode patch HOB after the microcode loaded by processor. This information can be used to check if a microcode slot has been used by existing processor or not. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2454 Cc: Eric Dong C

Re: [edk2-devel] [Patch] UefiCpuPkg: Shadow microcode patch according to FIT microcode entry.

Send by misoperation。 This patch has already been merged, pls ignore. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Siyuan, > Fu > Sent: 2020年1月10日 14:38 > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Laszlo > Ersek > Subject: [edk2-devel] [Patch] UefiCpuPkg: Sh

Re: [edk2-devel] [PATCH V2] BaseTools:Change the case rules for ECC check pointer names

Please update the copyright to 2020 Thanks, Bob -Original Message- From: Fan, ZhijuX Sent: Friday, January 10, 2020 12:18 PM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C Subject: [PATCH V2] BaseTools:Change the case rules for ECC check pointer names BZ:https://bugzilla.tianoc

Re: [edk2-devel] [PATCH 1/5] MdeModulePkg: remove EnterS3WithImmediateWake () from ResetSystemLib

On Fri, 10 Jan 2020 at 02:21, Ni, Ray wrote: > > I remember that I have given Reviewed-by. Have I? > Indeed. MdeModulePkg only has so many entries in Maintainers now that I failed to spot that you were responding to both PcAtChipsetPkg and MdeModulePkg. Thanks, > > -Original Message- >

[edk2-devel] [Patch] UefiCpuPkg: Shadow microcode patch according to FIT microcode entry.

The existing MpInitLib will shadow the microcode update patches from flash to memory and this is done by searching microcode region specified by PCD PcdCpuMicrocodePatchAddress and PcdCpuMicrocodePatchRegionSize. This brings a limition to platform FW that all the microcode patches must be placed in

Re: [edk2-devel] [PATCH] BaseTools: Retrieve git version info

Hi Pankaj, With your example in previous mail, I understand the usage model. Thanks. What about adding a scripts in BaseTools/Scripts to implementing this function? I'd expect the build wrapper only have the simple logic of calling build.py. Thanks, Bob -Original Message- From: Pankaj B

Re: [edk2-devel][edk2-platforms][PATCH v5] IntelSiliconPkg/Feature/SmmAccess/*: Fix incorrect Doxygen comment

Reviewed-by: Sai Chaganty -Original Message- From: Chen, Marc W Sent: Thursday, January 09, 2020 9:20 PM To: devel@edk2.groups.io Cc: Kubacki, Michael A ; Chaganty, Rangasai V ; Ni, Ray ; Gao, Liming ; Zhang, Shenglei ; Chen, Marc W Subject: [edk2-devel][edk2-platforms][PATCH v5] I

Re: [edk2-devel] [PATCH 1/1] ShellPkg/Application: Support nested variables substitution from cmd line

Vladimir, Is this enhancement an extension to Shell spec or violation of Shell spec? If it's an extension, I am happy to have such feature implemented. Otherwise, we may need to discuss in uefi.org. Can you list the unit tests you have done? Thanks, Ray > -Original Message- > From: devel

Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH] MdePkg/Protocols: Code Syntax correction

Resending the previous change; and also in the following repo:- https://github.com/ashrafj/edk2-staging/commit/dcc3bec4b0b40895834909500e3c82465693cadc Thanks Ashraf > -Original Message- > From: devel@edk2.groups.io On Behalf Of Javeed, > Ashraf > Sent: Friday, January 10, 2020 11:24 AM

[edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH] MdePkg/Protocols: Code Syntax correction

Signed-off-by: Ashraf Javeed Cc: Michael D Kinney Cc: Liming Gao Cc: Ray Ni --- --- MdePkg/Include/Protocol/PciExpressPlatform.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdePkg/Include/Protocol/PciExpressPlatform.h b/MdePkg/Include/Protocol/PciExpressPlatform.h

Re: [edk2-devel] [PATCH 1/3] MdeModulePkg/SdMmcPciHcDxe: Refactor command error detection

Hello Mateusz, Some inline comments below: > -Original Message- > From: Albecki, Mateusz > Sent: Tuesday, January 07, 2020 7:06 PM > To: devel@edk2.groups.io > Cc: Albecki, Mateusz; Wu, Hao A; Marcin Wojtas; Gao, Zhichao; Gao, Liming > Subject: [PATCH 1/3] MdeModulePkg/SdMmcPciHcDxe: Ref

Re: [edk2-devel] [PATCH 2/3] MdeModulePkg/SdMmcPciHcDxe: Add retries for sync commands

> -Original Message- > From: Albecki, Mateusz > Sent: Tuesday, January 07, 2020 7:06 PM > To: devel@edk2.groups.io > Cc: Albecki, Mateusz; Wu, Hao A; Marcin Wojtas; Gao, Zhichao; Gao, Liming > Subject: [PATCH 2/3] MdeModulePkg/SdMmcPciHcDxe: Add retries for sync > commands > > REF: https:/

Re: [edk2-devel] [PATCH 3/3] MdeModulePkg/SdMmcPciHcDxe: Add retries for async commands

> -Original Message- > From: Albecki, Mateusz > Sent: Tuesday, January 07, 2020 7:06 PM > To: devel@edk2.groups.io > Cc: Albecki, Mateusz; Wu, Hao A; Marcin Wojtas; Gao, Zhichao; Gao, Liming > Subject: [PATCH 3/3] MdeModulePkg/SdMmcPciHcDxe: Add retries for async > commands > > This patch

[edk2-devel][PATCH 1/3] MdePkg: Add definition for Fmp Capsule Dependency.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2421 Add new definitions for Fmp Capsule dependency in UEFI Spec 2.8. 1. Extend the Last Attempt Status with a value to indicate the firmware update fails with unsatisfied dependencies. 2. Add the definition of dependency expression op-codes. 3.

[edk2-devel][PATCH 2/3] MdeModulePkg/CapsuleApp: Enhance CapsuleApp for Fmp Capsule Dependency

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2421 1. Enhance "CapsuleApp -P" to output the depex expression op-codes in the EFI_FIRMWARE_IMAGE_DESCRIPTOR. 2. Enhance Last Attempt Status String with a new string to describe the error LAST_ATTEMPT_STATUS_ERROR_UNSATISFIED_DEPENDENCIES. Cc: M

[edk2-devel][PATCH 0/3] Fmp Capsule Dependency implementation.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2421 This series implements Fmp Capsule Dependency. Fmp Capsule Dependency is an incremental change of Fmp Capsule Update. The capsule format is extended to include a set of binary encoded dependency expression. The dependency expression is eval

[edk2-devel][PATCH 3/3] FmdDevicePkg/FmpDxe: Support Fmp Capsule Dependency.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2421 Capsule Dependency is an incremental change of Fmp Capsule Update. The capsule format is extended to include a set of binary encoded dependency expression. The dependency expression is signed together with the Fmp payload and evaluated befor

[edk2-devel][edk2-platforms][PATCH v5] IntelSiliconPkg/Feature/SmmAccess/*: Fix incorrect Doxygen comment

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2436 Fixed some doxygen comment that does not follow correct doxygen format. Updated some description of some functions. Notes: v1: - Initial version of code change. v2: - Update some description of some functions. v3: - Update some description

Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH V1] MdePkg/Protocols: New PCI Express Platform Protocol, EFI encodings

Hi Liming, Here is the updated commit with its title / message corrected, in the following edk2-staging repo: https://github.com/ashrafj/edk2-staging/commit/532f2d87a895a1e7b6846ca19c9bbc02f8702a3a Thanks Ashraf > -Original Message- > From: devel@edk2.groups.io On Behalf Of Javeed, > As

[edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH V1] MdePkg/Protocols: New PCI Express Platform Protocol, EFI encodings

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1954 Three interfaces added to PCI Express Platform Protocol:- (1) GetDevicePolicy() -> to retrieve device-specific platform policies (2) NotifyDeviceState() -> to notify platform about device PCI Express configuration state (3) GetPolicy() ->

[edk2-devel] [PATCH V2] BaseTools:Change the case rules for ECC check pointer names

BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2087 In CryptHkdf.c line 42 EVP_PKEY_CTX *pHkdfCtx; Variable pHkdfCtx begins with lower case 'p', which should be acceptable because it it is a pointer. (Refer to CCS_2_1_Draft, 4.3.3.3) So ECC tool should be improved to handle issues like th

Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH V8] MdePkg/Protocols: New PCI Express Platform Protocol, EFI encodings

Ashraf: This is new commit bases on original one. Please update patch title and commit message. Thanks Liming > -Original Message- > From: Javeed, Ashraf > Sent: Friday, January 10, 2020 12:00 PM > To: devel@edk2.groups.io; Javeed, Ashraf > Cc: Kinney, Michael D ; Gao, Liming > ; Ni

[edk2-devel] [PATCH v1] BaseTools/Capsule: Add capsule dependency support

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2412 Capsule generate tool support encode capsule dependencies through '-j' command with a JSON file. To enable dependency feature, "Dependencies" field for each payload in JSON file is required. The value of "Dependencies" field is C style infix

Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH V8] MdePkg/Protocols: New PCI Express Platform Protocol, EFI encodings

Hi, You can also review this patch into the below edk2-staging repo:- https://github.com/ashrafj/edk2-staging/commit/84ec9f060bab7d5ec97b36367e87124820694934 Thanks Ashraf > -Original Message- > From: devel@edk2.groups.io On Behalf Of Javeed, > Ashraf > Sent: Friday, January 10, 2020 9:2

[edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH V8] MdePkg/Protocols: New PCI Express Platform Protocol, EFI encodings

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1954 Three interfaces added to PCI Express Platform Protocol:- (1) GetDevicePolicy() -> to retrieve device-specific platform policies (2) NotifyDeviceState() -> to notify platform about device PCI Express configuration state (3) GetPolicy() ->

Re: [edk2-devel] [PATCH v2 2/2] UefiCpuPkg: Shadow microcode patch according to FIT microcode entry.

Reviewed-by: Eric Dong > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Siyuan, Fu > Sent: Thursday, January 9, 2020 10:14 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > ; Dong, Eric ; Ni, Ray > ; ler...@redhat.com > Sub

Re: [edk2-devel][edk2-platforms][PATCH v4] IntelSiliconPkg/Feature/SmmAccess/*: Fix incorrect Docygen comment

Hi Marc, I already added my R-b in V3, that can be used here. I just wanted to note that it would be nice in the future if you could include a Git note in the commit that summarizes the changes between patch versions. Thanks, Michael > -Original Message- > From: Chen, Marc W > Sent: T

[edk2-devel][edk2-platforms][PATCH v4] IntelSiliconPkg/Feature/SmmAccess/*: Fix incorrect Docygen comment

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2436 Cc: Michael Kubacki Cc: Sai Chaganty Cc: Ray Ni Cc: Liming Gao Cc: Shenglei Zhang Signed-off-by: Marc Chen --- .../Library/PeiSmmAccessLib/PeiSmmAccessLib.c | 37 +-- .../SmmAccess/SmmAccessDxe/SmmAccessDriver.c

Re: [edk2-devel] [PATCH v2 1/2] MdePkg: Add header file for Firmware Interface Table specification.

Reviewed-by: Liming Gao > -Original Message- > From: Fu, Siyuan > Sent: Thursday, January 9, 2020 10:14 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > ; Dong, Eric ; Ni, Ray > ; ler...@redhat.com > Subject: [PATCH v2 1/2] MdePkg: Add header file for Firmware Inter

[edk2-devel] [RFC] BZ 2298 MdePkg/DevicePathLib merger or not

HI all, REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2298 In the MdePkg, there are two folder for the DevicePathLib: 1. MdePkg\Library\UefiDevicePathLib 2. MdePkg\Library\UefiDevicePathLibDevicePathProtocol UefiDevicePathLibDevicePathProtocol is created to use the protocol to

Re: [edk2-devel] [PATCH 1/5] MdeModulePkg: remove EnterS3WithImmediateWake () from ResetSystemLib

I remember that I have given Reviewed-by. Have I? > -Original Message- > From: Laszlo Ersek > Sent: Thursday, January 9, 2020 8:56 PM > To: Ard Biesheuvel ; edk2-devel-groups-io > > Cc: Ni, Ray ; Wu, Hao A ; Wang, Jian J > ; Gao, Zhichao > > Subject: Re: [PATCH 1/5] MdeModulePkg: remo

Re: [edk2-devel] [RFC PATCH 2/2] MdeModulePkg/BdsDxe: allow consoles on drivers loaded via Driver####

Ard, I will give update on this by end of this week. sorry about the delay. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ard Biesheuvel > Sent: Thursday, January 9, 2020 8:54 PM > To: Ni, Ray > Cc: devel@edk2.groups.io; Laszlo Ersek ; Leif Lindholm > ; Gao, Zhichao > ;

[edk2-devel] New files uploaded to devel@edk2.groups.io

Hello, This email message is a notification to let you know that the following files have been uploaded to the Files area of the devel@edk2.groups.io group. * /Designs/2020/0110/EnablingPytools-Edk2PlatformsAndOvmf.pptx ( https://edk2.groups.io/g/devel/files/Designs/2020/0110/EnablingPytools-Ed

[edk2-devel] Upcoming Event: TianoCore Design Meeting - APAC/NAMO - Fri, 01/10/2020 9:30am-10:30am #cal-reminder

*Reminder:* TianoCore Design Meeting - APAC/NAMO *When:* Friday, 10 January 2020, 9:30am to 10:30am, (GMT+08:00) Asia/Chongqing *Where:* BlueJeans Meeting View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=674831 ) *Organizer:* Ray Ni ray...@intel.com ( ray...@intel.com?subject=Re:%

Re: [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Add missed comments for parameter.

Reviewed-by: Ray Ni > -Original Message- > From: devel@edk2.groups.io On Behalf Of Dong, Eric > Sent: Thursday, January 9, 2020 1:27 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Laszlo Ersek > Subject: [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Add missed comments > for parameter

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: build_linux_installer.py path fixes

Hi Philippe, I sincerely appreciate the code review, thank you! I have addressed your feedback, please see PATCH V2. Thanks, Nate -Original Message- From: Philippe Mathieu-Daudé Sent: Thursday, January 2, 2020 9:24 PM To: devel@edk2.groups.io; Desimone, Ashley E ; Desimone, Nathaniel

[edk2-devel] [edk2-staging/EdkRepo] [PATCH V2] EdkRepo: build_linux_installer.py path fixes

Make path handling in build_linux_installer.py more platform agnostic Cc: Ashley DeSimone Cc: Puja Pandya Cc: Erik Bjorge Cc: Bret Barkelew Cc: Philippe Mathieu-Daudé Signed-off-by: Nate DeSimone --- build-scripts/build_linux_installer.py | 10 +- 1 file changed, 5 insertions(+), 5

Re: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix 32-bit truncation in HTTPS download

Reviewed-by: Siyuan Fu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Laszlo > Ersek > Sent: 2020年1月9日 7:43 > To: edk2-devel-groups-io > Cc: Wu, Jiaxin ; Maciej Rabeda > ; Fu, Siyuan > Subject: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix 32-bit truncation > in HTTP

[edk2-devel] Upcoming Event: TianoCore Bug Triage - APAC / NAMO - Thu, 01/09/2020 5:00pm-5:30pm #cal-reminder

*Reminder:* TianoCore Bug Triage - APAC / NAMO *When:* Thursday, 9 January 2020, 5:00pm to 5:30pm, (GMT-08:00) America/Los Angeles *Where:* https://bluejeans.com/889357567?src=calendarLink View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=503274 ) *Organizer:* Brian Richardson bri

Re: [edk2-devel] [PATCH 4/4] ArmVirtPkg/ArmVirtQemu: add optional support for TPM2 measured boot

Hi Marc-André Would you please share some information on how to use vTPM with QEMU? I saw https://github.com/stefanberger/qemu-tpm But I am not sure if that has been integrated to official QEMU release? > -Original Message- > From: Laszlo Ersek > Sent: Thursday, January 9, 2020 9:07 PM

Re: [edk2-devel] [PATCH v1] IntelSiliconPkg-VTd: Fixed a ECC Error

Reviewed-by: Jiewen Yao > -Original Message- > From: Wang, Iwen Evelyn > Sent: Friday, January 10, 2020 6:15 AM > To: devel@edk2.groups.io > Cc: Huang, Jenny ; Shih, More ; > Ni, Ray ; Chaganty, Rangasai V > ; Yao, Jiewen > Subject: [PATCH v1] IntelSiliconPkg-VTd: Fixed a ECC Error > >

[edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: fix 2M->4K page splitting regression for PDEs

In commit 4eee0cc7cc0d ("UefiCpuPkg/PiSmmCpu: Enable 5 level paging when CPU supports", 2019-07-12), the Page Directory Entry setting was regressed (corrupted) when splitting a 2MB page to 512 4KB pages, in the InitPaging() function. Consider the following hunk, displayed with $ git show --functi

Re: [edk2-devel] [PATCH v1] IntelSiliconPkg-VTd: Fixed a ECC Error

Reviewed-by: Sai Chaganty -Original Message- From: Wang, Iwen Evelyn Sent: Thursday, January 09, 2020 2:15 PM To: devel@edk2.groups.io Cc: Huang, Jenny ; Shih, More ; Ni, Ray ; Chaganty, Rangasai V ; Yao, Jiewen Subject: [PATCH v1] IntelSiliconPkg-VTd: Fixed a ECC Error The function

[edk2-devel] [PATCH v1] IntelSiliconPkg-VTd: Fixed a ECC Error

The function has NO comment immediately preceding it. Need to remove the space between the function and the comment Signed-off-by: Evelyn Wang Cc: Jenny Huang Cc: More Shih Cc: Ray Ni Cc: Rangasai V Chaganty Cc: Jiewen Yao --- In V1: Add a issue description --- Silicon/Intel/IntelSiliconPk

[edk2-devel] [PATCH 1/1] ShellPkg/Application: Support nested variables substitution from cmd line

The current implementation of ShellSubstituteVariables() does not allow substitution of variables names containing another variable name(s) between %...% Example: %text%var_name%% where var_name variable contains 0. Here the variable value which should be returned on substitution would be contents

Re: [edk2-devel] EDK II Maintainers - EDK II CI is now active on edk2/master

Yes. That request is already captured in the BZ. Mike > -Original Message- > From: Laszlo Ersek > Sent: Thursday, January 9, 2020 1:31 PM > To: Kinney, Michael D ; > devel@edk2.groups.io; Sean Brogan > ; Bret Barkelew > ; Gao, Liming > > Subject: Re: [edk2-devel] EDK II Maintainers - E

Re: [edk2-devel] EDK II Maintainers - EDK II CI is now active on edk2/master

Hi Mike, On 01/06/20 19:17, Kinney, Michael D wrote: > Laszlo, > > Sorry for the delay in getting to these PactchCheck.py updates. > I know it is frustrating to be blocked by these types of issues. > I try to look at 2406 tomorrow. I think the manual override is > potentially more complex to imp

[edk2-devel] [PATCH] IntelSiliconPkg-VTd: Fixed a ECC space Error

Signed-off-by: Evelyn Wang Cc: Jenny Huang Cc: More Shih Cc: Ray Ni Cc: Rangasai V Chaganty Cc: Jiewen Yao --- Silicon/Intel/IntelSiliconPkg/Include/Library/PeiGetVtdPmrAlignmentLib.h | 1 - 1 file changed, 1 deletion(-) diff --git a/Silicon/Intel/IntelSiliconPkg/Include/Library/PeiGetVtdP

[edk2-devel] [ANNOUNCE] sbsigntools version 0.9.3 available

The fixes since 0.9.2 are James Bottomley (1): README: update git location and add mailing list information Laszlo Ersek (1): sbvarsign: fix "EFI_VARIABLE_AUTHENTICATION_2.TimeStamp.Year" assignment Steve McIntyre (1): Fix PE/COFF checksum calcul

Re: [edk2-devel] Interpretation of specification

On Thu, 2020-01-09 at 18:17 +0100, Laszlo Ersek wrote: > Hello James, > > On 01/08/20 20:13, James Bottomley wrote: > > On Wed, 2020-01-08 at 12:24 +0100, Laszlo Ersek wrote: > > > I don't know where sbsigntools development occurs (mailing list, > > > bug > > > tracker, ...). For now, I'm CC'ing J

Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/UefiBootManagerLib: log reserved mem allocation failure

On 1/9/20 12:43 AM, Laszlo Ersek wrote: The LoadFile protocol can report such a large buffer size that we cannot allocate enough reserved pages for. This particularly affects HTTP(S) Boot, if the remote file is very large (for example, an ISO image). While the TianoCore wiki mentions this at

Re: [edk2-devel] Interpretation of specification

Hello James, On 01/08/20 20:13, James Bottomley wrote: > On Wed, 2020-01-08 at 12:24 +0100, Laszlo Ersek wrote: >> I don't know where sbsigntools development occurs (mailing list, bug >> tracker, ...). For now, I'm CC'ing James. (The git repo lives in his >> space on .) > > Heh, that's a sore po

Re: [edk2-devel][edk2-platforms][PATCH v3] IntelSiliconPkg/Feature/SmmAccess/*: Fix incorrect Docygen comment

Reviewed-by: Michael Kubacki > -Original Message- > From: Chen, Marc W > Sent: Thursday, January 9, 2020 1:09 AM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chaganty, Rangasai V > ; Ni, Ray ; Gao, Liming > ; Zhang, Shenglei ; > Chen, Marc W > Subject: [edk2-devel][edk2-platfor

Re: [edk2-devel] [edk2-platforms][PATCH 2/2] Platform/RPi/RPiFirmwareDxe: Fix serial number population for RPi4

Hi Ard, On 2020.01.09 14:44, Ard Biesheuvel wrote: On Wed, 8 Jan 2020 at 18:00, Pete Batard wrote: Some (all?) Raspbery Pi 4 platforms report 0x1000 as their board serial when queried through the VideoCore mailbox. Fix this by using the MAC address then. Signed-off-by: Pete Bata

Re: [edk2-devel] [edk2-platforms][PATCH 2/2] Platform/RPi/RPiFirmwareDxe: Fix serial number population for RPi4

On Wed, 8 Jan 2020 at 18:00, Pete Batard wrote: > > Some (all?) Raspbery Pi 4 platforms report 0x1000 as their > board serial when queried through the VideoCore mailbox. > > Fix this by using the MAC address then. > > Signed-off-by: Pete Batard > --- > Platform/RaspberryPi/Drivers/Rp

Re: [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Add missed comments for parameter.

On 01/09/20 06:26, Eric Dong wrote: > This issue caused by below change: > SHA-1: b948a496150f4ae4f656c0f0ab672608723c80e6 > * UefiCpuPkg/PiSmmCpuDxeSmm: Pre-allocate PROCEDURE_TOKEN buffer > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2388 > > Cc: Ray Ni > Cc: Laszlo Ersek > Signe

Re: [edk2-devel] [PATCH] CryptoPkg/BaseCryptLib: deprecate HmacXxxGetContextSize interface

On 01/09/20 03:40, Wang, Jian J wrote: >> -Original Message- >> From: Laszlo Ersek >> Sent: Wednesday, January 08, 2020 6:24 PM >> To: Wang, Jian J ; devel@edk2.groups.io >> Cc: Lu, XiaoyuX >> Subject: Re: [PATCH] CryptoPkg/BaseCryptLib: deprecate >> HmacXxxGetContextSize interface >> >>

Re: [edk2-devel] [PATCH v2 2/2] UefiCpuPkg: Shadow microcode patch according to FIT microcode entry.

Hi, On 01/09/20 03:14, Siyuan Fu wrote: > The existing MpInitLib will shadow the microcode update patches from > flash to memory and this is done by searching microcode region specified > by PCD PcdCpuMicrocodePatchAddress and PcdCpuMicrocodePatchRegionSize. > This brings a limition to platform FW

Re: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix 32-bit truncation in HTTPS download

On 1/9/20 12:43 AM, Laszlo Ersek wrote: When downloading over TLS, each TLS message ("APP packet") is returned as a (decrypted) fragment table by EFI_TLS_PROTOCOL.ProcessPacket(). The TlsProcessMessage() function in "NetworkPkg/HttpDxe/HttpsSupport.c" linearizes the fragment table into a single

Re: [edk2-devel] [PATCH 0/2] OvmfPkg: clean up TPM2 related DSC/FDF content

On Wed, 8 Jan 2020 at 15:53, Philippe Mathieu-Daudé wrote: > > Cc'ing Marc-André & Stefan, maintainers of "OvmfPkg: TCG- and > TPM2-related modules". > > On 1/8/20 3:38 PM, Ard Biesheuvel wrote: > > Clean up some issues that Laszlo spotted in OVMF while reviewing TPM2 > > support for ArmVirtQemu.

Re: [edk2-devel] [PATCH 4/4] ArmVirtPkg/ArmVirtQemu: add optional support for TPM2 measured boot

On 01/09/20 01:51, Yao, Jiewen wrote: > Hi > Comment for the warning: >>> WARNING: TPM2 Event log has HashAlg unsupported by PCR bank (0xC) >>> WARNING: TPM2 Event log has HashAlg unsupported by PCR bank (0xD) > > The reason is that: The DSC added all HASH algorithm to the TCG2 driver. > (SHA1/S

Re: [edk2-devel] [PATCH 2/4] ArmVirtPkg/PlatformPeiLib: discover the TPM base address from the DT

On 01/08/20 15:41, Ard Biesheuvel wrote: > On Tue, 7 Jan 2020 at 16:42, Laszlo Ersek wrote: >> On 01/07/20 10:47, Ard Biesheuvel wrote: >>> >>> diff --git a/ArmVirtPkg/ArmVirtPkg.dec b/ArmVirtPkg/ArmVirtPkg.dec >>> index a019cc269d10..ed5114887489 100644 >>> --- a/ArmVirtPkg/ArmVirtPkg.dec >>> ++

Re: [edk2-devel] [PATCH 1/5] MdeModulePkg: remove EnterS3WithImmediateWake () from ResetSystemLib

On 01/08/20 19:51, Ard Biesheuvel wrote: > On Mon, 6 Jan 2020 at 16:13, Ard Biesheuvel wrote: >> >> EnterS3WithImmediateWake () no longer has any callers, so remove it >> from ResetSystemLib. >> >> Signed-off-by: Ard Biesheuvel > > Ping? > >> --- >> MdeModulePkg/Include/Library/ResetSystemLib.

Re: [edk2-devel] [RFC PATCH 2/2] MdeModulePkg/BdsDxe: allow consoles on drivers loaded via Driver####

On Mon, 23 Dec 2019 at 15:09, Ard Biesheuvel wrote: > > On Thu, 12 Dec 2019 at 10:05, Ard Biesheuvel > wrote: > > > > On Thu, 12 Dec 2019 at 09:59, Ni, Ray wrote: > > > > > > Ard, > > > I still cannot understand it. > > > > > > Since Driver are processed (process = LoadImage + StartImage) a

Re: [edk2-devel] [PATCH 1/2] OvmfPkg: reorganize TPM2 support in DSC/FDF files

On 01/09/20 13:38, Laszlo Ersek wrote: > Hi Ard, > > On 01/08/20 15:38, Ard Biesheuvel wrote: >> Put the TPM2 related DXE modules together in the DSC, and add a >> TPM2 support header comment while at it. >> >> Signed-off-by: Ard Biesheuvel >> --- >> OvmfPkg/OvmfPkgIa32.dsc| 9 ++--- >>

Re: [edk2-devel] [PATCH 2/2] OvmfPkg: use HII type PCDs for TPM2 config related variables

On 01/08/20 15:38, Ard Biesheuvel wrote: > The HII pages that are part of Tcg2ConfigDxe expect the following PCDs > to be of dynamic HII type, so declare them as such. > > gEfiSecurityPkgTokenSpaceGuid.PcdTcgPhysicalPresenceInterfaceVer > gEfiSecurityPkgTokenSpaceGuid.PcdTpm2AcpiTableRev > >

Re: [edk2-devel] [PATCH 1/2] OvmfPkg: reorganize TPM2 support in DSC/FDF files

On Thu, 9 Jan 2020 at 13:38, Laszlo Ersek wrote: > > Hi Ard, > > On 01/08/20 15:38, Ard Biesheuvel wrote: > > Put the TPM2 related DXE modules together in the DSC, and add a > > TPM2 support header comment while at it. > > > > Signed-off-by: Ard Biesheuvel > > --- > > OvmfPkg/OvmfPkgIa32.dsc

Re: [edk2-devel] [PATCH 1/2] OvmfPkg: reorganize TPM2 support in DSC/FDF files

Hi Ard, On 01/08/20 15:38, Ard Biesheuvel wrote: > Put the TPM2 related DXE modules together in the DSC, and add a > TPM2 support header comment while at it. > > Signed-off-by: Ard Biesheuvel > --- > OvmfPkg/OvmfPkgIa32.dsc| 9 ++--- > OvmfPkg/OvmfPkgIa32X64.dsc | 9 ++--- > OvmfPkg

[edk2-devel] [PATCH v4 1/4] BaseTools/PatchCheck.py: Extract email check code to EmailAddressCheck

As we are going to reuse this code out of the CommitMessageCheck class, extract it in a new class: EmailAddressCheck. Cc: Bob Feng Cc: Liming Gao Reviewed-by: Bob Feng Signed-off-by: Philippe Mathieu-Daude --- BaseTools/Scripts/PatchCheck.py | 83 + 1 file chan

[edk2-devel] [PATCH v4 4/4] BaseTools/PatchCheck.py: Check the committer email address

To avoid patches committed with incorrect email address, use the EmailAddressCheck class on the committer email too. Cc: Bob Feng Cc: Liming Gao Reviewed-by: Bob Feng Signed-off-by: Philippe Mathieu-Daude --- BaseTools/Scripts/PatchCheck.py | 6 ++ 1 file changed, 6 insertions(+) diff --

[edk2-devel] [PATCH v4 3/4] BaseTools/PatchCheck.py: Check the patch author email address

To avoid patches committed with incorrect email address, use the EmailAddressCheck class on the author email too. Example: $ python BaseTools/Scripts/PatchCheck.py 1a04951309f Checking git commit: 1a04951309f The 'Author' email address is not valid: * The email address cannot contain a sp

[edk2-devel] [PATCH v4 2/4] BaseTools/PatchCheck.py: Let EmailAddressCheck describe email checked

We are checking different emails from the signature list. We are going to check more. To be able to differency, add a description field, so the error reported is clearer. Cc: Bob Feng Cc: Liming Gao Reviewed-by: Bob Feng Signed-off-by: Philippe Mathieu-Daude --- BaseTools/Scripts/PatchCheck.p

[edk2-devel] [PATCH v4 0/4] BaseTools/PatchCheck: Check committer/author email addresses

Last month I cleaned the git-history incorrect email addresses: https://edk2.groups.io/g/devel/message/51834 but today I noticed more incorrect addresses got committed (see caa917491a4..33a3293651). To avoid having the same cleanup in the future, fix the problem once for all by having PatchCheck do

Re: [edk2-devel] [PATCH v3 4/4] BaseTools/PatchCheck.py: Check the committer email address

On 1/9/20 11:49 AM, Philippe Mathieu-Daude wrote: To avoid patches committed with incorrect email address, use the EmailAddressCheck class on the committer email too. Cc: Liming Gao Cc: Jordan Justen Sorry wrong Cc list, I'll respin. Reviewed-by: Bob Feng Signed-off-by: Philippe Mathieu-D

[edk2-devel] [PATCH v3 1/4] BaseTools/PatchCheck.py: Extract email check code to EmailAddressCheck

As we are going to reuse this code out of the CommitMessageCheck class, extract it in a new class: EmailAddressCheck. Cc: Liming Gao Cc: Jordan Justen Reviewed-by: Bob Feng Signed-off-by: Philippe Mathieu-Daude --- BaseTools/Scripts/PatchCheck.py | 83 + 1 file

[edk2-devel] [PATCH v3 2/4] BaseTools/PatchCheck.py: Let EmailAddressCheck describe email checked

We are checking different emails from the signature list. We are going to check more. To be able to differency, add a description field, so the error reported is clearer. Cc: Liming Gao Cc: Jordan Justen Reviewed-by: Bob Feng Signed-off-by: Philippe Mathieu-Daude --- BaseTools/Scripts/PatchCh

[edk2-devel] [PATCH v3 4/4] BaseTools/PatchCheck.py: Check the committer email address

To avoid patches committed with incorrect email address, use the EmailAddressCheck class on the committer email too. Cc: Liming Gao Cc: Jordan Justen Reviewed-by: Bob Feng Signed-off-by: Philippe Mathieu-Daude --- BaseTools/Scripts/PatchCheck.py | 6 ++ 1 file changed, 6 insertions(+) di

[edk2-devel] [PATCH v3 0/4] BaseTools/PatchCheck: Check committer/author email addresses

Last month I cleaned the git-history incorrect email addresses: https://edk2.groups.io/g/devel/message/51834 but today I noticed more incorrect addresses got committed (see caa917491a4..33a3293651). To avoid having the same cleanup in the future, fix the problem once for all by having PatchCheck do

[edk2-devel] [PATCH v3 3/4] BaseTools/PatchCheck.py: Check the patch author email address

To avoid patches committed with incorrect email address, use the EmailAddressCheck class on the author email too. Example: $ python BaseTools/Scripts/PatchCheck.py 1a04951309f Checking git commit: 1a04951309f The 'Author' email address is not valid: * The email address cannot contain a sp

Re: [edk2-devel] [PATCH v2 0/4] BaseTools/PatchCheck: Check committer/author email addresses

On 1/9/20 10:50 AM, Feng, Bob C wrote: Please update the copyright to 2020. OK will do. For the patch set, Reviewed-by: Bob Feng Thanks! -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Philippe Mathieu-Daudé Sent: Monday, January 6, 20

Re: [edk2-devel] [PATCH] BaseTools: Retrieve git version info

Hi Bob, This OS environment variable is only defined up until the point build command is running. As soon as build command finishes, these OS environment variables also vanish. Regards, Pankaj Bansal -Original Message- From: Feng, Bob C Sent: Thursday, January 9, 2020 3:31 PM To: Pank

Re: [edk2-devel] [PATCH] BaseTools: Retrieve git version info

Hi Pankaj, I think if the firmware module need to show git version information, the version information need to build into firmware binary but not set to OS environment variable. Thanks Bob -Original Message- From: Pankaj Bansal [mailto:pankaj.ban...@nxp.com] Sent: Thursday, January 9

Re: [edk2-devel] [PATCH v2 0/4] BaseTools/PatchCheck: Check committer/author email addresses

Please update the copyright to 2020. For the patch set, Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Philippe Mathieu-Daudé Sent: Monday, January 6, 2020 6:35 PM To: devel@edk2.groups.io Cc: Kinney, Michael D ; Laszlo Er

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] Platform/ARM/ArmJunoDxe: Fix 'unused variable' error for DynamicTables

Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#53056): https://edk2.groups.io/g/devel/message/53056 Mute This Topic: https://groups.io/mt/69576071/21656 Group Owner: devel+ow...@edk2.grou

[edk2-devel] [edk2-platforms][PATCH v1 1/1] Platform/ARM/ArmJunoDxe: Fix 'unused variable' error for DynamicTables

Fix 'mAcpiRegistration defined but not used' compiler error for Dynamic Tables Framework builds. Do not declare the mAcpiRegistration variable in the Dynamic Tables Framework context. An earlier patch made mAcpiRegistration variable STATIC. Reducing the scope made scope resolution simpler, thus,

Re: [edk2-devel] [PATCH 00/13] Extend and fix the TCG/TCG2 Physical Presence Interface

OK. But the PPData is internal implementation, it should never be used as parameter. If what is needed is the Parameter, please use RequestParameter explicitly and align with the TCG2 PP lib. Thank you Yao Jiewen > -Original Message- > From: Gao, Zhichao > Sent: Thursday, January 9,

[edk2-devel][edk2-platforms][PATCH v3] IntelSiliconPkg/Feature/SmmAccess/*: Fix incorrect Docygen comment

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2436 Cc: Michael Kubacki Cc: Sai Chaganty Cc: Ray Ni Cc: Liming Gao Cc: Shenglei Zhang Signed-off-by: Marc Chen --- .../Library/PeiSmmAccessLib/PeiSmmAccessLib.c | 37 ++-- .../SmmAccess/SmmAccessDxe/SmmAccessDriver.c

Re: [edk2-devel] [PATCH 00/13] Extend and fix the TCG/TCG2 Physical Presence Interface

Jiewen, The Tcg2Smm driver support to submit the TPM operation request to pre-OS environment and pre-OS environment, but it only transfer the operation request code and the request parameter and save to the "Tcg2PhysicalPresence" variable. But at the execution part, the interface only transfer t

Re: [edk2-devel][edk2-platforms][PATCH v2] IntelSiliconPkg/Feature/SmmAccess/*: Fix incorrect Docygen comment

Minor correction in SmmAccessDriver.c, in the introduction section - Change "post" to POST as shown below. "The SMM Base driver uses the services provided by the SMM access protocol to open SMRAM during POST and copy the SMM handler." With that update: Reviewed-by: Sai Chaganty Regards, Sai -