This patch removes the unnecessary alignment check on microcode patch TotalSize
introduced by commit d786a172. The TotalSize has already been checked with 1K
alignment and MAX_ADDRESS in previous code as below:
if ( (UINTN)MicrocodeEntryPoint > (MAX_ADDRESS - TotalSize) ||
((UINTN)Mic
This patch updates the microcode loader to always perform a microcode detect
and load on both BSP and AP processor. This is to fix a potential microcode
revision mismatch issue in below situation:
1. Assume there are two microcode co-exists in flash: one production version
and one debug version
Some other comment:
6. I disagree to move NvData.h to securityPkg.
This is designed to be an internal variable.
Why it need to move to security pkg to share with other driver?
I agree that duplicating code is bad solution.
And exposing internal data structure is as bad as duplicating code.
By de
This change looks good. What functionality test have been done?
-Original Message-
From: Pankaj Bansal
Sent: 2019年12月29日 12:54
To: devel@edk2.groups.io
Cc: Pankaj Bansal ; Bi, Dandan ;
Gao, Liming
Subject: [PATCH] MdeModulePkg PeiCore: Install SEC PPIs before library
constructor call
What is the platform use case?
Please give at least some examples.
> -Original Message-
> From: Gao, Zhichao
> Sent: Friday, January 3, 2020 1:08 PM
> To: Yao, Jiewen ; devel@edk2.groups.io
> Cc: Wang, Jian J ; Zhang, Chao B
> ; Justen, Jordan L ;
> Laszlo Ersek ; Ard Biesheuvel ;
> Marc
I found that besides the UsbKbDxe & UsbMouseDxe drivers,
UsbMouseAbsolutePointerDxe
has a similar issue. Could you help to address it as well?
Really sorry about this, I should have caught this earlier.
Best Regards,
Hao Wu
> -Original Message-
> From: devel@edk2.groups.io [mailto:deve
BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//Groups.io Inc//Groups.io Calendar//EN
METHOD:PUBLISH
CALSCALE:GREGORIAN
BEGIN:VEVENT
UID:calendar.23...@groups.io
DTSTAMP:20200103T052559Z
ORGANIZER;CN=Ray Ni:mailto:ray...@intel.com
DTSTART:20200110T013000Z
DTEND:20200110T023000Z
RRULE:FREQ=WEEKLY;INTERVAL=2;B
Hi Nate,
From: Nate DeSimone
Make path handling in build_linux_installer.py more platform agnostic
Cc: Ashley DeSimone
Cc: Puja Pandya
Cc: Erik Bjorge
Cc: Bret Barkelew
Signed-off-by: Nate DeSimone
---
build-scripts/build_linux_installer.py | 8
1 file changed, 4 insertions(+
See below.
> -Original Message-
> From: Yao, Jiewen
> Sent: Friday, January 3, 2020 11:09 AM
> To: Gao, Zhichao ; devel@edk2.groups.io
> Cc: Wang, Jian J ; Zhang, Chao B
> ; Justen, Jordan L ;
> Laszlo Ersek ; Ard Biesheuvel
> ; Marc-André Lureau
> ; Stefan Berger
> Subject: RE: [PATCH 00
The endpoint selected by the driver needs to not
only be an interrupt type, but have direction IN
as required to set up an asynchronous interrupt transfer.
Currently, the driver assumes that the first INT endpoint
will be of type IN, but that is not true of all devices,
and will silently fail on d
USB keyboard initialization fails if the OUT interrupt
endpoint precedes the IN endpoint. Fix that.
Matt DeVillier (1):
MdeModulePkg/Usb/EfiKey: Fix endpoint selection
MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
--
2.20.1
-=-=-=-=-=-=-=
The endpoint selected by the driver needs to not
only be an interrupt type, but have direction IN
as required to set up an asynchronous interrupt transfer.
Currently, the driver assumes that the first INT endpoint
will be of type IN, but that is not true of all devices,
and will silently fail on d
Hi
I am not clear on the purpose of this extension.
The Bugzilla just describes the solution.
But what is the problem you are trying to resolve?
I completely don’t understand.
Please do consider add the background information there.
Or it is hard for me to comment.
Thank you
Yao Jiewen
> ---
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2443
Add Tcg2PpVendorLibExecutePendingRequestEx and
Tcg2PpVendorLibSubmitRequestToPreOSFunctionEx to handle the
EFI_TCG2_PHYSICAL_PRESENCE parameters.
Implement in the null version.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Chao Zhang
Signed-off-by:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2443
Refer to Physical Presence Interface Spec Page 37, the firmware
may perform the PLATFORM RESET imediately after the
TPM_PhysicalSetDeactivated = TRUE but that requires tracking
the next command.
Change the operation to match the spec.
Cc: J
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2443
Extend the Tcg2PhysicalPresenceLibSubmitRequestToPreOSFunctionEx
to handle the FunctionIndex.
And modify the all of this function to avoid build error.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Chao Zhang
Signed-off-by: Zhichao Gao
---
Securi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2443
Use the pcd PcdPhysicalPresenceUserConfirmTimeout to control the
wait time of user response.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Chao Zhang
Signed-off-by: Zhichao Gao
---
.../DxeTcgPhysicalPresenceLib.c | 76 --
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2443
Add Tcg2PpVendorLibExecutePendingRequestEx and
Tcg2PpVendorLibSubmitRequestToPreOSFunctionEx to handle the
EFI_TCG2_PHYSICAL_PRESENCE parameters.
Add the definition first.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Chao Zhang
Signed-off-by: Zhic
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2443
Use the pcd PcdPhysicalPresenceUserConfirmTimeout to control the
wait time of user response.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Chao Zhang
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Cc: Marc-André Lureau
Cc: Stefan Berger
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2443
Add a pcd PcdPhysicalPresenceUserConfirmTimeout to set the wait time
of the user response.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Chao Zhang
Signed-off-by: Zhichao Gao
---
SecurityPkg/SecurityPkg.dec | 7 ++-
SecurityPkg/SecurityPkg.un
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2443
Replace the ASSERT with the error code return in the TpmPhysicalPresence
and GetTpmCapability.
Add missing error checking after call TpmPhysicalPresence in
TcgPhysicalPresenceLibProcessRequest.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Chao Zhan
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2443
1. Add two interfaces Tcg2PpVendorLibExecutePendingRequestEx and
Tcg2PpVendorLibSubmitRequestToPreOSFunctionEx to Tcg2PpVendorLib. It has one
more parameter PPData (type EFI_TCG2_PHYSICAL_PRESENCE) to transfer more data.
2. Use the Ex versio
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2443
Change the call of Tcg2PpVendorLibExecutePendingRequest to
Tcg2PpVendorLibExecutePendingRequestEx.
Change the call of Tcg2PpVendorLibSubmitRequestToPreOSFunction to
Tcg2PpVendorLibSubmitRequestToPreOSFunctionEx.
Cc: Jiewen Yao
Cc: Jian J W
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2443
Use the pcd PcdPhysicalPresenceUserConfirmTimeout to control the
wait time of user response.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Chao Zhang
Signed-off-by: Zhichao Gao
---
.../DxeTcg2PhysicalPresenceLib.c | 61 ++
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2443
Change the call of Tcg2PpVendorLibSubmitRequestToPreOSFunction to
Tcg2PpVendorLibSubmitRequestToPreOSFunctionEx.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Chao Zhang
Signed-off-by: Zhichao Gao
---
.../SmmTcg2PhysicalPresenceLib/SmmTcg2Physica
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2443
Add PPFunction to extend the EFI_TCG2_PHYSICAL_PRESENCE. It
refers to Physical Presence Function Index.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Chao Zhang
Signed-off-by: Zhichao Gao
---
SecurityPkg/Include/Guid/Tcg2PhysicalPresenceData.h |
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2443
Tcg2ConfigNvData.h is useful for the tcg2 driver. So move it
to the Include folder for other platform tcg2 instances to use.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Chao Zhang
Signed-off-by: Zhichao Gao
---
SecurityPkg/{Tcg/Tcg2Config => In
Similar comments with PATCH 1, could you help to change the modified 'if'
statement to:
if (((EndpointDescriptor.Attributes & (BIT0 | BIT1)) == USB_ENDPOINT_INTERRUPT)
&&
((EndpointDescriptor.EndpointAddress & USB_ENDPOINT_DIR_IN) != 0)) {
so that the 2nd condition can be aligned with others
Sorry for the delayed response.
Just a minor coding style comment, could you help to change the modified 'if'
statement to:
if (((EndpointDescriptor.Attributes & (BIT0 | BIT1)) == USB_ENDPOINT_INTERRUPT)
&&
((EndpointDescriptor.EndpointAddress & USB_ENDPOINT_DIR_IN) != 0)) {
so that the 2nd
Reviewed-by: Liming Gao
-Original Message-
From: Zhang, Shenglei
Sent: 2019年12月31日 14:18
To: Chen, Marc W ; devel@edk2.groups.io
Cc: Kubacki, Michael A ; Chaganty, Rangasai V
; Gao, Liming
Subject: RE: [edk2-devel][edk2-platforms][PATCH]
IntelSiliconPkg/Feature/SmmAccess/*: Fix incor
> -Original Message-
> From: Yao, Jiewen
> Sent: Thursday, January 2, 2020 10:16 PM
> To: Zeng, Star ; devel@edk2.groups.io
> Cc: Wang, Jian J ; Wu, Hao A ;
> Bi, Dandan
> Subject: RE: [PATCH 5/6] MdeModulePkg/Smbios: Add TCG PFP rev 105
> support.
>
> Below:
>
> > -Original Messa
Reviewed-by: Jiewen Yao
> -Original Message-
> From: Philippe Mathieu-Daude
> Sent: Friday, January 3, 2020 3:23 AM
> To: devel@edk2.groups.io
> Cc: Leif Lindholm ; Kinney, Michael D
> ; Andrew Fish ; Laszlo Ersek
> ; Philippe Mathieu-Daude ; Yao,
> Jiewen
> Subject: [PATCH v3 13/32] .m
Reviewed-by: Liming Gao
-Original Message-
From: devel@edk2.groups.io On Behalf Of Philippe
Mathieu-Daudé
Sent: 2020年1月3日 3:23
To: devel@edk2.groups.io
Cc: Leif Lindholm ; Kinney, Michael D
; Andrew Fish ; Laszlo Ersek
; Philippe Mathieu-Daude ; Gao, Liming
Subject: [edk2-devel] [PA
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Yonghong Zhu to have his/her name and email
address displayed properly in the git history.
Cc: Yonghong Zhu
Reviewed-by: Yonghong Zhu
Signed-off-by: Philippe Mathieu-Daude
---
.mailmap | 2 ++
1 fil
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Yu-Chen Lin to have his/her name and email
address displayed properly in the git history.
Cc: Yu-Chen Lin
Reviewed-by: Yu-Chen Lin
Signed-off-by: Philippe Mathieu-Daude
---
.mailmap | 1 +
1 file ch
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Vitaly Cheptsov to have his/her name and email
address displayed properly in the git history.
Cc: Vitaly Cheptsov
Reviewed-by: Vitaly Cheptsov
Signed-off-by: Philippe Mathieu-Daude
---
.mailmap | 1
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Vladimir Olovyannikov to have his/her name and
email address displayed properly in the git history.
Cc: Vladimir Olovyannikov
Reviewed-by: Vladimir Olovyannikov
Signed-off-by: Philippe Mathieu-Daude
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Ming Tan to have his/her name and email address
displayed properly in the git history.
Cc: Ming Tan
Reviewed-by: Ming Tan
Signed-off-by: Philippe Mathieu-Daude
---
.mailmap | 1 +
1 file changed, 1
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Michael Kubacki to have his/her name and email
address displayed properly in the git history.
Cc: Michael Kubacki
Reviewed-by: Michael Kubacki
Signed-off-by: Philippe Mathieu-Daude
---
.mailmap | 2
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Nikolai Saoukh to have his/her name and email
address displayed properly in the git history.
Cc: Nikolai Saoukh
Reviewed-by: Nikolai Saoukh
Signed-off-by: Philippe Mathieu-Daude
---
.mailmap | 1 +
Reviewed-by: Ashley DeSimone
-Original Message-
From: Desimone, Nathaniel L
Sent: Thursday, December 26, 2019 6:05 PM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Desimone, Ashley E
; Pandya, Puja ; Bjorge,
Erik C ; Bret Barkelew
Subject: [edk2-staging/EdkRepo] [PATCH] EdkRep
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Star Zeng to have his/her name and email address
displayed properly in the git history.
Cc: Star Zeng
Reviewed-by: Star Zeng
Signed-off-by: Philippe Mathieu-Daude
---
.mailmap | 3 +++
1 file change
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Shenglei Zhang to have his/her name and email
address displayed properly in the git history.
Cc: Shenglei Zhang
Reviewed-by: Shenglei Zhang
Signed-off-by: Philippe Mathieu-Daude
---
.mailmap | 1 +
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Maurice Ma to have his/her name and email
address displayed properly in the git history.
Cc: Maurice Ma
Reviewed-by: Maurice Ma
Signed-off-by: Philippe Mathieu-Daude
---
.mailmap | 1 +
1 file chang
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Samer El-Haj-Mahmoud to have his/her name and
email address displayed properly in the git history.
Cc: Samer El-Haj-Mahmoud
Cc: Samer El-Haj-Mahmoud
Reviewed-by: Samer El-Haj-Mahmoud
Signed-off-by:
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Philippe Mathieu-Daudé to have his/her name and
email address displayed properly in the git history.
Signed-off-by: Philippe Mathieu-Daude
---
.mailmap | 1 +
1 file changed, 1 insertion(+)
diff --gi
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Ray Ni to have his/her name and email address
displayed properly in the git history.
Cc: Ray Ni
Reviewed-by: Ray Ni
Signed-off-by: Philippe Mathieu-Daude
---
.mailmap | 7 +++
1 file changed, 7
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Chasel Chiu to have his/her name and email
address displayed properly in the git history.
Cc: Chasel Chiu
Reviewed-by: Chasel Chiu
Signed-off-by: Philippe Mathieu-Daude
---
.mailmap | 1 +
1 file ch
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Marc-André Lureau to have his/her name and email
address displayed properly in the git history.
Cc: Marc-André Lureau
Reviewed-by: Marc-André Lureau
Signed-off-by: Philippe Mathieu-Daude
---
.mailma
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Erik Bjorge to have his/her name and email
address displayed properly in the git history.
Cc: Erik Bjorge
Reviewed-by: Erik Bjorge
Signed-off-by: Philippe Mathieu-Daude
---
.mailmap | 1 +
1 file ch
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Marvin Häuser to have his/her name and email
address displayed properly in the git history (in particular,
commit 62ec4a5e).
Cc: Marvin Häuser
Cc: Marvin Häuser
Reviewed-by: Marvin Häuser
Signed-off-
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Aaron Li to have his/her name and email address
displayed properly in the git history.
Cc: Aaron Li
Cc: Songpeng Li
Reviewed-by: Aaron Li
Signed-off-by: Philippe Mathieu-Daude
---
.mailmap | 2 ++
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Hao Wu to have his/her name and email address
displayed properly in the git history.
Cc: Hao Wu
Reviewed-by: Hao A Wu
Signed-off-by: Philippe Mathieu-Daude
---
.mailmap | 2 ++
1 file changed, 2 ins
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Laszlo Ersek to have his/her name and email
address displayed properly in the git history.
Cc: Laszlo Ersek
Reviewed-by: Laszlo Ersek
Signed-off-by: Philippe Mathieu-Daude
---
.mailmap | 2 ++
1 fil
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Jiewen Yao to have his/her name and email
address displayed properly in the git history.
Cc: Jiewen Yao
Signed-off-by: Philippe Mathieu-Daude
---
.mailmap | 6 ++
1 file changed, 6 insertions(+)
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Baraneedharan Anbazhagan to have his/her name
and email address displayed properly in the git history.
Cc: Baraneedharan Anbazhagan
Reviewed-by: Baraneedharan Anbazhagan
Signed-off-by: Philippe Mathie
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Eric Dong to have his/her name and email
address displayed properly in the git history.
Cc: Eric Dong
Reviewed-by: Eric Dong
Signed-off-by: Philippe Mathieu-Daude
---
.mailmap | 4
1 file chang
The .mailmap git feature helps fixing commit mistakes (in name/email).
The easiest way to use it is with the --use-mailmap flag:
$ git log --use-mailmap
See:
* https://git-scm.com/docs/git-shortlog#_mapping_authors
* https://git-scm.com/docs/git-check-mailmap#_mapping_authors
Reviewed-by: Las
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Ashley DeSimone to have his/her name and email
address displayed properly in the git history.
Cc: Ashley DeSimone
Reviewed-by: Ashley DeSimone
Signed-off-by: Philippe Mathieu-Daude
---
.mailmap | 1
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Hot Tian to have his/her name and email address
displayed properly in the git history.
Cc: Hot Tian
Reviewed-by: Hot Tian
Signed-off-by: Philippe Mathieu-Daude
---
.mailmap | 2 ++
1 file changed, 2
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Ard Biesheuvel to have his/her name and email
address displayed properly in the git history.
Cc: Ard Biesheuvel
Reviewed-by: Ard Biesheuvel
Signed-off-by: Philippe Mathieu-Daude
---
.mailmap | 1 +
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Jim Dailey to have his/her name and email
address displayed properly in the git history.
Cc: Jim Dailey
Reviewed-by: Jim Dailey
Signed-off-by: Philippe Mathieu-Daude
---
.mailmap | 2 ++
1 file chan
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Liming Gao to have his/her name and email
address displayed properly in the git history.
Cc: Liming Gao
Reviewed-by: Liming Gao
Signed-off-by: Philippe Mathieu-Daude
---
.mailmap | 4
1 file ch
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Christopher J Zurcher to have his/her name and
email address displayed properly in the git history.
Cc: Christopher J Zurcher
Reviewed-by: Christopher J Zurcher
Signed-off-by: Philippe Mathieu-Daude
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Maciej Rabeda to have his/her name and email
address displayed properly in the git history.
Cc: Maciej Rabeda
Reviewed-by: Maciej Rabeda
Signed-off-by: Philippe Mathieu-Daude
---
.mailmap | 1 +
1 f
We use .mailmap to display contributors email addresses in an
uniform format.
Add an entry for Antoine Cœur to have his/her name and email
address displayed properly in the git history.
Cc: Antoine Cœur
Reviewed-by: Antoine Cœur
Signed-off-by: Philippe Mathieu-Daude
---
.mailmap | 2 ++
1 file
The .mailmap git feature helps fixing commit mistakes (in name/email).
The easiest way to use it is with the --use-mailmap flag:
$ git log --use-mailmap
See documentation [1] and [2], and interesting blog [3].
Laszlo replied [4] to v1 explaining stewards want to avoid avoid
cross-domain mappi
Reviewed-by: Ashley DeSimone
-Original Message-
From: Desimone, Nathaniel L
Sent: Thursday, December 26, 2019 6:05 PM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Desimone, Ashley E
; Pandya, Puja ; Bjorge,
Erik C ; Bret Barkelew
Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo
Hi Phil,
I am curious why the GIT committer information is so important.
Before CI, for any given package, the committer can be the
primary maintainer, the backup maintainer, or a steward.
The maintainer that actually does the commit is following the
process and the rules for doing a push, but m
On 12/6/19 1:24 PM, Laszlo Ersek wrote:
On 12/06/19 12:24, Philippe Mathieu-Daudé wrote:
The .mailmap git feature helps fixing commit mistakes (in name/email).
The easiest way to use it is with the --use-mailmap flag:
$ git log --use-mailmap
See:
* https://git-scm.com/docs/git-shortlog#_ma
On 1/2/20 4:24 PM, Philippe Mathieu-Daude wrote:
Last month I cleaned the git-history incorrect email
addresses: https://edk2.groups.io/g/devel/message/51834
but today I noticed more incorrect addresses got committed
(see caa917491a4..33a3293651).
To avoid having the same cleanup in the future, f
To avoid patches committed with incorrect email address,
use the EmailAddressCheck class on the author email too.
Example:
$ python BaseTools/Scripts/PatchCheck.py 1a04951309f
Checking git commit: 1a04951309f
The 'Author' email address is not valid:
* The email address cannot contain a sp
To avoid patches committed with incorrect email address,
use the EmailAddressCheck class on the committer email too.
Cc: Liming Gao
Cc: Jordan Justen
Signed-off-by: Philippe Mathieu-Daude
---
RFC because I haven't checked --pretty="%cn <%ce>" works on Windows shell.
BaseTools/Scripts/PatchChe
As we are going to reuse this code out of the CommitMessageCheck
class, extract it in a new class: EmailAddressCheck.
Cc: Liming Gao
Cc: Jordan Justen
Signed-off-by: Philippe Mathieu-Daude
---
BaseTools/Scripts/PatchCheck.py | 82 +
1 file changed, 53 insertions
Last month I cleaned the git-history incorrect email
addresses: https://edk2.groups.io/g/devel/message/51834
but today I noticed more incorrect addresses got committed
(see caa917491a4..33a3293651).
To avoid having the same cleanup in the future, fix the
problem once for all by having PatchCheck do
We are checking different emails from the signature list. We are
going to check more. To be able to differency, add a description
field, so the error reported is clearer.
Cc: Liming Gao
Cc: Jordan Justen
Signed-off-by: Philippe Mathieu-Daude
---
BaseTools/Scripts/PatchCheck.py | 10 +++---
Last month I cleaned the git-history incorrect email
addresses: https://edk2.groups.io/g/devel/message/51834
but today I noticed more incorrect addresses got committed
(see caa917491a4..33a3293651).
To avoid having the same cleanup in the future, fix the
problem once for all by having PatchCheck do
On 01/02/20 04:30, Ni, Ray wrote:
> Reviewed-by: Ray Ni
Eric, please go ahead with Ray's R-b.
Thanks
Laszlo
>
>> -Original Message-
>> From: Dong, Eric
>> Sent: Friday, December 27, 2019 3:49 PM
>> To: devel@edk2.groups.io
>> Cc: Ni, Ray ; Laszlo Ersek
>> Subject: [PATCH v2] UefiCpuP
On 01/02/20 04:12, Wu, Hao A wrote:
> Ray and Eric, thanks a lot for the review.
>
> Hello Laszlo,
> It seems that you are out of office, I plan to push the series without your
> comments first. If you have feedbacks/comments with regard to the series, I
> will follow up for the potential refine/r
Hi Michael,
On 11/12/19 3:55 AM, Michael D Kinney wrote:
EDK II Maintainers,
EDK II CI Phase 1 feature is now active on edk2/master.
Please use a GitHub pull request from a branch in a personal
fork of the edk2 repository with a 'push' label to request
a set of patches to be pushed to edk2/mas
Below:
> -Original Message-
> From: Zeng, Star
> Sent: Thursday, January 2, 2020 7:09 PM
> To: Yao, Jiewen ; devel@edk2.groups.io
> Cc: Wang, Jian J ; Wu, Hao A ;
> Bi, Dandan ; Zeng, Star
> Subject: RE: [PATCH 5/6] MdeModulePkg/Smbios: Add TCG PFP rev 105 support.
>
> Minor comments.
>
From: "Pavana.K"
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2389
Currently RSA signing scheme support is available for MD5, SHA-1 or
SHA-256 algorithms.The fix is to extend this support for SHA384 and
SHA512.
Cc: Liming Gao
Cc: Jian J Wang
Cc: Bob Feng
Signed-off-by: Pavana.K
---
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=113
Strip the trailing characters before checking the subject line is
less than 72 characters.
Fixes: e61406708c83f
Cc: Liming Gao
Cc: Jordan Justen
Reviewed-by: Jordan Justen
Signed-off-by: Philippe Mathieu-Daude
---
Cc: Yonghong Zhu
Cc: Z
On 1/2/20 10:39 AM, Jordan Justen wrote:
On 2019-12-19 06:12:56, Philippe Mathieu-Daudé wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=113
Strip the trailing characters before checking the subject line is
less than 72 characters.
Fixes: e61406708c83f
Cc: Liming Gao
Cc: Jordan Just
Minor comments.
> -Original Message-
> From: Yao, Jiewen
> Sent: Tuesday, December 31, 2019 2:44 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Wu, Hao A ;
> Bi, Dandan ; Zeng, Star
> Subject: [PATCH 5/6] MdeModulePkg/Smbios: Add TCG PFP rev 105 support.
>
> REF: https://bugzilla.tia
Reviewed-by: Star Zeng
> -Original Message-
> From: Yao, Jiewen
> Sent: Tuesday, December 31, 2019 2:44 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Wu, Hao A ;
> Bi, Dandan ; Zeng, Star
> Subject: [PATCH 3/6] MdeModulePkg/Smbios: Done measure Smbios
> multiple times.
>
> REF: htt
On 2019-12-19 06:12:56, Philippe Mathieu-Daudé wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=113
>
> Strip the trailing characters before checking the subject line is
> less than 72 characters.
>
> Fixes: e61406708c83f
> Cc: Liming Gao
> Cc: Jordan Justen
> Signed-off-by: Philipp
87 matches
Mail list logo
