[edk2-devel] [PATCH v2 5/6] UefiCpuPkg/MpInitLib: Relocate microcode patch fields in CPU_MP_DATA

2019-12-24 Thread Wu, Hao A
The below 2 microcode patch related fields in structure CPU_MP_DATA: UINT64 MicrocodePatchAddress; UINT64 MicrocodePatchRegionSize; They will be passed from PEI phase and be reused DXE phase. Previously, these 2 fields were placed after some fi

[edk2-devel] [PATCH v2 0/6] Microcode related optimizations

2019-12-24 Thread Wu, Hao A
Series is also available at: https://github.com/hwu25/edk2/tree/mpinitlib_opt_v2 V2 changes: A. For patch 2, rename function parameters and variables to better reflect their usage; B. For patch 2, remove unneeded check in LoadMicrocodePatchWorker(); C. For patch 3, rename a couple of fields in

[edk2-devel] [PATCH v2 3/6] UefiCpuPkg: Add definitions for EDKII microcode patch HOB

2019-12-24 Thread Wu, Hao A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2430 This commit will add the definitions for EDKII microcode patch HOB. The intention of adding this HOB is to provide a scheme to store the below information: A. The base address and size of the microcode patches that are being loaded (from

[edk2-devel] [PATCH v2 1/6] UefiCpuPkg/MpInitLib: Collect processors' CPUID & Platform ID info

2019-12-24 Thread Wu, Hao A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2429 This commit will collect the CPUID and Platform ID information for each processor within system. They will be stored in the CPU_AP_DATA structure. These information will be used in the next commit to decide whether a microcode patch will be

[edk2-devel] [PATCH v2 6/6] UefiCpuPkg/MpInitLib: Remove redundant microcode fields in CPU_MP_DATA

2019-12-24 Thread Wu, Hao A
Previous commits have introduced below fields in structure CPU_AP_DATA: UINT32 ProcessorSignature; UINT8 PlatformId; UINT64 MicrocodeEntryAddr; which store the information of: A. CPUID B. Platform ID C. Detected micro

[edk2-devel] [PATCH v2 4/6] UefiCpuPkg/MpInitLib: Produce EDKII microcode patch HOB

2019-12-24 Thread Wu, Hao A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2430 This commit will update the MpInitLib to: A. Collect the base address and size information after microcode patches being loaded into memory; B. Collect the detected microcode patch for each processor within system; C. Based on the collect

[edk2-devel] [PATCH v2 2/6] UefiCpuPkg/MpInitLib: Reduce the size when loading microcode patches

2019-12-24 Thread Wu, Hao A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2429 This commit will attempt to reduce the copy size when loading the microcode patches data from flash into memory. Such optimization is done by a pre-process of the microcode patch headers (on flash). A microcode patch will be loaded into memo

Re: [edk2-devel] [PATCH v1 3/4] UefiCpuPkg: Add definitions for EDKII microcode patch HOB

2019-12-24 Thread Wu, Hao A
> -Original Message- > From: Ni, Ray > Sent: Tuesday, December 24, 2019 4:16 PM > To: Wu, Hao A; devel@edk2.groups.io > Cc: Dong, Eric; Laszlo Ersek; Zeng, Star; Fu, Siyuan; Kinney, Michael D > Subject: RE: [PATCH v1 3/4] UefiCpuPkg: Add definitions for EDKII microcode > patch HOB > > I su

Re: [edk2-devel] [PATCH v1 4/4] UefiCpuPkg/MpInitLib: Produce EDKII microcode patch HOB

2019-12-24 Thread Wu, Hao A
> -Original Message- > From: Ni, Ray > Sent: Tuesday, December 24, 2019 11:54 AM > To: Wu, Hao A; devel@edk2.groups.io > Cc: Dong, Eric; Laszlo Ersek; Zeng, Star; Fu, Siyuan; Kinney, Michael D > Subject: RE: [PATCH v1 4/4] UefiCpuPkg/MpInitLib: Produce EDKII microcode > patch HOB > > Micro

Re: [edk2-devel] Anyone successfully enabled clangd in edk2 code?

2019-12-24 Thread Ni, Ray
Can you please share the clang-format configuration file? From: Tomas Pilar Sent: Tuesday, December 24, 2019 8:37 PM To: Devel EDK2 ; Ni, Ray Subject: RE: [edk2-devel] Anyone successfully enabled clangd in edk2 code? Oh but I am using clang-format to get vscode to format things according to pr

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Build ASL files before C files

2019-12-24 Thread PierreGondois
Hello Ard, > So this is for making changes at runtime, right? And are you only > using the char[] array in its entirety? Yes, this is to make changes at runtime on SSDT tables. If we consider that the SSDT table contained in the char[] array is in two parts: the header, and the AML blob; what we

Re: [edk2-devel] Anyone successfully enabled clangd in edk2 code?

2019-12-24 Thread Tomas Pilar (tpilar)
Oh but I am using clang-format to get vscode to format things according to proper code style. From: Tomas Pilar Sent: 24 December 2019 12:36 To: Devel EDK2 ; 'ray...@intel.com' Subject: RE: [edk2-devel] Anyone successfully enabled clangd in edk2 code? I don't know about clangd but I am successf

Re: [edk2-devel] Anyone successfully enabled clangd in edk2 code?

2019-12-24 Thread Tomas Pilar (tpilar)
I don't know about clangd but I am successfully using the vscode intellisense with EDKII including the multiple workspaces. It took some time to configure things with paths and includes to make it work correctly but the only problem I have at the moment is to get it to use the correct AutoGen.h

Re: [edk2-devel] [PATCH 1/2] SdMmcPciHcDxe: Send EdkiiSdMmcSwitchClockFreq after SD clock start

2019-12-24 Thread Ard Biesheuvel
On Tue, 24 Dec 2019 at 03:52, Wu, Hao A wrote: > > > -Original Message- > > From: Albecki, Mateusz > > Sent: Saturday, December 21, 2019 1:13 AM > > To: devel@edk2.groups.io > > Cc: Albecki, Mateusz; Wu, Hao A; Marcin Wojtas; Gao, Zhichao; Gao, Liming > > Subject: [PATCH 1/2] SdMmcPciHcDxe

Re: [edk2-devel] [Patch V3] IntelSiliconPkg/Include/Library:Add ConfigBlockLib.h

2019-12-24 Thread Ethan Tsao
Hi Ray and Sai, I found some issues during integration and then update patch. Please help to review again. Best Regards, Ethan > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ethan Tsao > Sent: Tuesday, December 24, 2019 5:39 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; C

[edk2-devel] reg: Remove Framework HII "class\subclass" in all VFR

2019-12-24 Thread Sivaraman Nainar
Hello Jiaxin: Edk2 older branch removed the "class\subclass" in all VFR in the Network Stack modules. (IP4, IP6 and ISCSI) Refer below commit. https://github.com/tianocore/edk2/commit/b965bd99c533b24bec56647a8c9b1fa2c2ed8bd8#diff-3d9f695b702160a70a74145d12121272 But when we upload the Initial I

[edk2-devel] [Patch V3] IntelSiliconPkg/Include/Library:Add ConfigBlockLib.h

2019-12-24 Thread Ethan Tsao
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2318 Move ConfigBlockLib.h and ConfigBlock.h to InstelSiliconPkg and remove all other ConfigBlockLib.h and ConfigBlock.h Signed-off-by: Ethan Tsao Cc: Ray Ni Cc: Rangasai V Chaganty --- Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg

Re: [edk2-devel] [PATCH v1 3/4] UefiCpuPkg: Add definitions for EDKII microcode patch HOB

2019-12-24 Thread Ni, Ray
I suggest to let the DetectedPatchOffset points to the microcode header instead of microcode data. Consumers can use the offset to get more information from header than just the microcode data. > -Original Message- > From: Wu, Hao A > Sent: Tuesday, December 24, 2019 9:37 AM > To: devel

Re: [edk2-devel] [Patch v2] IntelSiliconPkg/Include/Library:Add ConfigBlockLib.h

2019-12-24 Thread Ethan Tsao
Hi Ray, ConfigBlockLib consume the data structure from ConfigBlock.h. Which is located in KabylakeSiliconPkg and CoffeelakeSiliconPkg. Should we copy them to IntelSiliconPkg as well and delete? Best Regards, Ethan > -Original Message- > From: Ni, Ray > Sent: Tuesday, December 24, 2019

[edk2-devel] Anyone successfully enabled clangd in edk2 code?

2019-12-24 Thread Ni, Ray
All, I am interested in using clangd to support symbolic navigation in Visual Studio Code. But since EDKII doesn't have a master makefile, I am not sure how to enable clangd. Anyone tried that recently? Thanks, Ray -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this g

Re: [edk2-devel] Anyone successfully enabled clangd in edk2 code?

2019-12-24 Thread Ni, Ray
https://clang.llvm.org/extra/clangd/ From: devel@edk2.groups.io On Behalf Of Ni, Ray Sent: Tuesday, December 24, 2019 4:14 PM To: devel@edk2.groups.io Subject: [edk2-devel] Anyone successfully enabled clangd in edk2 code? All, I am interested in using clangd to support symbolic navigation in Vis

Re: [edk2-devel] HTTPS Certificate Validation During Enrollment

2019-12-24 Thread Siyuan, Fu
Hi, Siva We don’t think this is a real problem. The cert is saved as NV variable just like any other EFI variables, there are some basic checks like verify it’s a valid DER-encoded certificate before saving the certificate, and TLS config driver also provides a page to allow user to delete unus