[edk2-devel] [edk2-platforms] [PATCH 11/11] SimicsOpenBoardPkg: Add Bds Hook Points

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2336 Added a DXE driver that registers the minimum platform BDS hook points, to BoardX58Ich10 board. These hooks are triggered on the BDS hook events What was done: * Included a board specific instance of BoardBdsHookLib and BoardBootManagerLib

[edk2-devel] [edk2-platforms] [PATCH 01/11] MinPlatformPkg: Add BDS Hook Point Guids

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2336 Added BDS hook point guids as defined in the Minimum Platform specification. These GUIDs shall be used in the identification of three of the BDS hook point event groups. These event groups are Before Console After Trusted, Before Console Be

[edk2-devel] [edk2-platforms] [PATCH 03/11] BoardModulePkg: Add BDS Hook DXE Driver

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2336 This is a sample/generic DXE driver that registers all the BDS hook points or callbacks as defined in BoardBdsHookLib. Cc: Michael Kubacki Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Prince Agyeman --- .../BoardBdsHookDxe/BoardBd

[edk2-devel] [edk2-platforms] [PATCH 06/11] BoardModulePkg: Add Generic BoardBootManagerLib

This library implements a generic PlatformBootManagerWaitCallback and PlatformBootManagerUnableToBoot which will be linked Minplatform's PlatformBootManager library instance. Cc: Michael Kubacki Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Prince Agyeman --- .../BoardBootManagerLib/Board

[edk2-devel] [edk2-platforms] [PATCH 05/11] MinPlatformPkg: Add BDS Hook Points

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2336 Added BDS hook points to the Minplatform boot manager library as defined in the Minimum Platfrom specifcations. Changes made: * Added functions to signal three BDS event groups. These event groups are BeforeConsoleAfterTrustedConsole, Befo

[edk2-devel] [edk2-platforms] [PATCH 00/11] Add BDS Hook Points

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2336 This patch series implements BDS hook points as defined in the EDK II Minimum Platform Specification. For details, see https://edk2-docs.gitbooks.io/edk-ii-minimum-platform-specification/appendix_a_full_maps/a3_bds_hook_points.html What wa

[edk2-devel] [edk2-platforms] [PATCH 02/11] BoardModulePkg: Add BDS Hook Library

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2336 Added a generic board BDS hook library that implements BDS hook points as defined in the Minimum platform specification. This library implements callbacks for the three MinPlatformPkg BDS event groups, namely gBdsEventBeforeConsoleAfterTrus

[edk2-devel] [edk2-platforms] [PATCH 09/11] SimicsOpenBoardPkg: Add Bds Hook Library

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2336 Added Board BDS Hook library that implements simics specific Bds hook points or callbacks. Cc: Nate DeSimone Cc: Michael Kubacki Signed-off-by: Prince Agyeman --- .../Library/BoardBdsHookLib/BoardBdsHook.h| 173 ++ .../Library/Boa

[edk2-devel] [edk2-platforms] [PATCH 07/11] KabylakeOpenBoardPkg: Add BDS Hook Dxe Driver

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2336 Added a DXE driver that registers the minimum platform BDS hook points for the GalagoPro3 and KabylakeRvp3 boards. These hooks are triggered on the BDS hook events What was done: * Included an instance of BoardBdsHookLib and BoardBootManag

[edk2-devel] [edk2-platforms] [PATCH 04/11] MinPlatformPkg: Add BDS Board Boot Manager library

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2336 As Minplatform's PlatformBootManager library instance implements event signals (as specified in the minimum platform specification) to trigger board actions, some of its functions namely PlatformBootManagerWaitCallback and PlatformBootManage

[edk2-devel] [edk2-platforms] [PATCH 10/11] SimicsOpenBoardPkg: Add BDS Board Boot Manager library

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2336 This library implements PlatformBootManagerWaitCallback and PlatformBootManagerUnableToBoot which can be linked Minplatform's PlatformBootManager libary instance. Cc: Nate DeSimone Cc: Michael Kubacki Signed-off-by: Prince Agyeman ---

[edk2-devel] [edk2-platforms] [PATCH 08/11] WhiskeylakeOpenBoardPkg: Add BDS Hook Dxe Driver

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2336 Added a DXE driver that registers the minimum platform BDS hook points, to WhiskeylakeURvp board. These hooks are triggered on the BDS hook events What was done: * Included an instance of BdsHookLib and BoardBootManagerLib from BoardModule

[edk2-devel] [edk2-platforms] [PATCH v2] WhiskeylakeOpenBoardPkg: Update PCDs to enable stack sharing

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2409 Updated WhiskeylakeURvp PCDs to enable FSP/BL stack sharing. This fixes the boot failure seen with the latest Coffee Lake (CFL) FSP binary (v 7.0.68.41) Cc: Chasel Chiu Cc: Nate DeSimone Cc: Michael Kubacki Signed-off-by: Prince Agyeman

Re: [EXTERNAL] Re: [edk2-devel] EDK2 Host-Based Unit Test RFC (Now with docs!)

Mike, I think I’ve gotten all the feedback here and all the action items from our call. The current branch should be good to go, minus the couple of things that Intel was going to look into. Thanks! - Bret From: Bret Barkelew Sent: Friday, December 6, 2019

Re: [edk2-devel] [edk2-platforms] [PATCH] WhiskeylakeOpenBoardPkg: Update PCDs to enable stack sharing

Thanks for clarifying. Yes the minimum stack size of 160KB works as well. I will update this patch Thanks Prince -Original Message- From: Desimone, Nathaniel L Sent: Friday, December 13, 2019 2:27 PM To: devel@edk2.groups.io; Desimone, Nathaniel L ; Agyeman, Prince Cc: Chiu, Chasel

Re: [edk2-devel] [edk2-platforms] [PATCH] WhiskeylakeOpenBoardPkg: Update PCDs to enable stack sharing

Actually looking at the CoffeeLake FSP Integration Guide it states the minimum stack size to be 160KB (0x28000) so I guess a slight revision to my previous statement: gSiPkgTokenSpaceGuid.PcdPeiTemporaryRamStackSize|0x28000 Thanks, Nate -Original Message- From: devel@edk2.groups.io On

Re: [edk2-devel] [edk2-platforms] [PATCH] WhiskeylakeOpenBoardPkg: Update PCDs to enable stack sharing

Hi Prince, Looking at your patch I see the following two changes: 1. Reduce FSP Temp Ram size from 152KB to 64KB: - gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize|0x26000 + gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize|0x1 This makes sense because now that the FSP is using the si

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH V3 0/1] EdkRepo: Add squash command

Reviewed-by: Ashley DeSimone -Original Message- From: Desimone, Nathaniel L Sent: Thursday, December 12, 2019 11:54 PM To: devel@edk2.groups.io Cc: Desimone, Ashley E ; Pandya, Puja ; Bjorge, Erik C ; Bret Barkelew Subject: [edk2-staging/EdkRepo] [PATCH V3 0/1] EdkRepo: Add squash com

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH V3 1/1] EdkRepo: Add squash command

Reviewed-by: Ashley DeSimone -Original Message- From: Desimone, Nathaniel L Sent: Thursday, December 12, 2019 11:54 PM To: devel@edk2.groups.io Cc: Desimone, Ashley E ; Pandya, Puja ; Bjorge, Erik C ; Bret Barkelew Subject: [edk2-staging/EdkRepo] [PATCH V3 1/1] EdkRepo: Add squash com

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Make Python scripts in git_automation executable

Reviewed-by: Ashley DeSimone -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Nate DeSimone Sent: Thursday, December 12, 2019 4:30 PM To: devel@edk2.groups.io Cc: Desimone, Ashley E ; Pandya, Puja ; Bjorge, Erik C ; Bret Barkelew Subject: [edk2-

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: EdkRepo fails to run in detached HEAD mode

Reviewed-by: Ashley Desimone -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Desimone, Nathaniel L Sent: Monday, December 9, 2019 4:02 PM To: devel@edk2.groups.io Cc: Desimone, Ashley E ; Pandya, Puja ; Desimone, Nathaniel L Subject: [edk2-deve

[edk2-devel] [Patch 1/1] BaseTools/Scripts: Add package dependency graphing tool

https://bugzilla.tianocore.org/show_bug.cgi?id=2161 Add python script that recursively scans a directory for EDK II packages and generates GraphViz dot input that is used to render a graph of package dependencies in SVG format. Detects following error/warning conditions: * Ambiguous dependencies

[edk2-devel] [Patch 0/1] BaseTools/Scripts: Add package dependency graphing tool

https://bugzilla.tianocore.org/show_bug.cgi?id=2161 Add python script that recursively scans a directory for EDK II packages and generates GraphViz dot input that is used to render a graph of package dependencies in SVG format. Detects following error/warning conditions: * Ambiguous dependencies

Re: [edk2-devel] [edk2-platforms][PATCH v2 0/4] Platform/RPi4: Add PCIe and xHCI support

On 2019.12.13 17:40, Ard Biesheuvel wrote: On Fri, 13 Dec 2019 at 18:07, Pete Batard wrote: Changes from v1 (https://edk2.groups.io/g/devel/message/52160 - 52164): * Ensure that read/write accesses are serialized in PciSegmentLib. * Flesh out commit messages. * Minor comments and code updates

Re: [edk2-devel] [edk2-platforms][PATCH v2 0/4] Platform/RPi4: Add PCIe and xHCI support

On Fri, 13 Dec 2019 at 18:07, Pete Batard wrote: > > Changes from v1 (https://edk2.groups.io/g/devel/message/52160 - 52164): > > * Ensure that read/write accesses are serialized in PciSegmentLib. > * Flesh out commit messages. > * Minor comments and code updates for whitespaces & capitalization. >

Re: [edk2-devel] [edk2-platforms][PATCH v2 4/4] Platform/RPi4: Build the PCIe and xHCI drivers into the firmware

On 12/13/19 6:07 PM, Pete Batard wrote: From: Jeremy Linton This uses the recently introduced NonCoherentIoMmuDxe for PCIe access and should enable USB device usage in the UEFI environment. As mentioned in https://lkml.org/lkml/2019/9/9/170, imposing a 3 GB DMA limit might be necessary for the

[edk2-devel] [edk2-platforms][PATCH v2 2/4] Silicon/Bcm27xx: Add segment library to handle nonstandard ECAM

From: Jeremy Linton This SoC uses a nonstantard ECAM with requires the provision of a custom segment library. Basically, with the Bcm2711, the root port is the first bytes of the register space (offset 0) and individual devices are selected by computing their BDF index and writing that into the C

[edk2-devel] [edk2-platforms][PATCH v2 4/4] Platform/RPi4: Build the PCIe and xHCI drivers into the firmware

From: Jeremy Linton This uses the recently introduced NonCoherentIoMmuDxe for PCIe access and should enable USB device usage in the UEFI environment. As mentioned in https://lkml.org/lkml/2019/9/9/170, imposing a 3 GB DMA limit might be necessary for the 4 GB models so we follow suit by setting

[edk2-devel] [edk2-platforms][PATCH v2 3/4] Silicon/Bcm27xx: Add PCIe host bridge config library

From: Jeremy Linton Enables the instantiation of the PCI host bridge. Signed-off-by: Pete Batard --- Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciHostBridgeLib/Bcm2711PciHostBridgeLib.c | 193 Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciHostBridgeLib/Bcm2711PciHostB

[edk2-devel] [edk2-platforms][PATCH v2 0/4] Platform/RPi4: Add PCIe and xHCI support

Changes from v1 (https://edk2.groups.io/g/devel/message/52160 - 52164): * Ensure that read/write accesses are serialized in PciSegmentLib. * Flesh out commit messages. * Minor comments and code updates for whitespaces & capitalization. Jeremy Linton (4): Silicon/Bcm27xx: Add PCIe constants to B

[edk2-devel] [edk2-platforms][PATCH v2 1/4] Silicon/Bcm27xx: Add PCIe constants to Bcm2711.h

From: Jeremy Linton This populates all of the define's we need for PCIe accesses. Four new PCDs are also introduced for the register and MMIO platform constants. Signed-off-by: Pete Batard --- Silicon/Broadcom/Bcm27xx/Bcm27xx.dec| 4 ++ Silicon/Broadcom/Bcm27xx/Include

Re: [edk2-devel] [RFC PATCH v2 42/44] UefiCpuPkg/MpInitLib: Prepare SEV-ES guest APs for OS use

On 12/12/19 2:24 AM, Ni, Ray wrote: > Tom, > why this cannot be done as today's code in ExitBS callback? > Because it should be done after interrupt is disabled? The problem comes from the calls during and after the ExitBS callbacks are performed. Part of the finalization support is to set the AP

Re: [edk2-devel] [edk2-platforms] [PATCH] WhiskeylakeOpenBoardPkg: Update PCDs to enable stack sharing

Hi Nate, Which 256KB are you referring to ? The temporary ram size was reduced from 152KB (0x26000) to 64KB (0x1) With stack sharing enabled in FSP, temp ram size of 0x26000 causes system to hang during memory training. - gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize |0x26000 +