Re: [edk2-devel] EDK II Maintainers - EDK II CI is now active on edk2/master

2019-11-12 Thread Laszlo Ersek
On 11/12/19 20:50, Kinney, Michael D wrote: > Hi Laszlo, > > The setting that is required is 'Watch' on the edk2 repo. > Navigate to the main page for the tianocore edk2 repo: > > https://github.com/tianocore/edk2 > > At the top of the page, there is a drop down called 'Watch'. > Select 'Wat

Re: [edk2-devel] [PATCH 1/2] UefiCpuPkg/CpuCommonFeaturesLib: Remove XD enable/disable logic

2019-11-12 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Ni, Ray > Sent: Monday, November 11, 2019 11:05 AM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Laszlo Ersek > Subject: [PATCH 1/2] UefiCpuPkg/CpuCommonFeaturesLib: Remove XD > enable/disable logic > > REF: https://bugzilla.tianocore

Re: [edk2-devel] [PATCH 2/2] UefiCpuPkg/RegisterCpuFeature: Remove CPU_FEATURE_XD macro

2019-11-12 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Ni, Ray > Sent: Monday, November 11, 2019 11:05 AM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Laszlo Ersek > Subject: [PATCH 2/2] UefiCpuPkg/RegisterCpuFeature: Remove > CPU_FEATURE_XD macro > > REF: https://bugzilla.tianocore.org/

[edk2-devel] [PATCH edk2-platforms 1/5] QuarkPlatformPkg: add null version of RngLib

2019-11-12 Thread Wang, Jian J
It's a prerequisite of removing dependency of TimerLib from OpensslLib. RngLib will be used instead. To avoid build failure, add the null instance of it in advance. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1871 Cc: Michael D Kinney Cc: Kelly Steele Signed-off-by: Jian J Wang --- Pla

[edk2-devel] [PATCH edk2-platforms 5/5] MiscPlatforms: add null version RngLib

2019-11-12 Thread Wang, Jian J
It's a prerequisite of removing dependency of TimerLib from OpensslLib. RngLib will be used instead. To avoid build failure, add the null instance of it in advance. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1871 Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney Signed-off-by:

[edk2-devel] [PATCH edk2-platforms 0/5] Add RngLibNull for comming OpensslLib changes

2019-11-12 Thread Wang, Jian J
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1871 It's a prerequisite of removing dependency of TimerLib from OpensslLib. RngLib will be used instead. To avoid build failure, add the null instance of it in advance. Cc: Michael D Kinney Cc: Kelly Steele Cc: Dandan Bi Cc: Liming Gao Cc:

[edk2-devel] [PATCH edk2-platforms 4/5] Armada7k8k: add null version RngLib

2019-11-12 Thread Wang, Jian J
It's a prerequisite of removing dependency of TimerLib from OpensslLib. RngLib will be used instead. To avoid build failure, add the null instance of it in advance. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1871 Cc: Marcin Wojtas Cc: Liming Gao Cc: Michael D Kinney Signed-off-by: Jian

[edk2-devel] [PATCH edk2-platforms 2/5] UserInterfaceFeaturePkg: add null version RngLib

2019-11-12 Thread Wang, Jian J
It's a prerequisite of removing dependency of TimerLib from OpensslLib. RngLib will be used instead. To avoid build failure, add the null instance of it in advance. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1871 Cc: Dandan Bi Cc: Liming Gao Signed-off-by: Jian J Wang --- .../Intel/Us

[edk2-devel] [PATCH edk2-platforms 3/5] Vlv2TbltDevicePkg: add null version RngLib

2019-11-12 Thread Wang, Jian J
It's a prerequisite of removing dependency of TimerLib from OpensslLib. RngLib will be used instead. To avoid build failure, add the null instance of it in advance. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1871 Cc: Liming Gao Cc: Michael D Kinney Cc: Zailiang Sun Cc: Yi Qian Signed-

[edk2-devel] [PATCH v2] MdePkg: add null version of RngLib

2019-11-12 Thread Wang, Jian J
>v2: > - Change the name from RngLibNull to BaseRngLibNull according to Laszlo's >comments > - Move the module from SecurityPkg to MdePkg according to Laszlo's comments > - Update commit message according to Laszlo and Ray's comments This is null version of RngLib which should be used with

[edk2-devel] [edk2-platforms][PATCH V1 41/49] WhiskeylakeOpenBoardPkg/WhiskeylakeURvp: Add FvAdvancedPreMemory

2019-11-12 Thread Kubacki, Michael A
This change adds a standalone firmware volume for pre-memory advanced features called FvAdvancedPreMemory to the flash map. Pre-memory advanced feature modules were previously kept in a child firmware volume of FvAdvanced called FvAdvancedPreMem. This change simplifies the flash layout and separat

[edk2-devel] [edk2-platforms][PATCH V1 47/49] SimicsOpenBoardPkg: Enable advanced features

2019-11-12 Thread Kubacki, Michael A
This change adds the SMBIOS and Network advanced features to SimicsOpenBoardPkg. These features were previously used in SimicsOpenBoardPkg prior to an advanced feature refactor. Note that SimicsOpenBoardPkg depends upon these advanced features even when the boot stage is less than the advanced fea

[edk2-devel] [edk2-platforms][PATCH V1 45/49] KabylakeOpenBoardPkg/KabylakeRvp3: Enable advanced features

2019-11-12 Thread Kubacki, Michael A
This change enables advanced features to be used by the KabylakeRvp3 board in KabylakeOpenBoardPkg. Some platform macros in OpenBoardPkg.dsc are consolidated so all values are set at the top of the file before including advanced feature code. Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Mic

[edk2-devel] [edk2-platforms][PATCH V1 42/49] Platform/Intel: Add advanced feature build support

2019-11-12 Thread Kubacki, Michael A
This change adds the ability for board packages built with build_bios.py to build advanced features located in Features/Intel. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Agyeman Prince Signed-off-by: Michael Kubacki --- Platform/Intel/build.cfg | 1 + Platform/Intel/build_bios.

[edk2-devel] [edk2-platforms][PATCH V1 48/49] MinPlatformPkg: Install advanced feature FVs by stage enabled

2019-11-12 Thread Kubacki, Michael A
This change updates the FvReportLib instance in MinPlatformPkg to only install advanced feature firmware volumes if the advanced feature stage should be active. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Michael Kubacki --- Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec

[edk2-devel] [edk2-platforms][PATCH V1 44/49] KabylakeOpenBoardPkg/GalagoPro3: Enable advanced features

2019-11-12 Thread Kubacki, Michael A
This change enables advanced features to be used by the GalagoPro3 board in KabylakeOpenBoardPkg. Some platform macros in OpenBoardPkg.dsc are consolidated so all values are set at the top of the file before including advanced feature code. Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Micha

[edk2-devel] [edk2-platforms][PATCH V1 49/49] Maintainers.txt: Update Intel feature maintainers

2019-11-12 Thread Kubacki, Michael A
Cc: Dandan Bi Cc: Sai Chaganty Cc: Eric Dong Cc: Liming Gao Signed-off-by: Michael Kubacki --- Maintainers.txt | 26 ++-- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/Maintainers.txt b/Maintainers.txt index 9599024e20..001e94130f 100644 --- a/Maintainers.txt

[edk2-devel] [edk2-platforms][PATCH V1 46/49] WhiskeylakeOpenBoardPkg/WhiskeylakeURvp: Enable advanced features

2019-11-12 Thread Kubacki, Michael A
This change enables advanced features to be used by the WhiskeylakeURvp board in WhiskeylakeOpenBoardPkg. Some platform macros in OpenBoardPkg.dsc are consolidated so all values are set at the top of the file before including advanced feature code. Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-b

[edk2-devel] [edk2-platforms][PATCH V1 43/49] Platform/Intel/Readme.md Content update

2019-11-12 Thread Kubacki, Michael A
Updates the advanced feature location referenced in Readme.md to edk2-platforms/Features/Intel. Cc: Dandan Bi Cc: Sai Chaganty Cc: Eric Dong Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Michael Kubacki --- Platform/Intel/Readme.md | 14 +++--- 1 file changed, 7 insertions(+), 7 d

Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 12/12] PciBusDxe: New PCI feature Completion Timeout

2019-11-12 Thread Javeed, Ashraf
This patch is also uploaded in the following Repo for review:- https://github.com/ashrafj/edk2-staging/commit/fc451a1bb20fc774f7542ea06eb4e1b9ce369c0c Thanks Ashraf > -Original Message- > From: devel@edk2.groups.io On Behalf Of Javeed, > Ashraf > Sent: Friday, November 1, 2019 8:40 PM >

Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 11/12] PciBusDxe: New PCI feature No-Snoop

2019-11-12 Thread Javeed, Ashraf
This patch is also uploaded in following Repo for review:- https://github.com/ashrafj/edk2-staging/commit/da0d50ad3b542fc4b63f8debb7d690c83ef4218d Thanks Ashraf > -Original Message- > From: devel@edk2.groups.io On Behalf Of Javeed, > Ashraf > Sent: Friday, November 1, 2019 8:40 PM > To:

Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 10/12] PciBusDxe: New PCI feature Relax Ordering

2019-11-12 Thread Javeed, Ashraf
This patch is also uploaded in the following Repo for review:- https://github.com/ashrafj/edk2-staging/commit/8575d730644eda27a4b8b0eb05ee1f804b35 Thanks Ashraf > -Original Message- > From: devel@edk2.groups.io On Behalf Of Javeed, > Ashraf > Sent: Friday, November 1, 2019 8:40 PM >

Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 09/12] PciBusDxe: New PCI feature Max_Read_Req_Size

2019-11-12 Thread Javeed, Ashraf
This patch is also uploaded in the following Repo for review:- https://github.com/ashrafj/edk2-staging/commit/d16d7ea7df972fb711bca22266743c3602cf450b Thanks Ashraf > -Original Message- > From: devel@edk2.groups.io On Behalf Of Javeed, > Ashraf > Sent: Friday, November 1, 2019 8:40 PM >

[edk2-devel] [edk2-platforms][PATCH V1 35/49] KabylakeOpenBoardPkg/GalagoPro3: Add PEI_ARCH and DXE_ARCH

2019-11-12 Thread Kubacki, Michael A
This change adds two new macros to OpenBoardPkg.dsc that identify the build architecture for PEI and DXE modules. The intention of this macro is to ensure that all DSC files that compose the package build (such as those included from MinPlatformPkg or an advanced feature package) build phase-specif

[edk2-devel] [edk2-platforms][PATCH V1 37/49] SimicsOpenBoardPkg/BoardX58Ich10: Use PEI_ARCH and DXE_ARCH

2019-11-12 Thread Kubacki, Michael A
This change updates OpenBoardPkg.dsc to use the PEI_ARCH and DXE_ARCH specified in the DSC file for the board package components. An EDK II build limitation currently prevents the macros from being able to be used, so a todo has been placed with the action needed when the BaseTools update is compl

[edk2-devel] [edk2-platforms][PATCH V1 31/49] AdvancedFeaturePkg: Add feature build support

2019-11-12 Thread Kubacki, Michael A
This change adds the ability to build all currently available advanced features using the AdvancedFeaturePkg build. To build all advanced features, follow the instructions in the Feature/Intel/Readme.md file. The actual build is performed by executing the following command in the Features/Intel dir

Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 08/12] PciBusDxe: New PCI feature Max_Payload_Size

2019-11-12 Thread Javeed, Ashraf
This patch is also uploaded in the following Repo for review:- https://github.com/ashrafj/edk2-staging/commit/283733b638f1063ed3d37a6d79510f30a334c3ac Thanks Ashraf > -Original Message- > From: devel@edk2.groups.io On Behalf Of Javeed, > Ashraf > Sent: Friday, November 1, 2019 8:40 PM >

[edk2-devel] [edk2-platforms][PATCH V1 33/49] AdvancedFeaturePkg: Add FDF include files

2019-11-12 Thread Kubacki, Michael A
Adds FDF files that group all currently available advanced features so they can be conveniently included into board packages. The Minimum Platform defines two firmware volumes for advanced features: FvAdvancedPreMemory and FvAdvanced. This change provides all pre-memory advanced feature modules t

[edk2-devel] [edk2-platforms][PATCH V1 30/49] AdvancedFeaturePkg: Move to Features/Intel

2019-11-12 Thread Kubacki, Michael A
This change moves AdvancedFeaturePkg to the Features/Intel directory. AdvancedFeaturePkg will be the only package that is located at the root level of Features/Intel. Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Michael Kubacki --- {Platform => Features}/Intel/AdvancedFeaturePkg/AdvancedFeat

[edk2-devel] [edk2-platforms][PATCH V1 32/49] AdvancedFeaturePkg: Add temporary build workaround

2019-11-12 Thread Kubacki, Michael A
This change adds a temporary build workaround to allow the advanced feature PCDs to be used in conditional statements in DSC files even if they are not referenced in INF files. Support to allow a FeaturePCD to be used in a conditional statement without being referenced in an INF file has been requ

[edk2-devel] [edk2-platforms][PATCH V1 39/49] KabylakeOpenBoardPkg/KabylakeRvp3: Add FvAdvancedPreMemory

2019-11-12 Thread Kubacki, Michael A
This change adds a standalone firmware volume for pre-memory advanced features called FvAdvancedPreMemory to the flash map. Pre-memory advanced feature modules were previously kept in a child firmware volume of FvAdvanced called FvAdvancedPreMem. This change simplifies the flash layout and separat

[edk2-devel] [edk2-platforms][PATCH V1 34/49] KabylakeOpenBoardPkg/KabylakeRvp3: Add PEI_ARCH and DXE_ARCH

2019-11-12 Thread Kubacki, Michael A
This change adds two new macros to OpenBoardPkg.dsc that identify the build architecture for PEI and DXE modules. The intention of this macro is to ensure that all DSC files that compose the package build (such as those included from MinPlatformPkg or an advanced feature package) build phase-specif

[edk2-devel] [edk2-platforms][PATCH V1 40/49] KabylakeOpenBoardPkg/GalagoPro3: Add FvAdvancedPreMemory

2019-11-12 Thread Kubacki, Michael A
This change adds a standalone firmware volume for pre-memory advanced features called FvAdvancedPreMemory to the flash map. Pre-memory advanced feature modules were previously kept in a child firmware volume of FvAdvanced called FvAdvancedPreMem. This change simplifies the flash layout and separat

[edk2-devel] [edk2-platforms][PATCH V1 38/49] MinPlatformPkg: Add FvAdvancedPreMemory

2019-11-12 Thread Kubacki, Michael A
This change adds a new firmware volume to MinPlatformPkg called FvAdvancedPreMemory. This firmware volume is used to hold advanced feature modules that must be available in pre-memory. Previously, these modules were kept as an uncompressed child FV in FvAdvanced. However, in memory constrained env

[edk2-devel] [edk2-platforms][PATCH V1 29/49] AdvancedFeaturePkg: Remove remaining contents

2019-11-12 Thread Kubacki, Michael A
This change removes the remaining files in AdvancedFeaturePkg that are no longer part of the Minimum Platform Advanced Feature design. Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Michael Kubacki --- Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dec | 4 -- Pl

[edk2-devel] [edk2-platforms][PATCH V1 36/49] WhiskeylakeOpenBoardPkg/WhiskeylakeURvp: Add PEI_ARCH and DXE_ARCH

2019-11-12 Thread Kubacki, Michael A
This change adds two new macros to OpenBoardPkg.dsc that identify the build architecture for PEI and DXE modules. The intention of this macro is to ensure that all DSC files that compose the package build (such as those included from MinPlatformPkg or an advanced feature package) build phase-specif

[edk2-devel] [edk2-platforms][PATCH V1 21/49] Features/Intel/SmbiosFeaturePkg: Update default strings

2019-11-12 Thread Kubacki, Michael A
Updates the PCD string default values so they are generic. The PCDs should be customized by the package that uses the feature. Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Michael Kubacki --- Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosFeaturePkg.dec | 30 ++-- 1

[edk2-devel] [edk2-platforms][PATCH V1 17/49] Features/Intel/IpmiFeaturePkg: Add libraries

2019-11-12 Thread Kubacki, Michael A
This change adds the libraries required for the IPMI feature to IpmiFeaturePkg. Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Michael Kubacki --- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dec | 9 + Features/Intel/OutOfBandMan

[edk2-devel] [edk2-platforms][PATCH V1 11/49] TemplateFeaturePkg: Add initial package

2019-11-12 Thread Kubacki, Michael A
This change adds a new package called TemplateFeaturePkg that should be used as a starting point for the creation of new advanced feature packages. TemplateFeaturePkg is not meant to be built or used directly for functionality. It simply serves as a template to be copied and modified. The advanced

[edk2-devel] [edk2-platforms][PATCH V1 12/49] SimicsOpenBoardPkg: Remove advanced feature references

2019-11-12 Thread Kubacki, Michael A
Removes references to advanced features in the package to prepare for an advanced feature refactor that will impact the location of features and details such as package names and PCD token space identifiers. Cc: Wei David Y Cc: Agyeman Prince Signed-off-by: Michael Kubacki --- Platform/Intel/S

[edk2-devel] [edk2-platforms][PATCH V1 22/49] DebugFeaturePkg: Remove the ACPI Debug feature

2019-11-12 Thread Kubacki, Michael A
Removes the S3 feature from DebugFeaturePkg. The feature does not follow the advanced feature design. A future change will add the feature back following the advanced feature design. Cc: Eric Dong Cc: Liming Gao Signed-off-by: Michael Kubacki --- Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.

[edk2-devel] [edk2-platforms][PATCH V1 13/49] AdvancedFeaturePkg: Remove the S3 feature

2019-11-12 Thread Kubacki, Michael A
Removes the S3 feature from AdvancedFeaturePkg. The feature does not follow the advanced feature design. A future change will add the feature back following the advanced feature design. Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Michael Kubacki --- Platform/Intel/AdvancedFeaturePkg/Advance

[edk2-devel] [edk2-platforms][PATCH V1 18/49] Features/Intel/IpmiFeaturePkg: Add modules

2019-11-12 Thread Kubacki, Michael A
This change adds the modules for the IPMI feature to IpmiFeaturePkg. Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Michael Kubacki --- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dec | 8 + Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiF

[edk2-devel] [edk2-platforms][PATCH V1 16/49] Features/Intel/IpmiFeaturePkg: Add initial package

2019-11-12 Thread Kubacki, Michael A
Adds a new feature package for the IPMI feature. This change updates the advanced feature package template for IPMI and adds the updated template to the IpmiFeaturePkg. Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Michael Kubacki --- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFea

[edk2-devel] [edk2-platforms][PATCH V1 09/49] Features/Intel/UserInterface: Add Readme.md

2019-11-12 Thread Kubacki, Michael A
Adds the Readme.md file to briefly explain the types of features supported in the UserInterface feature domain directory. Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Michael Kubacki --- Features/Intel/UserInterface/Readme.md | 9 + 1 file changed, 9 insertions(+) diff --git a/Featu

[edk2-devel] [edk2-platforms][PATCH V1 19/49] AdvancedFeaturePkg: Remove the SMBIOS feature

2019-11-12 Thread Kubacki, Michael A
Removes the SMBIOS feature from AdvancedFeaturePkg. The feature does not follow the advanced feature design. A future change will add the feature back following the advanced feature design. Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Michael Kubacki --- Platform/Intel/AdvancedFeaturePkg/Adv

[edk2-devel] [edk2-platforms][PATCH V1 20/49] Features/Intel/SmbiosFeaturePkg: Add initial package

2019-11-12 Thread Kubacki, Michael A
Adds a new feature package for the SMBIOS feature. Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Michael Kubacki --- Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosFeaturePkg.dec | 172 Features/Intel/SystemInformation/SmbiosFeatur

[edk2-devel] [edk2-platforms][PATCH V1 15/49] AdvancedFeaturePkg: Remove the IPMI feature

2019-11-12 Thread Kubacki, Michael A
Removes the IPMI feature from AdvancedFeaturePkg. The feature does not follow the advanced feature design. A future change will add the feature back following the advanced feature design. Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Michael Kubacki --- Platform/Intel/AdvancedFeaturePkg/Advan

[edk2-devel] [edk2-platforms][PATCH V1 14/49] Features/Intel: Add S3FeaturePkg

2019-11-12 Thread Kubacki, Michael A
Adds a new feature package for the S3 feature. Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Michael Kubacki --- Features/Intel/PowerManagement/S3FeaturePkg/S3FeaturePkg.dec | 30 + Features/Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc | 122 Feat

[edk2-devel] [edk2-platforms][PATCH V1 28/49] Features/Intel/NetworkFeaturePkg: Add initial package

2019-11-12 Thread Kubacki, Michael A
Adds a new feature package for the Network feature. The Network feature code is actually in edk2/NetworkPkg at this time so this package inclues the content from edk2/NetworkPkg. In the future, it is preferred to move the source code from NetworkPkg to NetworkFeaturePkg. Cc: Sai Chaganty Cc: Lim

[edk2-devel] [edk2-platforms][PATCH V1 23/49] Features/Intel/AcpiDebugFeaturePkg: Add initial package

2019-11-12 Thread Kubacki, Michael A
Adds a new feature package for the ACPI Debug feature. Cc: Eric Dong Cc: Liming Gao Signed-off-by: Michael Kubacki --- Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugFeaturePkg.dec | 39 ++ Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugFeaturePkg.dsc | 30 +

Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 07/12] PciBusDxe: Record the PCI-Express Capability Structure

2019-11-12 Thread Javeed, Ashraf
This patch is also uploaded in the following Repo, for review:- https://github.com/ashrafj/edk2-staging/commit/8b40bc5cf23c57ad468939b84449a87c9d90b90a thanks Ashraf > -Original Message- > From: devel@edk2.groups.io On Behalf Of Javeed, > Ashraf > Sent: Friday, November 1, 2019 8:40 PM >

[edk2-devel] [edk2-platforms][PATCH V1 10/49] Features/Intel/Network: Add Readme.md

2019-11-12 Thread Kubacki, Michael A
Adds the Readme.md file to briefly explain the types of features supported in the Network feature domain directory. Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Michael Kubacki --- Features/Intel/Network/Readme.md | 5 + 1 file changed, 5 insertions(+) diff --git a/Features/Intel/Networ

[edk2-devel] [edk2-platforms][PATCH V1 02/49] DebugFeaturePkg: Package DSC style cleanup

2019-11-12 Thread Kubacki, Michael A
This change refactors DebugFeaturePkg.dsc to consolidate redundant sections and better group file content to improve maintainability and readability. This pattern is being applied in all Minimum Platform package DSC files. Cc: Eric Dong Cc: Liming Gao Signed-off-by: Michael Kubacki --- Platfo

[edk2-devel] [edk2-platforms][PATCH V1 04/49] Features/Intel: Add Readme.md

2019-11-12 Thread Kubacki, Michael A
This change adds the initial Readme.md to the root of the Features/ Intel directory. The features are maintained in an Intel directory because they are not tested on other systems. If there is interest to support a feature on systems other than Intel, the feature should be tested on those other sys

[edk2-devel] [edk2-platforms][PATCH V1 08/49] Features/Intel/Debug: Add Readme.md

2019-11-12 Thread Kubacki, Michael A
Adds the Readme.md file to briefly explain the types of features supported in the Debug feature domain directory. Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Michael Kubacki --- Features/Intel/Debugging/Readme.md | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Features/Intel/Debu

[edk2-devel] [edk2-platforms][PATCH V1 05/49] Features/Intel/PowerManagement: Add Readme.md

2019-11-12 Thread Kubacki, Michael A
Adds the Readme.md file to briefly explain the types of features supported in the PowerManagement feature domain directory. Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Michael Kubacki --- Features/Intel/PowerManagement/Readme.md | 10 ++ 1 file changed, 10 insertions(+) diff --git

Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 06/12] PciBusDxe: Integration of setup for PCI feature enumeration

2019-11-12 Thread Javeed, Ashraf
This patch is also uploaded in the following Repo, for review:- https://github.com/ashrafj/edk2-staging/commit/9e42cc3c6e100c46a65f6e5926686d5f4d9fa58a thanks Ashraf > -Original Message- > From: devel@edk2.groups.io On Behalf Of Javeed, > Ashraf > Sent: Friday, November 1, 2019 8:40 PM >

[edk2-devel] [edk2-platforms][PATCH V1 01/49] AdvancedFeaturePkg: Package DSC style cleanup

2019-11-12 Thread Kubacki, Michael A
This change refactors AdvancedFeaturePkg.dsc to consolidate redundant sections and better group file content to improve maintainability and readability. This pattern is being applied in all Minimum Platform package DSC files. Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Michael Kubacki ---

[edk2-devel] [edk2-platforms][PATCH V1 00/49] Intel Advanced Feature Refactor

2019-11-12 Thread Kubacki, Michael A
RFC:https://edk2.groups.io/g/devel/message/49880 This patch series introduces a consistent design for Intel advanced features. Advanced features in this context refer to the definition stated in the EDK II Minimum Platform specification. Information regarding this feature design is provided in Fe

[edk2-devel] [edk2-platforms][PATCH V1 03/49] UserInterfaceFeaturePkg: Package DSC style cleanup

2019-11-12 Thread Kubacki, Michael A
This change refactors UserInterfaceFeaturePkg.dsc to consolidate redundant sections and better group file content to improve maintainability and readability. This pattern is being applied in all Minimum Platform package DSC files. Cc: Dandan Bi Cc: Liming Gao Signed-off-by: Michael Kubacki ---

[edk2-devel] [edk2-platforms][PATCH V1 07/49] Features/Intel/SystemInformation: Add Readme.md

2019-11-12 Thread Kubacki, Michael A
Adds the Readme.md file to briefly explain the types of features supported in the SystemInformation feature domain directory. Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Michael Kubacki --- Features/Intel/SystemInformation/Readme.md | 8 1 file changed, 8 insertions(+) diff --git

[edk2-devel] [edk2-platforms][PATCH V1 06/49] Features/Intel/OutOfBandManagement: Add Readme.md

2019-11-12 Thread Kubacki, Michael A
Adds the Readme.md file to briefly explain the types of features supported in the OutOfBandManagement feature domain directory. Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Michael Kubacki --- Features/Intel/OutOfBandManagement/Readme.md | 8 1 file changed, 8 insertions(+) diff --

Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 05/12] PciBusDxe: Setup sub-phases for PCI feature enumeration

2019-11-12 Thread Javeed, Ashraf
This patch is also uploaded in the following Repo for review:- https://github.com/ashrafj/edk2-staging/commit/59854e2f4eb2b52c9e73f9c5c7fede6c5128b39a Thanks Ashraf > -Original Message- > From: devel@edk2.groups.io On Behalf Of Javeed, > Ashraf > Sent: Friday, November 1, 2019 8:40 PM >

Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 04/12] PciBusDxe: Inclusion of new PCI Platform Protocol 2

2019-11-12 Thread Javeed, Ashraf
This patch is also uploaded in the following Repo, for review:- https://github.com/ashrafj/edk2-staging/commit/bcaab03c212a8d6c3e23ab986aa3ec05b60dd61d Thanks Ashraf > -Original Message- > From: devel@edk2.groups.io On Behalf Of Javeed, > Ashraf > Sent: Friday, November 1, 2019 8:40 PM >

Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 03/12] PciBusDxe: Separation of the PCI device registration and start

2019-11-12 Thread Javeed, Ashraf
This patch is also uploaded in following Repo, for review:- https://github.com/ashrafj/edk2-staging/commit/421511cd582975c65983d75dad0e2a58956bfafd Thanks Ashraf > -Original Message- > From: devel@edk2.groups.io On Behalf Of Javeed, > Ashraf > Sent: Friday, November 1, 2019 8:40 PM > To:

Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 02/12] PciBusDxe: Reorganize the PCI Platform Protocol usage code

2019-11-12 Thread Javeed, Ashraf
This patch is also uploaded in the following Repo, for review:- https://github.com/ashrafj/edk2-staging/commit/ff68bb88bdb81d3921ebc7410c69e52e9d2fdb0e Thanks Ashraf > -Original Message- > From: devel@edk2.groups.io On Behalf Of Javeed, > Ashraf > Sent: Friday, November 1, 2019 8:40 PM >

Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 01/12] MdeModulePkg/PciBusDxe:New PCI features separation with PCD

2019-11-12 Thread Javeed, Ashraf
This patch is also uploaded in the following Repo:- https://github.com/ashrafj/edk2-staging/commit/0cc1a9555e1546ad94dd368160ece526d10d96a6 Please review. Thanks Ashraf > -Original Message- > From: devel@edk2.groups.io On Behalf Of Javeed, > Ashraf > Sent: Friday, November 1, 2019 8:40 P

[edk2-devel] [PATCH] BaseTools:Add [packages] section in dsc file

2019-11-12 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2270 Currently a PCD (e.g. FeaturePCD) cannot be used in a conditional statement in a DSC/FDF file without a module in the build referencing the PCD package DEC file. An example implementation that to support this is to allow a [Packages] section

Re: [edk2-devel] [PATCH V5 5/8] ShellPkg/SmbiosView: SMBIOS 3.3.0 add PCI gen4 values for type 9

2019-11-12 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Gao, Zhichao > Sent: Wednesday, November 13, 2019 10:11 AM > To: devel@edk2.groups.io > Cc: Gao, Zhichao ; Ni, Ray ; > Chaganty, Rangasai V > Subject: [PATCH V5 5/8] ShellPkg/SmbiosView: SMBIOS 3.3.0 add PCI gen4 > values for type 9 > >

Re: [edk2-devel] [[PATCH 1/1]] EmulatorPkg using CpuBreakPoint

2019-11-12 Thread Ni, Ray
Kilian, Thank you very much for enabling the better VS debugging experience. Minor comments below. From: devel@edk2.groups.io On Behalf Of Liming Gao Sent: Wednesday, November 13, 2019 9:07 AM To: devel@edk2.groups.io; kilian_ke...@outlook.com Cc: Richardson, Brian ; Kinney, Michael D ; Gao, Li

Re: [edk2-devel] [PATCH V5 0/8] Update SMBIOS 3.3.0

2019-11-12 Thread Gao, Zhichao
Sorry for this incomplete patch. The commit message's title also has a typo for the up/low cases issue. I would send a fixed one later. Thanks, Zhichao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Gao, > Zhichao > Sent: Wednesday, November 13, 2019 7:34 AM > To: devel@

[edk2-devel] [PATCH V5 3/8] MdePkg/SmBios.h: SMBIOS 3.3.0 Add value HBM and Die for type 17

2019-11-12 Thread Gao, Zhichao
From: "Gao, Zhichao" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2305 Memory Device (Type 17): - SMBIOSCR00178: add new memory device type value (HBM) and new form factor value (Die) Cc: Michael D Kinney Cc: Liming Gao Cc: Sai Chaganty Reviewed-by: Liming Gao Signed-off-by: Zhichao

[edk2-devel] [PATCH V5 8/8] ShellPkg/SmbiosView: SMBIOS 3.3.0 Update "Intel persistent memory"

2019-11-12 Thread Gao, Zhichao
From: "Gao, Zhichao" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2305 Memory Device (Type 17): - SMBIOSCR00179: update the string for Intel persistent memory Cc: Ray Ni Cc: Sai Chaganty Reviewed-by: Ray Ni Signed-off-by: Zhichao Gao --- ShellPkg/Library/UefiShellDebug1CommandsLib/S

[edk2-devel] [PATCH V5 6/8] ShellPkg/SmbiosView: SMBIOS 3.3.0 add support for CXL Flexbus

2019-11-12 Thread Gao, Zhichao
From: "Gao, Zhichao" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2305 Various: - SMBIOSCR00183: add support for CXL Flexbus Cc: Ray Ni Cc: Sai Chaganty Reviewed-by: Ray Ni Signed-off-by: Zhichao Gao --- .../Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c| 8

[edk2-devel] [PATCH V5 0/8] Update SMBIOS 3.3.0

2019-11-12 Thread Gao, Zhichao
The following changes were made to version 3.2.0 of the document to produce this version: System Slots (Type 9): - Add PCI Express Gen 4 values - Clarify bus number usage for PCI Express Memory Device (Type 17): - Add new memory device type value (HBM) and new form factor value (Die) - Update the s

[edk2-devel] [PATCH V5 5/8] ShellPkg/SmbiosView: SMBIOS 3.3.0 add PCI gen4 values for type 9

2019-11-12 Thread Gao, Zhichao
From: "Gao, Zhichao" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2305 System Slots (Type 9): - SMBIOSCR00184: add PCI Express Gen 4 values Add the Smbios.h to use the MARCOs or enums. Cc: Ray Ni Cc: Sai Chaganty Signed-off-by: Zhichao Gao --- .../SmbiosView/QueryTable.c

[edk2-devel] [PATCH V5 1/8] MdePkg/SmBios.h: SMBIOS 3.3.0 add PCI gen4 values for type 9

2019-11-12 Thread Gao, Zhichao
From: "Gao, Zhichao" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2305 System Slots (Type 9): - SMBIOSCR00184: add PCI Express Gen 4 values Cc: Michael D Kinney Cc: Liming Gao Cc: Sai Chaganty Reviewed-by: Sai Chaganty Reviewed-by: Liming Gao Signed-off-by: Zhichao Gao --- MdePkg/

[edk2-devel] [PATCH V5 2/8] MdePkg/SmBios.h: SMBIOS 3.3.0 add support for CXL Flexbus

2019-11-12 Thread Gao, Zhichao
From: "Gao, Zhichao" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2305 Various: - SMBIOSCR00183: add support for CXL Flexbus Cc: Michael D Kinney Cc: Liming Gao Cc: Sai Chaganty Reviewed-by: Sai Chaganty Reviewed-by: Liming Gao Signed-off-by: Zhichao Gao --- MdePkg/Include/Industr

[edk2-devel] [PATCH V5 7/8] ShellPkg/SmbiosView: SMBIOS 3.3.0 Add value HBM and Die for type 17

2019-11-12 Thread Gao, Zhichao
From: "Gao, Zhichao" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2305 Memory Device (Type 17): - SMBIOSCR00178: add new memory device type value (HBM) and new form factor value (Die) Cc: Ray Ni Cc: Sai Chaganty Reviewed-by: Ray Ni Signed-off-by: Zhichao Gao --- .../UefiShellDebug1C

[edk2-devel] [PATCH V5 4/8] MdePkg/SmBios.h: SMBIOS 3.3.0 Update Intel Persistent Memory string

2019-11-12 Thread Gao, Zhichao
From: "Gao, Zhichao" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2305 Memory Device (Type 17): - SMBIOSCR00179: update the string for Intel persistent memory Cc: Michael D Kinney Cc: Liming Gao Cc: Sai Chaganty Reviewed-by: Liming Gao Signed-off-by: Zhichao Gao --- MdePkg/Include/

[edk2-devel] [PATCH V5 1/8] MdePkg/Smbios.h: SMBIOS 3.3.0 add PCI gen4 values for type 9

2019-11-12 Thread Gao, Zhichao
From: "Gao, Zhichao" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2305 System Slots (Type 9): - SMBIOSCR00184: add PCI Express Gen 4 values Cc: Michael D Kinney Cc: Liming Gao Cc: Sai Chaganty Reviewed-by: Sai Chaganty Reviewed-by: Liming Gao Signed-off-by: Zhichao Gao --- MdePkg/

[edk2-devel] [PATCH V5 3/8] MdePkg/Smbios.h: SMBIOS 3.3.0 Add value HBM and Die for type 17

2019-11-12 Thread Gao, Zhichao
From: "Gao, Zhichao" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2305 Memory Device (Type 17): - SMBIOSCR00178: add new memory device type value (HBM) and new form factor value (Die) Cc: Michael D Kinney Cc: Liming Gao Cc: Sai Chaganty Reviewed-by: Liming Gao Signed-off-by: Zhichao

[edk2-devel] [PATCH V5 2/8] MdePkg/Smbios.h: SMBIOS 3.3.0 add support for CXL Flexbus

2019-11-12 Thread Gao, Zhichao
From: "Gao, Zhichao" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2305 Various: - SMBIOSCR00183: add support for CXL Flexbus Cc: Michael D Kinney Cc: Liming Gao Cc: Sai Chaganty Reviewed-by: Sai Chaganty Reviewed-by: Liming Gao Signed-off-by: Zhichao Gao --- MdePkg/Include/Industr

[edk2-devel] [PATCH V5 0/8] Update SMBIOS 3.3.0

2019-11-12 Thread Gao, Zhichao
The following changes were made to version 3.2.0 of the document to produce this version: System Slots (Type 9): - Add PCI Express Gen 4 values - Clarify bus number usage for PCI Express Memory Device (Type 17): - Add new memory device type value (HBM) and new form factor value (Die) - Update the s

Re: [edk2-devel] [Bug 2321] Add FitGen feature to support uCode Capsule Update

2019-11-12 Thread Chen, Kenji
Adding the correct one. -Original Message- From: devel@edk2.groups.io On Behalf Of Chen, Kenji Sent: Wednesday, November 13, 2019 9:53 AM To: devel@edk2.groups.io; Chen, Kenji ; Gao, Liming ; Ke, VincentX Subject: Re: [edk2-devel] [Bug 2321] Add FitGen feature to support uCode Capsule

Re: [edk2-devel] [Bug 2321] Add FitGen feature to support uCode Capsule Update

2019-11-12 Thread Liming Gao
The patch is not updated. >-Original Message- >From: Chen, Kenji >Sent: Wednesday, November 13, 2019 9:53 AM >To: devel@edk2.groups.io; Chen, Kenji ; Gao, Liming >; Ke, VincentX >Subject: RE: [edk2-devel] [Bug 2321] Add FitGen feature to support uCode >Capsule Update > >Newer version. >

Re: [edk2-devel] [Bug 2321] Add FitGen feature to support uCode Capsule Update

2019-11-12 Thread Chen, Kenji
Newer version. Add -L/-l for Microcode slot mode. Hi Vincent, Pls follow this to change the usage in postbuild.bat when generating BIOS image. Thanks, Kenji. -Original Message- From: devel@edk2.groups.io On Behalf Of Chen, Kenji Sent: Wednesday, November 13, 2019 9:43 AM To: Gao, Limi

Re: [edk2-devel] [Bug 2321] Add FitGen feature to support uCode Capsule Update

2019-11-12 Thread Chen, Kenji
Sure. Added the comment and help message. Will update BZ. -Original Message- From: Gao, Liming Sent: Wednesday, November 13, 2019 8:48 AM To: Chen, Kenji ; Ke, VincentX Cc: 'devel@edk2.groups.io' Subject: RE: [edk2-devel] [Bug 2321] Add FitGen feature to support uCode Capsule Update

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Build ASL files before C files

2019-11-12 Thread Bob Feng
Hi Pierre, I meet another problem related to .asl file. In one of platforms build process, there is a step which need to compile a .asl file a .h file firstly and that .h file will be included by a module’s source code. That step cannot be handled in edk2 build since the compilation command use

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Build ASL files before C files

2019-11-12 Thread Liming Gao
Pierre: Order may not resolve the problem. Build tool needs to know their relationship, and generate the correct dependency between ASL and C source file. If there is no dependency between them in Makefile, Makefile multiple thread build (make -jn) may break it. Thanks Liming From: devel@edk

Re: [edk2-devel] [[PATCH 1/1]] EmulatorPkg using CpuBreakPoint

2019-11-12 Thread Liming Gao
Kilian: Can you create the patch with the commit message? For the patch, I add my comments. From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Kilian Kegel Sent: Wednesday, November 06, 2019 1:36 AM To: Gao, Liming Cc: devel@edk2.groups.io; Richardson, Brian ; Kinney, M

Re: [edk2-devel] [Bug 2321] Add FitGen feature to support uCode Capsule Update

2019-11-12 Thread Liming Gao
Kenji: This patch adds -S option for Slotsize. Please update FitGen tool help message to list this new option. And, you also need to update BZ https://bugzilla.tianocore.org/show_bug.cgi?id=2321 for this change. Based on current description in BZ, I don't know why need to add -S option.

Re: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/Variable: Fix volatile variable RT cache update logic

2019-11-12 Thread Liming Gao
Reviewed-by: Liming Gao >-Original Message- >From: Kubacki, Michael A >Sent: Wednesday, November 13, 2019 7:41 AM >To: devel@edk2.groups.io >Cc: Gao, Liming ; Kinney, Michael D >; Wang, Jian J ; Wu, >Hao A >Subject: [PATCH V2 1/1] MdeModulePkg/Variable: Fix volatile variable RT >cache up

Re: [edk2-devel] [Bug 2321] Add FitGen feature to support uCode Capsule Update

2019-11-12 Thread Chen, Kenji
Updating the correct one. + Vincent to confirm the patch. Thanks, Kenji. -Original Message- From: Gao, Liming Sent: Tuesday, November 12, 2019 11:43 PM To: Chen, Kenji Subject: RE: [edk2-devel] [Bug 2321] Add FitGen feature to support uCode Capsule Update Here is edk2platform git repo

[edk2-devel] [PATCH V2 1/1] MdeModulePkg/Variable: Fix volatile variable RT cache update logic

2019-11-12 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2333 During a SetVariable () invocation, UpdateVariable () is called. UpdateVariable () contains logic to determine whether a volatile or non-volatile UEFI variable was set so the corresponding runtime cache can be updated to reflect the change. T

Re: [edk2-devel] EDK II Maintainers - EDK II CI is now active on edk2/master

2019-11-12 Thread Michael D Kinney
GitHub link with screen shots to enable 'Watch' feature. https://help.github.com/en/github/receiving-notifications-about-activity-on-github/watching-and-unwatching-repositories Mike > -Original Message- > From: Kinney, Michael D > Sent: Tuesday, November 12, 2019 11:51 AM > To: Laszlo E

Re: [edk2-devel] EDK II Maintainers - EDK II CI is now active on edk2/master

2019-11-12 Thread Michael D Kinney
Hi Laszlo, The setting that is required is 'Watch' on the edk2 repo. Navigate to the main page for the tianocore edk2 repo: https://github.com/tianocore/edk2 At the top of the page, there is a drop down called 'Watch'. Select 'Watching - Be notified of all conversations.' GitHub documentati

Re: [edk2-devel] "via Groups.io"

2019-11-12 Thread Laszlo Ersek
On 11/12/19 18:37, Richardson, Brian wrote: > Per the groups.io FAQ... > > https://groups.io/static/help#why-are-emails-from-some-people-changed-to-be-via-groups-io > > Why Are Emails From Some People Changed To Be 'via Groups.io'? > > The reason that some email addresses are changed to be 'via

Re: [edk2-devel] "via Groups.io"

2019-11-12 Thread Brian Richardson
Per the groups.io FAQ... https://groups.io/static/help#why-are-emails-from-some-people-changed-to-be-via-groups-io Why Are Emails From Some People Changed To Be 'via Groups.io'? The reason that some email addresses are changed to be 'via Groups.io' is because of something called DMARC. Some ema

  1   2   >