Sets gEfiMdeModulePkgTokenSpaceGuid.PcdEnableVariableRuntimeCache
to FALSE in OvmfPkgIa32.dsc, OvmfPkgIa32X64.dsc, and OvmfPkgX64.dsc
so that when SMM_REQUIRE is TRUE, the SMM variable driver will not
use the runtime variable cache.
This is done for OvmfPkg because it currently depends upon a SMM
This change enables the variable runtime cache by default by setting
gEfiMdeModulePkgTokenSpaceGuid.PcdEnableVariableRuntimeCache in
MdeModulePkg.dec to TRUE.
Cc: Dandan Bi
Cc: Ard Biesheuvel
Cc: Eric Dong
Cc: Laszlo Ersek
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Ray Ni
Cc: Jian J Wang
Cc:
https://bugzilla.tianocore.org/show_bug.cgi?id=2220
This change implements the Runtime Service GetNextVariableName()
using the runtime cache in VariableSmmRuntimeDxe. Runtime Service
calls to GetNextVariableName() will no longer trigger a SW SMI
when gEfiMdeModulePkgTokenSpaceGuid.PcdEnableVariabl
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2220
V6 Changes:
[PATCH V5 07/10] MdeModulePkg/Variable: Add RT GetVariable() cache support
The most significant change is:
* Free mVariableRuntimeHobCacheBuffer in CheckForRuntimeCacheSync () in
VariableSmmRuntimeDxe.c with FreePages () ins
This change moves the following functions into a dedicated file
so they may be used in other variable files as needed. These are
commonly needed for basic variable data structure parsing
operations. The functions are grouped together in VariableParsing.c
to support cohesiveness for these operations
The majority of logic related to GetNextVariableName () is currently
implemented in VariableServiceGetNextVariableInternal (). The list
of variable stores to search for the given variable name and variable
GUID is defined in the function body. This change adds a new parameter
so that the caller mus
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2220
This change reduces SMIs for GetVariable () by maintaining a
UEFI variable cache in Runtime DXE in addition to the pre-
existing cache in SMRAM. When the Runtime Service GetVariable()
is invoked, a Runtime DXE cache is used instead of trigger
This change adds a dedicated file for variable operations specific
to non-volatile variables. This decreases the overall length of the
relatively large Variable.c file.
Cc: Dandan Bi
Cc: Ard Biesheuvel
Cc: Eric Dong
Cc: Laszlo Ersek
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Ray Ni
Cc: Jian J
UpdateVariableInfo () currently accepts parameters regarding updates
to be made to a global variable of type VARIABLE_INFO_ENTRY. This
change passes the structure by pointer to UpdateVariableInfo ()
so structures other than the fixed global variable can be updated.
Cc: Dandan Bi
Cc: Ard Biesheuve
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2220
The current VariableInfo application only checks for variable
statistics from SMM if the variable information entries are
not present in the UEFI System Configuration table as published
by the DXE UEFI variable driver (VariableRuntimeDxe).
T
The file VariableParsing.c provides generic functionality related
to parsing variable related structures and information. In order to
calculate offsets for certain operations, the functions must know if
authenticated variables are enabled as this increases the size of
variable headers.
This change
Reviewed-by: Michael Kubacki
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chiu,
> Chasel
> Sent: Wednesday, October 30, 2019 5:30 PM
> To: devel@edk2.groups.io
> Cc: Lu, Shifei A ; Zhou, Bowen
> ; Oram, Isaac W
> Subject: [edk2-devel] [edk2-platforms: PATCH v2 5/6]
> P
Reviewed-by: Michael Kubacki
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chiu,
> Chasel
> Sent: Wednesday, October 30, 2019 5:30 PM
> To: devel@edk2.groups.io
> Cc: Wei, David Y ; Agyeman, Prince
>
> Subject: [edk2-devel] [edk2-platforms: PATCH v2 6/6]
> SimicsOpenBoa
Reviewed-by: Michael Kubacki
> -Original Message-
> From: Chiu, Chasel
> Sent: Wednesday, October 30, 2019 5:30 PM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A ; Desimone, Nathaniel
> L
> Subject: [edk2-platforms: PATCH v2 4/6] WhiskeylakeOpenBoardPkg: Add
> SetCacheLib library c
Reviewed-by: Michael Kubacki
> -Original Message-
> From: Chiu, Chasel
> Sent: Wednesday, October 30, 2019 5:30 PM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A ; Desimone, Nathaniel
> L ; Gao, Liming ;
> Jeremy Soller
> Subject: [edk2-platforms: PATCH v2 3/6] KabylakeOpenBoardPkg
Reviewed-by: Michael Kubacki
> -Original Message-
> From: Chiu, Chasel
> Sent: Wednesday, October 30, 2019 5:30 PM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A ; Desimone, Nathaniel
> L ; Gao, Liming
> Subject: [edk2-platforms: PATCH v2 2/6] MinPlatformPkg: Add SetCacheLib
> libr
1. It would be good to list the new library class in the
[LibraryClasses] section of MinPlatformPkg.dec.
2. I think it would be more descriptive to call these library
instances BaseSetCacheLibNull and BaseSetCacheLib.
3. It would be helpful to provide a description somewhere such as
SetCac
Hi Chasel,
I don't think SetCacheLib is quite precise enough. Can you please
consider an alternative such as SetMtrrLib?
Thanks,
Michael
> -Original Message-
> From: Chiu, Chasel
> Sent: Wednesday, October 30, 2019 5:30 PM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A ; Desimone,
Agreed.
On Thu, 31 Oct 2019, 12:39 Kinney, Michael D,
wrote:
> Hi Leif,
>
> I will see if we can add a proper file header with a description.
>
> I may break this out into its own patch since it is useful to
> install these pip modules to run CI tests and builds locally.
> The pip modules are no
Leif,
Thanks. I agree. I will split it out.
Mike
> -Original Message-
> From: Leif Lindholm
> Sent: Tuesday, October 29, 2019 7:30 PM
> To: Kinney, Michael D
> Cc: devel@edk2.groups.io; Sean Brogan
> ; Andrew Fish
> ; Laszlo Ersek
> Subject: Re: [Patch v3 02/22] .gitignore: Ignore p
Hi Leif,
Thanks for noticing the reference to the ci dir. That content
Has been moved to .azurepipelines directory and the Readme.md
filename is correct there.
I will split out the format changes to this Readme.md into its
own patch so it will not be mixed with the CI features.
I agree that th
Hi Leif,
I will see if we can add a proper file header with a description.
I may break this out into its own patch since it is useful to
install these pip modules to run CI tests and builds locally.
The pip modules are not only use in a CI agent.
Mike
> -Original Message-
> From: devel@
Liming,
For gcc/clang if you repeat an argument the last argument wins. This is the
default behavior and it does not warn, as it is designed to work with features
like PcdOptimizeCompilerEnable.
If VC++ warns for this behavior should we disable D9025 for VC++ so all the
toolchains have the sa
-Original Message-
From: devel@edk2.groups.io On Behalf Of Zhang, Shenglei
Sent: Wednesday, October 30, 2019 10:27 PM
To: devel@edk2.groups.io
Cc: Wang, Jian J ; Wu, Hao A
Subject: [edk2-devel] [PATCH v2 4/4] MdeModulePkg/SetupBrowserDxe: Add check
for GetBufferForValue()
The returned v
> -Original Message-
> From: Zhang, Shenglei
> Sent: Wednesday, October 30, 2019 10:08 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A; Ni, Ray
> Subject: [PATCH v2 1/3] MdeModulePkg/EhciPei: Initialize the variable Map
>
> Map is used but not Initialized.
> Map is called by IoMmuMap, in whi
> -Original Message-
> From: Zhang, Shenglei
> Sent: Wednesday, October 30, 2019 10:08 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A; Ni, Ray
> Subject: [PATCH v2 2/3] MdeModulePkg/UhciPei: Initialize the variable
> RequestMap
>
> RequestMap is used but not Initialized.
> RequestMap is cal
> -Original Message-
> From: Zhang, Shenglei
> Sent: Wednesday, October 30, 2019 8:33 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A; Ni, Ray
> Subject: [PATCH v2] MdeModulePkg/SdBlockIoPei: Add check for DeviceIndex
>
> DeviceIndex is used as index in Slot[]. The max size of Slot[]
> is SD
Yes. This is the expect behavior. Compiler optimization is disabled, then Od
option will be used for VS tool chain.
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Tiger
Liu(BJ-RD)
Sent: Thursday, October 31, 2019 9:40 AM
To: devel@edk2.groups.io; Gao, Liming
Subject: Re:
Hi, Liming:
Thanks for your explanation.
If setting PcdOptimizeCompilerEnable as disable, then will cause D9025
compiling warning.
Such as:
cl : Command line warning D9025 : overriding '/O1' with '/Od'
So, is it ok?
Thanks
发件人: devel@edk2.groups.io 代表 Liming Gao
发送时间: 2019年10月30日 23:00
收件人: de
Reviewed-by: Nate DeSimone
-Original Message-
From: Chiu, Chasel
Sent: Wednesday, October 30, 2019 5:30 PM
To: devel@edk2.groups.io
Cc: Kubacki, Michael A ; Desimone, Nathaniel L
Subject: [edk2-platforms: PATCH v2 4/6] WhiskeylakeOpenBoardPkg: Add
SetCacheLib library class.
REF: htt
Reviewed-by: Nate DeSimone
-Original Message-
From: devel@edk2.groups.io On Behalf Of Chiu, Chasel
Sent: Wednesday, October 30, 2019 5:30 PM
To: devel@edk2.groups.io
Cc: Wei, David Y ; Agyeman, Prince
Subject: [edk2-devel] [edk2-platforms: PATCH v2 6/6]
SimicsOpenBoardPkg/BoardX58Ich1
Reviewed-by: Nate DeSimone
-Original Message-
From: Chiu, Chasel
Sent: Wednesday, October 30, 2019 5:30 PM
To: devel@edk2.groups.io
Cc: Kubacki, Michael A ; Desimone, Nathaniel L
; Gao, Liming ; Jeremy
Soller
Subject: [edk2-platforms: PATCH v2 3/6] KabylakeOpenBoardPkg: Add SetCacheL
Reviewed-by: Nate DeSimone
-Original Message-
From: Chiu, Chasel
Sent: Wednesday, October 30, 2019 5:30 PM
To: devel@edk2.groups.io
Cc: Kubacki, Michael A ; Desimone, Nathaniel L
; Gao, Liming
Subject: [edk2-platforms: PATCH v2 2/6] MinPlatformPkg: Add SetCacheLib library
class.
REF
Reviewed-by: Nate DeSimone
-Original Message-
From: devel@edk2.groups.io On Behalf Of Chiu, Chasel
Sent: Wednesday, October 30, 2019 5:30 PM
To: devel@edk2.groups.io
Cc: Lu, Shifei A ; Zhou, Bowen ;
Oram, Isaac W
Subject: [edk2-devel] [edk2-platforms: PATCH v2 5/6]
PurleyOpenBoardPkg/
Reviewed-by: Nate DeSimone
-Original Message-
From: Chiu, Chasel
Sent: Wednesday, October 30, 2019 5:30 PM
To: devel@edk2.groups.io
Cc: Kubacki, Michael A ; Desimone, Nathaniel L
; Gao, Liming
Subject: [edk2-platforms: PATCH v2 1/6] MinPlatformPkg: Add SetCacheLib library
class.
REF
Your whitespace doesn't quite match edk2 coding style guidelines, but we can
fix that during commit.
Reviewed-by: Nate DeSimone
-Original Message-
From: Agyeman, Prince
Sent: Wednesday, October 30, 2019 10:05 AM
To: devel@edk2.groups.io
Cc: Sinha, Ankit ; Desimone, Nathaniel L
; Kuba
Reviewed-by: Nate DeSimone
-Original Message-
From: devel@edk2.groups.io On Behalf Of Kubacki, Michael
A
Sent: Tuesday, October 29, 2019 4:05 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
; Jeremy Soller
Subject: [edk2-devel] [edk2-platforms][PATCH V1 1/2] Kabyl
Reviewed-by: Nate DeSimone
-Original Message-
From: Kubacki, Michael A
Sent: Tuesday, October 29, 2019 4:05 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
Subject: [edk2-platforms][PATCH V1 2/2] WhiskeylakeOpenBoardPkg: Correct
Platform Hook Library references
Reviewed-by: Nate DeSimone
-Original Message-
From: Agyeman, Prince
Sent: Tuesday, October 29, 2019 3:27 PM
To: devel@edk2.groups.io
Cc: Sinha, Ankit ; Desimone, Nathaniel L
; Kubacki, Michael A
Subject: [edk2-platforms] [PATCH] SimicsOpenBoardPkg: Add CmosAccessLib to
BoardX58Ich10
Reviewed-by: Nate DeSimone
-Original Message-
From: Agyeman, Prince
Sent: Tuesday, October 29, 2019 1:36 PM
To: devel@edk2.groups.io
Cc: Sinha, Ankit ; Desimone, Nathaniel L
; Kubacki, Michael A
Subject: [edk2-platforms] [PATCH] SimicsOpenBoardPkg: Change Build Output
Directory
REF
Pierre:
Can you give the whole solution for this usage model? Does it mean C source
file depends on ASL file? This is related to the priority of source file type.
Now, there is no method to let user configure them. I suggest to introduce the
generic way instead of the specific handle.
Thanks
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2314
Include SetCacheLib from MinPlatformPkg.
Cc: Wei David Y
Cc: Agyeman Prince
Signed-off-by: Chasel Chiu
---
Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/Platform/Int
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2314
MinPlatformPkg should contain the library class header (API)
and the NULL library class instance.
Cc: Michael Kubacki
Cc: Nate DeSimone
Cc: Liming Gao
Signed-off-by: Chasel Chiu
---
Platform/Intel/MinPlatformPkg/Library/SetCacheLib/Set
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2314
Include SetCacheLib from MinPlatformPkg.
Cc: Shifei A Lu
Cc: Xiaohu Zhou
Cc: Isaac W Oram
Signed-off-by: Chasel Chiu
---
Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkg.dsc | 3 ++-
1 file changed, 2 insertions(+), 1 delet
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2314
MinPlatformPkg PlatformInit modules to consume SetCacheLib.
Cc: Michael Kubacki
Cc: Nate DeSimone
Cc: Liming Gao
Signed-off-by: Chasel Chiu
---
Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPostMem.c
| 149
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2314
Kabylake boards are relying on FSP to configure MTRRs so
they can include SetCacheLibNull.
Test: internal platform can boot with FSP API and Dispatch modes.
Cc: Michael Kubacki
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Jeremy Soller
Signed-
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2314
Whiskeylake board relying on FSP to configure MTRRs so
it can include SetCacheLibNull.
Test: internal platform can boot with FSP API modes.
Cc: Michael Kubacki
Cc: Nate DeSimone
Signed-off-by: Chasel Chiu
---
Platform/Intel/Whiskeylake
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2314
The MTRRs may be redundantly or incorrectly configured.
It is recommended to move this functionality to a library
class that with a NULL library by default. The board
package may provide its own library implementation.
MinPlatformPkg should
Signed-off-by: Nate DeSimone
Cc: Ashley E Desimone
Cc: Puja Pandya
---
edkrepo_installer/EdkRepoInstaller/App.xaml.cs | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/edkrepo_installer/EdkRepoInstaller/App.xaml.cs
b/edkrepo_installer/EdkRepoInstaller/App.xaml.cs
in
Newer versions of pip add the following output in addition to
the JSON output when running on Python 2.7:
DEPRECATION: Python 2.7 will reach the end of its life on
January 1st, 2020. Please upgrade your Python as Python 2.7 won't
be maintained after that date. A future version of pip will
drop sup
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2225
Currently, gcc 5 encounters an error "unused-but-set-variable" in
BdsPlatform.c as a result of a Status variable not being used
after it's set.
This was fixed by printing the Status variable when
EfiBootManagerDeleteLoadOptionVariable func
Mike,
On the Unix side the strategy was to launch via the debugger [1], and also pass
EFI specific debugger scripts into the debuggers on launch.
I've played with trick with OS apps by using CpuDeadLoop(). To get unstuck you
just need to update Index to be non Zero. I've also used this techni
Liming,
This may be something that is better with a command line option when
WinHost.exe is started instead of a PCD.
I also think there is a way to run VS first and start a process from VS and do
an initial BP. Does that work with latest Windows 10?
Mike
From: Gao, Liming
Sent: Wednesday,
Andrew:
I prefer to keep short CLANG9 as the tool chain name. I add wiki page
https://github.com/tianocore/tianocore.github.io/wiki/CLANG9-Tools-Chain to
introduce it. And, we have CLANG38 tool chain. It generates ELF image and DWARF
debug symbol format. It can work with LLVM 9.0 release. Cur
OK. I see now. This way is better.
Thanks
Liming
From: Minnow Ware
Sent: Wednesday, October 30, 2019 11:22 PM
To: devel@edk2.groups.io; Gao, Liming ;
kilian_ke...@outlook.com
Cc: Richardson, Brian ; Kinney, Michael D
; Ni, Ray
Subject: RE: [edk2-devel] [edk2] [EmulatorPkg] using __debugbreak()
Hi Liming,
1. when you invoke WINHOST.EXE /debug, it waits for developer input
2. otherwise default behavior
A PCD is needless.
Regards,
Kilian
From: devel@edk2.groups.io on behalf of Liming Gao
Sent: Wednesday, October 30, 2019 4:03:13 PM
To: devel@ed
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-Original Message-
From: devel@edk2.groups.io On Behalf Of PierreGondois
via Groups.Io
Sent: 30 October 2019 02:17 PM
To: devel@edk2.groups.io
Cc: Pierre Gondois ;
michael.d.kin...@intel.comliming.gao@intel.comsami.muja...@arm.com; nd
Reviewed-by: Liming Gao
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of PierreGondois
> Sent: Wednesday, October 30, 2019 10:17 PM
> To: devel@edk2.groups.io
> Cc: Pierre Gondois ;
> michael.d.kin...@intel.comliming.gao@intel.comsami.muja...@arm.com;
> n...@arm.com
> Subj
Kilian:
I think this idea is good. It can be enabled when the developer wants to do
the source level debug. So, one PCD may be introduced to control the logic. By
default, there is no change. When PCD is enabled, WinHost will wait for the
developer input.
Can you submit BZ for this request, an
NOOPT is build target. It includes the compiler option to disable optimization.
If the platform supports NOOPT target, it can be built with -b NOOPT.
PcdOptimizeCompilerEnable is one feature PCD defined in edk2-platforms. It can
be used to control the compiler option in [BuildOptions] section. I
Entry and RetEntry might be NULL before used.
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Shenglei Zhang
Reviewed-by: Hao A Wu
---
MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCmdSymbol.c | 2 +-
MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c| 2 +-
2 files changed, 2 insertions(+)
The variables and return value might be NULL.
So add check for them before they are used.
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Dandan Bi
Cc: Eric Dong
Cc: Hao A Wu
Cc: Liming Gao
Shenglei Zhang (4):
v2: Update the checking method in 02/04.
MdeModulePkg/EbcDebugger: Add check for Entry and Re
The returned value from GetBufferForValue might be NULL, so add a
check for that before it is used.
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Shenglei Zhang
---
MdeModulePkg/Universal/SetupBrowserDxe/Expression.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/MdeModulePkg/Universal
EsrtRepository might be NULL. So return EFI_OUT_OF_RESOURCES
when it is NULL.
Cc: Hao A Wu
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
Reviewed-by: Hao A Wu
---
MdeModulePkg/Universal/EsrtDxe/EsrtImpl.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/MdeModulePkg/Universal/Es
If the target string doesn't appear in the searched string,
StringPtr will be NULL. So add a check for that.
Cc: Dandan Bi
Cc: Eric Dong
Signed-off-by: Shenglei Zhang
---
v2: Instead of returning a value, we add ASSERT to ensure
StringPtr is not NULL.
MdeModulePkg/Universal/HiiDatabaseDxe
From: Pierre Gondois
The ACPI specification, version 6.3, January 2019,
defines the Named Object Encoding for ExternalOp
in section '20.2.5.2 Named Objects Encoding'.
This patch adds the definition for ExternalOp to
the list of Primary Opcode definitions.
Signed-off-by: Pierre Gondois
---
The
From: Pierre Gondois
The ACPI specification, version 6.3, January 2019,
defines the Named Object Encoding for ExternalOp
in section '20.2.5.2 Named Objects Encoding'.
This patch adds the definition for ExternalOp to
the list of Primary Opcode definitions.
Signed-off-by: Pierre Gondois
---
The
Initialize the variables before used.
v2: Commit message in all patches has been updated.
Cc: Hao A Wu
Cc: Ray Ni
Cc: Dandan Bi
Cc: Liming Gao
Shenglei Zhang (3):
MdeModulePkg/EhciPei: Initialize the variable Map
MdeModulePkg/UhciPei: Initialize the variable RequestMap
MdeModulePkg/Mem
MapMemory is not initialized by FindGuardedMemoryMap
or CoreInternalAllocatePages which calls MapMemory.
So we give a 0 to it.
Cc: Dandan Bi
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
MdeModulePkg/Core/Dxe/Mem/HeapGuard.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MdeModulePkg
Map is used but not Initialized.
Map is called by IoMmuMap, in which Mapping(Map) is called by IoMmu->Map.
We can not assume Map is given an initial value at any step.
Cc: Hao A Wu
Cc: Ray Ni
Signed-off-by: Shenglei Zhang
---
MdeModulePkg/Bus/Pci/EhciPei/EhciUrb.c | 2 ++
1 file changed, 2 ins
RequestMap is used but not Initialized.
RequestMap is called by UhciMapUserRequest, in which RequestMap(Map)
is called by IoMmuMap, and is finally called by IoMmu->Map.
We can not assume RequestMap is given an initial value at any step.
Cc: Hao A Wu
Cc: Ray Ni
Signed-off-by: Shenglei Zhang
---
The first one was not sent to devel@edk2.groups.io
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#49660): https://edk2.groups.io/g/devel/message/49660
Mute This Topic: https://groups.io/mt/39786201/21656
Group Owner: devel+ow...@edk2.grou
From: Pierre Gondois
The '-tc' option of the Intel iASL compiler facilitates
generation of AML code in a C array. This AML code is
output to a .hex file. The .hex file can be included
from a C source file, thereby allowing one to run a
fix-up code in C.
For example, this technique can be used to
The size of mHiiEfiColors is 16.
mHiiEfiColors[Private->Attribute >> 4] may be out of boundary.
So add a check for that.
Cc: Dandan Bi
Cc: Eric Dong
Signed-off-by: Shenglei Zhang
---
v2: Instead of returing value, we add ASSERT to ensure
"Private->Attribute >> 4" is not out of boundary.
M
DeviceIndex is used as index in Slot[]. The max size of Slot[]
is SD_PEIM_MAX_SLOTS. So DeviceIndex should be checked before used.
Cc: Hao A Wu
Cc: Ray Ni
Signed-off-by: Shenglei Zhang
---
v2. Update the check boundary from "SD_PEIM_MAX_SLOTS-1"
to "SD_PEIM_MAX_SLOTS". Beacuse DeviceIndex i
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2314
Include SetCacheLib from MinPlatformPkg.
Cc: Shifei A Lu
Cc: Xiaohu Zhou
Cc: Isaac W Oram
Signed-off-by: Chasel Chiu
---
Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkg.dsc | 3 ++-
1 file changed, 2 insertions(+), 1 delet
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2314
Include SetCacheLib from MinPlatformPkg.
Cc: Wei David Y
Cc: Agyeman Prince
Signed-off-by: Chasel Chiu
---
Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/Platform/Int
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2314
Kabylake boards are relying on FSP to configure MTRRs so
they can include SetCacheLibNull.
Test: internal platform can boot with FSP API and Dispatch modes.
Cc: Michael Kubacki
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Jeremy Soller
Signed-
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2314
Whiskeylake board relying on FSP to configure MTRRs so
it can include SetCacheLibNull.
Test: internal platform can boot with FSP API modes.
Cc: Michael Kubacki
Cc: Nate DeSimone
Signed-off-by: Chasel Chiu
---
Platform/Intel/Whiskeylake
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2314
MinPlatformPkg should contain the library class header (API)
and the NULL library class instance.
Cc: Michael Kubacki
Cc: Nate DeSimone
Cc: Liming Gao
Signed-off-by: Chasel Chiu
---
Platform/Intel/MinPlatformPkg/Library/SetCacheLib/Set
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2314
The MTRRs may be redundantly or incorrectly configured.
It is recommended to move this functionality to a library
class that with a NULL library by default. The board
package may provide its own library implementation.
MinPlatformPkg should
MpInitLib sets X2ApicEnable in two places.
1. CollectProcessorCount()
This function is called when MpInitLibInitialize() hasn't been
called before.
It sets X2ApicEnable and later in the same function it configures
all CPUs to operate in X2 APIC mode.
2. MpInitLibInitialize()
The X2Ap
Ray Ni (2):
UefiCpuPkg/MpInitLib: Set X2ApicEnable flag from BSP
UefiCpuPkg/MpInitLib: Remove global variable X2ApicEnable
UefiCpuPkg/Library/MpInitLib/MpLib.c | 37
UefiCpuPkg/Library/MpInitLib/MpLib.h | 1 -
2 files changed, 21 insertions(+), 17 deletions(-)
-
Today's logic sets X2ApicEnable flag in each AP's initialization
path when InitFlag == ApInitConfig.
Since all CPUs update the same global data, a spin-lock is used
to avoid modifications from multiple CPUs happen at the same time.
The spin-lock causes two problems:
1. Potential performance downgra
Hi Liming,
CpuBreakPoint() is the same as __debugbreak() on Microsoft Compiler and
generates INT 3 DebugTrap.
Yes, that procedure has worked in the past and I have used it in the same way
as you do.
But with newer Windows versions, Windows just terminates the “exceptional”
process that emits
On Wed, Oct 30, 2019 at 1:14 PM Ard Biesheuvel
wrote:
>
> On Wed, 30 Oct 2019 at 08:36, Prabhakar Kushwaha
> wrote:
> >
> > On Wed, Oct 30, 2019 at 12:43 PM Ard Biesheuvel
> > wrote:
> > >
> > > On Tue, 29 Oct 2019 at 18:17, Prabhakar Kushwaha
> > > wrote:
> > > >
> > > > Hi All,
> > > >
> > >
> -Original Message-
> From: Wu, Hao A
> Sent: Wednesday, October 30, 2019 3:15 PM
> To: devel@edk2.groups.io; Zhang, Shenglei
> Cc: Ni, Ray
> Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/SdBlockIoPei: Add check
> for DeviceIndex
>
> > -Original Message-
> > From: devel@edk2
On Wed, 30 Oct 2019 at 08:36, Prabhakar Kushwaha
wrote:
>
> On Wed, Oct 30, 2019 at 12:43 PM Ard Biesheuvel
> wrote:
> >
> > On Tue, 29 Oct 2019 at 18:17, Prabhakar Kushwaha
> > wrote:
> > >
> > > Hi All,
> > >
> > > I am working on Ubuntu-18.04 with UEFI on ARM64(64 bit) platform. The
> > > UEF
On Wed, Oct 30, 2019 at 12:43 PM Ard Biesheuvel
wrote:
>
> On Tue, 29 Oct 2019 at 18:17, Prabhakar Kushwaha
> wrote:
> >
> > Hi All,
> >
> > I am working on Ubuntu-18.04 with UEFI on ARM64(64 bit) platform. The
> > UEFI used is having ACPI tables.
> >
> > I am trying to understand where and how /
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Zhang, Shenglei
> Sent: Monday, October 21, 2019 10:13 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J; Wu, Hao A
> Subject: [edk2-devel] [PATCH] MdeModulePkg/Oniguruma: Remove redundant
> IF sta
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Zhang, Shenglei
> Sent: Thursday, October 17, 2019 2:21 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A; Ni, Ray
> Subject: [edk2-devel] [PATCH] MdeModulePkg/SdBlockIoPei: Add check for
> DeviceInde
On Tue, 29 Oct 2019 at 18:17, Prabhakar Kushwaha
wrote:
>
> Hi All,
>
> I am working on Ubuntu-18.04 with UEFI on ARM64(64 bit) platform. The
> UEFI used is having ACPI tables.
>
> I am trying to understand where and how /sys/firmware/fdt is getting
> created. is it created by UEFI or grub and pas
Hello Eric and Dandan,
Could you help to review this patch?
Thanks in advance.
Best Regards,
Hao Wu
> -Original Message-
> From: Zhang, Shenglei
> Sent: Thursday, October 17, 2019 11:31 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J; Wu, Hao A
> Subject: [PATCH 4/4] MdeModulePkg/Setup
> -Original Message-
> From: Zhang, Shenglei
> Sent: Thursday, October 17, 2019 11:31 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J; Wu, Hao A
> Subject: [PATCH 1/4] MdeModulePkg/EbcDebugger: Add check for Entry and
> RetEntry
>
> Entry and RetEntry might be NULL before used.
>
> Cc: J
> -Original Message-
> From: Zhang, Shenglei
> Sent: Thursday, October 17, 2019 11:31 AM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A; Gao, Liming
> Subject: [PATCH 3/4] MdeModulePkg/EsrtDxe: Add check for EsrtRepository
>
> EsrtRepository might be NULL. So return EFI_OUT_OF_RESOURCES
> when
95 matches
Mail list logo
