Refer to CSS 5.2.2.6 Always put space before an open parenthesis.
FreePool(AsciiBuffer); should be FreePool (AsciiBuffer);
After address that, Reviewed-by: Zhichao Gao
Thanks,
Zhichao
> -Original Message-
> From: Zhang, Shenglei
> Sent: Monday, October 14, 2019 9:25 AM
> To: devel@edk2.g
After the expression,
'CopyMem (&ConfigNvData->TargetUrl, Field->Str, Field->Len);',
the '\0' should be set to TargetUrl[Field->Len] rather than
TargetUrl[Field->Len + 1].
Besides the boundary check should be more strict.
Field->Len should range from 0-254 rather than 0-255.
Cc: Siyuan Fu
Cc: Jia
Reviewed-by: Siyuan Fu
> -Original Message-
> From: Zhang, Shenglei
> Sent: 2019年10月12日 15:43
> To: devel@edk2.groups.io
> Cc: Fu, Siyuan ; Wu, Jiaxin
> Subject: [PATCH] NetworkPkg/DxeNetLib: Change the order of conditions in
> IF statement
>
> The condition, NET_HEADSPACE(&(Nbuf->Bloc
After the expression,
'CopyMem (&ConfigNvData->TargetUrl, Field->Str, Field->Len);',
the '\0' should be set to TargetUrl[Field->Len] rather than
TargetUrl[Field->Len + 1].
Besides the boundary check should be more strict.
Field->Len should range from 0-254 rather than 0-255.
Cc: Siyuan Fu
Cc: Jia
Add check for MemFile->Buffer.
Return EFI_OUT_OF_RESOURCES if MemFile->Buffer is NULL.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Shenglei Zhang
---
v2: Add the expressiong to free AsciiBuffer before the function is returned.
ShellPkg/Application/Shell/FileHandleWrappers.c | 7 +++
1 file
Pushed at a1f94045ffe9218ec438c4d23980de4243d21cd0
-Original Message-
From: Gao, Liming
Sent: Saturday, October 12, 2019 2:04 PM
To: Feng, Bob C ; devel@edk2.groups.io
Subject: RE: [Patch 1/1] BaseTools: Fix a bug of genffs command generation
Bob:
I think this version patch is correct,
> -Original Message-
> From: Zhang, Shenglei
> Sent: Saturday, October 12, 2019 3:51 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Gao, Zhichao
> Subject: [PATCH] ShellPkg/Shell/FileHandleWrappers.c: Add check for
> MemFile->Buffer
>
> Add check for MemFile->Buffer.
> Return EFI_OUT_OF
