Re: [edk2-devel] [Patch][edk2-stable201908] BaseTools: fix an incremental build issue.

Pushed at df43ea6c08100487776bb0962c657d214e345ae7 Thanks, Bob -Original Message- From: Kinney, Michael D Sent: Thursday, August 29, 2019 2:40 AM To: Gao, Liming ; Feng, Bob C ; devel@edk2.groups.io; Kinney, Michael D Cc: Shi, Steven ; af...@apple.com; Laszlo Ersek (ler...@redhat.com)

Re: [edk2-devel] [Patch][edk2-stable201908] BaseTools: Fixed regression issue for building !x86 builds

Pushed at 37eef91017ad042035090cae46557f9d6e2d5917 Thanks, Bob -Original Message- From: Kinney, Michael D Sent: Thursday, August 29, 2019 2:43 AM To: Gao, Liming ; Leif Lindholm ; devel@edk2.groups.io; Feng, Bob C ; Kinney, Michael D Cc: af...@apple.com; Laszlo Ersek (ler...@redhat.co

Re: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling.

Hi Liming, Per your request, I have created an pull request as below: https://github.com/tianocore/edk2/pull/147 MdePkg/DxeHstiLib: Added checks to improve error handling. #147 Open JayRaghuram wants to merge 1 commit into tianocore:master

Re: [edk2-devel] [edk2-platforms PATCH v2 7/7] Platform/Intel: Add build option for SIMICS QSP Platform

Reviewed-by: Nate DeSimone -Original Message- From: Wei, David Y Sent: Tuesday, August 27, 2019 5:40 PM To: devel@edk2.groups.io Cc: Wu, Hao A ; Gao, Liming ; Sinha, Ankit ; Agyeman, Prince ; Kubacki, Michael A ; Desimone, Nathaniel L ; Kinney, Michael D Subject: [edk2-platforms PATC

Re: [edk2-devel] [edk2-platforms PATCH v2 6/7] SimicsOpenBoardPkg/BoardX58Ich10: Add board module for QSP Build tip

Update copyright year on DecomprScratchEnd.fdf.inc, OpenBoardPkg.fdf.inc, VarStore.fdf.inc -Original Message- From: Wei, David Y Sent: Tuesday, August 27, 2019 5:40 PM To: devel@edk2.groups.io Cc: Wu, Hao A ; Gao, Liming ; Sinha, Ankit ; Agyeman, Prince ; Kubacki, Michael A ; Desimone,

Re: [edk2-devel] [edk2-platforms PATCH v2 4/7] SimicsOpenBoardPkg: Add DXE driver for Legacy Sio

Reviewed-by: Nate DeSimone -Original Message- From: Wei, David Y Sent: Tuesday, August 27, 2019 5:40 PM To: devel@edk2.groups.io Cc: Wu, Hao A ; Gao, Liming ; Sinha, Ankit ; Agyeman, Prince ; Kubacki, Michael A ; Desimone, Nathaniel L ; Kinney, Michael D Subject: [edk2-platforms PATC

Re: [edk2-devel] [edk2-platforms PATCH v2 1/7] SimicsX58SktPkg: Add CPU Pkg for SimicsX58

Please update all of the copyright years. -Original Message- From: Wei, David Y Sent: Tuesday, August 27, 2019 5:40 PM To: devel@edk2.groups.io Cc: Wu, Hao A ; Gao, Liming ; Sinha, Ankit ; Agyeman, Prince ; Kubacki, Michael A ; Desimone, Nathaniel L ; Kinney, Michael D Subject: [edk2-

Re: [edk2-devel] [edk2-platforms][PATCH V5 2/2] WhiskeylakeOpenBoardPkg: Fix GCC Build Failures

Reviewed-by: Nate DeSimone -Original Message- From: Kubacki, Michael A Sent: Tuesday, August 27, 2019 9:17 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming Subject: [edk2-platforms][PATCH V5 2/2] WhiskeylakeOpenBoardPkg: Fix GCC Build Failures REF:ht

Re: [edk2-devel] [Patch][edk2-stable201908] BaseTools: Fixed regression issue for building !x86 builds

Hi Bob, I agree this is a critical regression issue that must be fixed for the edk2-stable201908 release. Tested-by: Michael D Kinney Acked-by: Michael D Kinney Thanks, Mike > -Original Message- > From: Gao, Liming > Sent: Wednesday, August 28, 2019 8:22 AM > To: Leif Lindholm ; > de

Re: [edk2-devel] [Patch][edk2-stable201908] BaseTools: fix an incremental build issue.

Liming, I can no longer reproduce the issues I noted below. I agree this is a critical regression issue that must be fixed for the edk2-stable201908 release. Tested-by: Michael D Kinney Acked-by: Michael D Kinney Thanks, Mike > -Original Message- > From: Kinney, Michael D > Sent: We

Re: [edk2-devel] [Patch][edk2-stable201908] BaseTools: fix an incremental build issue.

Liming, I set up a fresh environment and I now see the expected behavior when modifying INF files with this patch applied. I can not reproduce the issues I saw earlier today. I will continue to do some more testing before I provide a Tested-by. Mike -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: Yo

Re: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling.

Liming, Stephano and all stewards, My understanding is the requirement of embedding patch into the mail body is due to a limitation in old system (01.org). That system couldn't support mail attachments. With the existence of mail attachments capability in new groups.io system, can we accept suc

Re: [edk2-devel] [Patch][edk2-stable201908] BaseTools: fix an incremental build issue.

Liming, This fix does not look complete to me. I applied this patch and used FatPkg as a test. I modified FatPkg/EnhancedFatDxe/Fat.inf removing Defines, Source files, Library Classes, GUID, Protocols, and PCDs and it never rebuilds the module. If I remove the BASE_NAME define, I get a stack t

Re: [edk2-devel] [Patch][edk2-stable201908] BaseTools: fix an incremental build issue.

Mike: I add notes in BZ. Current problem is that the change in INF file will not trig rebuild. For example: 1st build: build -p MdeModulePkg\MdeModulePkg.dsc -a IA32 -m MdeModulePkg\Application\HelloWorld\HelloWorld.inf 2st build with below change update MdeModulePkg\Application\HelloWorld\H

Re: [edk2-devel] [Patch][edk2-stable201908] BaseTools: fix an incremental build issue.

Bob and Liming, What is an example test case that fails? Please add to BZ. We need this information to test that this fix resolves the issue. Mike > -Original Message- > From: Gao, Liming > Sent: Wednesday, August 28, 2019 8:26 AM > To: Feng, Bob C ; > devel@edk2.groups.io > Cc: Shi, S

Re: [edk2-devel] [Patch][edk2-stable201908] BaseTools: fix an incremental build issue.

Bob: This is the critical regression issue for the incremental build. I request to catch it in this stable tag 201908. This patch corrects the behavior. Reviewed-by: Liming Gao Thanks Liming > -Original Message- > From: Feng, Bob C > Sent: Wednesday, August 28, 2019 4:52 PM > To:

Re: [edk2-devel] [Patch][edk2-stable201908] BaseTools: Fixed regression issue for building !x86 builds

Bob: This fix is clear. Reviewed-by: Liming Gao Thanks Liming > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Wednesday, August 28, 2019 10:01 PM > To: devel@edk2.groups.io; Feng, Bob C > Cc: Gao, Liming > Subject: Re: [edk2-devel] [Patch][edk2-sta

Re: [edk2-devel] [Patch][edk2-stable201908] BaseTools: Fixed regression issue for building !x86 builds

On Wed, Aug 28, 2019 at 05:17:10PM +0800, Bob Feng wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2134 > > This patch is to fix a build tool regression issue which > was introduced by commit e8449e1d8e. > > In commit e8449e1d8e, build tool check the pcd before > filter out the irrele

Re: [edk2-devel] Cancelled Event: TianoCore Design / Bug Triage - EMEA - Wednesday, 28 August 2019 #cal-cancelled

No designs submitted and we have conflicting meetings this week. We will circle back with a Triage meeting next week, along with our community meetings. On Wed, Aug 28, 2019 at 6:37 AM devel@edk2.groups.io Calendar wrote: > > Cancelled: TianoCore Design / Bug Triage - EMEA > > This event has bee

[edk2-devel] Cancelled Event: TianoCore Design / Bug Triage - EMEA - Wednesday, 28 August 2019 #cal-cancelled

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCEL CALSCALE:GREGORIAN BEGIN:VEVENT STATUS:CANCELLED UID:calendar.15...@groups.io DTSTAMP:20190828T133703Z ORGANIZER;CN=Stephano Cetola:mailto:stephano.cet...@linux.intel.com DTSTART;TZID=America/Los_Angeles:20190

Re: [edk2-rfc] [edk2-devel] CPU hotplug using SMM with QEMU+OVMF

On Tue, 27 Aug 2019 22:11:15 +0200 Laszlo Ersek wrote: > On 08/27/19 18:23, Igor Mammedov wrote: > > On Mon, 26 Aug 2019 17:30:43 +0200 > > Laszlo Ersek wrote: > > > >> On 08/23/19 17:25, Kinney, Michael D wrote: > >>> Hi Jiewen, > >>> > >>> If a hot add CPU needs to run any code before the > >

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: fix !x86 builds (more)

On Wed, Aug 28, 2019 at 01:40:22AM +, Wu, Hao A wrote: > Per my understanding to the analysis from Leif, Laszlo and Mike, the patch > will depend on the precedence of the below rules: > > * [LibraryClasses.common.$(MODULE_TYPE)] > * [LibraryClasses.$(Arch)] > > So for now, we should wait for

Re: [edk2-devel] [edk2-staging/RISC-V PATCH v1 1/14]: BaseTools: Update EDK2 build tool for RISC-V platform

On Wed, 28 Aug 2019 08:43:10 + "Chang, Abner (HPS SW/FW Technologist)" wrote: > Thanks Jonathan, the cover letter and 3/14 patch were just sent. Great. So am I right in thinking these apply to: https://github.com/tianocore/edk2-staging/tree/RISC-V ? Any plans to rebase that tree as it seem

Re: [edk2-devel] [edk2-staging/RISC-V PATCH v1 1/14]: BaseTools: Update EDK2 build tool for RISC-V platform

Hi Abner, Just noticed in passing that this series doesn't seem to have a 3/14? Speaking personally it would be useful to have a cover letter with a quick summary of the series content. Thanks, Jonathan On Tue, 27 Aug 2019 14:00:19 +0800 Abner Chang wrote: > Elf64Convert.c > - Relocation pro

[edk2-devel] [Patch][edk2-stable201908] BaseTools: Fixed regression issue for building !x86 builds

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2134 This patch is to fix a build tool regression issue which was introduced by commit e8449e1d8e. In commit e8449e1d8e, build tool check the pcd before filter out the irrelevant library instance. The logic of evaluating the priority of the libr

Re: [edk2-devel] [edk2-staging/RISC-V PATCH v1 1/14]: BaseTools: Update EDK2 build tool for RISC-V platform

> -Original Message- > From: Jonathan Cameron [mailto:jonathan.came...@huawei.com] > Sent: Wednesday, August 28, 2019 5:00 PM > To: Chang, Abner (HPS SW/FW Technologist) > Cc: devel@edk2.groups.io > Subject: Re: [edk2-devel] [edk2-staging/RISC-V PATCH v1 1/14]: BaseTools: > Update EDK2 bui

[edk2-devel] [Patch][edk2-stable201908] BaseTools: fix an incremental build issue.

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2137 This patch is going to fix a regression issue of incremental build which was introduced by the commit 94459080c. The changing on INF file will not trigger module rebuild. Signed-off-by: Bob Feng Cc: Liming Gao Cc: Steven Shi --- BaseTool

Re: [edk2-devel] [edk2-staging/RISC-V PATCH v1 1/14]: BaseTools: Update EDK2 build tool for RISC-V platform

Thanks Jonathan, the cover letter and 3/14 patch were just sent. Abner > -Original Message- > From: Jonathan Cameron [mailto:jonathan.came...@huawei.com] > Sent: Wednesday, August 28, 2019 4:18 PM > To: Chang, Abner (HPS SW/FW Technologist) > Cc: devel@edk2.groups.io > Subject: Re: [edk2

[edk2-devel] [edk2-staging/RISC-V PATCH v1 0/14]: Update RiscVPkg

The main changes of these series of patches are, - Update RiscVPkg to conform with RISC-V Privilege Spec v1.10. - Incorporate and leverage RISC-V OpenSBI to provide EDK2 port OpenSBI library. - Abstract RISC-V platform implementation-specific drivers to EDK2 RISC-V platform package. - Remove sta

[edk2-devel] [edk2-staging/RISC-V PATCH v1 3/14]: MdePkg/BaseLib: Revise BaseLib for RISC-V RV64 Processor.

Define and use macros to manipulate RISC-V CSR. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Abner Chang --- MdePkg/Library/BaseLib/RiscV64/DisableInterrupts.c | 7 +- MdePkg/Library/BaseLib/RiscV64/EnableInterrupts.c | 6 +- MdePkg/Library/BaseLib/RiscV64/GetInter

Re: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling.

OK. So, you can't use git send-email to send this patch. Another way is to fork edk2 and create the branch to include this change. Then, send the mail to let people review this patch in your branch. And, for this patch, can you submit BZ https://bugzilla.tianocore.org/ first? Then, update its com