Reviewed-by: Michael D Kinney
> -Original Message-
> From: Sun, Zailiang
> Sent: Friday, August 2, 2019 7:55 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ;
> Gao, Liming ; Qian, Yi
>
> Subject: [PATCH V2 edk2-platforms] Maintainers.txt:
> Update maintainers for Vlv2*Pkgs
>
> I
In V2: V2 is the same as V1.
Qian Yi would not work as a maintainer for Vlv2TbltDevicePkg and
Vlv2DeviceRefCodePkg any more. Added Michael Kinney instead.
cc: Michael D Kinney
Cc: Liming Gao
Cc: Yi Qian
Signed-off-by: Zailiang Sun
---
Maintainers.txt | 4 ++--
1 file changed, 2 insertions(+)
Thanks and agree.
Comment inlined.
thank you!
Yao, Jiewen
> 在 2019年8月3日,上午6:06,Laszlo Ersek 写道:
>
>> On 08/02/19 04:46, Yao, Jiewen wrote:
>> Thanks Laszlo. Comment below:
>>
>>> -Original Message-
>>> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>>> Laszlo
On 08/01/19 21:16, Roman Kagan wrote:
> I'm trying to come up with a solution to the problem that OpenSSL
> internally uses static variables ("per-thread" in no-threads config) to
> store pointers, which remain unadjusted upon SetVirtualAddressMap and
> cause the guest OS crash.
>
> More specifica
Use BaseLib MultuU64x64() to prevent intrinsics being added on IA32 builds.
Add acpiview to a version of the Shell that is build with ShellPkg.dsc to catch
this type of issue in ShellPkg builds.
Cc: Jaben Carsey
Cc: Ray Ni
Cc: Zhichao Gao
Cc: Sami Mujawar
Signed-off-by: Michael D Kinney
Mich
https://bugzilla.tianocore.org/show_bug.cgi?id=1970
Update ShellPkg DSC file to build an extra version of
the Shell with all commands integrated. This verifies
that the shell can build in this max configuration.
Cc: Jaben Carsey
Cc: Ray Ni
Cc: Zhichao Gao
Cc: Sami Mujawar
Signed-off-by: Mich
https://bugzilla.tianocore.org/show_bug.cgi?id=1970
Update SLIT_ELEMENT() macro to use MultU64x64() to
perform multiplication on 64-bit operands. This is
required to avoid use of an intrinsic on IA32 VS20xx
builds.
Cc: Jaben Carsey
Cc: Ray Ni
Cc: Zhichao Gao
Cc: Sami Mujawar
Signed-off-by: M
On 08/02/19 20:29, Jordan Justen wrote:
> First, I hope we don't add lots of large .pdf files into the source
> tree. I see two duplicated > 200k .pdf files in edk2, which seems like
> a waste of space in the edk2 tree.
>
> BaseTools/Source/C/BrotliCompress/docs/brotli-comparison-study-2015-09-22.p
Roman,
Sorry for the top post, as my email client seems to have eating your email.
1) In C static scopes the visibility of the symbol from a compiler linker point
of view, but the static and non-static globals are going to be stored in the
same section of the image. On macOS clang the only diff
On 08/02/19 04:46, Yao, Jiewen wrote:
> Thanks Laszlo. Comment below:
>
>> -Original Message-
>> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>> Laszlo Ersek
>> Sent: Friday, August 2, 2019 10:05 AM
>> To: Yao, Jiewen ; devel@edk2.groups.io
>> Cc: Ni, Ray ; Dong, E
On 08/01/19 23:14, Andrew Fish wrote:
> The MpServices API and even the BSP don't apply at runtime, but then
> again you can't run code on the APs at runtime.
My understanding is that the OS can invoke a runtime service on any
processor. Plus, the UEFI spec classifies runtime services into groups
On 2019-08-02 03:55, Leif Lindholm wrote:
> One change I would like to see enacted *immediately* is that *any*
> imports from other open source projects state the repository and the
> commit hash that it originated from. In the commit message - and where
> BZs are referenced in the message, also co
I think we can push this in now.
Zhichao,
Do you agree? If yes, can you prep this for merging?
Thanks
-Jaben
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Jonathan Watt
> Sent: Friday, August 02, 2019 1:28 PM
> To: devel@edk2.groups.io
> C
Zhichao,
I did not modify the build of the standard Shell. It
does not include the acpiview.
The patch builds a 2nd version of the shell with a different
FILE_GUID for build testing purposes. I think it is very
important for the ShellPkg to have build tests for all the
content in the ShellPkg t
It's been three months now since I contributed the patch. Could someone update
me on the progress on getting it landed?
On 11/06/2019 22:53, Jonathan Watt wrote:
> Since I haven't contributed before I'm not sure what the timeline for these
> things generally is. It's been a month though. Can the p
Jordan,
I agree we should not adding PDFs or other binary files
to the edk2 or edk2-platforms repos.
The PDF was just an example, and it looks like git has some
auto conversion behavior in the show command and that could
impact binary file types other than pdf. This patch only
removes the false
On 2019-08-01 17:13:11, Michael D Kinney wrote:
> https://bugzilla.tianocore.org/show_bug.cgi?id=2044
>
> * Add '--no-textconv' to 'git show' command to disable binary->text
> conversion.
> * Ignore blank lines in patch
> * Ignore lines with 'copy from ' and 'copy to ' prefixes
>
> Cc: Bob Feng
First, I hope we don't add lots of large .pdf files into the source
tree. I see two duplicated > 200k .pdf files in edk2, which seems like
a waste of space in the edk2 tree.
BaseTools/Source/C/BrotliCompress/docs/brotli-comparison-study-2015-09-22.pdf
MdeModulePkg/Library/BrotliCustomDecompressLib
Hi Mike, All,
I agree it will be good to add acpiview to the standard ShellPkg build.
Regards,
Sami Mujawar
-Original Message-
From: Carsey, Jaben
Sent: 01 August 2019 09:46 PM
To: Kinney, Michael D ; Sami Mujawar
; devel@edk2.groups.io
Cc: Ni, Ray ; Gao, Zhichao
Subject: RE: [edk2-d
I thought with this change the DSC would build 2 images. The second image would
have the acpiview command and you could ignore that image for your purpose.
-Jaben
> -Original Message-
> From: Gao, Zhichao
> Sent: Thursday, August 1, 2019 10:36 PM
> To: devel@edk2.groups.io; Kinney, Micha
Reviewed-by: Ray Ni
> -Original Message-
> From: Zhang, Shenglei
> Sent: Friday, August 2, 2019 2:55 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Wu, Hao A ; Ni,
> Ray ; Zeng, Star
> ; Shenglei
> Subject: [PATCH 2/2] MdeModulePkg: Remove RecoveryLib.h and PeiRecoveryLibNull
>
> Re
Reviewed-by: Ray Ni
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Zhang, Shenglei
> Sent: Friday, August 2, 2019 2:55 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Wu, Hao A ; Ni,
> Ray ; Zeng, Star
>
> Subject: [edk2-devel] [PATCH 1/2] MdeModulePkg: Remove S3Lib.
Zhichao,
Yes. I think that idea could work as well. I will try it out.
Mike
> -Original Message-
> From: Gao, Zhichao
> Sent: Thursday, August 1, 2019 10:28 PM
> To: devel@edk2.groups.io; Kinney, Michael D
>
> Cc: Carsey, Jaben ; Ni, Ray
> ; Sami Mujawar
> Subject: RE: [edk2-devel] [
On 8/2/19 11:55 AM, Leif Lindholm wrote:
> So, I'm not going to give any of the reviewers a hard time about this
> - the patch *looks* right and we've all occasionally given R-b on
> things we haven't actually tested because we don't always have the
> time. And by the time I hit it, it had already
So, I'm not going to give any of the reviewers a hard time about this
- the patch *looks* right and we've all occasionally given R-b on
things we haven't actually tested because we don't always have the
time. And by the time I hit it, it had already been fixed upstream.
But what worries me is that
Qian Yi would not work as a maintainer for Vlv2TbltDevicePkg and
Vlv2DeviceRefCodePkg any more. Added Michael Kinney instead.
Cc: Liming Gao
Cc: Yi Qian
Signed-off-by: Zailiang Sun
---
Maintainers.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Maintainers.txt b/Mai
Reviewed-by: Eric Dong
> -Original Message-
> From: Zhang, Shenglei
> Sent: Wednesday, July 31, 2019 11:38 AM
> To: devel@edk2.groups.io
> Cc: Zhang, Shenglei ; Dong, Eric
> ; Ni, Ray ; Laszlo Ersek
>
> Subject: [PATCH v2 1/1] UefiCpuPkg/PiSmmCpuDxeSmm: Make code
> consistent with commen
For the patch set,
Reviewed-by: Bob Feng
-Original Message-
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Michael D
Kinney
Sent: Friday, August 2, 2019 8:13 AM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming ;
Justen, Jordan L
Subject: [edk2-devel] [Patch
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2047
Build raise exception if there is libraryclass
missing in dsc file and --pcd build option is used.
Build should report the missing libraryclass but not
a call stack.
This patch is going to fix it.
Cc: Liming Gao
Signed-off-by: Bob Feng
-
Hi Hao,
pt., 2 sie 2019 o 03:04 Wu, Hao A napisał(a):
> > -Original Message-
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Ni,
> > Ray
> > Sent: Thursday, August 01, 2019 12:51 AM
> > To: devel@edk2.groups.io; m...@semihalf.com
> > Cc: leif.lindh...@linaro.o
30 matches
Mail list logo