Hi Supreeth,
I have already pushed this series of patches into repo since we don't want to
leave the build issue to next week.
I also sent a patch to remove source and header files required for building Ipf
library from sctlib.inf file. Please help to review and push if it is good to
you. Thank
Remove source and header files required for building Ipf library from
inf file as edk2 (edk2-stable201905) has removed IPF support.
Cc: Supreeth Venkatesh
Signed-off-by: Eric Jin
---
uefi-sct/SctPkg/Library/SctLib/SctLib.inf | 9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff --
Hello Ravi Kumar,
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ravi
Kumar Siadri
Sent: Thursday, June 13, 2019 4:18 PM
To: Wu, Hao A
Cc: devel@edk2.groups.io
Subject: Re: [edk2-devel] ExtScsiPassThru support for Logical SCSI devices
Hi Wu Hao A,
Thanks for the response.
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Laszlo Ersek
> Sent: Thursday, June 13, 2019 10:42 PM
> To: devel@edk2.groups.io; Wu, Hao A
> Cc: Ni, Ray; Justen, Jordan L; Ard Biesheuvel
> Subject: Re: [edk2-devel] [PATCH v1 2/6] OvmfPkg/OvmfP
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1843
This commit will drop the driver's dependency on the IntelFrameworkPkg:
gEfiLegacyBiosProtocolGuid
Such dependency has already been addressed by the duplication of the above
definition from IntelFrameworkPkg into the OvmfPkg.
Cc: Ray Ni
Cc
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1843
Currently, the file GUID reference of the UEFI Shell app is indirected
via the PCD gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile,
which is set to a fixed value for OvmfPkg.
So instead, use the symbolic GUID in ShellPkg for this purp
The series is also available at:
https://github.com/hwu25/edk2/tree/ovmf_drop_framework_v3
V3 changes:
* Abandon the changes made in V2. Since the duplication of required CSM
modules by OvmfPkg is done (rather than drop the CSM support on OVMF).
* Use the symbolic GUID already defined in ShellP
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1843
For the driver's INF file, this commit will remove the redundant reference
to 'IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec'.
Cc: Ray Ni
Cc: Jordan Justen
Cc: Ard Biesheuvel
Signed-off-by: Hao A Wu
Reviewed-by: Laszlo Ersek
---
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1843
This commit will update the INF file of the CsmSupportLib to drop its
dependency on IntelFrameworkPkg:
gEfiLegacyBiosPlatformProtocolGuid
gEfiLegacyBiosProtocolGuid
gEfiLegacyInterruptProtocolGuid
The above dependencies have already been ad
Forgot to mention test:
1. Unit test and security test based on HBFA test framework
2. System test on three real platforms
Regards,
Jian
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Wang,
> Jian J
> Sent: Friday, June 14, 2019 8:30 AM
> To:
Thanks all.
Series pushed via commits 0a35997643..b0663641c9.
Best Regards,
Hao Wu
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> David Woodhouse
> Sent: Thursday, June 13, 2019 5:40 AM
> To: Wu, Hao A; devel@edk2.groups.io
> Cc: Ni, Ray; Ju
> -Original Message-
> From: Albecki, Mateusz
> Sent: Thursday, June 13, 2019 10:39 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A
> Subject: RE: [PATCH 2/2] MdeModulePkg/SdMmcHcDxe: Implement revision
> 3 of SdMmcOverrideProtocol
>
> Resending to group. Inline reply to some of the comments
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1855
UniTool is one python script to generate UQI (Universal Question
Identifier) unicode string for HII question PROMPT string. UQI
string can be used to identify each HII question.
The scripts function will sync up UQI definitions with uni files
Loop in Ard and Marcin.
Hello Ard and Marcin,
We are proposing to make an extension to the SDMMC Override protocol to
more customization for platforms during the SD/eMMC device/controller
initialization process.
For convenience, the series is available at:
https://github.com/hwu25/edk2/tree/sdm
*Reminder:* TianoCore Design Meeting - APAC/NAMO
*When:* Thursday, 13 June 2019, 6:30pm to 7:30pm, (GMT-07:00) America/Los
Angeles
*Where:* https://zoom.us/j/969264410
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=458028 )
*Organizer:* Stephano Cetola stephano.cet...@intel.com
Yes, ok for me.
Good idea to add the overview of the package content.
Thank you
Yao Jiewen
From: Oram, Isaac W
Sent: Friday, June 14, 2019 8:55 AM
To: Gao, Liming ; Yao, Jiewen ;
Dong, Eric ; devel@edk2.groups.io; Kinney, Michael D
Subject: RE: [RFC][edk2-platform][Add new packages in Platform
This looks good to me. I would suggest that we also capture an overview of the
organization and the targeted contents of the different packages in the
Platform/Intel/Readme.md or maybe a wiki page.
Thanks,
Isaac
From: Gao, Liming
Sent: Wednesday, June 12, 2019 6:27 AM
To: Oram, Isaac W ; Yao,
Jiewen,
> -Original Message-
> From: Yao, Jiewen
> Sent: Wednesday, June 12, 2019 12:49 PM
> To: Wang, Jian J ; devel@edk2.groups.io
> Cc: Zhang, Chao B ; Hernandez Beltran, Jorge
> ; Han, Harry
> Subject: RE: [PATCH v2 0/3] Common OBB verification feature
>
> Thanks Jian. Some comment b
Thanks for the reply.
I understand now that this is not a very proper change.
I will talk to the bug reporter in Bugzilla to see if we can keep the current
status.
Best Regards,
Zhiguang Liu
>-Original Message-
>From: Justen, Jordan L
>Sent: Thursday, June 13, 2019 3:47 PM
>To: Liu, Zh
> -Original Message-
> From: Yao, Jiewen
> Sent: Friday, June 14, 2019 6:32 AM
> To: Zurcher, Christopher J; Gao, Liming; devel@edk2.groups.io
> Cc: Kinney, Michael D; Wang, Jian J; Ni, Ray; Wu, Hao A
> Subject: RE: [PATCH v4 0/2] Add SCSI Support for Storage Security Command
> Protocol
>
*Reminder:* TianoCore Bug Triage - APAC / NAMO
*When:* Thursday, 13 June 2019, 5:00pm to 5:30pm, (GMT-07:00) America/Los
Angeles
*Where:* https://zoom.us/j/769108409
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=458031 )
*Organizer:* Stephano Cetola stephano.cet...@intel.com (
On 2019-06-13 17:32, Rebecca Cran wrote:
> This fixes the build on FreeBSD, where DSO_METHOD_openssl is undefined
> since dso_openssl.c only compiles the function if DSO_NONE is defined.
Sorry, I just realized this isn't applicable to the OpenSSL we currently
pull in: I was testing against OpenSSL
This fixes the build on FreeBSD, where DSO_METHOD_openssl is undefined
since dso_openssl.c only compiles the function if DSO_NONE is defined.
Signed-off-by: Rebecca Cran
---
CryptoPkg/Library/OpensslLib/OpensslLib.inf | 2 +-
CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf | 2 +-
2 file
Thank you Christopher.
Your code looks good to me.
I also recommend MdeModulePkg/SCSI owner take a look and give r-b.
Ray or Hao
Can you help on that?
Thank you
Yao Jiewen
> -Original Message-
> From: Zurcher, Christopher J
> Sent: Friday, June 14, 2019 6:26 AM
> To: Gao, Liming ; devel
A unit test has been run which provisions RPMB key, writes data, and verifies
it after reading on the following boot.
Further, this code is being exercised for secure storage on multiple platforms
as part of standard boot flow.
Unit test files emailed separately.
Thanks,
Christopher Zurcher
-
> Why remove ASCIT8_1 & ASCIT8_2? Can we keep them for compatibility?
If that's preferred, I can add them back in. They were only removed as they are
marked obsolete in SPC-5.
--
Christopher Zurcher
-Original Message-
From: Gao, Liming
Sent: Thursday, June 13, 2019 05:54
To: Zurcher, C
Felix:
Sorry for the late response.
> -Original Message-
> From: Felix Polyudov [mailto:fel...@ami.com]
> Sent: Friday, May 24, 2019 8:53 PM
> To: devel@edk2.groups.io; Gao, Zhichao
> Cc: Wang, Jian J ; Wu, Hao A ; Ni,
> Ray ; Zeng, Star
> ; Gao, Liming ; Sean Brogan
> ; Michael Turn
On 6/13/19 6:18 PM, Leif Lindholm wrote:
> TimeBaseLib EfiTimeToEpoch returns a UINTN, meaning its behaviour differs
> between architectures. This upsets VS2017 when building for 32-bit ARM
> (and likely would if building for IA32 too). Similarly, some internal
> calculations used UINTN for operati
On Thu, 13 Jun 2019 at 18:18, Leif Lindholm wrote:
>
> TimeBaseLib EfiTimeToEpoch returns a UINTN, meaning its behaviour differs
> between architectures. This upsets VS2017 when building for 32-bit ARM
> (and likely would if building for IA32 too). Similarly, some internal
> calculations used UINT
EfiTimeToEpoch currently returns a UINTN.
Also, some internal calculations was using UINTN for fixed-width.
Both of these lead to warnings/errors with VS2017.
Replace with appropriate fixed-size types.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=997
Cc: Alexei Fedorov
Signed-off-by: Leif
TimeBaseLib EfiTimeToEpoch returns a UINTN, meaning its behaviour differs
between architectures. This upsets VS2017 when building for 32-bit ARM
(and likely would if building for IA32 too). Similarly, some internal
calculations used UINTN for operating on fixed-size fields, giving
further issues.
The comments describes the device as being 32-bit:
"the maximum time span is just over 136 years"
then uses a UINTN to hold the value.
Change to UINT32 so we don't get different behaviour for different
architectures.
Signed-off-by: Leif Lindholm
---
ArmPlatformPkg/Library/PL031RealTimeClockLib
Hi, Laszlo
Thank you for the reminder. Reviewed patch #4 just now.
Regards,
Maurice
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Thursday, June 13, 2019 8:32
> To: Ard Biesheuvel ; Leif Lindholm
> ; Ma, Maurice ; Dong,
> Guo ; You, Benjamin
> Cc: Wang, J
Reviewed-by: Maurice Ma
Regards,
Maurice
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Anthony PERARD
> Sent: Thursday, June 6, 2019 6:15
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Julien Grall ; Ard
> Biesheuvel ; Leif Lindholm
> ; Laszlo
On 06/13/19 17:32, Laszlo Ersek wrote:
> On 06/06/19 15:14, Anthony PERARD wrote:
>> The macro SERIAL_DXE_FILE_GUID is been defined twice and the GUID is been
>> used
>> once without defining the macro. This patch series define a macro in
>> MdeModulePkg where the SerialDxe is, and replace all oth
On 06/06/19 15:14, Anthony PERARD wrote:
> The macro SERIAL_DXE_FILE_GUID is been defined twice and the GUID is been used
> once without defining the macro. This patch series define a macro in
> MdeModulePkg where the SerialDxe is, and replace all other use by this new
> one,
> EDKII_SERIAL_PORT_L
On 05/27/19 08:48, Wu, Hao A wrote:
> '''
> Please note that this series will be hold until all the below requirements
> are met:
>
> A. edk2-stable201905 is created;
> B. OvmfPkg has been updated to drop its dependency on
>IntelFramework[Module]Pkg; (Patches already been sent)
> C. Platforms
Hello Hao,
On 05/27/19 08:36, Wu, Hao A wrote:
> '''
> Please note that this patch will be hold until all the below requirements
> are met:
>
> A. edk2-stable201905 is created;
> B. OvmfPkg has drop its usage of the legacy ISA stack (which includes
>the IsaAcpiDxe driver);
> C. UefiPayloadPkg
On 05/27/19 07:19, Wu, Hao A wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1843
>
> This commit will update the INF file of the CsmSupportLib to drop its
> dependency on IntelFrameworkPkg:
>
> gEfiLegacyBiosPlatformProtocolGuid
> gEfiLegacyBiosProtocolGuid
> gEfiLegacyInterruptProto
On 05/27/19 07:19, Wu, Hao A wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1843
>
> This commit will drop the driver's dependency on the IntelFrameworkPkg:
> gEfiLegacyBiosProtocolGuid
>
> Such dependency has already been addressed by the duplication of the above
> definition from I
Hi Hao,
On 05/27/19 07:19, Wu, Hao A wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1843
>
> OVMF is currently using the PCD 'PcdShellFile' defined in
> IntelFrameworkModulePkg.
>
> This commit will add this PCD into the OVMF DEC file in order to drop
> OVMF's dependency on IntelFra
Resending to group. Inline reply to some of the comments.
As for the mapping between eMMC driver strength and SD controller driver
strength should we use this one:
SD controller -> eMMC card
B-> Type 0
A -> Type 1
C -> Type 2
D
On 05/27/19 07:19, Wu, Hao A wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1843
>
> For the driver's INF file, this commit will remove the redundant reference
> to 'IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec'.
>
> Cc: Ray Ni
> Cc: Jordan Justen
> Cc: Laszlo Ersek
> Cc: A
On 06/13/19 10:40, David Woodhouse wrote:
> The DX register is supposed to contain the required alignment for the
> allocation. It was zero, and SeaBIOS doesn't (well, didn't) cope well
> with that. Set it appropriately.
>
> Also set BX to indicate the regions it's OK to allocate in too. That
> wa
On 05/27/19 05:03, Wu, Hao A wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1811
>
> This commit updates the OVMF DSC/FDF files to consume the copied CSM
> components within OvmfPkg.
>
> Cc: David Woodhouse
> Cc: Ray Ni
> Cc: Jordan Justen
> Cc: Laszlo Ersek
> Cc: Ard Biesheuvel
On 05/27/19 05:03, Wu, Hao A wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1811
>
> This commit will update the library's INF file to:
>
> A) Assign a new file GUID;
> B) Remove the IntelFramework[Module]Pkg DEC file dependency.
>
> Please note that a subsequent commit (final patch
On 05/27/19 05:03, Wu, Hao A wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1811
>
> This commit will update the library's INF file to:
>
> A) Assign a new file GUID;
> B) Remove the IntelFramework[Module]Pkg DEC file dependency.
>
> Please note that a subsequent commit (final patch
On 05/27/19 05:03, Wu, Hao A wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1811
>
> This commit will update the driver's INF file to:
>
> A) Assign a new file GUID;
> B) Consume the PCDs duplicated in OvmfPkg DEC file;
> C) Remove the IntelFramework[Module]Pkg DEC file dependency.
>
On 05/27/19 05:03, Wu, Hao A wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1811
>
> This commit will update the driver's INF file to:
>
> A) Assign a new file GUID;
> B) Consume the PCDs duplicated in OvmfPkg DEC file;
> C) Remove the IntelFramework[Module]Pkg DEC file dependency.
>
On 05/27/19 05:03, Wu, Hao A wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1811
>
> This commit will add the PCD definitions consumed by the duplicated
> drivers:
>
> * VideoDxe
> * LegacyBiosDxe
>
> into the OvmfPkg DEC file.
>
> Please note that, instead of adding these PCDs und
Resending to group.
> -Original Message-
> From: Wu, Hao A
> Sent: Monday, June 10, 2019 5:19 AM
> To: Albecki, Mateusz
> Subject: RE: [PATCH 1/2] MdeModulePkg/SdMmcOverride: Add
> GetOperatingParam notify phase
>
> Thanks Mateusz,
>
> Please refer to the comments in patch 2/2 for the r
On 05/27/19 05:03, Wu, Hao A wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1811
>
> The previous file-duplication commit has put all the CSM related header
> files within folder: OvmfPkg/Csm/Inclue.
>
> This commit will update the DEC file to add that folder under the
> '[Include]'
On 05/27/19 05:03, Wu, Hao A wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1811
>
> This commit will add the Guid definitions of the duplicated CSM-related
> Guids and Protocols from IntelFramework[Module]Pkg.
>
> Cc: David Woodhouse
> Cc: Ray Ni
> Cc: Jordan Justen
> Cc: Laszlo
Resending to group.
From: Wu, Hao A
Sent: Monday, June 10, 2019 5:18 AM
To: Albecki, Mateusz
Subject: RE: [PATCH 0/2] Add GetOperatingParam notify phase to SdMmcOverride
protocol
Hello Mateusz,
Thanks for the patch series and sorry for the delayed response.
One question first, I did not
On 05/27/19 05:03, Wu, Hao A wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1811
>
> This commit copies the exact:
>
> Drivers:
> * VideoDxe
> * LegacyBiosDxe
>
> Libraries:
> * LegacyBootMaintUiLib
> * LegacyBootManagerLib
>
> Guid header files:
> * Legacy Bios Guid
> * LegacyDevO
On 05/27/19 05:03, Wu, Hao A wrote:
> According to the discussion at:
>
> https://edk2.groups.io/g/devel/topic/31627718#40659
> (Request by Laszlo to find proper maintainer for to-be-duplicated CSM
> components in OvmfPkg.)
>
> and:
>
> https://edk2.groups.io/g/devel/topic/31682287#40996
> (Conf
Zurcher:
Can you share what test has been done for this feature?
Thanks
Liming
> -Original Message-
> From: Zurcher, Christopher J
> Sent: Thursday, June 13, 2019 10:05 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Yao, Jiewen
> ; Wang, Jian J ; Gao,
> Liming
> Subject: [PATC
> -Original Message-
> From: Zurcher, Christopher J
> Sent: Thursday, June 13, 2019 10:05 AM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen ; Wang, Jian J ;
> Gao, Liming
> Subject: [PATCH v4 1/2] MdePkg: Implement SCSI commands for Security Protocol
> In/Out
>
> This patch implements t
On 06/13/19 10:34, David Woodhouse wrote:
> On Thu, 2019-06-13 at 06:28 +, Wu, Hao A wrote:
>> Hello Ray,
>>
>> Do you have comment on this?
>>
>> Some inline comments below:
>>
>>> -Original Message-
>>> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>>> David Wo
Reviewed-by: Liming Gao
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Krzysztof Koch
> Sent: Wednesday, June 12, 2019 10:11 PM
> To: devel@edk2.groups.io
> Cc: Carsey, Jaben ; Ni, Ray ; Gao,
> Zhichao ; Kinney, Michael D
> ; Gao, Liming ;
Reviewed-by: Alexei Fedorov
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#42358): https://edk2.groups.io/g/devel/message/42358
Mute This Topic: https://groups.io/mt/32042587/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: htt
Reviewed-by: Alexei Fedorov
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#42357): https://edk2.groups.io/g/devel/message/42357
Mute This Topic: https://groups.io/mt/32042460/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: htt
On Thu, Jun 13, 2019 at 01:42:29PM +0200, Ard Biesheuvel wrote:
> On Thu, 13 Jun 2019 at 13:41, Leif Lindholm wrote:
> >
> > The migration of OptionRomPkg to edk2-platforms broke the HiKey build.
> > Update the paths in .dsc/.fdf to restore.
> >
> > Signed-off-by: Leif Lindholm
>
> Acked-by: Ard
Reviewed-by: Alexei Fedorov
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#42355): https://edk2.groups.io/g/devel/message/42355
Mute This Topic: https://groups.io/mt/32043797/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: htt
On Thu, 13 Jun 2019 at 13:41, Leif Lindholm wrote:
>
> The migration of OptionRomPkg to edk2-platforms broke the HiKey build.
> Update the paths in .dsc/.fdf to restore.
>
> Signed-off-by: Leif Lindholm
Acked-by: Ard Biesheuvel
> ---
> Platform/Hisilicon/HiKey/HiKey.dsc | 2 +-
> Platform/His
The migration of OptionRomPkg to edk2-platforms broke the HiKey build.
Update the paths in .dsc/.fdf to restore.
Signed-off-by: Leif Lindholm
---
Platform/Hisilicon/HiKey/HiKey.dsc | 2 +-
Platform/Hisilicon/HiKey/HiKey.fdf | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/P
On 06/13/19 08:58, Wu, Hao A wrote:
>> -Original Message-
>> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>> Wu, Hao A
>> Sent: Monday, May 27, 2019 10:15 AM
>> To: Gao, Zhichao; devel@edk2.groups.io
>> Cc: Wang, Jian J; Ni, Ray; Zeng, Star; Gao, Liming; Sean Brogan
Reviewed-by: Bob Feng
-Original Message-
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Chiu,
Chasel
Sent: Thursday, June 13, 2019 4:32 PM
To: devel@edk2.groups.io
Cc: Kubacki, Michael A ; Desimone, Nathaniel L
; Gao, Liming ; Feng, Bob
C
Subject: [edk2-devel]
The DX register is supposed to contain the required alignment for the
allocation. It was zero, and SeaBIOS doesn't (well, didn't) cope well
with that. Set it appropriately.
Also set BX to indicate the regions it's OK to allocate in too. That
wasn't being initialised and was just using whatever the
On Thu, 2019-06-13 at 06:28 +, Wu, Hao A wrote:
> Hello Ray,
>
> Do you have comment on this?
>
> Some inline comments below:
>
> > -Original Message-
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > David Woodhouse
> > Sent: Thursday, June 13, 2019 5:43
Thanks Bob! I was not aware that BaseTools already handled this.
I just verified and it works so I will update code review which will only touch
build.cfg.
Thanks!
Chasel
> -Original Message-
> From: Feng, Bob C
> Sent: Thursday, June 13, 2019 3:39 PM
> To: devel@edk2.groups.io; Chiu,
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1913
To improve build performance by default the maximum
processors should be used for building.
NUMBER_OF_PROCESSORS in build.cfg is set to 0 so
BaseTools can utilize maximum processors for build.
Test: tried NUMBER_OF_PROCESSORS 0 and 1 cases
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1913
To improve build performance by default the maximum
processors should be used for building.
NUMBER_OF_PROCESSORS in build.cfg is set to 0 so
BaseTools can utilize maximum processors for build.
Test: tried NUMBER_OF_PROCESSORS 0 and 1 cases
> -Original Message-
> From: Gao, Zhichao
> Sent: Wednesday, June 12, 2019 10:40 AM
> To: devel@edk2.groups.io
> Cc: Bret Barkelew; Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Gao, Liming;
> Sean Brogan; Michael Turner
> Subject: [PATCH] MdeModulePkg: Add lacking instances for build only
Reviewed-by: Nate DeSimone
On 6/12/19, 11:17 PM, "Chiu, Chasel" wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1913
To improve build performance by default the maximum
processors should be used for building.
To support this, NUMBER_OF_PROCESSORS in build.cfg ha
Hi Wu Hao A,
Thanks for the response.
I have added my comments in line.
Thanks,
Ravi Kumar
On Wed, Jun 12, 2019 at 1:26 PM Wu, Hao A wrote:
> Hello Ravi Kumar,
>
>
>
> Inline comments below:
>
>
>
> *From:* devel@edk2.groups.io [mailto:devel@edk2.groups.io] *On Behalf Of *Ravi
> Kumar Siadr
Ashish,
Supreeth already sent out the patch yesterday, we will let you know if the
patches are committed to repo. Thanks.
Best Regards
Eric
From: Jin, Eric
Sent: Wednesday, June 12, 2019 5:19 PM
To: Ashish Singhal ; Supreeth Venkatesh
; devel@edk2.groups.io
Cc: Jin, Eric
Subject: RE: UEFI SC
Hello Supreeth,
The serial patch 1- 5 is good to me.
Could you add one patch to remove source and header files required for building
library from SctPkg/Library/SctLib/SctLib.inf ?
[sources.ipf]
Ipf/SctLibPlat.h
Ipf/initplat.c
Ipf/salpal.c
Ipf/libsalpal.h
Math.c
Best Regards
Eric
---
> -Original Message-
> From: Gao, Zhichao
> Sent: Wednesday, June 12, 2019 10:40 AM
> To: devel@edk2.groups.io
> Cc: Bret Barkelew; Wu, Hao A; Gao, Liming; Sean Brogan; Michael Turner; Leif
> Lindholm; Gao, Zhichao
> Subject: [PATCH] SourceLevelDebugPkg: Add lacking instances for build only
On Thu, 2019-06-13 at 00:40 -0700, Jordan Justen wrote:
> On 2019-06-12 23:28:12, Wu, Hao A wrote:
> >
> > > -Original Message-
> > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > > David Woodhouse
> > > Sent: Thursday, June 13, 2019 5:43 AM
> > >
> > > The DX
> -Original Message-
> From: Wu, Hao A
> Sent: Thursday, June 13, 2019 3:39 PM
> To: devel@edk2.groups.io; Gao, Zhichao
> Cc: Wang, Jian J ; Ni, Ray ; Zeng,
> Star ; Gao, Liming ; Sean
> Brogan ; Michael Turner
> ; Bret Barkelew
>
> Subject: RE: [edk2-devel] [PATCH V3 2/2] MdeModulePkg
> -Original Message-
> From: Gao, Zhichao
> Sent: Monday, June 10, 2019 1:21 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Gao, Liming; Sean Brogan;
> Michael Turner; Bret Barkelew; Leif Lindholm
> Subject: [PATCH v5 0/5] MdeModulePkg/CapsulePei: Optimize
On 2019-06-11 22:42:13, Liu, Zhiguang wrote:
> Thanks for the comments.
> I will change the commit message in the next version.
> But I don't think this is a issue worth making a major change.
> Given that the change is consistent with NT32, will you agree with this
> change?
Hmm. You are right t
On 2019-06-12 23:28:12, Wu, Hao A wrote:
>
> > -Original Message-
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > David Woodhouse
> > Sent: Thursday, June 13, 2019 5:43 AM
> >
> > The DX register is supposed to contain the required alignment for the
> > alloc
One comment below:
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Gao, Zhichao
> Sent: Tuesday, June 04, 2019 9:05 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Gao, Liming; Sean Brogan;
> Michael Turner; B
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Gao, Zhichao
> Sent: Tuesday, June 04, 2019 9:05 AM
> To: devel@edk2.groups.io
> Cc: Bret Barkelew; Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Gao, Liming;
> Sean Brogan; Michael Turner
> Subje
Hi Chasel,
Patch looks good.
For the process number, build.py does the same thing as this patch. If pass -n
0 to build.py, build.py will set the processor number to
multiprocessing.cpu_count()
Thanks,
Bob
-Original Message-
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On
> -Original Message-
> From: Wu, Hao A
> Sent: Thursday, June 13, 2019 2:28 PM
> To: devel@edk2.groups.io; dw...@infradead.org; Ni, Ray
>
> Cc: Justen, Jordan L ; Laszlo Ersek
> ; Ard Biesheuvel
> Subject: RE: [edk2-devel] [PATCH 11/10] OvmfPkg/Csm/LegacyBiosDxe:
> Correct Legacy16GetTabl
88 matches
Mail list logo
