Re: [edk2-devel] [Patch 0/3] Move network related components from MdeModulePkg to NetworkPkg

2019-05-27 Thread Ard Biesheuvel
On Tue, 28 May 2019 at 08:46, Ard Biesheuvel wrote: > > On Tue, 28 May 2019 at 04:58, Liming Gao wrote: > > > > Hi, all > > > >I just push this patch set 4542f8b8135f1f1ee5654e25139be9769e139ddd.. > > ec56fa27842835e69a2b89b602866c3d652315eb. > > > >If you find any break issue, please le

Re: [edk2-devel] [Patch 0/3] Move network related components from MdeModulePkg to NetworkPkg

2019-05-27 Thread Ard Biesheuvel
On Tue, 28 May 2019 at 04:58, Liming Gao wrote: > > Hi, all > >I just push this patch set 4542f8b8135f1f1ee5654e25139be9769e139ddd.. > ec56fa27842835e69a2b89b602866c3d652315eb. > >If you find any break issue, please let me know. > DeveloperBox.dsc in edk2-platforms no longer builds: /ho

Re: [edk2-devel] [PATCH v2 0/7] update ArmSoftFloatLib to latest upstream version

2019-05-27 Thread Ard Biesheuvel
On Mon, 27 May 2019 at 22:51, Ard Biesheuvel wrote: > > Currently, our move to OpenSSL 1.1.1b is being blocked by an issue in > the ARM software floating point library, which lacks some intrinsics > that the ARM EABI spec defines. > > Since the code was in pretty sorry state, let's fix this by upg

[edk2-devel] [PATCH V4] BaseTools:Make BaseTools support new rules to generate RAW FFS FILE

2019-05-27 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1765 If RAW FFS File Rule has no section for its data.For RAW FFS File, directly call GenFfs tool to generate FFS file. Ffs Rule: [Rule.Common.USER_DEFINED.MicroCode] FILE RAW = $(NAMED_GUID) { $(INF_OUTPUT)/$(MODULE_NAME).bin } [Rule.

Re: [edk2-devel] [PATCH v2 6/7] BaseTools/tools_def CLANG3x ARM AARCH64: force use of C99 standard

2019-05-27 Thread Ard Biesheuvel
On Tue, 28 May 2019 at 02:17, Liming Gao wrote: > > Ard: > Is there any impact with new option? If no behavior change, I am OK for > this patch. Reviewed-by: Liming Gao > We don't rely on anything provided by the C11 standard, so it should not result in a behavior change. I do wonder whether

Re: [edk2-devel] [PATCH V2] UefiCpuPkg CpuCommFeaturesLib: Reduce to set MSR_IA32_CLOCK_MODULATION

2019-05-27 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Zeng, Star > Sent: Tuesday, May 21, 2019 6:36 PM > To: devel@edk2.groups.io > Cc: Zeng, Star ; Laszlo Ersek ; > Dong, Eric ; Ni, Ray ; Kumar, > Chandana C ; Li, Kevin Y > > Subject: [PATCH V2] UefiCpuPkg CpuCommFeaturesLib: Reduce to set

Re: [edk2-devel] [PATCH V3] BaseTools:Make BaseTools support new rules to generate RAW FFS FILE

2019-05-27 Thread Bob Feng
Zhiju, +def GetFileList(FfsInf, FileType, FileExtension, Dict = {}, IsMakefile=False, SectionType=None): For Dict = {}, {} as default value of a parameter is wrong, please update it as None. And inside this function, add If Dict is None: Dict = {} Others looks fine for me. Thanks, Bob -

Re: [edk2-devel] [Patch 0/3] Move network related components from MdeModulePkg to NetworkPkg

2019-05-27 Thread Liming Gao
Hi, all I just push this patch set 4542f8b8135f1f1ee5654e25139be9769e139ddd.. ec56fa27842835e69a2b89b602866c3d652315eb. If you find any break issue, please let me know. Thanks Liming >-Original Message- >From: Fu, Siyuan >Sent: Friday, May 17, 2019 8:46 AM >To: devel@edk2.groups.

[edk2-devel] [patch] ShellPkg/Debug1CommandsLib: Fix bugs in func DisplaySysEventLogData

2019-05-27 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1498 This patch fix following bugs in func DisplaySysEventLogData: 1. Log increment (Log = (LOG_RECORD_FORMAT *) (LogData + Offset);) should happened in the end of while loop, not in the very beginning. 2. DisplaySELTypes function should be used

Re: [edk2-devel] [PATCH] PciBusDxe: duplicate node insertion for every PPB device in the system

2019-05-27 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Javeed, Ashraf > Sent: Monday, May 27, 2019 6:24 PM > To: devel@edk2.groups.io > Cc: Javeed, Ashraf ; Wang, Jian J > ; Ni, Ray > Subject: [PATCH] PciBusDxe: duplicate node insertion for every PPB device in > the system > > https://bugzil

Re: [edk2-devel] [Patch] BaseTools/Capsule: Supports UEFI Capsule with multiple payloads and embedded drivers

2019-05-27 Thread Eric Jin
Liming, Yes. It is not for Q2 stable tag. Best Regards Eric -Original Message- From: Gao, Liming Sent: Monday, May 27, 2019 9:58 PM To: devel@edk2.groups.io; Jin, Eric Cc: Feng, Bob C ; Kinney, Michael D ; Kinney, Michael D Subject: RE: [edk2-devel] [Patch] BaseTools/Capsule: Support

[edk2-devel] [PATCH] BaseTools/GenBiosId: Add a new tool GenBiosId

2019-05-27 Thread Zhang, Shenglei
GenBiosId is a tool to generate the BIOS ID binary file which uses the data from the configuration file. https://bugzilla.tianocore.org/show_bug.cgi?id=1846 Signed-off-by: Shenglei Zhang --- BaseTools/Source/C/GenBiosId/GenBiosId.c | 627 +++ BaseTools/Source/C/GNUmakefile

Re: [edk2-devel][Patch] MdeModulePkg/CapsuleApp: Enhance Capsule-On-Disk related functions.

2019-05-27 Thread Wu, Hao A
> -Original Message- > From: Xu, Wei6 > Sent: Friday, May 24, 2019 5:02 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J; Wu, Hao A; Zhang, Chao B; Xu, Wei6 > Subject: [edk2-devel][Patch] MdeModulePkg/CapsuleApp: Enhance > Capsule-On-Disk related functions. > > BZ: https://bugzilla.tianoco

Re: [edk2-devel] [Patch 0/3] Add modules to BoardModulePkg.

2019-05-27 Thread Liming Gao
Besides, please submit BZ for the change. >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Liming Gao >Sent: Tuesday, May 28, 2019 8:39 AM >To: devel@edk2.groups.io; Dong, Eric >Subject: Re: [edk2-devel] [Patch 0/3] Add modules to BoardModulePkg

Re: [edk2-devel] [Patch 0/3] Add modules to BoardModulePkg.

2019-05-27 Thread Liming Gao
Eric: I have two comments. 1. Add BoardModulePkg.dsc to cover the build for new added modules. 2. Remove BIOS_ID_GUID macro definition in Guid/BiosId.h. There is no code to consume it. Thanks Liming >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Beh

Re: [edk2-devel][Patch] MdeModulePkg/CapsuleApp: Enhance Capsule-On-Disk related functions.

2019-05-27 Thread Zhang, Chao B
Reviewed-by: Chao Zhang -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Xu, Wei6 Sent: Friday, May 24, 2019 5:02 PM To: devel@edk2.groups.io Cc: Wang, Jian J ; Wu, Hao A ; Zhang, Chao B ; Xu, Wei6 Subject: [edk2-devel][Patch] MdeModulePkg/Capsule

Re: [edk2-devel] [PATCH v2 6/7] BaseTools/tools_def CLANG3x ARM AARCH64: force use of C99 standard

2019-05-27 Thread Liming Gao
Ard: Is there any impact with new option? If no behavior change, I am OK for this patch. Reviewed-by: Liming Gao Thanks Liming >-Original Message- >From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >Sent: Tuesday, May 28, 2019 4:52 AM >To: devel@edk2.groups.io >Cc: Ard Biesheuve

[edk2-devel] Adding HTTP and TLS support to Armada80x0McBin (from the MarvellEmbeddedProcessors edk2-open-platforms repo)

2019-05-27 Thread rebecca
I've been working with the MACCHIATObin board, and noticed settings for HTTP and TLS in Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc in the repo https://github.com/MarvellEmbeddedProcessors/edk2-open-platform.git . I'd like to enable them if possible to help with debugging a problem with a

[edk2-devel] [PATCH v2 7/7] ArmPkg/ArmLib ARM: set .fpu to let Clang 7 assemble ArmV7Support.S

2019-05-27 Thread Ard Biesheuvel
Clang 7 complains about the vmsr instruction in ArmV7Support.S, which is only available on cores that implement some flavour of VFP. So set the .fpu to NEON like we do in some other places. Signed-off-by: Ard Biesheuvel --- Note that the !clang alternative does not assembler for Clang-7 either so

[edk2-devel] [PATCH v2 5/7] ArmPkg/ArmSoftFloatLib: add SPDX identifiers

2019-05-27 Thread Ard Biesheuvel
Add the appropriate SPDX identifiers to all files taken from the 3-clause BSD licensed SoftFloat library. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1845 Acked-by: Jian J Wang Signed-off-by: Ard Biesheuvel --- ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/build/Linux-ARM-VFPv2-GCC/platf

[edk2-devel] [PATCH v2 3/7] ArmPkg/ArmSoftFloatLib: remove source files that are no longer used

2019-05-27 Thread Ard Biesheuvel
Now that we have switched to a new version of the SoftFloat code, remove the source files that make up the old implementation, and are no longer referenced. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1845 Build-tested-by: Laszlo Ersek Acked-by: Jian J Wang Tested-by: Xiaoyu Lu Signed-o

[edk2-devel] [PATCH v2 1/7] ArmPkg: import latest version (3e) of the Berkeley Softfloat library

2019-05-27 Thread Ard Biesheuvel
In preparation of bringing ArmSoftFloatLib up to date in order to provide some missing routines, import the unmodified SoftFloat-3e source into the tree. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1845 Build-tested-by: Laszlo Ersek Acked-by: Jian J Wang Tested-by: Xiaoyu Lu Signed-off-

[edk2-devel] [PATCH v2 4/7] ArmPkg/ArmSoftFloatLib: remove new source files that are not used

2019-05-27 Thread Ard Biesheuvel
Now that we have switched to a new version of the SoftFloat code, remove the source files that are not in fact used to implement the API that our library exposes. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1845 Acked-by: Jian J Wang Signed-off-by: Ard Biesheuvel --- ArmPkg/Library/ArmS

[edk2-devel] [PATCH v2 6/7] BaseTools/tools_def CLANG3x ARM AARCH64: force use of C99 standard

2019-05-27 Thread Ard Biesheuvel
When building OpenSSL for ARM or AARCH64 with recent Clang, the following error may result: In file included from .../CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyEku.c:18: In file included from .../CryptoPkg/Library/OpensslLib/openssl/crypto/include/internal/x509_int.h:10: In file in

[edk2-devel] [PATCH v2 0/7] update ArmSoftFloatLib to latest upstream version

2019-05-27 Thread Ard Biesheuvel
Currently, our move to OpenSSL 1.1.1b is being blocked by an issue in the ARM software floating point library, which lacks some intrinsics that the ARM EABI spec defines. Since the code was in pretty sorry state, let's fix this by upgrading to the very latest version of the core library this code

[edk2-devel] [PATCH v2 2/7] ArmPkg/ArmSoftFloatLib: switch to new version of softfloat library

2019-05-27 Thread Ard Biesheuvel
Update the INF description and the top level .c files in order to switch to the new version of the SoftFloat library imported in the previous patch. Note that we no longer use the code that travelled a long way from the 2002 version of the softfloat library via NetBsd and the StdLib package. Inste

Re: [edk2-devel] [PATCH v1] OvmfPkg: Drop build flag USE_LEGACY_ISA_STACK and legacy ISA stack

2019-05-27 Thread Laszlo Ersek
On 05/27/19 05:23, Wu, Hao A wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1842 > > According to the discussion at: > https://edk2.groups.io/g/devel/topic/30918343#38093 > > For OVMF, we keep both ISA stacks: > * The legacy one in PcAtChipsetPkg/IntelFrameworkModulePkg > * The Sio b

Re: [edk2-devel] [RFC][PATCH v1 0/1] PcAtChipsetPkg: Remove framework modules

2019-05-27 Thread Laszlo Ersek
On 05/27/19 18:56, Laszlo Ersek wrote: > On 05/27/19 08:36, Wu, Hao A wrote: >> ''' >> Please note that this patch will be hold until all the below requirements >> are met: >> >> A. edk2-stable201905 is created; >> B. OvmfPkg has drop its usage of the legacy ISA stack (which includes >>the IsaA

Re: [edk2-devel] [RFC][PATCH v1 0/1] PcAtChipsetPkg: Remove framework modules

2019-05-27 Thread Laszlo Ersek
On 05/27/19 08:36, Wu, Hao A wrote: > ''' > Please note that this patch will be hold until all the below requirements > are met: > > A. edk2-stable201905 is created; > B. OvmfPkg has drop its usage of the legacy ISA stack (which includes >the IsaAcpiDxe driver); > C. UefiPayloadPkg has been up

Re: [edk2-devel] [PATCH 0/3] update ArmSoftFloatLib to latest upstream version

2019-05-27 Thread Laszlo Ersek
On 05/24/19 23:32, Ard Biesheuvel wrote: > On Fri, 24 May 2019 at 22:57, Laszlo Ersek wrote: >> (1) We should file a new TianoCore BZ (Feature Request) for this >> ArmSoftFloatLib upgrade, and we should block TianoCore#1089 with that >> new BZ. >> >> (2) The new BZ should be referenced in all of

[edk2-devel] [PATCH] PciBusDxe: duplicate node insertion for every PPB device in the system

2019-05-27 Thread Javeed, Ashraf
https://bugzilla.tianocore.org/show_bug.cgi?id=1796 Bug fixed in PciBusDxe\PciLib.c. Removed the redundant second call to PciSearchDevice sub-routine when the PCD for the Hot-Plug support is disabled. Signed-off-by: Ashraf Javeed Cc: Jian J Wang Cc: Ray Ni --- MdeModulePkg/Bus/Pci/PciBusDxe/Pc

Re: [edk2-devel] [edk2-platforms][PATCH v1 06/16] Hisilicon/D0x: Use StatusCode Router & Handler in MdeModulePkg

2019-05-27 Thread ming . huang
I have tested this patch simply, it can boot to OS sucessfully. Thanks. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#41419): https://edk2.groups.io/g/devel/message/41419 Mute This Topic: https://groups.io/mt/31614327/21656 Group Owner:

Re: [edk2-devel] [Patch] BaseTools/Capsule: Supports UEFI Capsule with multiple payloads and embedded drivers

2019-05-27 Thread Liming Gao
Seemly, this is new feature implementation. It will not be for Q2 stable tag. Right? > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Eric Jin > Sent: Monday, May 27, 2019 3:28 PM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming ; > K

Re: [edk2-devel] [PATCH 0/3] update ArmSoftFloatLib to latest upstream version

2019-05-27 Thread Xiaoyu Lu
Hi Ard, Thanks for these patches. I did some function tests for it. Here is the results: --- Test 1: --- test uint32_to_f64 4026531839: Mem: 00 00 E0 FF FF FF ED 41 test uint32_to_f64 4294967295: Mem: 00 00 E0 FF FF FF EF 41 Test 2: --- Test f64_to

[edk2-devel] [PATCH v2 6/7] EmbeddedPkg: Fix DwEmmc SendCommand polling

2019-05-27 Thread Loh, Tien Hock
From: "Tien Hock, Loh" Change SendCommand polling mode to remove unnecessary delay, and check for transfer done only when block data is to be read/write. This would also increase performance slightly. Signed-off-by: "Tien Hock, Loh" Cc: Leif Lindholm Cc: Ard Biesheuvel --- EmbeddedPkg/Driver

[edk2-devel] [PATCH v2 4/7] EmbeddedPkg: Fix response check flag

2019-05-27 Thread Loh, Tien Hock
From: "Tien Hock, Loh" Do not send CRC response check if the MMC command does not support CRC response Signed-off-by: Tien Hock, Loh Cc: Leif Lindholm Cc: Ard Biesheuvel --- EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Emb

[edk2-devel] [PATCH v2 2/7] EmbeddedPkg: Fix DwEmmc CMD8 support for SD

2019-05-27 Thread Loh, Tien Hock
From: "Tien Hock, Loh" On CMD8, for SD, the controller should not expect data as this is a SEND_IF_COND command to verify SD operating condition, and does not have data. Signed-off-by: Tien Hock, Loh Cc: Leif Lindholm Cc: Ard Biesheuvel -- v2 - Change IsEmmc to EFI_MMC_HOST_CARD_TYPE --- Em

[edk2-devel] [PATCH v2 0/7] Fix some bugs with DwEmmc

2019-05-27 Thread Loh, Tien Hock
From: "Tien Hock, Loh" There are some issues with DwEmmc when being used with SD protocol. These series of patches fixes the issues. TIen Hock, Loh (1): EmbeddedPkg: Add SD command support for DwEmmc Tien Hock, Loh (6): EmbeddedPkg: Fix DwEmmc CMD8 support for SD EmbeddedPkg: Send command

[edk2-devel] [PATCH v2 7/7] EmbeddedPkg: Fix DwEmmc read/write size in preparing DMA size

2019-05-27 Thread Loh, Tien Hock
From: "Tien Hock, Loh" Add support for reading data that is less than DWEMMC_BLOCK_SIZE, otherwise it would read bigger data than requested and cause errors Signed-off-by: "Tien Hock, Loh" Cc: Leif Lindholm Cc: Ard Biesheuvel -- v2: - Fix white space issue --- EmbeddedPkg/Drivers/DwEmmcDxe/

[edk2-devel] [PATCH v2 5/7] EmbeddedPkg: Clear CTYPE on initialization

2019-05-27 Thread Loh, Tien Hock
From: "Tien Hock, Loh" Clear CTYPE on initialization. This is important if previous bootloader changes the CTYPE can cause the controller to not initialize correctly if CTYPE is not reset to 0 Signed-off-by: "Tien Hock, Loh" Cc: Leif Lindholm Cc: Ard Biesheuvel --- EmbeddedPkg/Drivers/DwEmmc

[edk2-devel] [PATCH v2 1/7] EmbeddedPkg: Add SD command support for DwEmmc

2019-05-27 Thread Loh, Tien Hock
From: "TIen Hock, Loh" Added ACMD6 for SD support. For SD, after CMD55 is sent, the next command should be an application command, which should not expect data Signed-off-by: "Tien Hock, Loh" Cc: Leif Lindholm Cc: Ard Biesheuvel -- v2: - Move IsACmd as a local static variable in function - F

[edk2-devel] [PATCH v2 3/7] EmbeddedPkg: Send command when MMC ask for response

2019-05-27 Thread Loh, Tien Hock
From: "Tien Hock, Loh" Send command when MMC ask for response in DwEmmcReceiveResponse, and command is a pending command (eg. DMA needs to be set up first) Signed-off-by: "Tien Hock, Loh" Cc: Leif Lindholm Cc: Ard Biesheuvel --- EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c | 9 - 1 file

Re: [edk2-devel] [PATCH 0/3] update ArmSoftFloatLib to latest upstream version

2019-05-27 Thread Wang, Jian J
Ard, Thanks for the contribution. The patch series fix the openssl1.1.1 upgrade build break for ARM. From this perspective, Acked-by: Jian J Wang Thanks, Jian > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Friday, May 24, 2019 11:12 PM > To: devel

[edk2-devel] [Patch] BaseTools/Capsule: Supports UEFI Capsule with multiple payloads and embedded drivers

2019-05-27 Thread Eric Jin
https://bugzilla.tianocore.org/show_bug.cgi?id=1834 * Add arguments "--embedded-driver" to support embedded driver in command line. * Add arguments "--update-image-index" to identify ImageIndex within the device in command line. * Add arguments "-j JSONFILE" to support multiple payloads and embe