Re: [edk2-devel] RFC for Edk2-ToolEnv

Yes the plan would be to support both CI and local builds. There is actually more features related to support platform builds so I think it would be better to keep ci out of the name. The reason why Tool-Env was suggested is the modules can be used to run anything within the python environment

Re: [edk2-devel] [edk2] Soft Feature Freeze starts today for edk2-stable201905

Laszlo: >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Laszlo Ersek >Sent: Wednesday, May 22, 2019 9:05 PM >To: devel@edk2.groups.io; Gao, Liming >Cc: Kinney, Michael D ; Cetola, Stephano >; Andrew Fish ; Leif >Lindholm >Subject: Re: [edk2-dev

[edk2-devel] [PATCH V2] BaseTools:Make BaseTools support the correct RAW FFS FILE generation

BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1765 RAW FFS File has no section for its data. For RAW FFS File, directly call GenFfs tool to generate FFS file. Ffs Rule: [Rule.Common.USER_DEFINED.MicroCode] FILE RAW = $(NAMED_GUID) { SectionType FileType $(INF_OUTPUT)/$(MODULE_NAME).bin

Re: [edk2-devel] [PATCH] BaseTools:Make BaseTools support the correct RAW FFS FILE generation

Zhiju: This usage is only valid when FILE type RAW. Please add this check. Thanks Liming >-Original Message- >From: Fan, ZhijuX >Sent: Thursday, May 23, 2019 11:30 AM >To: devel@edk2.groups.io >Cc: Gao, Liming ; Feng, Bob C >Subject: [PATCH] BaseTools:Make BaseTools support the correct

Re: [edk2-devel] [PATCH v4 0/7] CryptoPkg: Upgrade OpenSSL to 1.1.1b

Ard, > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ard > Biesheuvel > Sent: Tuesday, May 21, 2019 9:39 PM > To: Laszlo Ersek > Cc: Wang, Jian J ; devel@edk2.groups.io; Lu, XiaoyuX > ; Ye, Ting ; Leif Lindholm > ; Gao, Liming > Subject: Re:

[edk2-devel] [PATCH] EmulatorPkg: Fix bugs about BlockIo2

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1760 Signal BlockIO2 callback event manually Add some checks before readfile/writefile function. Signed-off-by: Zhiguang Liu Cc: Jordan Justen Cc: Andrew Fish Cc: Ray Ni --- EmulatorPkg/EmuBlockIoDxe/EmuBlockIo.c | 13 ++--- Emula

Re: [edk2-devel] [edk2-platforms][PATCH V2] Maintainers.txt: Add maintainers

Reviewed-by: Michael Kubacki > -Original Message- > From: Desimone, Nathaniel L > Sent: Wednesday, May 22, 2019 11:35 AM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chaganty, Rangasai V > > Subject: [edk2-platforms][PATCH V2] Maintainers.txt: Add maintainers > > Add maintainer

[edk2-devel] [PATCH] BaseTools:Make BaseTools support the correct RAW FFS FILE generation

BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1765 RAW FFS File has no section for its data. For RAW FFS File, directly call GenFfs tool to generate FFS file. Ffs Rule: [Rule.Common.USER_DEFINED.MicroCode] FILE RAW = $(NAMED_GUID) { SectionType FileType $(INF_OUTPUT)/$(MODULE_NAME).bin

Re: [edk2-devel] RFC for Edk2-ToolEnv

Hi Sean, Does the PIP module here support both local platform builds and CI builds? I am looking at the name of the repo and trying to align with the edk2-tools-library repo name so it is obvious the two repos are related. Maybe focus on the CI part for the name and we reuse the CI features to

Re: [edk2-devel] RFC for Edk2-Library

Hi Sean, Can you send an RFC V2 that makes the following changes: 1) Add use of python virtual environments 2) Update Repository name: edk2-tools-library 3) Provide a summary of the APIs/Services that this PIP module provides and the APIs/Services from the edk2 repo that this PIP module de

[edk2-devel] edk2-stable201905 features and soft/hard freeze and release date

Hello, There have been a few discussion during the soft freeze for edk2-stable201905 on changes that can be accepted or not. The TianoCore Stewards met today to discuss these topics and make some decisions on the following features. * Update OpenSSL version to upcoming 1.1.1 https://bugzilla.t

Re: [edk2-devel] [Patch] BaseTools: Remove './SecMain' from 'run' target

Mike, I missed the second 'SecMain', I'll send another patch to fix it. Bob -Original Message- From: Kinney, Michael D Sent: Thursday, May 23, 2019 6:31 AM To: Gao, Liming ; Feng, Bob C ; devel@edk2.groups.io; Kinney, Michael D Subject: RE: [Patch] BaseTools: Remove './SecMain' from '

Re: [edk2-devel] [Patch 2/3] NetworkPkg: Move Network library header file from MdeModulePkg to NetworkPkg

Reviewed-by: Jiaxin Wu > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Liming Gao > Sent: Wednesday, May 15, 2019 8:02 PM > To: devel@edk2.groups.io > Cc: Fu, Siyuan ; Wu, Jiaxin > Subject: [edk2-devel] [Patch 2/3] NetworkPkg: Move Network

Re: [edk2-devel] [Patch 1/3] NetworkPkg: Move Network library and drivers from MdeModulePkg to NetworkPkg

Reviewed-by: Jiaxin Wu > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Liming Gao > Sent: Wednesday, May 15, 2019 8:02 PM > To: devel@edk2.groups.io > Cc: Fu, Siyuan ; Wu, Jiaxin > Subject: [edk2-devel] [Patch 1/3] NetworkPkg: Move Network

Re: [edk2-devel] [PATCH V2] UefiCpuPkg CpuCommFeaturesLib: Fix ASSERT if LMCE is supported

Laszlo, > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, May 22, 2019 6:32 PM > To: devel@edk2.groups.io; Zeng, Star > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Chandana C ; Li, Kevin Y > > Subject: Re: [edk2-devel] [PATCH V2] UefiCpuPkg CpuCommFeaturesLi

Re: [edk2-devel] [edk2-platforms][PATCH V2] Maintainers.txt: Add maintainers

Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Nate > DeSimone > Sent: Thursday, May 23, 2019 2:35 AM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chaganty, Rangasai V > > Subject: [edk2-devel] [edk2-platf

Re: [edk2-devel] [edk2-platforms] [PATCH v2 3/5] KabylakeOpenBoardPkg: Added GCC5 build support

Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Agyeman, Prince > Sent: Tuesday, May 21, 2019 11:08 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Agyeman, Prince > > Subject: [edk2-devel] [edk2-platforms] [PA

Re: [edk2-devel] [edk2-platforms] [PATCH v2 2/5] KabylakeSiliconPkg: Casting functions to EFIAPI

Reviewed-by: Chasel Chiu > -Original Message- > From: Agyeman, Prince > Sent: Tuesday, May 21, 2019 11:08 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Agyeman, Prince > ; Kubacki, Michael A > ; Kinney, Michael D > ; Desimone, Nathaniel L > ; Gao, Liming ; Sinha, > Ankit > Subjec

Re: [edk2-devel] [edk2-platforms] [PATCH v2 1/5] MinPlatformPkg: Added GCC5 build support

Reviewed-by: Chasel Chiu > -Original Message- > From: Desimone, Nathaniel L > Sent: Thursday, May 23, 2019 3:12 AM > To: Agyeman, Prince ; devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > ; Kinney, Michael D > ; Gao, Liming ; Sinha, > Ankit > Subject: RE: [edk2-platforms

Re: [edk2-devel] [Patch] BaseTools: Remove './SecMain' from 'run' target

Hi Bob, I just noticed that there is a 2nd reference to 'SecMain' in build.py that was missed in this patch review. Is there a reason both were not removed? Mike > -Original Message- > From: Kinney, Michael D > Sent: Tuesday, May 21, 2019 8:45 AM > To: Gao, Liming ; Feng, Bob C > ; deve

Re: [edk2-devel] iSCSI and iBFT

On 22/05/2019 11:40, Tomas Pilar (tpilar) wrote: Yeah, I just AllocateCopyPool the static struct on heap for each device. I can honestly see how one would assume that a protocol instance would never be installed on more than one handle, same as I assumed that using a statically allocated struc

Re: [edk2-devel] [edk2-platforms] [PATCH v2 5/5] Intel/Readme.md: Updated readme with linux build instructions

Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Agyeman, Prince Sent: Monday, May 20, 2019 8:08 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Agyeman, Prince Subject: [edk2-devel] [edk2-platforms] [PATCH v2 5/5] Intel/Readme.md: Updated readme wi

Re: [edk2-devel] [edk2-platforms] [PATCH v2 1/5] MinPlatformPkg: Added GCC5 build support

Reviewed-by: Nate DeSimone -Original Message- From: Agyeman, Prince Sent: Monday, May 20, 2019 8:08 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Agyeman, Prince ; Kubacki, Michael A ; Kinney, Michael D ; Desimone, Nathaniel L ; Gao, Liming ; Sinha, Ankit Subject: [edk2-platforms]

Re: [edk2-devel] [edk2-platforms] [PATCH v2 3/5] KabylakeOpenBoardPkg: Added GCC5 build support

Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Agyeman, Prince Sent: Monday, May 20, 2019 8:08 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Agyeman, Prince Subject: [edk2-devel] [edk2-platforms] [PATCH v2 3/5] KabylakeOpenBoardPkg: Added GCC5 b

Re: [edk2-devel] [edk2-platforms] [PATCH v2 4/5] ClevoOpenBoardPkg: Added GCC5 build support

Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Agyeman, Prince Sent: Monday, May 20, 2019 8:08 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Agyeman, Prince Subject: [edk2-devel] [edk2-platforms] [PATCH v2 4/5] ClevoOpenBoardPkg: Added GCC5 buil

Re: [edk2-devel] [edk2-platforms] [PATCH v2 2/5] KabylakeSiliconPkg: Casting functions to EFIAPI

Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Agyeman, Prince Sent: Monday, May 20, 2019 8:08 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Agyeman, Prince ; Kubacki, Michael A ; Kinney, Michael D ; Desimone, Nathaniel L ; Gao, Liming ; Sinha,

Re: [edk2-devel] Help needed in building UEFI qcow2 images

Laszlo, Sorry I got the attachment too. It was just scrolled off the screen after the boiler plate. Groups.io Links: You receive all messages sent to this group. View/Reply Online (#41228) | | Mute This Topic

Re: [edk2-devel] [edk2-platforms] [PATCH v2 1/5] MinPlatformPkg: Added GCC5 build support

Reviewed-by: Michael Kubacki > -Original Message- > From: Agyeman, Prince > Sent: Monday, May 20, 2019 8:08 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Agyeman, Prince > ; Kubacki, Michael A > ; Kinney, Michael D > ; Desimone, Nathaniel L > ; Gao, Liming ; > Sinha, Ankit > Subject

Re: [edk2-devel] [edk2-platforms] [PATCH v2 2/5] KabylakeSiliconPkg: Casting functions to EFIAPI

Reviewed-by: Michael Kubacki > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Agyeman, Prince > Sent: Monday, May 20, 2019 8:08 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Agyeman, Prince > ; Kubacki, Michael A > ; Kinney, Michael D > ;

Re: [edk2-devel] [edk2-platforms] [PATCH v2 5/5] Intel/Readme.md: Updated readme with linux build instructions

Reviewed-by: Michael Kubacki > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Agyeman, Prince > Sent: Monday, May 20, 2019 8:08 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Agyeman, Prince > > Subject: [edk2-devel] [edk2-platforms] [PAT

Re: [edk2-devel] Help needed in building UEFI qcow2 images

On 05/22/19 17:58, Andrew Fish via Groups.Io wrote: > Tom, > > Looks like the mailing list stripped your attachment. I got the attachment OK, and I also see it in both mail archives: https://edk2.groups.io/g/devel/message/41228 ed4cfca6710b43f78ea5d6d05a87b676@ukex01.SolarFlarecom.com">http://

[edk2-devel] [edk2-platforms][PATCH V2] Maintainers.txt: Add maintainers

Add maintainers for MinPlatformPkg, ClevoOpenBoardPkg, and KabylakeSiliconPkg Cc: Michael Kubacki Cc: Sai Chaganty Signed-off-by: Nate DeSimone --- Maintainers.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Maintainers.txt b/Maintainers.txt index 927cd5ed93..e900523eee 100644 --- a

Re: [edk2-devel] [PATCH] Maintainers.txt: Add maintainer for ClevoOpenBoardPkg

Reviewed-by: Michael Kubacki > -Original Message- > From: Desimone, Nathaniel L > Sent: Monday, May 20, 2019 11:28 AM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A > Subject: [PATCH] Maintainers.txt: Add maintainer for ClevoOpenBoardPkg > > Signed-off-by: Nate DeSimone > Cc: Mich

Re: [edk2-devel] Help needed in building UEFI qcow2 images

It should work Stephano is going to take a look. Thanks, Andrew Fish > On May 22, 2019, at 9:57 AM, Tomas Pilar (tpilar) > wrote: > > Thanks Andrew, > > I thought that groups.io is supposed to allow attachments? > > Anyway snippet below: > > > > > Qemu Test > 6a92c8c3-c6b4-4b57

Re: [edk2-devel] [RFC][edk2-platform][Add new packages in Platform\Intel directory]

I am concerned that BoardSupportPkg is misleading. My understanding is that many people are familiar with board support files, board support packages, and similar concepts explicitly using the words board and support. And in my experience, they have always had the board specific details. Our

Re: [edk2-devel] Help needed in building UEFI qcow2 images

Thanks Andrew, I thought that groups.io is supposed to allow attachments? Anyway snippet below:   Qemu Test   6a92c8c3-c6b4-4b57-a164-0a9917eeaf19   2097152   2097152   2       /machine

Re: [edk2-devel] Help needed in building UEFI qcow2 images

Tom, Looks like the mailing list stripped your attachment. Thanks, Andrew Fish > On May 22, 2019, at 4:19 AM, Tomas Pilar (tpilar) > wrote: > > Hi Pavan, > > I am currently playing around with setting up a OVMF based test framework > myself. You likely need to tell qemu to use OVMF as it’s

Re: [edk2-devel] [Patch] MdeModulePkg: Update MdeModulePkg.dsc to remove Network related modules

On Wed, May 22, 2019 at 11:41:03AM +, Gao, Liming wrote: > > -Original Message- > > From: Laszlo Ersek [mailto:ler...@redhat.com] > > Sent: Wednesday, May 22, 2019 5:11 PM > > To: Gao, Liming ; Wu, Hao A ; > > devel@edk2.groups.io > > Cc: leif.lindh...@linaro.org; Kinney, Michael D >

Re: [edk2-devel] [Patch V3] OpensslLib: Missing local header files in [Sources] section of .INFs

Thanks for the feedback. I will move it forward into the next patch. I also agree with Laszlo's comment on the first patch: " I'd request that we please hold this patch for now. (Comments in disagreement are welcome of course.) If we agree, I'd suggest marking TianoCore#1821 dependent on TianoC

Re: [edk2-devel] [edk2] Soft Feature Freeze starts today for edk2-stable201905

On 05/22/19 14:09, Liming Gao wrote: > Here, I don't want to argue whether they are feature or bug. I just > want to share my thinking, and collect feedback, then work out the > clear rule so that all developers can follow. Good question. Assume we push a series that adds a feature, but then we r

Re: [edk2-devel] [edk2] Soft Feature Freeze starts today for edk2-stable201905

Laszlo: > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, May 22, 2019 5:01 AM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Kinney, Michael D > ; Cetola, Stephano > ; Andrew Fish ; Leif Lindholm > > Subject: Re: [edk2-devel] [edk2] Soft Feature Fre

Re: [edk2-devel] [Patch] MdeModulePkg: Update MdeModulePkg.dsc to remove Network related modules

> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, May 22, 2019 5:11 PM > To: Gao, Liming ; Wu, Hao A ; > devel@edk2.groups.io > Cc: leif.lindh...@linaro.org; Kinney, Michael D ; > af...@apple.com > Subject: Re: [edk2-devel] [Patch] MdeModulePkg: Updat

Re: [edk2-devel] Help needed in building UEFI qcow2 images

Hi Pavan, I am currently playing around with setting up a OVMF based test framework myself. You likely need to tell qemu to use OVMF as it's firmware. I attach my current working libvirt XML file for creating UEFI VMs (diskless) - note the and the elements within the element. You want to ad

Re: [edk2-devel] [edk2-platforms] [PATCH] Maintainers.txt: Add maintainers

Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Nate > DeSimone > Sent: Wednesday, May 22, 2019 2:17 AM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chaganty, Rangasai V > > Subject: [edk2-devel] [edk2-platf

[edk2-devel] Help needed in building UEFI qcow2 images

Hi, [re-posting the question] I am looking for information/documentation which helps me in enabling UEFI boot to the existing (KVM)VM template. I am trying for CentOS 6.5(64-bit) no GUI 64-bit (KVM) template. I found some images available over https://www.kraxel.org/repos/images/ with fed

Re: [edk2-devel] iSCSI and iBFT

Yeah, I just AllocateCopyPool the static struct on heap for each device. I can honestly see how one would assume that a protocol instance would never be installed on more than one handle, same as I assumed that using a statically allocated struct containing nothing but boilerplate info would als

Re: [edk2-devel] [PATCH V2] UefiCpuPkg CpuCommFeaturesLib: Fix ASSERT if LMCE is supported

On 05/22/19 12:17, Zeng, Star wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1829 > > There will be ASSERT if LMCE is supported as below. > DXE_ASSERT!: [CpuFeaturesDxe] > XXX\UefiCpuPkg\Library\CpuCommonFeaturesLib\MachineCheck.c (342): > ConfigData != ((void *) 0) > > The cod

Re: [edk2-devel] iSCSI and iBFT

On 05/22/19 11:55, Tomas Pilar wrote: > iPXE identifies the device it was pxe booted from by searching parents of the > LoadedImage which support SNP and NII and uses the address of the installed > NII and SNP as a discriminant to see if a device is in fact the one it was > pxe booted from. This

[edk2-devel] [PATCH V2] UefiCpuPkg CpuCommFeaturesLib: Fix ASSERT if LMCE is supported

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1829 There will be ASSERT if LMCE is supported as below. DXE_ASSERT!: [CpuFeaturesDxe] XXX\UefiCpuPkg\Library\CpuCommonFeaturesLib\MachineCheck.c (342): ConfigData != ((void *) 0) The code should get Config Data and FeatureControlGetConfigD

Re: [edk2-devel] iSCSI and iBFT

iPXE identifies the device it was pxe booted from by searching parents of the LoadedImage which support SNP and NII and uses the address of the installed NII and SNP as a discriminant to see if a device is in fact the one it was pxe booted from. This convoluted process is done to shoehorn chainl

Re: [edk2-devel] [Patch V3] OpensslLib: Missing local header files in [Sources] section of .INFs

On 05/22/19 11:40, Xiaoyu Lu wrote: > Hi Christian, > > (1) We use OpenSSL configure script disabled some OpenSSL feature. >But I saw you include all .h files from OpenSSL(only excluded some). >Even some header files we don't need (In openssl/crypto/). >Can you rule them out? >

Re: [edk2-devel] [Patch V3] OpensslLib: Missing local header files in [Sources] section of .INFs

Hi Christian, (1) We use OpenSSL configure script disabled some OpenSSL feature. But I saw you include all .h files from OpenSSL(only excluded some). Even some header files we don't need (In openssl/crypto/). Can you rule them out? I found OpenSSl use configdata.pm to store configu

Re: [edk2-devel] [edk2-platforms] [PATCH] Maintainers.txt: Add maintainers

Reviewed-by: Sai Chaganty -Original Message- From: Desimone, Nathaniel L Sent: Tuesday, May 21, 2019 11:17 AM To: devel@edk2.groups.io Cc: Kubacki, Michael A ; Chaganty, Rangasai V Subject: [edk2-platforms] [PATCH] Maintainers.txt: Add maintainers Add maintainers for MinPlatformPkg,

[edk2-devel] [RFC] Proposal to move IntelSiliconPkg from edk2 repo to edk2-platforms repo

Hello Everyone, As we are noticing, there are some activities in progress to reduce edk2 repo. I would like to propose to move IntelSiliconPkg from edk2 repo to edk2-platforms repo. There is no dependency on this package from any other module in edk2 repo so it should be safe to move to edk2-pla

Re: [edk2-devel] [Enable measured boot with SM3 digest algorithm 0/4]

Hello Jiewen, I tested SM3 PCR extensions on the OvmfPkg using swTPM (and TPM2 simulator). The validation was done comparing PCR extensions from the TCG2 EventLog and SM3 PCR Bank data from the simulator at every extension. Additionally each SM3 extension and resulting values were compared and c

Re: [edk2-devel] why does RAND_add() take "randomness" as a "double"?

Double makes sense. Entropy is often estimated as a real value. E.g. we have the aforementioned coin flipper feeding data serially. Adding each bit sequentially means 0.125 bytes of entropy per call. Not the best example Pauli -- Oracle Dr Paul Dale | Cryptographer | Network Security & Enc

Re: [edk2-devel] [PATCH] OpensslLib: Missing local header files in [Sources] section of .INFs

On 05/21/19 21:03, Christian Rodriguez wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1821 > > Update OpenSSL autogeneration script for .INFs because some > OpenSSL local headers are missing from [Sources] section of > OpensslLib.inf and OpensslLibCrypto.inf. Update OpensslLib.inf and

Re: [edk2-devel] [PATCH] UefiCpuPkg CpuCommFeaturesLib: Fix ASSERT if LMCE is supported

On 05/22/19 05:26, Star Zeng wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1829 > > There will be ASSERT if LMCE is supported as below. > DXE_ASSERT!: [CpuFeaturesDxe] > XXX\UefiCpuPkg\Library\CpuCommonFeaturesLib\MachineCheck.c (342): > ConfigData != ((void *) 0) > > The code

Re: [edk2-devel] [Patch] MdeModulePkg: Update MdeModulePkg.dsc to remove Network related modules

On 05/22/19 03:50, Gao, Liming wrote: > This is a bug. Because NetworkPkg dsc has included all network modules, the > ones in MdeModule are duplicated. I'm not sure I'm convinced -- if this patch is not applied, what precisely is the functionality that breaks? What are the symptoms? Either way,

Re: [edk2-devel] [PATCH v4 0/7] CryptoPkg: Upgrade OpenSSL to 1.1.1b

On 05/22/19 02:10, Kinney, Michael D wrote: > Hi Laszlo, > > Another option we can consider is delaying the > freeze windows and release date (if required) to > accommodate the OpenSSL 1.1.1b feature. Yes, that's reasonable. And, the same argument could apply to

Re: [edk2-devel] [edk2] Soft Feature Freeze starts today for edk2-stable201905

On 05/22/19 10:28, Ni, Ray wrote: >>> 110d4729b58e EmulatorPkg: Add NetworkPkg/NetworkPkg.dec as the >> package >>> dependency >> >> Invalid, same as commit 911efe279ec3 above. >> >> ... No, wait, this is worse: this patch had not received *any* review >> feedback >> on the list: >> >> 201905201

[edk2-devel] [PATCH 0/2] Add FSP Dispatch mode switch

Boot loader (FspWrapper/Platform code) now can switch to Dispatch mode defined by FSP 2.1 spec using PcdFspModeSelection. For backward compatibility different FspBinPkg may be consumed in each mode. To support this switch, below are required changes in KabylakeOpenBoardPkg and KabylakeSiliconPkg:

[edk2-devel] [PATCH 2/2] KabylakeOpenBoardPkg: Add FSP Dispatch switch.

From: "Chasel, Chiu" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1832 Basing on PcdFspModeSelection setting either KabylakeFspBinPkg or AmberLakeFspBinPkg will be used and temporary memory arrangement will be different as AmberLakeFspBinPkg will share the same stack with boot loader. Als

[edk2-devel] [PATCH 1/2] KabylakeSiliconPkg: Add FSP Dispatch switch.

From: "Chasel, Chiu" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1832 PcdFspModeSelection is used as switch for boot loader to consume FSP in API mode or Dispatch mode. For backward compatibility, if boot loader running in FSP API mode the KabylakeFspBinPkg will be used which does not ha

Re: [edk2-devel] [edk2] Soft Feature Freeze starts today for edk2-stable201905

> > 110d4729b58e EmulatorPkg: Add NetworkPkg/NetworkPkg.dec as the > package > > dependency > > Invalid, same as commit 911efe279ec3 above. > > ... No, wait, this is worse: this patch had not received *any* review feedback > on the list: > > 20190520130920.9464-3-liming.gao@intel.com">http://m

Re: [edk2-devel] [PATCH 2/4] EmbeddedPkg: Fix response check flag

Hi Ard, Leif, Can you help review this? Thanks! -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#41204): https://edk2.groups.io/g/devel/message/41204 Mute This Topic: https://groups.io/mt/31552954/21656 Group Owner: devel+ow...@edk2.group

Re: [edk2-devel] [PATCH v2] EmbeddedPkg: Clear CTYPE on initialization

Hi Ard, Leif, Can you help review this? Thanks! -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#41205): https://edk2.groups.io/g/devel/message/41205 Mute This Topic: https://groups.io/mt/31552976/21656 Group Owner: devel+ow...@edk2.group

[edk2-devel] [PATCH 1/2] [staging/HBFA PATCH]: UefiHostUnitTestCasePkg: Remove PcdFrameworkCompatibilitySupport

To be consistent with edk2, remove PcdFrameworkCompatibilitySupport Signed-off-by: Tengfen Sun --- .../TestCase/FatPkg/FatPei/Override/FatPei.inf | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/HBFA/UefiHostUnitTestCasePkg/TestCase/FatPkg/FatPei/Override/Fa

[edk2-devel] [PATCH 0/2] [staging/HBFA PATCH]: Remove PcdFrameworkCompatibilitySupport

To be consistent with edk2, remove PcdFrameworkCompatibilitySupport tengfens (2): [staging/HBFA PATCH]: UefiHostUnitTestCasePkg: Remove PcdFrameworkCompatibilitySupport [staging/HBFA PATCH]: UefiHostFuzzTestCasePkg: Remove PcdFrameworkCompatibilitySupport .../TestCase/FatPkg/FatPei/O

[edk2-devel] [PATCH 2/2] [staging/HBFA PATCH]: UefiHostFuzzTestCasePkg: Remove PcdFrameworkCompatibilitySupport

To be consistent with edk2, remove PcdFrameworkCompatibilitySupport Signed-off-by: Tengfen Sun --- .../TestCase/FatPkg/FatPei/Override/FatPei.inf | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/HBFA/UefiHostFuzzTestCasePkg/TestCase/FatPkg/FatPei/Override/Fa

Re: [edk2-devel] [PATCH v4 edk2-platforms 1/1] Silicon/DesignWare/Driver: DwEmacSnpDxe: Add DesignWare EMAC driver

On Wed, 22 May 2019 at 03:37, Ooi, Tzy Way wrote: > > Hi Maintainers, > > Please could you help to review this patch? Thanks. > I already did, but my email response got rejected twice https://edk2.groups.io/g/devel/message/40829?p=,,,20,0,0,0::Created,,emac,20,2,0,31541649 -=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH 3/4] [staging/HBFA PATCH]: UefiHostUnitTestCasePkg: Add CmockaLib

Add CmockaLib into UefiHostUnitTestCasePkg.dsc REF: https://edk2.groups.io/g/devel/message/39893 Signed-off-by: Tengfen Sun --- .../UefiHostUnitTestCasePkg.dsc | 11 +++ 1 file changed, 11 insertions(+) diff --git a/HBFA/UefiHostUnitTestCasePkg/UefiHostUnitTestCase

[edk2-devel] [PATCH 1/4] [staging/HBFA PATCH]: CmockaHostUnitTestPkg: Add cmocka submodule.

Add cmocka submodule to improve the current build process. REF: https://edk2.groups.io/g/devel/message/39893 Signed-off-by: Jiewen Yao Signed-off-by: Tengfen Sun --- .gitmodules | 3 +++ HBFA/CmockaHostUnitTestPkg/Library/CmockaLib/cmocka | 1 + 2 files c

[edk2-devel] [PATCH 4/4] [staging/HBFA PATCH]: UefiHostUnitTestPkg: Enable cmocka unit test build with CmockaHostUnitTestPkg

In order to improve the current build process, enable cmocka unit test build with CmockaHostUnitTestPkg. REF: https://edk2.groups.io/g/devel/message/39893 Signed-off-by: Tengfen Sun --- .../UnitTestAssertLibcmocka.inf | 4 +- .../UnitTestLibcmocka/UnitTestLibcmocka.inf | 2 +

[edk2-devel] [PATCH 0/4] [staging/HBFA PATCH]: Enable cmocka unit test build with submodule.

In order to improve the current build process, add cmocka submodule for unit test build. REF: https://edk2.groups.io/g/devel/message/39893 tengfens (4): [staging/HBFA PATCH]: CmockaHostUnitTestPkg: Add cmocka submodule. [staging/HBFA PATCH]: CmockaHostUnitTestPkg: Enable CmockaHostUnitTes

[edk2-devel] [PATCH 2/4] [staging/HBFA PATCH]: CmockaHostUnitTestPkg: Enable CmockaHostUnitTestPkg build.

Enable build for CmockaHostUnitTestPkg with cmocka submodule. REF: https://edk2.groups.io/g/devel/message/39893 Signed-off-by: Tengfen Sun --- .../CmockaHostUnitTestPkg.dec | 16 + .../CmockaHostUnitTestPkg.dsc | 22 + .../Library/CmockaLib/Cmo

[edk2-devel] [PATCH] SecurityPkg/OpalPassword: Add PCD to skip password prompt

https://bugzilla.tianocore.org/show_bug.cgi?id=1801 Add a PCD for skipping password prompt in device unlocked status. Previous change only support if storage device is in locked status. This change is added to support the case that security status of the storage device is unlocked. Signed-off-by: