Re: [edk2-devel] [PATCH] IntelFrameworkModulePkg/DebugLib: Fix string copy issue

2019-05-21 Thread Liming Gao
Yes. MdeModulePkg one is correct. The issue is only in IntelFrameworkModulePkg one. This is a regression issue. Before remove IntelFrameworkModulePkg, it is still required to be fixed. Thanks Liming > -Original Message- > From: Ni, Ray > Sent: Wednesday, May 22, 2019 1:22 PM > To: dev

Re: [edk2-devel] [PATCH] IntelFrameworkModulePkg/DebugLib: Fix string copy issue

2019-05-21 Thread Ni, Ray
Can the library in MdeModulePkg be used? The IntelFrameworkPkg/IntelFrameworkModulePkg will be removed in June. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Gao, > Zhichao > Sent: Tuesday, May 21, 2019 3:50 PM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Wu, Hao A > S

Re: [edk2-devel] [RFC][edk2-platform][Add new packages in Platform\Intel directory]

2019-05-21 Thread Kubacki, Michael A
In that case, I’d like to move the proposed name to BoardSupportPkg. Thanks, Michael From: Gao, Liming Sent: Tuesday, May 21, 2019 9:00 PM To: Kubacki, Michael A ; devel@edk2.groups.io Subject: RE: [edk2-devel] [RFC][edk2-platform][Add new packages in Platform\Intel directory] Michael: I am OK

Re: [edk2-devel] [RFC][edk2-platform][Add new packages in Platform\Intel directory]

2019-05-21 Thread Liming Gao
Michael: I am OK for both name. I think they have same meaning. To avoid the common word in Package name, such as Generic or Universal, BoardSupportPkg name may be better. Thanks Liming From: Kubacki, Michael A [mailto:michael.a.kuba...@intel.com] Sent: Monday, May 20, 2019 1:30 PM To: Gao; Gao

Re: [edk2-devel] [Patch edk2-platform 2/3] Platform/Intel/Vlv2TbltDevicePkg: Add NetworkPkg.dec as the package dependency

2019-05-21 Thread Sun, Zailiang
Reviewed-by: Zailiang Sun > -Original Message- > From: Gao, Liming > Sent: Monday, May 20, 2019 9:10 PM > To: devel@edk2.groups.io > Cc: Sun, Zailiang ; Qian, Yi > Subject: [Patch edk2-platform 2/3] Platform/Intel/Vlv2TbltDevicePkg: Add > NetworkPkg.dec as the package dependency > > Net

Re: [edk2-devel] [edk2-platforms][PATCH v1 06/16] Hisilicon/D0x: Use StatusCode Router & Handler in MdeModulePkg

2019-05-21 Thread Ni, Ray
> -Original Message- > From: devel@edk2.groups.io On Behalf Of Wu, Hao > A > Sent: Monday, May 20, 2019 4:50 PM > To: devel@edk2.groups.io; ard.biesheu...@linaro.org; Leif Lindholm > > Cc: Kinney, Michael D > Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 06/16] Hisilicon/D0x: > Use

[edk2-devel] [PATCH] UefiCpuPkg CpuCommFeaturesLib: Fix ASSERT if LMCE is supported

2019-05-21 Thread Zeng, Star
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1829 There will be ASSERT if LMCE is supported as below. DXE_ASSERT!: [CpuFeaturesDxe] XXX\UefiCpuPkg\Library\CpuCommonFeaturesLib\MachineCheck.c (342): ConfigData != ((void *) 0) The code should get Config Data and FeatureControlGetConfigD

FW: [edk2-devel] [Patch 2/2] EmulatorPkg: Add NetworkPkg/NetworkPkg.dec as the package dependency

2019-05-21 Thread Liming Gao
Forward to edk2 mail list -Original Message- From: Ni, Ray Sent: Tuesday, May 21, 2019 10:29 AM To: Gao, Liming Subject: RE: [edk2-devel] [Patch 2/2] EmulatorPkg: Add NetworkPkg/NetworkPkg.dec as the package dependency Reviewed-by: Ray Ni > > > -Original Message- > > From: de

Re: [edk2-devel] [PATCH] IntelFrameworkModulePkg/DebugLib: Fix string copy issue

2019-05-21 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: Wu, Hao A > Sent: Tuesday, May 21, 2019 4:03 PM > To: devel@edk2.groups.io; Gao, Zhichao > Cc: Gao, Liming > Subject: RE: [edk2-devel] [PATCH] IntelFrameworkModulePkg/DebugLib: Fix > string copy issue > > > -Original Message

Re: [edk2-devel] [Patch] MdeModulePkg: Update MdeModulePkg.dsc to remove Network related modules

2019-05-21 Thread Liming Gao
This is a bug. Because NetworkPkg dsc has included all network modules, the ones in MdeModule are duplicated. This change is to remove the duplicated one. Thanks Liming > -Original Message- > From: Wu, Hao A > Sent: Wednesday, May 22, 2019 9:44 AM > To: devel@edk2.groups.io; Gao, Liming

Re: [edk2-devel] [Patch] MdeModulePkg: Update MdeModulePkg.dsc to remove Network related modules

2019-05-21 Thread Wu, Hao A
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Liming Gao > Sent: Tuesday, May 21, 2019 11:22 PM > To: devel@edk2.groups.io > Cc: Wu, Hao A > Subject: [edk2-devel] [Patch] MdeModulePkg: Update MdeModulePkg.dsc > to remove Network related modul

[edk2-devel] [Patch V5 edk2-platform 17/18] Platform/MinPlatformPkg: Update DSC to use NetworkPkg DSC.

2019-05-21 Thread Liming Gao
From: Shenglei Zhang This patch updates the DSC file to use the include fragment files provided by NetworkPkg. And add network related definition in CoreCommonLib.dsc, remove HttpLib from CoreDxeLib.dsc. Cc: Michael A Kubacki Cc: Jiewen Yao Cc: Shifei A Lu Cc: Xiaohu Zhou Signed-off-by: Shen

Re: [edk2-devel] [Patch] BaseTools: Update Conf/target.template with the default EmulatorPkg.dsc

2019-05-21 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Liming Gao Sent: Tuesday, May 21, 2019 11:09 PM To: devel@edk2.groups.io Cc: Feng, Bob C Subject: [edk2-devel] [Patch] BaseTools: Update Conf/target.template with the default

Re: [edk2-devel] [Patch] BaseTools: Remove './SecMain' from 'run' target

2019-05-21 Thread Bob Feng
I entered a new BZ to create the EmulatorPkg postbuild script for "build run" support. https://bugzilla.tianocore.org/show_bug.cgi?id=1828 Thanks, Bob -Original Message- From: Kinney, Michael D Sent: Tuesday, May 21, 2019 11:45 PM To: Gao, Liming ; Feng, Bob C ; devel@edk2.groups.io;

Re: [edk2-devel] [PATCH v2] KabylakeOpenBoardPkg: Fixed system hang caused by MemoryTest.

2019-05-21 Thread Kubacki, Michael A
Reviewed-by: Michael Kubacki > -Original Message- > From: Chiu, Chasel > Sent: Tuesday, May 21, 2019 5:03 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Kubacki, Michael A > > Subject: [PATCH v2] KabylakeOpenBoardPkg: Fixed system hang caused by > MemoryTest

Re: [edk2-devel] [PATCH V1 1/1] ShellPkg/acpiview: GTDT updates for ACPI 6.3

2019-05-21 Thread Gao, Zhichao
The code change looks good for me. But when I try to apply your patch to my local edk2 code, I would encounter an error "error: corrupt patch at line 23". Making sure the patch that can apply to the edk2 trunk is important. Otherwise, the testers and maintainers may take time to write the whole

Re: [edk2-devel] [PATCH v4 0/7] CryptoPkg: Upgrade OpenSSL to 1.1.1b

2019-05-21 Thread Michael D Kinney
Hi Laszlo, Another option we can consider is delaying the freeze windows and release date (if required) to accommodate the OpenSSL 1.1.1b feature. The following page shows that the current branch being used by EDK II (1.1.0j) with EOL on 9/11/2019. https://www.openssl.org/policies/releasestrat.h

[edk2-devel] [PATCH v2] KabylakeOpenBoardPkg: Fixed system hang caused by MemoryTest.

2019-05-21 Thread Chiu, Chasel
From: "Chasel, Chiu" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1550 OS hang due to non-existing memory reported as usable memory. There are 2 different RVP3 boards and one with 4GB memory down implementation while another one with 8GB. Since rest of the configurations are exactly the s

Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] Readme.md: Add Intel platforms

2019-05-21 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Wednesday, May 22, 2019 12:49 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Desimone, Nathaniel L > ; Chiu, Chasel ; Gao, > Liming ; Ni, Ray > Subject: [edk2-platforms][PATCH V1 1/1] Readme.md:

Re: [edk2-devel] [PATCH] KabylakeOpenBoardPkg: Fixed system hang caused by MemoryTest.

2019-05-21 Thread Kubacki, Michael A
Please promote BaseEcLib to the "GenericBoardPkg" or whatever name is decided when created. We can extend command and vendor support there in the future. In BaseEcLib.c, remove SLE_FLAG usage and positive logic blocks. Thanks, Michael > -Original Message- > From: Chiu, Chasel > Sent: Tu

Re: [edk2-devel] [PATCH v4 0/7] CryptoPkg: Upgrade OpenSSL to 1.1.1b

2019-05-21 Thread Laszlo Ersek
On 05/16/19 09:54, Xiaoyu lu wrote: > This series is also available at: > https://github.com/xiaoyuxlu/edk2/tree/bz_1089_upgrade_to_openssl_1_1_1b_v4 > > Changes: > > (1) CryptoPkgOpensslLib: Modify process_files.pl for upgrading OpenSSL > > (2) CryptoPkg/OpensslLib: Exclude unnecessary files i

Re: [edk2-devel] [Patch 0/7] Add new CLANG8ELF tool chain for new LLVM/CLANG8

2019-05-21 Thread Laszlo Ersek
On 04/26/19 16:42, Liming Gao wrote: > BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1603 > LLVM/CLANG8 formal release http://releases.llvm.org/download.html#8.0.0 > It can be downloaded and installed in Windows/Linux/Mac OS. > > CLANG8ELF tool chain is added to generate ELF image, and convert

[edk2-devel] [Patch V3] OpensslLib: Missing local header files in [Sources] section of .INFs

2019-05-21 Thread Christian Rodriguez
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1821 In V2: Remove opensslconf.h because it is a script generated header. Update OpenSSL autogeneration script for .INFs because some OpenSSL local headers are missing from [Sources] section of OpensslLib.inf and OpensslLibCrypto.inf. Update Opens

Re: [edk2-devel] [PATCH] BaseTools:Add the FeatureFlagExpression usage to the InfBuildData

2019-05-21 Thread Laszlo Ersek
On 05/17/19 02:57, Fan, ZhijuX wrote: > BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1446 > > FeatureFlagExpression Support in LibraryClasses/Guids/Ppi/Protocols > section of INF file. The Pcd value in the expression is from INF or DEC > When a FeatureFlagExpression is present,if the expressi

Re: [edk2-devel] [edk2] Soft Feature Freeze starts today for edk2-stable201905

2019-05-21 Thread Laszlo Ersek
On 05/21/19 23:01, Laszlo Ersek wrote: > > https://github.com/lersek/edk2/wiki/SoftFeatureFreeze#what-is-the-soft-feature-freeze Sorry, this link was wrong -- I got it from my browsers URL bar history, and didn't notice it early enough. The right URL is: https://github.com/tianocore/tianocore

Re: [edk2-devel] [edk2] Soft Feature Freeze starts today for edk2-stable201905

2019-05-21 Thread Laszlo Ersek
Hi, On 05/17/19 10:56, Liming Gao wrote: > Hi, all > > https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning > lists edk2-stable201905 tag planning. Now, we enter into Soft Feature > Freeze phase. In this phase, the feature without Reviewed-by or > Acked-by tags will be

Re: [edk2-devel] iSCSI and iBFT

2019-05-21 Thread Laszlo Ersek
On 05/21/19 16:54, Tomas Pilar (tpilar) wrote: > I am going to commit the cardinal sin of online dev support. heh :) > 'Never mind, found the problem' What was it? I didn't ignore your original email -- I looked at iPXE briefly, but couldn't blame anything at once, and then I quickly ran out of

[edk2-devel] [PATCH] OpensslLib: Missing local header files in [Sources] section of .INFs

2019-05-21 Thread Christian Rodriguez
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1821 Update OpenSSL autogeneration script for .INFs because some OpenSSL local headers are missing from [Sources] section of OpensslLib.inf and OpensslLibCrypto.inf. Update OpensslLib.inf and OpensslLibCrypto.inf using the updated script. Enforce

Re: [edk2-devel] [edk2-platforms] [PATCH] Maintainers.txt: Add maintainers

2019-05-21 Thread Kubacki, Michael A
Reviewed-by: Michael Kubacki > -Original Message- > From: Desimone, Nathaniel L > Sent: Tuesday, May 21, 2019 11:17 AM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chaganty, Rangasai > V > Subject: [edk2-platforms] [PATCH] Maintainers.txt: Add maintainers > > Add maintainers fo

[edk2-devel] [edk2-platforms] [PATCH] Maintainers.txt: Add maintainers

2019-05-21 Thread Nate DeSimone
Add maintainers for MinPlatformPkg, ClevoOpenBoardPkg, and KabylakeSiliconPkg Cc: Michael Kubacki Cc: Sai Chaganty Signed-off-by: Nate DeSimone --- Maintainers.txt | 4 1 file changed, 4 insertions(+) diff --git a/Maintainers.txt b/Maintainers.txt index 927cd5ed93..2fac4a4c30 100644 ---

Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] Readme.md: Add Intel platforms

2019-05-21 Thread Nate DeSimone
Reviewed-by: Nate DeSimone On 5/21/19, 9:50 AM, "Kubacki, Michael A" wrote: Adds information to Readme.md for Intel platforms recently moved to the edk2-platforms repository. Cc: Michael D Kinney Cc: Nate DeSimone Cc: Chasel Chiu Cc: Liming Gao Cc: Ruiyu Ni

Re: [edk2-devel] [Enable measured boot with SM3 digest algorithm 0/4]

2019-05-21 Thread Yao, Jiewen
Cool Thanks thank you! Yao, Jiewen > 在 2019年5月21日,上午9:58,Desai, Imran 写道: > > Hello Jiewen, > > I tested SM3 PCR extensions on the OvmfPkg using swTPM (and TPM2 simulator). > The validation was done comparing PCR extensions from the TCG2 EventLog and > SM3 PCR Bank data from the simulator at

Re: [edk2-devel] why does RAND_add() take "randomness" as a "double"?

2019-05-21 Thread Laszlo Ersek
Hi, On 05/21/19 16:15, Laszlo Ersek wrote: > (resending, with my subscription to completed) > > Hi OpenSSL Developers, > > (cross-posting and ,) I've received comments on the openssl-user mailing list, but regrettably, all of those responses stripped the email address. So, AFAICS, none of th

[edk2-devel] [edk2-platforms][PATCH V1 1/1] Readme.md: Add Intel platforms

2019-05-21 Thread Kubacki, Michael A
Adds information to Readme.md for Intel platforms recently moved to the edk2-platforms repository. Cc: Michael D Kinney Cc: Nate DeSimone Cc: Chasel Chiu Cc: Liming Gao Cc: Ruiyu Ni Signed-off-by: Michael Kubacki --- Readme.md | 20 ++-- 1 file changed, 14 insertions(+), 6

[edk2-devel] [PATCH] KabylakeOpenBoardPkg: Fixed system hang caused by MemoryTest.

2019-05-21 Thread Chiu, Chasel
From: "Chasel, Chiu" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1550 OS hang due to non-existing memory reported as usable memory. There are 2 different RVP3 boards and one with 4GB memory down implementation while another one with 8GB. Since rest of the configurations are exactly the s

Re: [edk2-devel] [Patch] BaseTools: Remove './SecMain' from 'run' target

2019-05-21 Thread Michael D Kinney
Reviewed-by: Michael D Kinney If we want the 'run' target to work for the EmulatorPkg, we can add a python post build script to support that. Please enter a BZ feature request. There is an example in the following edk2-staging branch that runs QEMU for an OvmfPkg build using a 'run' target. ht

[edk2-devel] [Patch] MdeModulePkg: Update MdeModulePkg.dsc to remove Network related modules

2019-05-21 Thread Liming Gao
Network related modules have been included in NetworkPkg.dsc. They can be removed from MdeModulePkg.dsc. Signed-off-by: Liming Gao Cc: Hao A Wu --- MdeModulePkg/MdeModulePkg.dsc | 19 --- 1 file changed, 19 deletions(-) diff --git a/MdeModulePkg/MdeModulePkg.dsc b/MdeModulePkg/

[edk2-devel] [Patch] BaseTools: Update Conf/target.template with the default EmulatorPkg.dsc

2019-05-21 Thread Liming Gao
Nt32Pkg has been removed. The default platform is changed to EmulatorPkg.dsc. Signed-off-by: Liming Gao Cc: Bob Feng --- BaseTools/Conf/target.template | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/BaseTools/Conf/target.template b/BaseTools/Conf/target.template index d

Re: [edk2-devel] [Patch] BaseTools: Remove './SecMain' from 'run' target

2019-05-21 Thread Liming Gao
Bob: Because NT32 has been removed, this change should be OK. Reviewed-by: Liming Gao Thanks Liming > -Original Message- > From: Feng, Bob C > Sent: Friday, May 10, 2019 3:34 PM > To: Gao, Liming ; devel@edk2.groups.io > Cc: Kinney, Michael D > Subject: RE: [Patch] BaseTools: Remove '

Re: [edk2-devel] iSCSI and iBFT

2019-05-21 Thread Tomas Pilar (tpilar)
I am going to commit the cardinal sin of online dev support. 'Never mind, found the problem' From: Tomas Pilar Sent: 20 May 2019 16:57 To: 'devel@edk2.groups.io' Subject: iSCSI and iBFT Hi, I have a bit of an esoteric problem. When I configure the software iscsi intiator that is part of EDK2

[edk2-devel] [Patch V5 edk2-platform 16/18] Platform/PurleyOpenBoardPkg: Update DSC to use NetworkPkg DSC

2019-05-21 Thread Liming Gao
From: Shenglei Zhang This patch updates the platform DSC files to use the include fragment files provided by NetworkPkg. And add network related definition in Purley PlatformPkg.dsc. Cc: Michael A Kubacki Cc: Jiewen Yao Cc: Shifei A Lu Cc: Xiaohu Zhou Signed-off-by: Shenglei Zhang Reviewed-

[edk2-devel] why does RAND_add() take "randomness" as a "double"?

2019-05-21 Thread Laszlo Ersek
(resending, with my subscription to completed) Hi OpenSSL Developers, (cross-posting and ,) OpenSSL commit [1] changed the representation of the "entropy amount" -- later renamed to "randomess" in [2] -- from "int" to "double". I've read the commit message: commit 853f757ecea74a271a7c5cdee3f3

[edk2-devel] [PATCH] BaseTools: Add a checking for Sources section in INF file

2019-05-21 Thread Christian Rodriguez
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1804 In the Edk2 INF spec 3.9, it states, All HII Unicode format files must be listed in [Sources] section. Add a check to see if [Sources] section lists all the "source" type files of a module. Performance impact should be minimal with this patch

Re: [edk2-devel] [PATCH edk2-platforms V3 04/18] Hisilicon/D05: Update DSC/FDF to use NetworkPkg DSC/FDF

2019-05-21 Thread Liming Gao
Leif: The unnecessary change is caused by the line ending. I send the new version patch. Please help review it. On version info, I agree not to add them in the commit message. We can describe them in the cover letter so that people know what changes in this version. Thanks Liming > -

Re: [edk2-devel] [PATCH v4 0/7] CryptoPkg: Upgrade OpenSSL to 1.1.1b

2019-05-21 Thread Ard Biesheuvel
On Tue, 21 May 2019 at 13:23, Laszlo Ersek wrote: > > Hi, > > On 05/21/19 11:09, Wang, Jian J wrote: > > Ard, > > > >> -Original Message- > >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ard > >> Biesheuvel > >> Sent: Tuesday, May 21, 2019 5:02 PM > >> To: Wang, J

[edk2-devel] [Patch edk2-platform V4 17/18] Platform/MinPlatformPkg: Update DSC to use NetworkPkg DSC.

2019-05-21 Thread Liming Gao
From: Shenglei Zhang This patch updates the DSC file to use the include fragment files provided by NetworkPkg. And add network related definition in CoreCommonLib.dsc. Cc: Michael A Kubacki Cc: Jiewen Yao Cc: Shifei A Lu Cc: Xiaohu Zhou Signed-off-by: Shenglei Zhang Reviewed-by: Michael Kub

[edk2-devel] [Patch edk2-platform V4 16/18] Platform/PurleyOpenBoardPkg: Update DSC to use NetworkPkg DSC

2019-05-21 Thread Liming Gao
From: Shenglei Zhang This patch updates the platform DSC files to use the include fragment files provided by NetworkPkg. And add network related definition in Purley PlatformPkg.dsc. Cc: Michael A Kubacki Cc: Jiewen Yao Cc: Shifei A Lu Cc: Xiaohu Zhou Signed-off-by: Shenglei Zhang Reviewed-

[edk2-devel] [Patch edk2-platform V4 18/18] Platform/AdvancedFeaturePkg: Update DSC/FDF to use NetworkPkg DSC/FDF

2019-05-21 Thread Liming Gao
From: Shenglei Zhang This patch updates the platform DSC/FDF files to use the include fragment files provided by NetworkPkg. And add network related definition in CoreAdvancedDxeInclude.dsc/fdf. Cc: Michael A Kubacki Cc: Jiewen Yao Cc: Shifei A Lu Cc: Xiaohu Zhou Signed-off-by: Shenglei Zhan

[edk2-devel] [Patch edk2-platform V4 12/18] Silicon/Armada7k8k: Update DSC/FDF to use NetworkPkg DSC/FDF

2019-05-21 Thread Liming Gao
From: Shenglei Zhang This patch updates the platform DSC/FDF files to use the include fragment files provided by NetworkPkg. Cc: Leif Lindholm Signed-off-by: Shenglei Zhang --- Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc| 8 Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc

[edk2-devel] [Patch edk2-platform V4 04/18] Hisilicon/D05: Update DSC/FDF to use NetworkPkg DSC/FDF

2019-05-21 Thread Liming Gao
From: Shenglei Zhang This patch updates the platform DSC/FDF files to use the include fragment files provided by NetworkPkg. Cc: Leif Lindholm Signed-off-by: Shenglei Zhang --- Platform/Hisilicon/D05/D05.dsc | 45 ++--- Platform/Hisilicon/D05/D05.fdf |

[edk2-devel] [Patch edk2-platform V4 06/18] Hisilicon/HiKey: Update DSC/FDF to use NetworkPkg DSC/FDF

2019-05-21 Thread Liming Gao
From: Shenglei Zhang This patch updates the platform DSC/FDF files to use the include fragment files provided by NetworkPkg. Signed-off-by: Shenglei Zhang Reviewed-by: Leif Lindholm --- Platform/Hisilicon/HiKey/HiKey.dsc | 26 ++ Platform/Hisilicon/HiKey/HiKey.fdf | 10

[edk2-devel] [Patch edk2-platform V4 15/18] Platform/Vlv2TbltDevicePkg: Update DSC/FDF to use NetworkPkg DSC/FDF.

2019-05-21 Thread Liming Gao
From: Shenglei Zhang This patch updates the platform DSC/FDF files to use the include fragment files provided by NetworkPkg. Cc: Zailiang Sun Cc: Yi Qian Signed-off-by: Shenglei Zhang Reviewed-by: Zailiang Sun --- Platform/Intel/Vlv2TbltDevicePkg/PlatformPkg.fdf | 24 ++--

[edk2-devel] [Patch edk2-platform V4 08/18] Platform/CelloBoard: Update DSC/FDF to use NetworkPkg DSC/FDF

2019-05-21 Thread Liming Gao
From: Shenglei Zhang This patch updates the platform DSC/FDF files to use the include fragment files provided by NetworkPkg. Signed-off-by: Shenglei Zhang Reviewed-by: Leif Lindholm --- Platform/LeMaker/CelloBoard/CelloBoard.dsc | 28 Platform/LeMaker/CelloBoard/C

[edk2-devel] [Patch edk2-platform V4 02/18] Platform/VExpressPkg: Update DSC/FDF to use NetworkPkg DSC/FDF

2019-05-21 Thread Liming Gao
From: Shenglei Zhang This patch updates the platform DSC/FDF files to use the include fragment files provided by NetworkPkg. Signed-off-by: Shenglei Zhang Reviewed-by: Leif Lindholm --- Platform/ARM/VExpressPkg/ArmVExpress-networking.fdf.inc | 12 +--- Platform/ARM/VExpressPkg/ArmVExp

[edk2-devel] [Patch edk2-platform V4 00/18] Add Network's include segment files in DSC/FDF

2019-05-21 Thread Liming Gao
We have plan to move all network related modules/libraries to NetworkPkg. So in order to make these changes happen smoothly, We update platforms' DSC/FDF to use Network's include segment files. v2:1.Add Contributed-under tag in all patches,based on current edk2/master. 2.Modify changes in part

[edk2-devel] [Patch edk2-platform V4 10/18] Platform/SynQuacerEvalBoard: Update DSC/FDF to use NetworkPkg DSC/FDF

2019-05-21 Thread Liming Gao
From: Shenglei Zhang This patch updates the platform DSC/FDF files to use the include fragment files provided by NetworkPkg. Cc: Leif Lindholm Signed-off-by: Shenglei Zhang Reviewed-by: Leif Lindholm --- Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 35 -

[edk2-devel] [Patch edk2-platform V4 13/18] Platform/SgiPkg: Update FDF to use NetworkPkg FDF

2019-05-21 Thread Liming Gao
From: Shenglei Zhang This patch updates the platform FDF files to use the include fragment files provided by NetworkPkg. Signed-off-by: Shenglei Zhang Reviewed-by: Leif Lindholm --- Platform/ARM/SgiPkg/SgiPlatform.fdf | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --

[edk2-devel] [Patch edk2-platform V4 14/18] Platform/RDKQemu: Update DSC to use NetworkPkg DSC.

2019-05-21 Thread Liming Gao
From: Shenglei Zhang This patch updates the platform DSC files to use the include fragment files provided by NetworkPkg. Signed-off-by: Shenglei Zhang Reviewed-by: Leif Lindholm --- Platform/Comcast/RDKQemu/RDKQemu.dsc | 34 ++ 1 file changed, 10 insertions(+),

[edk2-devel] [Patch edk2-platform V4 11/18] Platform/Overdrive1000Board: Update DSC/FDF to use NetworkPkg DSC/FDF

2019-05-21 Thread Liming Gao
From: Shenglei Zhang This patch updates the platform DSC/FDF files to use the include fragment files provided by NetworkPkg. Signed-off-by: Shenglei Zhang Reviewed-by: Leif Lindholm --- Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 27 +-- Platform/Sof

[edk2-devel] [Patch edk2-platform V4 07/18] Hisilicon/HiKey960: Update DSC/FDF to use NetworkPkg DSC/FDF

2019-05-21 Thread Liming Gao
From: Shenglei Zhang This patch updates the platform DSC/FDF files to use the include fragment files provided by NetworkPkg. Signed-off-by: Shenglei Zhang Reviewed-by: Leif Lindholm --- Platform/Hisilicon/HiKey960/HiKey960.dsc | 25 ++--- Platform/Hisilicon/HiKey960/HiKey9

[edk2-devel] [Patch edk2-platform V4 09/18] Platform/DeveloperBox: Update DSC/FDF to use NetworkPkg DSC/FDF

2019-05-21 Thread Liming Gao
From: Shenglei Zhang This patch updates the platform DSC/FDF files to use the include fragment files provided by NetworkPkg. Signed-off-by: Shenglei Zhang Reviewed-by: Leif Lindholm --- Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 29 +++-- Platform/Socionext/De

[edk2-devel] [Patch edk2-platform V4 03/18] Hisilicon/D03: Update DSC/FDF to use NetworkPkg DSC/FDF

2019-05-21 Thread Liming Gao
From: Shenglei Zhang This patch updates the platform DSC/FDF files to use the include fragment files provided by NetworkPkg. Signed-off-by: Shenglei Zhang Reviewed-by: Leif Lindholm --- Platform/Hisilicon/D03/D03.dsc | 26 +++--- Platform/Hisilicon/D03/D03.fdf | 10 +--

[edk2-devel] [Patch edk2-platform V4 05/18] Hisilicon/D06: Update DSC/FDF to use NetworkPkg DSC/FDF

2019-05-21 Thread Liming Gao
From: Shenglei Zhang This patch updates the platform DSC/FDF files to use the include fragment files provided by NetworkPkg. Signed-off-by: Shenglei Zhang Reviewed-by: Leif Lindholm --- Platform/Hisilicon/D06/D06.dsc | 42 ++ Platform/Hisilicon/D06/D06.

[edk2-devel] [Patch edk2-platform V4 01/18] Platform/OverdriveBoard: Update DSC/FDF to use NetworkPkg DSC/FDF

2019-05-21 Thread Liming Gao
From: Shenglei Zhang This patch updates the platform DSC/FDF files to use the include fragment files provided by NetworkPkg. Signed-off-by: Shenglei Zhang Reviewed-by: Leif Lindholm --- Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 31 +-- Platform/AMD/Overdriv

Re: [edk2-devel] [PATCH v4 0/7] CryptoPkg: Upgrade OpenSSL to 1.1.1b

2019-05-21 Thread Laszlo Ersek
On 05/21/19 15:02, Wang, Jian J wrote: >> -Original Message- >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >> Laszlo Ersek >> Sent: Tuesday, May 21, 2019 8:24 PM >> To: Wang, Jian J ; devel@edk2.groups.io; >> ard.biesheu...@linaro.org >> Cc: Lu, XiaoyuX ; Ye, Ting

Re: [edk2-devel] [PATCH edk2-platforms V3 10/18] Platform/SynQuacerEvalBoard: Update DSC/FDF to use NetworkPkg DSC/FDF

2019-05-21 Thread Liming Gao
Leif: > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Leif > Lindholm > Sent: Tuesday, May 21, 2019 7:59 PM > To: Zhang, Shenglei > Cc: devel@edk2.groups.io > Subject: Re: [edk2-devel] [PATCH edk2-platforms V3 10/18] > Platform/SynQuacerEvalB

Re: [edk2-devel] [PATCH edk2-platforms V3 12/18] Silicon/Armada7k8k: Update DSC/FDF to use NetworkPkg DSC/FDF

2019-05-21 Thread Liming Gao
Leif: > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Leif > Lindholm > Sent: Tuesday, May 21, 2019 8:04 PM > To: Zhang, Shenglei > Cc: devel@edk2.groups.io > Subject: Re: [edk2-devel] [PATCH edk2-platforms V3 12/18] Silicon/Armada7k8k: > Upd

Re: [edk2-devel] [PATCH v4 0/7] CryptoPkg: Upgrade OpenSSL to 1.1.1b

2019-05-21 Thread Wang, Jian J
Laszlo, > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Laszlo Ersek > Sent: Tuesday, May 21, 2019 8:24 PM > To: Wang, Jian J ; devel@edk2.groups.io; > ard.biesheu...@linaro.org > Cc: Lu, XiaoyuX ; Ye, Ting ; Leif > Lindholm ; Gao, Liming >

[edk2-devel] why does RAND_add() take "randomness" as a "double"?

2019-05-21 Thread Laszlo Ersek
Hi OpenSSL Developers, (cross-posting and ,) OpenSSL commit [1] changed the representation of the "entropy amount" -- later renamed to "randomess" in [2] -- from "int" to "double". I've read the commit message: commit 853f757ecea74a271a7c5cdee3f3b5fe0d3ae863 Author: Bodo Möller Date: Sat Feb

Re: [edk2-devel] [PATCH v4 0/7] CryptoPkg: Upgrade OpenSSL to 1.1.1b

2019-05-21 Thread Laszlo Ersek
Hi, On 05/21/19 11:09, Wang, Jian J wrote: > Ard, > >> -Original Message- >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ard >> Biesheuvel >> Sent: Tuesday, May 21, 2019 5:02 PM >> To: Wang, Jian J >> Cc: devel@edk2.groups.io; Laszlo Ersek ; Lu, XiaoyuX >> ; Ye,

Re: [edk2-devel] [PATCH edk2-platforms V3 12/18] Silicon/Armada7k8k: Update DSC/FDF to use NetworkPkg DSC/FDF

2019-05-21 Thread Leif Lindholm
On Mon, May 20, 2019 at 03:07:23PM +0800, Shenglei Zhang wrote: > This patch updates the platform DSC/FDF files to use the include fragment > files provided by NetworkPkg. > > v2:Remove the definitions from Armada7k8k.dsc.inc to Armada70x0Db.dsc, >Armada80x0Db.dsc and Armada80x0McBin.dsc. Ver

Re: [edk2-devel] [PATCH edk2-platforms V3 10/18] Platform/SynQuacerEvalBoard: Update DSC/FDF to use NetworkPkg DSC/FDF

2019-05-21 Thread Leif Lindholm
On Mon, May 20, 2019 at 03:07:21PM +0800, Shenglei Zhang wrote: > This patch updates the platform DSC/FDF files to use the include fragment > files provided by NetworkPkg. > > v2: Change Network.dsc.inc to Network.fdf.inc in SynQuacerEvalBoard.fdf. Any notes on changes go under the "---" line bel

Re: [edk2-devel] [PATCH edk2-platforms V3 04/18] Hisilicon/D05: Update DSC/FDF to use NetworkPkg DSC/FDF

2019-05-21 Thread Leif Lindholm
On Mon, May 20, 2019 at 03:07:15PM +0800, Shenglei Zhang wrote: > This patch updates the platform DSC/FDF files to use the include fragment > files provided by NetworkPkg. > > v2: Withdraw unrelated changes. Any comments on changes since previous patch go underneath the "---" line below - they do

[edk2-devel] [PATCH V2] UefiCpuPkg CpuCommFeaturesLib: Reduce to set MSR_IA32_CLOCK_MODULATION

2019-05-21 Thread Zeng, Star
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1810 This patch covers two problems. 1. Current code gets CPUID_THERMAL_POWER_MANAGEMENT in ClockModulationInitialize() and uses its ECMD bit for all processors. But ClockModulationInitialize() is only executed by BSP, that means the bit is just

Re: [edk2-devel] [PATCH v4 0/7] CryptoPkg: Upgrade OpenSSL to 1.1.1b

2019-05-21 Thread Wang, Jian J
Ard, > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ard > Biesheuvel > Sent: Tuesday, May 21, 2019 5:02 PM > To: Wang, Jian J > Cc: devel@edk2.groups.io; Laszlo Ersek ; Lu, XiaoyuX > ; Ye, Ting ; Leif Lindholm > ; Gao, Liming > Subject: Re: [

Re: [edk2-devel] [PATCH v4 0/7] CryptoPkg: Upgrade OpenSSL to 1.1.1b

2019-05-21 Thread Ard Biesheuvel
On Tue, 21 May 2019 at 09:43, Wang, Jian J wrote: > > Hi Ard, > > Any comments? > > Regards, > Jian > > > -Original Message- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Wang, > > Jian J > > Sent: Monday, May 20, 2019 9:41 AM > > To: devel@edk2.groups.io; ard.b

Re: [edk2-devel] [PATCH] IntelFrameworkModulePkg/DebugLib: Fix string copy issue

2019-05-21 Thread Wu, Hao A
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Gao, Zhichao > Sent: Tuesday, May 21, 2019 3:50 PM > To: devel@edk2.groups.io > Cc: Gao, Liming; Wu, Hao A > Subject: [edk2-devel] [PATCH] IntelFrameworkModulePkg/DebugLib: Fix > string copy issue

[edk2-devel] [PATCH] IntelFrameworkModulePkg/DebugLib: Fix string copy issue

2019-05-21 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1826 There is a bug to use AsciiStrCpyS to copy a truncated string. If would cause an assert because the truncated length is always less than the source string length. It should use the AsciiStrnCpyS instead. Cc: Liming Gao Cc: Hao A Wu Signed

Re: [edk2-devel] [PATCH edk2-platforms V3 18/18] Platform/AdvancedFeaturePkg: Update DSC/FDF to use NetworkPkg DSC/FDF

2019-05-21 Thread Zhou, Bowen
Reviewed-by: Xiaohu Zhou -Original Message- From: Zhang, Shenglei Sent: Monday, May 20, 2019 3:07 PM To: devel@edk2.groups.io Cc: Kubacki, Michael A ; Yao, Jiewen ; Lu, Shifei A ; Zhou, Bowen Subject: [PATCH edk2-platforms V3 18/18] Platform/AdvancedFeaturePkg: Update DSC/FDF to use

Re: [edk2-devel] [PATCH v4 0/7] CryptoPkg: Upgrade OpenSSL to 1.1.1b

2019-05-21 Thread Wang, Jian J
Hi Ard, Any comments? Regards, Jian > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Wang, > Jian J > Sent: Monday, May 20, 2019 9:41 AM > To: devel@edk2.groups.io; ard.biesheu...@linaro.org; Laszlo Ersek > > Cc: Lu, XiaoyuX ; Ye, Ting ; Leif