Re: [edk2-devel] [[PATCH v2] 7/7] EmbeddedPkg: Fix DwEmmc driver bugs

> -Original Message- > From: Leif Lindholm > Sent: Friday, May 3, 2019 8:19 PM > To: Loh, Tien Hock > Cc: devel@edk2.groups.io; thlo...@gmail.com; Ard Biesheuvel > > Subject: Re: [[PATCH v2] 7/7] EmbeddedPkg: Fix DwEmmc driver bugs > > On Fri, May 03, 2019 at 11:27:03AM +0800, tien.hock

Re: [edk2-devel] OVMF will not start to build using "OvmfPkg/build.sh -a X64 -n 40"

I see, my gcc version is the default version of Red Hat 7.6: (GCC) 4.8.5. So I use "build -p OvmfPkg/OvmfPkgIa32X64.dsc -a IA32 -a X64 -t GCC48", it succeed. We will wait the bug fix, OvmfPkg/build.sh can recognize the gcc version automatically. Thanks a lot! Thanks, Fan -Original Messa

[edk2-devel] [PATCH] Revert "BaseTools:code of test python module is moved to edksetup"

This reverts commit df7c81b5b219c9aee776baa466dd64c9d318dd80. In commint df7c81b5b219c9,used a function to test python module But the Boolean value of the return value of this function is the opposite of the Correct result, resulting in an unexpected result Cc: Bob Feng Cc: Liming Gao Signed-of

Re: [edk2-devel] OVMF will not start to build using "OvmfPkg/build.sh -a X64 -n 40"

Sure, detailed log attached, no error in make_BaseTools.log, the error occurred in build edk2. After running "build -p OvmfPkg/OvmfPkgIa32X64.dsc -a IA32 -a X64 -t GCC5", error log is edk2_build.log. After running "build -p OvmfPkg/OvmfPkgIa32X64.dsc -a IA32 -a X64", the error is different, erro

Re: [edk2-devel] OVMF will not start to build using "OvmfPkg/build.sh -a X64 -n 40"

You should specify tool chain tag with GCC5. The error message is that "gcc: error: unrecognized command line option '-no-pie'". Seemly, your GCC version is not GCC 5 or high version. What's your GCC compiler version? Please try GCC49 tool chain. The command is "build -p OvmfPkg/OvmfPkgIa32X64

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: BaseSerialPortLib16550: Update Mmio32 to UNI

> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Loh, > Tien Hock > Sent: Tuesday, May 07, 2019 7:08 PM > To: devel@edk2.groups.io; thlo...@gmail.com > Cc: tien.hock.loh; Loh, Tien Hock; Wang, Jian J; Wu, Hao A; Zhu, Yonghong > Subject: [edk2-deve

Re: [edk2-devel] OVMF will not start to build using "OvmfPkg/build.sh -a X64 -n 40"

Farrah: This is the problem in df7c81b5b219c9ae. Patch owner are looking it, then fix it. On build failure, could you share more log? This log doesn't show what compiler error in the driver. Thanks Liming > -Original Message- > From: Chen, Farrah > Sent: Thursday, May 9, 2019 2:19

Re: [edk2-devel] OVMF will not start to build using "OvmfPkg/build.sh -a X64 -n 40"

Glad to know, thanks! Thanks, Fan -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Gary Lin Sent: Thursday, May 9, 2019 2:20 PM To: Chen, Farrah Cc: devel@edk2.groups.io; Hao, Xudong ; Wei, Danmei ; Gao, Liming Subject: Re: [edk2-devel] OVMF

Re: [edk2-devel] OVMF will not start to build using "OvmfPkg/build.sh -a X64 -n 40"

On Thu, May 09, 2019 at 06:04:42AM +, Chen, Farrah wrote: > Hi Gary, > > Thanks a lot, we can build successfully with this method. > BTW, will this patch be merged to upstream? > I already reported the issue to bugzilla of the original patch: https://bugzilla.tianocore.org/show_bug.cgi?id=158

Re: [edk2-devel] OVMF will not start to build using "OvmfPkg/build.sh -a X64 -n 40"

Hi Liming, We have been using " OvmfPkg/build.sh -a X64" for such a long time, ovmf can be built successfully with this method until commit df7c81b5b219c9ae, and in edk2/OvmfPkg/README, it asks me to use " OvmfPkg/build.sh". As Gray's advice, we modified return value of TestUtilModule() in edkse

Re: [edk2-devel] OVMF will not start to build using "OvmfPkg/build.sh -a X64 -n 40"

Hi Gary, Thanks a lot, we can build successfully with this method. BTW, will this patch be merged to upstream? Thanks, Fan -Original Message- From: Gary Lin [mailto:g...@suse.com] Sent: Thursday, May 9, 2019 12:07 PM To: Chen, Farrah Cc: devel@edk2.groups.io; Hao, Xudong ; Wei, Dan

Re: [edk2-devel] [PATCH] BaseTools: Skip .mcb file module in Binary Cache

> > Can we have better way to describe the binary cache? > Yes. Steven provides some wiki pages for it. https://raw.githubusercontent.com/shijunjing/WikiDoc/master/BuildCache/MultipleBuildCache.jpg I agree it sounds a bit confusing. Binary Cache is the legacy name for the current model level b

Re: [edk2-devel] [PATCH] BaseTools: Skip .mcb file module in Binary Cache

Jiewen: > -Original Message- > From: Yao, Jiewen > Sent: Thursday, May 9, 2019 1:13 PM > To: devel@edk2.groups.io; Shi, Steven > Cc: Feng, Bob C ; Gao, Liming ; > Rodriguez, Christian ; > Johnson, Michael > Subject: RE: [edk2-devel] [PATCH] BaseTools: Skip .mcb file module in Binary >

[edk2-devel] [PATCH v2 4/6] CryptoPkg/OpensslLib: Prepare for upgrading OpenSSL

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1089 Disable warning for building OpenSSL_1_1_1b add /wd4132 /wd4700 /wd4310 for Visual Studio in OpensslLib[Crypto].inf add -Wno-error=unused-but-set-variable for GCC in OpensslLib[Crypto].inf Although this option is set in some build environm

[edk2-devel] [PATCH v2 6/6] CryptoPkg/BaseCryptLib: Make HMAC_CTX size backward compatible

From: Xiaoyu Lu Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1089 OpenSSL internally redefines the size of HMAC_CTX at crypto/hmac/hmac_lcl.h(OpenSSL commit e0810e35). We should not use it directly and should remove relevant functions(Hmac*GetContextSize). But for compatiblility, st

[edk2-devel] [PATCH v2 1/6] CryptoPkg/OpensslLib: Modify process_files.pl for upgrading OpenSSL

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1089 OpenSSL configure mechanism use --with-rand-seed=xxx option to configure random number generation. OpenSSL_1_1_0j(74f2d9c1ec5f5510e1d3da5a9f03c28df0977762) we use default --with-rand-seed=os option to for building it. But OpenSSL_1_1_1b(50

[edk2-devel] [PATCH v2 3/6] CryptoPkg/IntrinsicLib: Fix possible unresolved external symbol issue

From: Xiaoyu Lu REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1089 This is for the upcoming upgrade to OpenSSL_1_1_1b Compiler optimization(Visual Studio) may automatically use _ftol2 instead of some type conversion. For example: OpensslLib.lib(drbg_lib.obj) : error LNK2001: unresol

[edk2-devel] [PATCH v2 5/6] CryptoPkg: Upgrade OpenSSL to 1.1.1b

From: Xiaoyu Lu REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1089 Update OpenSSL submodule to OpenSSL_1_1_1b OpenSSL_1_1_1b(50eaac9f3337667259de725451f201e784599687) Run process_files.pl script to regenerate OpensslLib[Crypto].inf and opensslconf.h Remove NO_SYSLOG from OpensslLib[C

[edk2-devel] [PATCH v2 2/6] CryptoPkg/OpensslLib: Exclude unnecessary files in process_files.pl

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1089 When running process_files.py to configure OpenSSL, we can exclude some unnecessary files. This can reduce porting time, compiling time and library size. OpenSSL_1_1_1(1708e3e85b4a8) add a STORE module (crypto/store/*). But UEFI don't use t

Re: [edk2-devel] [PATCH] BaseTools: Skip .mcb file module in Binary Cache

Hi Can we have better way to describe the binary cache? I have 2 concern: 1) we have other type of binary besides MCB. How can we indicate that without update base tool source code ? 2) .inc might be text file, instead of binary. How can we support that? Thank you Yao Jiewen > -Original Me

Re: [edk2-devel] [PATCH V2] IntelSiliconPkg/IntelVTdDxe: Do global invalidation before boot

Reviewed-by: Chasel Chiu > -Original Message- > From: Gao, Zhichao > Sent: Thursday, May 9, 2019 11:34 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Chiu, Chasel ; > Ni, Ray ; Chaganty, Rangasai V > > Subject: [PATCH V2] IntelSiliconPkg/IntelVTdDxe: Do global invalidation before >

[edk2-devel] [PATCH] BaseTools: Skip .mcb file module in Binary Cache

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1723 Current Kabylake open platform will build fail if enabled to consume the binary cache, because the binary cache doesn't support to recovery the .mcb microcode file, e.g. m80406E8_0026.mcb, in a platform level folder which is outside of t

[edk2-devel] [Patch 00/16] Vlv2TbltDevicePkg: Sync with edk2/master

Fix a number of small issues for MinnowMax to build and boot with latest edk2/master and to prepare MinnowMax for move to edk2-platforms/master. Cc: Zailiang Sun Cc: Yi Qian Signed-off-by: Michael D Kinney Michael D Kinney (16): Vlv2TbltDevicePkg/PlatformFlashAccessLib: Add error return V

[edk2-devel] [Patch 11/16] Vlv2TbltDevicePkg/Stitch/Gcc: Update default setting binary

Update the binary file that contains the default configuration settings. This file is generated using FCE.exe during a Windows build and this binary file needs to be updated when there are changes to the configuration setting layout or configuration setting default values. Cc: Zailiang Sun Cc: Y

[edk2-devel] [Patch 04/16] Vlv2TbltDevicePkg/PpmPolicy: Fix call to MP Services Protocol

The NumberOfEnabledProcessors parameter to the MP Services Protocol service GetNumberOfProcessors() is not optional and is not allowed to be NULL. Add the CpuEnabledCount local variable and pass it into GetNumberOfProcessors(). Cc: Zailiang Sun Cc: Yi Qian Signed-off-by: Michael D Kinney ---

[edk2-devel] [Patch 05/16] Vlv2TbltDevicePkg/SmBiosMiscDxe: Fix GCC build issue

From: Michael D Kinney Fix loop comparison for end of languages. Cc: Zailiang Sun Cc: Yi Qian Signed-off-by: Michael D Kinney --- .../MiscNumberOfInstallableLanguagesFunction.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/Vlv2TbltDevicePkg/SmBiosMis

[edk2-devel] [Patch 02/16] Vlv2TbltDevicePkg/AcpiPlatform: Change Size type to UINTN

Change the type of the local variable Size in the function AcpiPlatformEntryPoint() from UINT32 to UINTN. This local variable is passed into the function ReadSection() that returns a value of type UINTN. Using type UINT32 can potentially corrupt an adjacent local on the stack. Cc: Zailiang Sun

[edk2-devel] [Patch 10/16] Vlv2TbltDevicePkg: Always enable QuietBoot to produce BGRT

Cc: Zailiang Sun Cc: Yi Qian Signed-off-by: Michael D Kinney --- .../Library/PlatformBdsLib/BdsPlatform.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/Vlv2TbltDevicePkg/Library/PlatformBdsLib/BdsPlatform.c b/Vlv2TbltDevicePkg/Library/PlatformBds

[edk2-devel] [Patch 16/16] Vlv2TbltDevicePkg: Update Readme.md

Cc: Zailiang Sun Cc: Yi Qian Signed-off-by: Michael D Kinney --- Vlv2TbltDevicePkg/Readme.md | 232 +--- 1 file changed, 190 insertions(+), 42 deletions(-) diff --git a/Vlv2TbltDevicePkg/Readme.md b/Vlv2TbltDevicePkg/Readme.md index 139aa4ea61..647d0ba361 100644

[edk2-devel] [Patch 09/16] Vlv2TbltDevicePkg: Add PchInitSmm module

Add the PcdInitSmm module that should not have been removed. This module performs actions at Exit Boot Services to place devices in an OS compatible state. Wothout this module, so versions of Linux are not bootable. Cc: Zailiang Sun Cc: Yi Qian Signed-off-by: Michael D Kinney --- Vlv2TbltDevi

[edk2-devel] [Patch 13/16] Vlv2TbltDevicePkg/Capsule: Do not clear UEFI varstore

Preserve the UEFI Variable store when a capsule update is performed. UEFI Variables are used to store firmware version information for the sample devices (Red, Green, Blue). Cc: Zailiang Sun Cc: Yi Qian Signed-off-by: Michael D Kinney --- .../Feature/Capsule/Library/FmpDeviceLib/FmpDeviceLib.

[edk2-devel] [Patch 12/16] Vlv2TbltDevicePkg: Remove directory assumptions from build scripts

In preparation for moving Vlv2TbltDevicePkg to the edk2-platforms repository, the batch scripts used to build this platform are updated to not make any assumptions about the directory location of Vlv2TbltDevicePkg. Cc: Zailiang Sun Cc: Yi Qian Signed-off-by: Michael D Kinney --- Vlv2TbltDevice

[edk2-devel] [Patch 01/16] Vlv2TbltDevicePkg/PlatformFlashAccessLib: Add error return

If the FLASH device cannot be erased or written, then the flag FlashError is set to TRUE. Add the missing logic to return an error if FlashError is TRUE. The missing logic was found from a GCC build that noticed a local variable was declared and assigned, but was not being used. Cc: Zailiang Sun

[edk2-devel] [Patch 15/16] Vlv2TbltDevicePkg/Capsule: Add Linux/LVFS generation scripts

Add batch scripts to generate the LVFS compatible capsule update driver. Add DSC/FDF files to build capsules and invoke post build shell scripts for Linux build environments. Make versions consistent. Cc: Zailiang Sun Cc: Yi Qian Signed-off-by: Michael D Kinney --- .../Capsule/GenerateCapsul

[edk2-devel] [Patch 14/16] Vlv2TbltDevicePkg/Capsule: Remove path to openssl tools

Remove path to openssl tools from batch scripts. Instead, the path to the openssl tools must be included in PATH for a build to complete. Cc: Zailiang Sun Cc: Yi Qian Signed-off-by: Michael D Kinney --- .../Feature/Capsule/GenerateCapsule/GenCapsuleMinnowMax.bat | 2 -- .../Capsule/Genera

[edk2-devel] [Patch 06/16] Vlv2TbltDevicePkg: Find UEFI Shell using gUefiShellFileGuid

Remove use of PCD PcdShellFile from the IntelFrameworkModulePkg and instead use gUefiShellFileGuid to find the UEFI Shell in an FV. Cc: Zailiang Sun Cc: Yi Qian Signed-off-by: Michael D Kinney --- Vlv2TbltDevicePkg/Library/PlatformBdsLib/BdsPlatform.c | 4 ++-- .../Library/PlatformBdsLib/Pla

[edk2-devel] [Patch 08/16] Vlv2TbltDevicePkg: Use CpuDxe from UefiCpuPkg

Use CpuDxe module from UefiCPuPkg instead of pre-built binary module MpCpu. Cc: Zailiang Sun Cc: Yi Qian Signed-off-by: Michael D Kinney --- Vlv2TbltDevicePkg/PlatformPkg.fdf | 2 +- Vlv2TbltDevicePkg/PlatformPkgGcc.fdf| 2 +- Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 8 ++--

[edk2-devel] [Patch 07/16] Vlv2TbltDevicePkg: Build full UEFI Shell from sources

Update DSC files to build full UEFI Shell from sources. Cc: Zailiang Sun Cc: Yi Qian Signed-off-by: Michael D Kinney --- Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 20 ++-- Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 22 ++ Vlv2TbltDevicePkg/PlatformPkgX64.dsc

[edk2-devel] [Patch 03/16] Vlv2TbltDevicePkg/AcpiPlatform: Add variable protocols to depex

Add the arch protocols gEfiVariableArchProtocolGuid and gEfiVariableWriteArchProtocolGuid to the dependency expression for the AcpiPlatform module to guarantee that the variables that AcpiPlatform depends upon are set before they are used by this module. Cc: Zailiang Sun Cc: Yi Qian Signed-off-b

Re: [edk2-devel] [PATCH 0/2] Add batch option to support build Binary Cache

Hi Liming, User can override the BinCache by set BINARY_CACHE_PATH environment variable, see below code in the patch. The BinCache is only used if user doesn't set the binary cache path variable. +@if not defined BINARY_CACHE_PATH ( + echo Info: BINARY_CACHE_PATH is empty, use BinCache as defau

Re: [edk2-devel] OVMF will not start to build using "OvmfPkg/build.sh -a X64 -n 40"

On Thu, May 09, 2019 at 03:29:09AM +, Chen, Farrah wrote: > Yes, thanks, my return value is 1. > And how can we build ovmf correctlly? The build steps have been updated? > You can tweak TestUtilModule() in edksetup.sh like this: function TestUtilModule() { if ( $PYTHON_COMMAND -c "import

Re: [edk2-devel] [PATCH V2] BaseTools:improve code to support C files with .C suffixes

I agree with your point. I'll not push this patch to edk2 master. So far I've seen there is only one file with extension ".C" in one platform package. I've asked the owner to change it to lower case ".c". I enter an BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1790 to clean up the ".C" su

[edk2-devel] [PATCH 1/1] EmbeddedPkg: Send command when MMC ask for response

From: "Tien Hock, Loh" Send command when MMC ask for response in DwEmmcReceiveResponse, and command is a pending command (eg. DMA needs to be set up first) Signed-off-by: "Tien Hock, Loh" Cc: Leif Lindholm Cc: Ard Biesheuvel --- EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c | 9 - 1 file

Re: [edk2-devel] [[PATCH v2] 5/7] EmbeddedPkg: Fix DwEmmc driver bugs

> -Original Message- > From: Leif Lindholm > Sent: Friday, May 3, 2019 8:11 PM > To: Loh, Tien Hock > Cc: devel@edk2.groups.io; thlo...@gmail.com; Ard Biesheuvel > > Subject: Re: [[PATCH v2] 5/7] EmbeddedPkg: Fix DwEmmc driver bugs > > On Fri, May 03, 2019 at 11:27:01AM +0800, tien.hock

Re: [edk2-devel] [PATCH 0/2] Add batch option to support build Binary Cache

Steven: Could you let user specify BinCache directory instead of hard code name? Thanks Liming > -Original Message- > From: Shi, Steven > Sent: Thursday, May 9, 2019 11:21 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Lu, Shifei A > ; Gao, Liming ; Bi, Dandan > ; Kubacki, Michael A

Re: [edk2-devel] OVMF will not start to build using "OvmfPkg/build.sh -a X64 -n 40"

Fan: The below is my step to build OvmfIa32X64. I don't try OvmfPkg/build.sh 1. . edksetup.sh 2. cd BaseTools, type make 3. cd .. 4. build -p OvmfPkg/OvmfPkgIa32X64.dsc -a IA32 -a X64 -t GCC5 Thanks Liming > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] O

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg: Display VENDOR_ID in ASCII when parsing PPTT

The patch looks good for me. And make the Vender Id to be ASCII format make more sense than hex data format depend on the info in https://uefi.org/ACPI_ID_List?search. I'd like to test it on some real open platform. But seems most platforms do not install PPTT. By the way I can't 'am' your patch

Re: [edk2-devel] [PATCH V2] IntelSiliconPkg/IntelVTdDxe: Do global invalidation before boot

Reviewed-by: jiewen@intel.com > -Original Message- > From: Gao, Zhichao > Sent: Wednesday, May 8, 2019 8:34 PM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Chiu, Chasel > ; Ni, Ray ; Chaganty, Rangasai V > > Subject: [PATCH V2] IntelSiliconPkg/IntelVTdDxe: Do global invalidation > b

[edk2-devel] [PATCH V2] IntelSiliconPkg/IntelVTdDxe: Do global invalidation before boot

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1547 V2: Abandon V1. Do global invalidation of context-cache and IOTLB at ExitBootServices. V1: Only doing IOTLB invalidation would cause a BSOD 'DRIVER_VERIFIER_DMA_VIOLATION' while changing the second level page entry's attributes. So always d

Re: [edk2-devel] [Patch][edk2-platform] Migrate devel-MinPlatform branch to master branch

Hi, all I don't get the rejection on this change. Leif gives some comments. They don't block this migration. They can be resolved after this migration. Today, I update https://github.com/lgao4/edk2-platforms/tree/master_minplatform based on the latest edk2 platform master and devel-MinPlatf

Re: [edk2-devel] OVMF will not start to build using "OvmfPkg/build.sh -a X64 -n 40"

Yes, thanks, my return value is 1. And how can we build ovmf correctlly? The build steps have been updated? [vmm@vmm-build edk2]$ OvmfPkg/build.sh -a X64 -n 40 Initializing workspace /home/fan/edk2/BaseTools Loading previous configuration from /home/fan/edk2/Conf/BuildEnv.sh WORKSPACE: /home/fan/e

[edk2-devel] [PATCH 2/2] PurleyOpenBoardPkg/BoardMtOlympus: Extend build to support Binary Cache

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1785 Extend the options in the Purley build batch file to support Binary Cache produce and consume switch. --- .../PurleyOpenBoardPkg/BoardMtOlympus/bld.bat | 18 -- .../BoardMtOlympus/prebuild.bat| 4 ++-- 2 fil

[edk2-devel] [PATCH 1/2] KabylakeOpenBoardPkg/KabylakeRvp3: Extend build to support Binary Cache

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1784 Need extend the options in the Kabylake build bld.bat file to support Binary Cache. --- .../KabylakeOpenBoardPkg/KabylakeRvp3/bld.bat | 24 +-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/Platform/Intel/Kab

Re: [edk2-devel] OVMF will not start to build using "OvmfPkg/build.sh -a X64 -n 40"

On Thu, May 09, 2019 at 02:31:13AM +, Chen, Farrah wrote: > Hi, > > We build the latest OVMF and found that it doesn't start to build using > "OvmfPkg/build.sh -a X64 -n 40" actually. > > Step: > git clone https://github.com/tianocore/edk2.git > cd edk2 > git submodule init > git submodule

[edk2-devel] [PATCH 0/2] Add batch option to support build Binary Cache

This patch serial is to extend the options in the Kabylake and Purley build batch file to support build Binary Cache produce and consume switch. Steven Shi (2): KabylakeOpenBoardPkg/KabylakeRvp3: Extend build to support Binary Cache PurleyOpenBoardPkg/BoardMtOlympus: Extend build to suppo

[edk2-devel] [PATCH 1/1] EmbeddedPkg: Fix DwEmmc CMD8 support for SD

From: "Tien Hock, Loh" On CMD8, for SD, the controller should not expect data as this is a SEND_IF_COND command to verify SD operating condition, and does not have data. Signed-off-by: Tien Hock, Loh Cc: Leif Lindholm Cc: Ard Biesheuvel -- v2 - Change IsEmmc to EFI_MMC_HOST_CARD_TYPE --- Em

Re: [edk2-devel] [Patch v2 1/3] SecurityPkg/SecurityPkg.dec: Change default value.

> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Dong, > Eric > Sent: Wednesday, May 08, 2019 11:02 AM > To: devel@edk2.groups.io > Cc: Wu, Hao A > Subject: [edk2-devel] [Patch v2 1/3] SecurityPkg/SecurityPkg.dec: Change > default value. Just one

Re: [edk2-devel] [Patch v2 3/3] SecurityPkg/OpalPassword: Fix "Enable Feature" Menu disappear issue.

> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Dong, > Eric > Sent: Wednesday, May 08, 2019 11:02 AM > To: devel@edk2.groups.io > Cc: Wu, Hao A > Subject: [edk2-devel] [Patch v2 3/3] SecurityPkg/OpalPassword: Fix "Enable > Feature" Menu disappea

Re: [edk2-devel] [Patch v2 2/3] SecurityPkg/OpalPassword: Change send BlockSID policy.

> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Dong, > Eric > Sent: Wednesday, May 08, 2019 11:02 AM > To: devel@edk2.groups.io > Cc: Wu, Hao A > Subject: [edk2-devel] [Patch v2 2/3] SecurityPkg/OpalPassword: Change send > BlockSID policy. > >

[edk2-devel] OVMF will not start to build using "OvmfPkg/build.sh -a X64 -n 40"

Hi, We build the latest OVMF and found that it doesn't start to build using "OvmfPkg/build.sh -a X64 -n 40" actually. Step: git clone https://github.com/tianocore/edk2.git cd edk2 git submodule init git submodule update -recursive OvmfPkg/build.sh -a X64 -n 40 Then it didn't start to build. lo

Re: [edk2-devel] [Patch V2] BaseTools: Correct the value assignment for StructurePcd

Please remove Contributed-under: TianoCore Contribution Agreement 1.1. Please list which test has been done for this change. > -Original Message- > From: Fan, ZhijuX > Sent: Monday, May 6, 2019 10:38 AM > To: devel@edk2.groups.io > Cc: Gao, Liming > Subject: [Patch V2] BaseTools: Correc

Re: [edk2-devel] [Patch] BaseTools: Fix the issue that build report missing Module Size

Reviewed-by: Liming Gao > -Original Message- > From: Feng, Bob C > Sent: Wednesday, May 8, 2019 5:47 PM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming > Subject: [Patch] BaseTools: Fix the issue that build report missing Module > Size > > BZ: https://bugzilla.tianocore.org/

Re: [edk2-devel] [PATCH 0/2] Retire CorebootModulePkg and CorebootPayloadPkg

This patchset looks good me. Reviewed-by: Maurice Ma Regards, Maurice > -Original Message- > From: Dong, Guo > Sent: Tuesday, May 7, 2019 15:27 > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Agyeman, Prince > ; You, Benjamin ; > Dong, Guo > Subject: [edk2-devel] [PATCH 0/2] Retire Core

Re: [edk2-devel] [edk2-platforms] [patch v2 0/7] Update UefiDecompressLib instance

> -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Thursday, May 9, 2019 2:02 AM > To: Bi, Dandan > Cc: devel@edk2.groups.io; Ard Biesheuvel ; > Kinney, Michael D > Subject: Re: [edk2-platforms] [patch v2 0/7] Update UefiDecompressLib > instance > > On

Re: [edk2-devel] tool chain tag setting for vs2017

From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of "徐林 Sent: Wednesday, May 8, 2019 11:49 PM To: Leif Lindholm ; devel ; pete Subject: Re: [edk2-devel] tool chain tag setting for vs2017 > >On Wed, May 08, 2019 at 03:44:45PM +0100, Pete Batard wrote: >> On 2019.05.08 13:16,

Re: [edk2-devel] [edk2-platforms: PATCH v2 0/4] Armada 7k8k network improvements

śr., 8 maj 2019 o 19:52 Leif Lindholm napisał(a): > > On Mon, May 06, 2019 at 04:37:03AM +0200, Marcin Wojtas wrote: > > Hi, > > > > The second version of the patchset addresses all comments from > > v1 review. Details can be found in a changelog below. > > > > The purpose of this patchset is to f

[edk2-devel] [PATCH] Marvell/Drivers: MvFvbDxe: Fix compilation error

Commit cee103d37d6b ("Marvell/Drivers: MvFvbDxe: Introduce non-mmio mode) introduced a compilation error, visible with certain toolchains. Fix that. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c | 4 +---

Re: [edk2-devel][edk2-test][PATCH V2] EFI/Protocol: Fix to use VENDOR_DEVICE_PATH to create the Debug port device node for DevicePath related protocol tests.

On Wed, 2019-05-08 at 10:02 +0800, Nick Wang wrote: > Follow edk2 tree hash: 9343d0a1cd09544686b14dba5b428d7bc811f6b9 to > use VENDOR_DEVICE_PATH to create the Debug port device node. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Nick Wang Reviewed-by: Supreeth Venk

Re: [edk2-devel] [PATCH V2] BaseTools:improve code to support C files with .C suffixes

On 05/08/19 14:08, Leif Lindholm wrote: > Hi Fan Zhiju, > > I understand your reasoning, but that strengthens my view that we > should leave this change out. > > Actually, could we consider *dropping* support for .C files > altogether, since we are striving to support multiple toolchains, and > t

Re: [edk2-devel] [edk2-test] issue in writing SCT test case

+ devel@edk2.groups.io Adding edk2-test to Subject line. Did you add this test case details to SctPkg/Config/Data/Category.ini? Also, John had created a script to generate a n

Re: [edk2-devel] [edk2-platforms] [patch v2 0/7] Update UefiDecompressLib instance

On Wed, May 08, 2019 at 10:00:24AM +0800, Dandan Bi wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1722 > > BaseUefiDecompressLib in MdePkg is the > base UEFI decompress Library. > BaseUefiTianoCustomDecompressLib in MdeModulePkg > implements the base UEFI decompress functionality an

Re: [edk2-devel] [edk2-platforms: PATCH v2 0/4] Armada 7k8k network improvements

On Mon, May 06, 2019 at 04:37:03AM +0200, Marcin Wojtas wrote: > Hi, > > The second version of the patchset addresses all comments from > v1 review. Details can be found in a changelog below. > > The purpose of this patchset is to fix possible hangs when attempting > to PXE boot on unconnected in

Re: [edk2-devel] [patch] ShellBinPkg: Remove ShellBinPkg

Killian, The immediate replacement is to use the link to the edk2-stable tag from March that includes the UEFI Shell binary. https://github.com/tianocore/edk2/tree/edk2-stable201903/ShellBinPkg/UefiShell/X64 There have been discussions that future edk2-stable tags to provide pre-built binaries

Re: [edk2-devel] [Patch V3 0/8] Resolve Quark build and boot issues

Reviewed-by: Kelly Steele > -Original Message- > From: Kinney, Michael D > Sent: April 30, 2019 12:31 > To: devel@edk2.groups.io > Cc: Steele, Kelly ; Gao, Liming > ; Dong, Eric ; Ni, Ray > ; Laszlo Ersek > Subject: [Patch V3 0/8] Resolve Quark build and boot issues > > New in V3 >

Re: [edk2-devel] tool chain tag setting for vs2017

> >On Wed, May 08, 2019 at 03:44:45PM +0100, Pete Batard wrote: >> On 2019.05.08 13:16, xulin wrote: >> > Got it. BTW, do you have plan to support for higher version GCC? Such as >> > GCC8? >> >> Well, I am not speaking for the project as a whole, but past experience >> seems to indic

Re: [edk2-devel] tool chain tag setting for vs2017

On Wed, May 08, 2019 at 03:44:45PM +0100, Pete Batard wrote: > On 2019.05.08 13:16, xulin wrote: > > Got it. BTW, do you have plan to support for higher version GCC? Such as > > GCC8? > > Well, I am not speaking for the project as a whole, but past experience > seems to indicate that support for n

Re: [edk2-devel] tool chain tag setting for vs2017

On 2019.05.08 13:16, xulin wrote: Got it. BTW, do you have plan to support for higher version GCC? Such as GCC8? Well, I am not speaking for the project as a whole, but past experience seems to indicate that support for newer toolchain is added by contributors (which, really, can be anyone) o

Re: [edk2-devel] [PATCH V2] BaseTools:improve code to support C files with .C suffixes

On Wed, May 08, 2019 at 06:59:40AM -0700, Andrew Fish wrote: > > > > On May 8, 2019, at 5:08 AM, Leif Lindholm wrote: > > > > Hi Fan Zhiju, > > > > I understand your reasoning, but that strengthens my view that we > > should leave this change out. > > > > Actually, could we consider *dropping

[edk2-devel] [PATCH v1 1/1] DynamicTablesPkg: Add frame number validation to GTDT generator

Added code to check if the Generic Timer Block Structure's frame number provided by the platform repository is within the allowed range (0-7). References: - ACPI 6.2 Errata A, Table 5-122, September 2017 Signed-off-by: Krzysztof Koch --- The changes can be seen at: https://github.com/Krzysztof

Re: [edk2-devel] [PATCH V2] BaseTools:improve code to support C files with .C suffixes

> On May 8, 2019, at 5:08 AM, Leif Lindholm wrote: > > Hi Fan Zhiju, > > I understand your reasoning, but that strengthens my view that we > should leave this change out. > > Actually, could we consider *dropping* support for .C files > altogether, since we are striving to support multiple to

[edk2-devel] [PATCH v1 1/1] ShellPkg: acpiview: Add GT Frame Number validation to GTDT parser

The ACPI 6.2 specification mandates that the Generic Timer (GT) Block Timer Structures must have a frame number in the range 0-7. Update the GTDT parser to warn if this condition is violated. Signed-off-by: Krzysztof Koch --- The changes can be seen at: https://github.com/KrzysztofKoch1/edk2

[edk2-devel] [PATCH v1 1/1] ShellPkg: Display VENDOR_ID in ASCII when parsing PPTT

The ID Type Structure (Type 2) inside the Processor Properties Topology Table (PPTT) has a VENDOR_ID field which identifies the node vendor. The approved values are listed in the ACPI ID Registry and they are meant to be interpreted as arrays of ASCII characters. This change to the acpiview parser

Re: [edk2-devel] tool chain tag setting for vs2017

在 2019年5月8日，下午6:25，Pete Batard 写道：Hi Flynn,On 2019.05.08 09:00, "徐林 wrote:Hey guys,I may found a problem here..I'm trying to build tianocore with visual studio 2017, the tianocore commit id isdf7c81b5b219c9aee776baa466dd64c9d318dd80(Tue Apr 30 10:16:01 2019),after seting up the build environment a

Re: [edk2-devel] [PATCH V2] BaseTools:improve code to support C files with .C suffixes

Hi Fan Zhiju, I understand your reasoning, but that strengthens my view that we should leave this change out. Actually, could we consider *dropping* support for .C files altogether, since we are striving to support multiple toolchains, and the two major families of toolchains we use consider .C f

Re: [edk2-devel] [PATCH] BaseTools:The code used to test python module is moved to edksetup

On Wed, May 08, 2019 at 12:38:24PM +0100, Leif Lindholm wrote: > Hi guys, > > This patch (now committed) break our ci (which runs with 'set -e'). > This seems to be caused by TestUtilModule() returning error (1 - > non-zero) when it actually finds the module, and success (0) when it > does not. >

Re: [edk2-devel] [PATCH] BaseTools:The code used to test python module is moved to edksetup

Hi guys, This patch (now committed) break our ci (which runs with 'set -e'). This seems to be caused by TestUtilModule() returning error (1 - non-zero) when it actually finds the module, and success (0) when it does not. While debugging, I found another side effect that I have not had time to tra

[edk2-devel] [PATCH 1/1] EmbeddedPkg: Add SD command support for DwEmmc

From: "TIen Hock, Loh" Added ACMD6 for SD support. For SD, after CMD55 is sent, the next command should be an application command, which should not expect data Signed-off-by: "Tien Hock, Loh" Cc: Leif Lindholm Cc: Ard Biesheuvel -- v2: - Move IsACmd as a local static variable in function - F

Re: [edk2-devel] [PATCH V2] BaseTools:improve code to support C files with .C suffixes

Hi Leif, This patch is going to fix the bug in commit 05217d210e. this patch and commit 05217d210e is just for MSVC. It doesn't have any effect on GCC. this patch does not imply to compile .C as C instead of C++. We just found out that they build break because the.C file was in the source file,

Re: [edk2-devel] tool chain tag setting for vs2017

Hi Flynn, On 2019.05.08 09:00, " wrote: Hey guys, I may found a problem here.. I'm trying to build tianocore with visual studio 2017, the tianocore commit id is df7c81b5b219c9aee776baa466dd64c9d318dd80(Tue Apr 30 10:16:01 2019), after seting up the build environment and change TOOL_CHAIN

Re: [edk2-devel] [patch] ShellBinPkg: Remove ShellBinPkg

Hi all, does that mean, that SHELL.EFI from a trusted source is currently unavailable for the industry? There are a couple of web sites that refer to “https://github.com/tianocore/edk2/raw/master/ShellBinPkg/UefiShell/X64” (https://www.google.com/search?ei=SUvPXPneNIeFmwXQvo6gAg&q=https%

[edk2-devel] tool chain tag setting for vs2017

Hey guys, I may found a problem here.. I'm trying to build tianocore with visual studio 2017, the tianocore commit id is df7c81b5b219c9aee776baa466dd64c9d318dd80(Tue Apr 30 10:16:01 2019), after seting up the build environment and change TOOL_CHAIN_TAG to VS2017x86 according from https://git

Re: [edk2-devel] RFC for Edk2-Library

On 05/07/19 23:35, Sean via Groups.Io wrote: > RFC Edk2-Library creation > > Create a new tianocore owned repository to host a python library > package in support of UEFI development. This package will allow easy > sharing of python library code to facilitate reuse. Inclusion of this > package a

[edk2-devel] [Patch] BaseTools: Fix the issue that build report missing Module Size

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1786 commit b1e27d changed GENFW output folder from DEBUG to OUTPUT, but that commit missed updating the buildreport.py for FwReportFileName. This patch is going to fix this issue. Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/P

Re: [edk2-devel] [PATCH 4/4] OvmfPkg/PlatformPei: fix MTRR for low-RAM sizes that have many bits clear

Hi Phil, On 05/08/19 09:33, Philippe Mathieu-Daudé wrote: > On 5/4/19 2:07 AM, Laszlo Ersek wrote: >> Assume that we boot OVMF in a QEMU guest with 1025 MB of RAM. The >> following assertion will fire: >> >>> ASSERT_EFI_ERROR (Status = Out of Resources) >>> ASSERT OvmfPkg/PlatformPei/MemDetect.c(6

Re: [edk2-devel] [PATCH V2] BaseTools:improve code to support C files with .C suffixes

On Tue, May 07, 2019 at 07:01:26PM -0700, Andrew Fish wrote: > > > > On May 7, 2019, at 7:40 AM, Leif Lindholm wrote: > > > > Hi Fan Zhiju, > > > > But where does the string come from that contains a .C suffix? > > Is the tool internally converting things to uppercase, or is some > > source fi

Re: [edk2-devel] [PATCH 3/3] ArmPlatformPkg:Delete FrameworkDatabase from ArmPlatformPkg

Hi Thomas, On Wed, May 08, 2019 at 06:11:18AM +, Thomas Abraham wrote: > > We do not use this file and am ok if this is removed. However, I will let > > Thomas confirm this. > > This makefile is not used for ARM platforms (FVP, Juno, SGI, RD) and so > this makefile can be removed. Excellent

Re: [edk2-devel] [PATCH V2 1/6] MdeModulePkg/ResetSystemLib.h: Add useful reset data definition

On 05/08/19 06:49, Zhichao Gao wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1772 > > Add a useful definition of reset data which start with a NULL > string and followed by a EFI_GUID. > > Cc: Jian J Wang > Cc: Hao Wu > Cc: Ray Ni > Cc: Star Zeng > Cc: Liming Gao > Cc: Sean Br

Re: [edk2-devel] [patch 04/11] MdeModulePkg/Core: Remove PcdFrameworkCompatibilitySupport usage

Dandan: I am OK to submit the separate BZ to remove the header definition of EFI_PE32_IMAGE_PROTOCOL. For this patch, the change is good. Reviewed-by: Liming Gao Thanks Liming >-Original Message- >From: Bi, Dandan >Sent: Tuesday, May 07, 2019 3:08 PM >To: Wu, Hao A ; devel@edk2.gr

Re: [edk2-devel] [PATCH v1 1/1 -resend] MdePkg: Add ACPI 6.3 header file

Reviewed-by: Sami Mujawar -Original Message- From: Gao, Liming Sent: 07 May 2019 04:08 PM To: devel@edk2.groups.io; Krzysztof Koch Cc: Sami Mujawar ; nd Subject: RE: [edk2-devel] [PATCH v1 1/1 -resend] MdePkg: Add ACPI 6.3 header file The change is good. Reviewed-by: Liming Gao Th

Re: [edk2-devel] [PATCH 4/4] OvmfPkg/PlatformPei: fix MTRR for low-RAM sizes that have many bits clear

On 5/4/19 2:07 AM, Laszlo Ersek wrote: > Assume that we boot OVMF in a QEMU guest with 1025 MB of RAM. The > following assertion will fire: > >> ASSERT_EFI_ERROR (Status = Out of Resources) >> ASSERT OvmfPkg/PlatformPei/MemDetect.c(696): !EFI_ERROR (Status) > > That's because the range [1025 MB,

  1   2   >