Re: [edk2-devel] [edk2-platforms/devel-MinPlatform] [PATCH v2 1/3] Platform/Intel: Added python build script.

2019-04-19 Thread Nate DeSimone
1. There are PEP8 coding style violations all over. Functions are supposed to be lower case with underscores, same with variables and module names. For example: a. BuildBios.py should be build_bios.py b. def preBuild(buildConfig, buildType="DEBUG", silent=False, toolchain=None) s

[edk2-devel] [Patch] edk2: Remove AppPkg, StdLib, StdLibPrivateInternalFiles

2019-04-19 Thread Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=1734 Remove the following packages and move them to the new edk2-libc repository * AppPkg * StdLib * StdLibPrivateInternalFiles Cc: Jaben Carsey Cc: Daryl McDaniel Signed-off-by: Michael D Kinney --- AppPkg Maintainers.txt

[edk2-devel] [edk2] Request to add new edk2-libc repository

2019-04-19 Thread Michael D Kinney
Hello, There were no objections to the following RFC to add a new edk2-libc repository. https://edk2.groups.io/g/devel/message/35211 I have entered the following Feature Request Bugzilla https://bugzilla.tianocore.org/show_bug.cgi?id=1734 I have posted a version of the edk2-libc reposi

[edk2-devel] [staging/about Patch] Remove reference to Tiano Contributor's Agreement

2019-04-19 Thread Michael D Kinney
Cc: Andrew Fish Cc: Laszlo Ersek Cc: Leif Lindholm Signed-off-by: Michael D Kinney --- README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README b/README index b640a482f9..60f14a654a 100644 --- a/README +++ b/README @@ -27,7 +27,7 @@ Process for creating, using, and mai

[edk2-devel] CryptoPkg maintainers: Gang Wei's email address no longer valid ("Address rejected")?

2019-04-19 Thread rebecca via Groups.Io
Maintainers.txt lists Gang Wei as a reviewer for CryptoPkg, but my email to them was just bounced: : host mga12.intel.com[192.55.52.136] said: 550 #5.1.0 Address rejected. (in reply to RCPT TO command) Do they still work on EDK2? -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links:

[edk2-devel] [PATCH] CryptoPkg: add issetugid declaration to fix openssl build on FreeBSD

2019-04-19 Thread rebecca via Groups.Io
When building OpenSSL, the OpenBSD/FreeBSD/DFBSD code in crypto/uid.c calls issetugid(). Add the declaration of this function to CrtLibSupport.h to avoid the need to patch the openssl code on these platforms. Signed-off-by: Rebecca Cran --- CryptoPkg/Library/Include/CrtLibSupport.h | 1 + 1 file

Re: [edk2-devel] [PATCH resend] MdeModulePkg/EsrtDxe: allocate ESRT table from RtServicesData memory

2019-04-19 Thread Michael D Kinney
Ard, Saw your patch to cache the GUID table. The ESRT Table is not that much bigger, so the algorithm may be simpler if you just make a copy of the ESRT table with the active entries. * 16+24 bytes per ESRT entry. * 16 bytes/entry for just the GUID. The only advantage of checking against the

Re: [edk2-devel] [PATCH resend] MdeModulePkg/EsrtDxe: allocate ESRT table from RtServicesData memory

2019-04-19 Thread Michael D Kinney
Ard, I think skipping the nested check at runtime is a good idea. No need for ESRT at RT and no need to cache GUIDs at EBS. Mike > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Friday, April 19, 2019 11:43 AM > To: Kinney, Michael D > Cc: devel@ed

[edk2-devel] [PATCH] MdeModulePkg/DxeCapsuleLibFmp: avoid ESRT accesses at runtime

2019-04-19 Thread Ard Biesheuvel
The DxeCapsuleLibFmp code accesses the ESRT table to decide whether a certain capsule is an FMP capsule. Since the UEFI spec mandates that the ESRT resides in EfiBootServicesData memory, this results in problems at OS runtime, since the firmware implementation itself cannot access memory that has n

Re: [edk2-devel] [PATCH resend] MdeModulePkg/EsrtDxe: allocate ESRT table from RtServicesData memory

2019-04-19 Thread Ard Biesheuvel
On Fri, 19 Apr 2019 at 20:38, Ard Biesheuvel wrote: > > On Fri, 19 Apr 2019 at 20:23, Kinney, Michael D > wrote: > > > > Ard, > > > > Let's see if we can remove the ESRT access from those > > paths. That would be the better fix. > > > > I am not that familiar with this code, but it seems that th

Re: [edk2-devel] [PATCH resend] MdeModulePkg/EsrtDxe: allocate ESRT table from RtServicesData memory

2019-04-19 Thread Ard Biesheuvel
On Fri, 19 Apr 2019 at 20:23, Kinney, Michael D wrote: > > Ard, > > Let's see if we can remove the ESRT access from those > paths. That would be the better fix. > I am not that familiar with this code, but it seems that the only reason we access the ESRT at runtime is to check whether a capsule

Re: [edk2-devel] [PATCH resend] MdeModulePkg/EsrtDxe: allocate ESRT table from RtServicesData memory

2019-04-19 Thread Michael D Kinney
Ard, Let's see if we can remove the ESRT access from those paths. That would be the better fix. Thanks, Mike > -Original Message- > From: devel@edk2.groups.io > [mailto:devel@edk2.groups.io] On Behalf Of Ard > Biesheuvel > Sent: Friday, April 19, 2019 11:11 AM > To: Kinney, Michael D

Re: [edk2-devel] [PATCH resend] MdeModulePkg/EsrtDxe: allocate ESRT table from RtServicesData memory

2019-04-19 Thread Ard Biesheuvel
On Fri, 19 Apr 2019 at 20:08, Kinney, Michael D wrote: > > Ard, > > Where is the use of ESRT at runtime? > DxeCapsuleLibFmp is invoked at runtime by the UpdateCapsule() and QueryCapsuleCapabilities() code. The Canonical FWTS crashes on this runtime service on some ARM and x86 systems due to this

Re: [edk2-devel] [PATCH resend] MdeModulePkg/EsrtDxe: allocate ESRT table from RtServicesData memory

2019-04-19 Thread Michael D Kinney
Ard, Where is the use of ESRT at runtime? The SetVa conversion of the ESRT table may be an old artifact that we should consider removing. Thanks, Mike > -Original Message- > From: devel@edk2.groups.io > [mailto:devel@edk2.groups.io] On Behalf Of Ard > Biesheuvel > Sent: Friday, April 1

Re: [edk2-devel] [PATCH resend] MdeModulePkg/EsrtDxe: allocate ESRT table from RtServicesData memory

2019-04-19 Thread Ard Biesheuvel
On Fri, 19 Apr 2019 at 19:42, Ard Biesheuvel wrote: > > On Fri, 19 Apr 2019 at 19:36, Michael D Kinney > wrote: > > > > Hi Ard, > > > > The UEFI Specification Section 23.3 says: > > > > "The ESRT shall be stored in memory of type EfiBootServicesData." > > > > If an RT driver needs ESRT in

Re: [edk2-devel] [PATCH resend] MdeModulePkg/EsrtDxe: allocate ESRT table from RtServicesData memory

2019-04-19 Thread Ard Biesheuvel
On Fri, 19 Apr 2019 at 19:36, Michael D Kinney wrote: > > Hi Ard, > > The UEFI Specification Section 23.3 says: > > "The ESRT shall be stored in memory of type EfiBootServicesData." > > If an RT driver needs ESRT info after ExitBootServices(), then the > RT driver should collect that infor

Re: [edk2-devel] [PATCH resend] MdeModulePkg/EsrtDxe: allocate ESRT table from RtServicesData memory

2019-04-19 Thread Michael D Kinney
Hi Ard, The UEFI Specification Section 23.3 says: "The ESRT shall be stored in memory of type EfiBootServicesData." If an RT driver needs ESRT info after ExitBootServices(), then the RT driver should collect that information before ExitBootServices(). Best regards, Mike > -Origina

[edk2-devel] [PATCH resend] MdeModulePkg/EsrtDxe: allocate ESRT table from RtServicesData memory

2019-04-19 Thread Ard Biesheuvel
Given that the firmware itself may access the ESRT table when the OS invokes the UpdateCapsule () boot service, it requires a virtual mapping and so it needs to be allocated from RtServicesData memory. Signed-off-by: Ard Biesheuvel --- MdeModulePkg/Universal/EsrtDxe/EsrtDxe.c | 3 ++- 1 file cha

Re: [edk2-devel] Requestion for LTS version on EDK2

2019-04-19 Thread liyi 00215672
Hi Laszlo, 1. If we could put some human resources into stable-branch(LTS), so could you give us an rough assessment, how many people should we put them into that? :) 2. If we make a stable-branch(LTS) into reality, we can invent some rules, likes one year(or two years) to release a LTS version