[edk2-devel] TianoCore Community Design Meeting Minutes

Hi everyone, In the first design meeting, Matthew and Sean from Microsoft presented the Mu tools. Below are some notes Mike and I captured from the meeting. Please reply to this mail for any questions and comments. Matthew Carlson / Sean Brogan - Microsoft - Project Mu Tools https://edk2.gr

[edk2-devel] TianoCore Design Meeting - APAC/NAMO - Thu, 04/18/2019 6:30pm-7:30pm #cal-reminder

"TianoCore Design Meeting - APAC/NAMO" Reminder When: Thursday, 18 April 2019 6:30pm to 7:30pm (GMT-07:00) America/Los Angeles Where: https://zoom.us/j/969264410 Description: Join Zoom Meeting https://zoom.us/j/969264410 ( https://zoom.us/j/969264410 )   One tap mobile +164655

[edk2-devel] TianoCore Bug Triage - APAC / NAMO - Thu, 04/18/2019 5:00pm-5:30pm #cal-reminder

"TianoCore Bug Triage - APAC / NAMO" Reminder When: Thursday, 18 April 2019 5:00pm to 5:30pm (GMT-07:00) America/Los Angeles Where: https://zoom.us/j/769108409 Description: Join Zoom Meeting https://zoom.us/j/769108409 ( https://zoom.us/j/769108409 )   One tap mobile +17207072

Re: [edk2-devel] Requestion for LTS version on EDK2

On 04/18/19 09:17, liyi 00215672 wrote: > Hi Guys, > Backgroud: If we choose one stable-tag as our own UEFI codebase, however > after 3 years, there are so many new features(but we don't need) will be > added into EDK2 main tree. > > Requestion: Could EDK2 community plan or maintain "LTS version

Re: [edk2-devel] [PATCH 04/10] MdePkg/PiFirmwareFile: fix undefined behavior in FFS_FILE_SIZE

On 04/18/19 10:45, Laszlo Ersek wrote: > Beyond that, I checked the documentation of "-fstrict-aliasing" in the > gcc manual at > . It > provides several examples; one of them is: > >> Similarly, access by taking the address, cas

Re: [edk2-devel] [WebSite Patch] Change preferred license of EDK II to BSD+Patent

On 04/15/19 22:38, Michael D Kinney wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=1656 > > Change the web page documentation to state that the preferred license > of the EDK II is the BSD+Patent License. > > Cc: Andrew Fish > Cc: Laszlo Ersek > Cc: Leif Lindholm > Signed-off-by: Mich

Re: [edk2-devel] [WebSite Patch] Change preferred license of EDK II to BSD+Patent

On 04/18/19 22:27, Kinney, Michael D wrote: > > >> -Original Message- >> From: devel@edk2.groups.io >> [mailto:devel@edk2.groups.io] On Behalf Of Laszlo Ersek >> Sent: Thursday, April 18, 2019 2:14 AM >> To: Kinney, Michael D ; >> devel@edk2.groups.io >> Cc: Andrew Fish ; Leif Lindholm >>

[edk2-devel] [edk2-platforms] [RFC] Migrate devel-MinPlatform branch to master branch

Hello, This RFC proposes moving the content on the devel-MinPlatform branch in the edk2-platforms repository to the master branch in the edk2-platforms repository. The devel-MinPlatform branch has been used for the initial development of an EDK II based platform design referred to as "Minimum Pla

Re: [edk2-devel] [WebSite Patch] Change preferred license of EDK II to BSD+Patent

> -Original Message- > From: devel@edk2.groups.io > [mailto:devel@edk2.groups.io] On Behalf Of Laszlo Ersek > Sent: Thursday, April 18, 2019 2:14 AM > To: Kinney, Michael D ; > devel@edk2.groups.io > Cc: Andrew Fish ; Leif Lindholm > > Subject: Re: [edk2-devel] [WebSite Patch] Change > p

Re: [edk2-devel] [PATCH v2 0/5] patches for some warnings raised by "RH covscan"

Series Reviewed-by: Jordan Justen On 2019-04-18 10:47:05, Laszlo Ersek wrote: > Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1710 > Repo: https://github.com/lersek/edk2.git > Branch: covscan_bz_1710_v2 > > Patch-level updates relative to v1 have been noted on the patches > them

Re: [edk2-devel] [PATCH v2 0/5] patches for some warnings raised by "RH covscan"

Series Reviewed-by: Michael D Kinney > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, April 18, 2019 10:47 AM > To: edk2-devel-groups-io > Cc: Ard Biesheuvel ; Feng, > Bob C ; Justen, Jordan L > ; Gao, Liming > ; Kinney, Michael D > ; Zhu, Yonghong >

Re: [edk2-devel] [PATCH 04/10] MdePkg/PiFirmwareFile: fix undefined behavior in FFS_FILE_SIZE

On 4/18/19 7:59 PM, Kinney, Michael D wrote: > Philippe, > > Comments below. > > Thanks, > > Mike > >> -Original Message- >> From: Philippe Mathieu-Daudé [mailto:phi...@redhat.com] >> Sent: Thursday, April 18, 2019 10:20 AM >> To: devel@edk2.groups.io; Kinney, Michael D >> ; ler...@redh

Re: [edk2-devel] [PATCH 04/10] MdePkg/PiFirmwareFile: fix undefined behavior in FFS_FILE_SIZE

Philippe, Comments below. Thanks, Mike > -Original Message- > From: Philippe Mathieu-Daudé [mailto:phi...@redhat.com] > Sent: Thursday, April 18, 2019 10:20 AM > To: devel@edk2.groups.io; Kinney, Michael D > ; ler...@redhat.com > Cc: Gao, Liming > Subject: Re: [edk2-devel] [PATCH 04/10

[edk2-devel] [PATCH v2 4/5] MdePkg/PiFirmwareFile: fix undefined behavior in FFS_FILE_SIZE

Accessing "EFI_FFS_FILE_HEADER.Size", which is of type UINT8[3], through a (UINT32*), is undefined behavior. Fix it by accessing the array elements individually. Cc: Liming Gao Cc: Michael D Kinney Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1710 Signed-off-by: Laszlo Ersek --- No

[edk2-devel] [PATCH v2 2/5] MdePkg/PiFirmwareFile: fix undefined behavior in SECTION_SIZE

RH covscan justifiedly reports that accessing "EFI_COMMON_SECTION_HEADER.Size", which is of type UINT8[3], through a (UINT32*), is undefined behavior: > Error: OVERRUN (CWE-119): > edk2-89910a39dcfd/OvmfPkg/Sec/SecMain.c:178: overrun-local: Overrunning > array of 3 bytes at byte offset 3 by derefe

[edk2-devel] [PATCH v2 5/5] OvmfPkg/Sec: fix out-of-bounds reads

RH covscan justifiedly reports that accessing "EFI_FFS_FILE_HEADER.Size" and "EFI_COMMON_SECTION_HEADER.Size", which both are of type UINT8[3], through (UINT32*), is undefined behavior: > Error: OVERRUN (CWE-119): > edk2-89910a39dcfd/OvmfPkg/Sec/SecMain.c:283: overrun-local: Overrunning > array of

[edk2-devel] [PATCH v2 3/5] BaseTools/PiFirmwareFile: fix undefined behavior in SECTION_SIZE

Sync SECTION_SIZE() from MdePkg to BaseTools, from an earlier patch in this series. Cc: Bob Feng Cc: Liming Gao Cc: Yonghong Zhu Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1710 Signed-off-by: Laszlo Ersek --- Notes: v2: - sync with the v2 MdePkg/PiFirmwareFile SECTI

[edk2-devel] [PATCH v2 1/5] MdePkg/PiFirmwareFile: express IS_SECTION2 in terms of SECTION_SIZE

The IS_SECTION2() function-like macro duplicates the SECTION_SIZE() calculation, just to compare the computed size against 0xFF. Invoke SECTION_SIZE() instead; only preserve the comparison. Cc: Liming Gao Cc: Michael D Kinney Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1710 Sign

[edk2-devel] [PATCH v2 0/5] patches for some warnings raised by "RH covscan"

Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1710 Repo: https://github.com/lersek/edk2.git Branch: covscan_bz_1710_v2 Patch-level updates relative to v1 have been noted on the patches themselves. And earlier I described the changes to the series's structure at

Re: [edk2-devel] [PATCH 04/10] MdePkg/PiFirmwareFile: fix undefined behavior in FFS_FILE_SIZE

Hi Michael, On 4/17/19 7:52 PM, Michael D Kinney wrote: > Laszlo, > > I have been following this thread. I think the style > used here to access the 3 array elements to build the > 24-bit size value is the best approach. I prefer this > over adding the union. > > I agree there is a read overru

Re: [edk2-devel] [PATCH 02/10] MdePkg/PiFirmwareFile: fix undefined behavior in SECTION_SIZE

> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, April 18, 2019 5:39 PM > To: devel@edk2.groups.io; Justen, Jordan L ; > Andrew Fish > Cc: Kinney, Michael D ; Gao, Liming > > Subject: Re: [edk2-devel] [PATCH 02/10] MdePkg/PiFirmwareFile: fix undefin

[edk2-devel] TianoCore Design Meeting - EMEA/NAMO - Thu, 04/18/2019 8:00am-9:00am #cal-reminder

"TianoCore Design Meeting - EMEA/NAMO" Reminder When: Thursday, 18 April 2019 8:00am to 9:00am (GMT-07:00) America/Los Angeles Where: https://zoom.us/j/571317753 Description: Join Zoom Meeting https://zoom.us/j/571317753 ( https://zoom.us/j/571317753 )   One tap mobile +172070

Re: [edk2-devel] [PATCH] BaseTools: Hash false success.. minor change in hash invalidation

Please don't forget to review this patch. It corrects a small error in my last patch. We should only invalidate hashes in the gBinCacheDest not gBinCacheSource because we want to error handle the hashes being written. -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.group

Re: [edk2-devel] [PATCH 00/10] patches for some warnings raised by "RH covscan"

Based on feedback thus far: On 04/13/19 01:31, Laszlo Ersek wrote: > Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1710 > Repo: https://github.com/lersek/edk2.git > Branch: covscan_bz_1710 > > "covscan" is an internal service at Red Hat that lets associates run > static analysis

[edk2-devel] [Patch V2] BaseTools: Enhance Bin Cache database to support save the cache

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1726 V2: Added the platform name to the path Add more level sub-directories in the database to support save the cache for multiple platforms with multiple tool-chains and targets, just like edk2 Build output. Signed-off-by: Christian Rodriguez C

Re: [edk2-devel] [edk2-CCodingStandardsSpecification Patch V2] Change preferred license of EDK II to BSD+Patent

On 4/17/19 7:27 PM, Michael D Kinney wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=1656 > > Change the EDK II C Coding Standards Specification to state that > the preferred license of the EDK II is the BSD+Patent License and > that file headers should use SPDX license identifiers. > > R

[edk2-devel] [PATCH V3] BaseTools:fixed the incorrect autogen makefile which cause build failure.

BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1729 On some build environment, build fails but on the other build machines, build success. This is the regression issue introduced by commit 05217d210e8da37b47d0be58ec363f7af2fa1c18 As Dict is unordered, an error occurs when extract the index

Re: [edk2-devel] [PATCH V2 05/25] SecurityPkg/Tcg2Dxe: Change comments of ShutdownTpmOnReset

Reviewed-by: Chao Zhang -Original Message- From: Gao, Zhichao Sent: Wednesday, April 17, 2019 2:27 PM To: devel@edk2.groups.io Cc: Zhang, Chao B ; Yao, Jiewen ; Gao, Liming ; Sean Brogan ; Michael Turner ; Bret Barkelew Subject: [PATCH V2 05/25] SecurityPkg/Tcg2Dxe: Change comments o

[edk2-devel] Requestion for LTS version on EDK2

Hi Guys, Backgroud: If we choose one stable-tag as our own UEFI codebase, however after 3 years, there are so many new features(but we don't need) will be added into EDK2 main tree. Requestion: Could EDK2 community plan or maintain "LTS version" concept like Linux? On LTS version , we only make

[edk2-devel] [PATCH v5] NetworkPkg/UefiPxeBcDxe:Add two PCD to control PXE.

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1695 Setup need provide an item for user to control IPV46 PXE boot. Origin UefiPxeBcDxe driver doesn't have such interface. This change added two PCD to control IPV4/6 PXE in PxeBcSupported(). Platform code should override this two PCD according t

Re: [edk2-devel] [PATCH V2] BaseTools:Makefiles cause data errors on some platforms

Zhiju, please update the title. -Bob -Original Message- From: Fan, ZhijuX Sent: Thursday, April 18, 2019 4:05 PM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C Subject: [PATCH V2] BaseTools:Makefiles cause data errors on some platforms BZ:https://bugzilla.tianocore.org/show_bug

Re: [edk2-devel] [PATCH 02/10] MdePkg/PiFirmwareFile: fix undefined behavior in SECTION_SIZE

On 04/17/19 21:35, Jordan Justen wrote: > On 2019-04-17 07:59:41, Laszlo Ersek wrote: >> On 04/17/19 13:44, Andrew Fish wrote: >> >>> Sorry I digressed into the C specification discussion, and did not >>> deal with the patch in general. My point is the original code is legal >>> C code. If you look

Re: [edk2-devel] [WebSite Patch] Change preferred license of EDK II to BSD+Patent

On 04/18/19 05:31, Kinney, Michael D wrote: > Laszlo, > > I am still working on how to pre-view these changes as they > would appear on the website once checked in. That's OK -- in this case I'm fine if I can only look at the pre-patch rendering. But those rendered pages, I would like to see. >

Re: [edk2-devel] [PATCH 04/10] MdePkg/PiFirmwareFile: fix undefined behavior in FFS_FILE_SIZE

On 04/17/19 20:31, Kinney, Michael D wrote: > Laszlo, > > We should also be able to do a consistent fix without > adding any new unions or macros: > > #define FFS_FILE_SIZE(FfsFileHeaderPtr) ((UINT32)( \ > (((EFI_FFS_FILE_HEADER *) (UINTN) FfsFileHeaderPtr)->Size[0] ) | \ > (((EFI_FFS_FIL

Re: [edk2-devel] [PATCH 04/10] MdePkg/PiFirmwareFile: fix undefined behavior in FFS_FILE_SIZE

On 04/17/19 20:36, Kinney, Michael D wrote: > Andrew, > > My suggestion is to read the 3 bytes and shift and or to build 24-bit value. > That is what is in the patch at the bottom. It uses an extra layer of macros > that I am not in favor of. There is an additional email with a proposed > app

Re: [edk2-devel] [PATCH 04/10] MdePkg/PiFirmwareFile: fix undefined behavior in FFS_FILE_SIZE

On 04/17/19 20:31, Andrew Fish wrote: > I was actually writing a mail to some people that sit on the C/C++ > standards committee that are UB experts to get some clarification when > you sent this mail. [...] > > I'm basically asking if this code pedantic conforms to C99 and C11: > > EFI_COMMON_SEC

Re: [edk2-devel] [edk2-CCodingStandardsSpecification Patch V2] Change preferred license of EDK II to BSD+Patent

On 04/17/19 19:27, Michael D Kinney wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=1656 > > Change the EDK II C Coding Standards Specification to state that > the preferred license of the EDK II is the BSD+Patent License and > that file headers should use SPDX license identifiers. > > Re

[edk2-devel] [PATCH V2] BaseTools:Makefiles cause data errors on some platforms

BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1729 On some build environment, build fails but on the other build machines, build success. This is the regression issue introduced by commit 05217d210e8da37b47d0be58ec363f7af2fa1c18 As Dict is unordered, an error occurs when extract the index