Re: [edk2-devel] [PATCH 3/3] MdeModulePkg/UfsPassThruDxe: Add UFS info protocol

2019-04-14 Thread Wu, Hao A
> -Original Message- > From: Albecki, Mateusz > Sent: Saturday, April 13, 2019 7:23 AM > To: Wu, Hao A; devel@edk2.groups.io > Cc: Ni, Ray > Subject: RE: [PATCH 3/3] MdeModulePkg/UfsPassThruDxe: Add UFS info > protocol > > I wasn't really thinking about efi code that can come in from devic

Re: [edk2-devel] [RFC] Propose update of security bug handling process

2019-04-14 Thread Wang, Jian J
Laszlo, > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Laszlo Ersek > Sent: Friday, April 12, 2019 8:52 PM > To: Wang, Jian J > Cc: devel@edk2.groups.io; Zimmer, Vincent ; > Cetola, Stephano ; Gao, Liming > > Subject: Re: [edk2-devel] [RFC

Re: [edk2-devel] [PATCH 21/25] Vlv2TbltdevicePkg/ResetSystemLib: Add new API ResetSystem

2019-04-14 Thread Sun, Zailiang
Reviewed-by: Zailiang Sun > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Gao, Zhichao > Sent: Monday, April 15, 2019 11:06 AM > To: devel@edk2.groups.io > Cc: Sun, Zailiang ; Qian, Yi ; Gao, > Liming > Subject: [edk2-devel] [PATCH 21/25] Vl

[edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH 4/5] KabylakeSiliconPkg/PeiResetSystemLib: Add a new API ResetSystem

2019-04-14 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 Add a new API ResetSystem to this ResetSystemLib instance. It only adds the basic functions from ResetSystemRuntimeDxe. Lacking of this interface may cause link error, if some drivers use this new API and link to this library instance. Make

[edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH 1/5] KabylakeSiliconPkg/BaseResetSystemLib: Add a new API ResetSystem

2019-04-14 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 Add a new API ResetSystem to this ResetSystemLib instance. It only adds the basic functions from ResetSystemRuntimeDxe. Lacking of this interface may cause link error, if some drivers use this new API and link to this library instance. Make

[edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH 2/5] KabylakeSiliconPkg/DxeResetSystemLib: Add a new API ResetSystem

2019-04-14 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 Add a new API ResetSystem to this ResetSystemLib instance. It only adds the basic functions from ResetSystemRuntimeDxe. Lacking of this interface may cause link error, if some drivers use this new API and link to this library instance. Make

[edk2-devel] [PATCH 24/25] MdeModulePkg/ResetUtilityLib: Add a new API ResetSystemWithSubtype

2019-04-14 Thread Gao, Zhichao
From: Bret Barkelew BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1458 Add a new API ResetSystemWithSubtype's prototype declaration in header file. Also add the required data type header file. Cc: Jian J Wang Cc: Hao Wu Cc: Ray Ni Cc: Star Zeng Cc: Liming Gao Cc: Sean Brogan Cc: Mich

[edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH 5/5] KabylakeSiliconPkg/DxeRuntimeResetSystemLib: Add a new API ResetSystem

2019-04-14 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 Add a new API ResetSystem to this ResetSystemLib instance. It only adds the basic functions from ResetSystemRuntimeDxe. Lacking of this interface may cause link error, if some drivers use this new API and link to this library instance. Make

[edk2-devel] [edk2-platforms PATCH] Platform/ResetSystemLib: Add a new API ResetSystem

2019-04-14 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 Add a new API ResetSystem to this ResetSystemLib instance. It only adds the basic functions from ResetSystemRuntimeDxe. Lacking of this interface may cause link error, if some drivers use this new API and link to this library instance. Make

[edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH 3/5] LewisburgPkg/DxeRuntimeResetSystemLib: Add a new API ResetSystem

2019-04-14 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 Add a new API ResetSystem to this ResetSystemLib instance. It only adds the basic functions from ResetSystemRuntimeDxe. Lacking of this interface may cause link error, if some drivers use this new API and link to this library instance. Make

[edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH 0/5] Add a new API ResetSystem for ResetSystemLib instances

2019-04-14 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 Add a new API ResetSystem to this ResetSystemLib instance. It only adds the basic functions from ResetSystemRuntimeDxe. Lacking of this interface may cause link error, if some drivers use this new API and link to this library instance. Make

[edk2-devel] [PATCH 25/25] MdeModulePkg/ResetUtilityLib: Add a new API ResetSystemWithSubtype

2019-04-14 Thread Gao, Zhichao
From: Bret Barkelew BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1458 Implement the new API ResetSystemWithSubtype. Depend on Uefi Spec 2.8 chapter 8.5.1, the ResetData is valid while the ResetStatus is EFI_SUCCESS regardless of the ResetType. Also change the function ResetPlatofrmSpecific

[edk2-devel] [PATCH 12/25] MdeModulePkg/ResetSystemPei: Change comments of ResetSystem2

2019-04-14 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 Refer to Uefi spec 2.8, the ResetData is valid while ResetStatus is EFI_SUCCESS regardless of the ResetType is EfiResetPlatformSpecific or not. Cc: Jian J Wang Cc: Hao Wu Cc: Ray Ni Cc: Star Zeng Cc: Liming Gao Cc: Sean Brogan Cc: Mic

[edk2-devel] [PATCH 16/25] CorebootPayloadPkg/ResetSystemLib: Add new API ResetSystem

2019-04-14 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 Add a new API ResetSystem to this ResetSystemLib instance. It only adds the basic functions from ResetSystemRuntimeDxe. Lacking of this interface may cause link error, if some drivers use this new API and link to this library instance. Notes

[edk2-devel] [PATCH 22/25] ArmPkg/ArmSmcPsciResetSystemLib: Add a new API ResetSystem

2019-04-14 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 Add a new API ResetSystem to this ResetSystemLib instance. It only adds the basic functions from ResetSystemRuntimeDxe. Lacking of this interface may cause link error, if some drivers use this new API and link to this library instance. Notes

[edk2-devel] [PATCH 18/25] OvmfPkg/ResetSystemLib: Add new API ResetSystem

2019-04-14 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 Add a new API ResetSystem to this ResetSystemLib instance. It only adds the basic functions from ResetSystemRuntimeDxe. Lacking of this interface may cause link error, if some drivers use this new API and link to this library instance. Notes

[edk2-devel] [PATCH 14/25] MdeModulePkg/NvmExpressHci.c: Change comments

2019-04-14 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 Refer to Uefi spec 2.8, the ResetData is valid while ResetStatus is EFI_SUCCESS regardless of the ResetType is EfiResetPlatformSpecific or not. So change the comments of NvmeShutdownAllControllers. Cc: Jian J Wang Cc: Hao Wu Cc: Ray Ni C

[edk2-devel] [PATCH 20/25] QuarkSocPkg/ResetSystemLib: Add new API ResetSystem

2019-04-14 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 Add a new API ResetSystem to this ResetSystemLib instance. It only adds the basic functions from ResetSystemRuntimeDxe. Lacking of this interface may cause link error, if some drivers use this new API and link to this library instance. Notes

[edk2-devel] [PATCH 02/25] MdePkg/PiPeiCis.h: Change comments of EFI_PEI_RESET2_SYSTEM

2019-04-14 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 Refer to Uefi spec 2.8, the ResetData is valid while ResetStatus is EFI_SUCCESS regardless of the ResetType is EfiResetPlatformSpecific or not. Cc: Michael D Kinney Cc: Liming Gao Cc: Sean Brogan Cc: Michael Turner Cc: Bret Barkelew Si

[edk2-devel] [PATCH 08/25] MdeModulePkg/BaseResetSystemLibNull.c: Change comments of ResetSystem

2019-04-14 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 Refer to Uefi spec 2.8, the ResetData is valid while ResetStatus is EFI_SUCCESS regardless of the ResetType is EfiResetPlatformSpecific or not. Cc: Jian J Wang Cc: Hao Wu Cc: Ray Ni Cc: Star Zeng Cc: Liming Gao Cc: Sean Brogan Cc: Mic

[edk2-devel] [PATCH 00/25] Add the new APIs ResetSystem and ResetSystemWithSubtype

2019-04-14 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 Refer to Uefi spec 2.8, the ResetData is valid while ResetStatus is EFI_SUCCESS regardless of the ResetType is EfiResetPlatformSpecific or not. Add a new API ResetSystem to ResetSystemLib instances. The new driver may consume this new API and

[edk2-devel] [PATCH 06/25] MdeModulePkg/ResetSystemLib.h: Change comments of ResetSystem

2019-04-14 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 Refer to Uefi spec 2.8, the ResetData is valid while ResetStatus is EFI_SUCCESS regardless of the ResetType is EfiResetPlatformSpecific or not. Cc: Jian J Wang Cc: Hao Wu Cc: Ray Ni Cc: Star Zeng Cc: Liming Gao Cc: Sean Brogan Cc: Mic

[edk2-devel] [PATCH 10/25] MdeModulePkg/PeiResetSystemlib.c: Change comments of ResetSystem

2019-04-14 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 Refer to Uefi spec 2.8, the ResetData is valid while ResetStatus is EFI_SUCCESS regardless of the ResetType is EfiResetPlatformSpecific or not. Cc: Jian J Wang Cc: Hao Wu Cc: Ray Ni Cc: Star Zeng Cc: Liming Gao Cc: Sean Brogan Cc: Mic

[edk2-devel] [PATCH 04/25] MdePkg/PeiServicesLib.c: Change comments of PeiServicesResetSystem2

2019-04-14 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 Refer to Uefi spec 2.8, the ResetData is valid while ResetStatus is EFI_SUCCESS regardless of the ResetType is EfiResetPlatformSpecific or not. Cc: Michael D Kinney Cc: Liming Gao Cc: Sean Brogan Cc: Michael Turner Cc: Bret Barkelew Si

[edk2-devel] [PATCH 23/25] ArmVirtPkg/ArmVirtPsciResetSystemLib: Add a new API ResetSystem

2019-04-14 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 Add a new API ResetSystem to this ResetSystemLib instance. It only adds the basic functions from ResetSystemRuntimeDxe. Lacking of this interface may cause link error, if some drivers use this new API and link to this library instance. Notes

[edk2-devel] [PATCH 19/25] PcAtChipsetPkg/ResetSystemLib: Add new API ResetSystem

2019-04-14 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 Add a new API ResetSystem to this ResetSystemLib instance. It only adds the basic functions from ResetSystemRuntimeDxe. Lacking of this interface may cause link error, if some drivers use this new API and link to this library instance. Notes

[edk2-devel] [PATCH 21/25] Vlv2TbltdevicePkg/ResetSystemLib: Add new API ResetSystem

2019-04-14 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 Add a new API ResetSystem to this ResetSystemLib instance. It only adds the basic functions from ResetSystemRuntimeDxe. Lacking of this interface may cause link error, if some drivers use this new API and link to this library instance. Notes

[edk2-devel] [PATCH 17/25] Nt32Pkg/ResetSystemLib: Add new API ResetSystem

2019-04-14 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 Add a new API ResetSystem to this ResetSystemLib instance. It only adds the basic functions from ResetSystemRuntimeDxe. Lacking of this interface may cause link error, if some drivers use this new API and link to this library instance. Notes

[edk2-devel] [PATCH 15/25] BeagleBoardPkg/ResetSystemLib: Add new API ResetSystem

2019-04-14 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 Add a new API ResetSystem to this ResetSystemLib instance. It only adds the basic functions from ResetSystemRuntimeDxe. Lacking of this interface may cause link error, if some drivers use this new API and link to this library instance. Notes

[edk2-devel] [PATCH 07/25] MdeModulePkg/DxeResetSystemLib.c: Change comments of ResetSystem

2019-04-14 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 Refer to Uefi spec 2.8, the ResetData is valid while ResetStatus is EFI_SUCCESS regardless of the ResetType is EfiResetPlatformSpecific or not. Cc: Jian J Wang Cc: Hao Wu Cc: Ray Ni Cc: Star Zeng Cc: Liming Gao Cc: Sean Brogan Cc: Mic

[edk2-devel] [PATCH 01/25] MdePkg/UefiSpec.h: Change comments of EFI_RESET_SYSTEM

2019-04-14 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 Refer to Uefi spec 2.8, the ResetData is valid while ResetStatus is EFI_SUCCESS regardless of the ResetType is EfiResetPlatformSpecific or not. Cc: Michael D Kinney Cc: Liming Gao Cc: Sean Brogan Cc: Michael Turner Cc: Bret Barkelew Si

[edk2-devel] [PATCH 11/25] MdeModulePkg/ResetSystemRuntimeDxe: Change comments

2019-04-14 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 Refer to Uefi spec 2.8, the ResetData is valid while ResetStatus is EFI_SUCCESS regardless of the ResetType is EfiResetPlatformSpecific or not. So change the comments of RuntimeServiceResetSystem. Cc: Jian J Wang Cc: Hao Wu Cc: Ray Ni Cc

[edk2-devel] [PATCH 05/25] SecurityPkg/Tcg2Dxe: Change comments of ShutdownTpmOnReset

2019-04-14 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 Refer to Uefi spec 2.8, the ResetData is valid while ResetStatus is EFI_SUCCESS regardless of the ResetType is EfiResetPlatformSpecific or not. Cc: Chao Zhang Cc: Jiewen Yao Cc: Liming Gao Cc: Sean Brogan Cc: Michael Turner Cc: Bret Ba

[edk2-devel] [PATCH 13/25] MdeModulePkg/PeiMain: Change comments of PeiResetSystem2

2019-04-14 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 Refer to Uefi spec 2.8, the ResetData is valid while ResetStatus is EFI_SUCCESS regardless of the ResetType is EfiResetPlatformSpecific or not. Cc: Jian J Wang Cc: Hao Wu Cc: Ray Ni Cc: Star Zeng Cc: Liming Gao Cc: Sean Brogan Cc: Mic

[edk2-devel] [PATCH 09/25] MdeModulePkg/RuntimeResetSystemLib.c: Change comments

2019-04-14 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 Refer to Uefi spec 2.8, the ResetData is valid while ResetStatus is EFI_SUCCESS regardless of the ResetType is EfiResetPlatformSpecific or not. So change the comments of ResetSystem. Cc: Jian J Wang Cc: Hao Wu Cc: Ray Ni Cc: Star Zeng C

[edk2-devel] [PATCH 03/25] MdePkg/PeiServicesLib.h: Change comments of PeiServicesResetSystem2

2019-04-14 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 Refer to Uefi spec 2.8, the ResetData is valid while ResetStatus is EFI_SUCCESS regardless of the ResetType is EfiResetPlatformSpecific or not. Cc: Michael D Kinney Cc: Liming Gao Cc: Sean Brogan Cc: Michael Turner Cc: Bret Barkelew Si

[edk2-devel] [RFC PATCH edk2-non-osi] Emulator: add binary AARCH64 build of X86 PE/COFF emulator

2019-04-14 Thread Ard Biesheuvel
Repo: http://github.com/ardbiesheuvel/X86EmulatorPkg.git Commit: 5f4deb30eb935f9004b93d97712cc3ac3ae1ca97 Repo: http://github.com/tiancore/edk2.git Commit: 2e21e8c4b89656897797019a9c56bc5ccbf12df1 Note that the X86EmulatorPkg project's license is _L_GPL not GPL, and so it could arguably be in

Re: [edk2-devel] RamDiskDxe.efi Help

2019-04-14 Thread Wu, Hao A
Hello Joe Teumer, At this moment, the RamDiskDxe driver does not support creating RAM disks using the Shell command. Instead, you can create ones via a BIOS setup page. Under shell, you can follow the below steps: exit (under Shell, a setup page will show up) Device Manager RAM Disk Configuratio

Re: [edk2-devel] [PATCH v6 0/7] MdeModulePkg: add support for dispatching foreign arch PE/COFF images

2019-04-14 Thread Ard Biesheuvel
On Sun, 14 Apr 2019 at 18:25, Wu, Hao A wrote: > > > -Original Message- > > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > > Sent: Monday, April 15, 2019 3:52 AM > > To: devel@edk2.groups.io > > Cc: Ard Biesheuvel; Kinney, Michael D; Andrew Fish; Leif Lindholm; Zeng, > > Star;

Re: [edk2-devel] [PATCH v6 0/7] MdeModulePkg: add support for dispatching foreign arch PE/COFF images

2019-04-14 Thread Wu, Hao A
> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Monday, April 15, 2019 3:52 AM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel; Kinney, Michael D; Andrew Fish; Leif Lindholm; Zeng, Star; > Dong, Eric; Ni, Ray; Gao, Liming; Carsey, Jaben; Shi, Steven; W

Re: [edk2-devel] [PATCH v6 2/7] MdeModulePkg/DxeCore: invoke the emulator protocol for foreign images

2019-04-14 Thread Wu, Hao A
> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Monday, April 15, 2019 3:52 AM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel; Kinney, Michael D; Andrew Fish; Leif Lindholm; Zeng, Star; > Dong, Eric; Ni, Ray; Gao, Liming; Carsey, Jaben; Shi, Steven; W

Re: [edk2-devel] [PATCH v6 1/7] MdeModulePkg: introduce PE/COFF image emulator protocol

2019-04-14 Thread Wu, Hao A
> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Monday, April 15, 2019 3:52 AM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel; Kinney, Michael D; Andrew Fish; Leif Lindholm; Zeng, Star; > Dong, Eric; Ni, Ray; Gao, Liming; Carsey, Jaben; Shi, Steven; W

Re: [edk2-devel] [edk2][PATCH] BaseTools:Coding problems cause can not encode FMP Auth Header

2019-04-14 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Wednesday, April 10, 2019 4:41 PM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C Subject: [edk2][PATCH] BaseTools:Coding problems cause can not encode FMP Auth Header GenerateCapsule: error: can not encode FMP Au

Re: [edk2-devel] [Wiki Patch 2/2] Change preferred license of EDK II to BSD+Patent

2019-04-14 Thread Leif Lindholm
Minor suggestion below: On Fri, Apr 12, 2019 at 03:50:40PM -0700, Michael D Kinney wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=1656 > > Change the Wiki documentation to state that the preferred license of the > EDK II is the BSD+Patent License and remove references to the TianoCore >

[edk2-devel] [PATCH v6 6/7] MdePkg/UefiBaseType.h: treat EBC as a non-native machine type

2019-04-14 Thread Ard Biesheuvel
Instead of classifying EBC as a supported machine type and have special handling in DXE core for loading EBC images, make it a foreign type and rely on the EDK2 PE/COFF image emulator protocol to claim the image when the DXE core finds that it cannot be supported natively. Signed-off-by: Ard Biesh

[edk2-devel] [PATCH v6 4/7] MdeModulePkg/UefiBootManagerLib: allow foreign Driver#### images

2019-04-14 Thread Ard Biesheuvel
Allow PE/COFF images that must execute under emulation for Driver options, by removing the redundant machine type check from the BDS code. Signed-off-by: Ard Biesheuvel Reviewed-by: Michael D Kinney --- MdeModulePkg/Library/UefiBootManagerLib/BmLoadOption.c | 6 ++ 1 file changed, 2 ins

[edk2-devel] [PATCH v6 2/7] MdeModulePkg/DxeCore: invoke the emulator protocol for foreign images

2019-04-14 Thread Ard Biesheuvel
When encountering PE/COFF images that cannot be supported natively, attempt to locate an instance of the PE/COFF image emulator protocol, and if it supports the image, proceed with loading it and register it with the emulator. Signed-off-by: Ard Biesheuvel Reviewed-by: Michael D Kinney --- MdeM

[edk2-devel] [PATCH v6 0/7] MdeModulePkg: add support for dispatching foreign arch PE/COFF images

2019-04-14 Thread Ard Biesheuvel
Add the basic plumbing to DXE core, the PCI bus driver and the boot manager to allow PE/COFF images to be dispatched that target an architecture that is not native for the platform, but which is supported by one of potentially several available emulators. One implementation of such an emulator can

[edk2-devel] [PATCH v6 3/7] MdeModulePkg/PciBusDxe: dispatch option ROMs for foreign architectures

2019-04-14 Thread Ard Biesheuvel
Delete the explicit machine type check for option ROM images, and instead, rely on the LoadImage() boot service to decide whether an option ROM can be dispatched or not. This permits platforms to ship with emulators to execute option ROMs that are not native to the processor architecture. Signed-o

[edk2-devel] [PATCH v6 1/7] MdeModulePkg: introduce PE/COFF image emulator protocol

2019-04-14 Thread Ard Biesheuvel
Introduce a protocol that can be invoked by the image loading services to execute foreign architecture PE/COFF images via an emulator. Signed-off-by: Ard Biesheuvel Reviewed-by: Michael D Kinney --- MdeModulePkg/Include/Protocol/PeCoffImageEmulator.h | 107 MdeModulePkg/Mde

[edk2-devel] [PATCH v6 5/7] MdeModulePkg/EbcDxe: implement the PE/COFF emulator protocol

2019-04-14 Thread Ard Biesheuvel
Implement the new EDK2 PE/COFF image emulator protocol so that we can remove the EBC specific handling in the DXE core and other places in the core code. Signed-off-by: Ard Biesheuvel Reviewed-by: Michael D Kinney --- MdeModulePkg/Universal/EbcDxe/EbcDebugger.inf | 3 + MdeModulePkg/Universal

[edk2-devel] [PATCH v6 7/7] MdeModulePkg/DxeCore: remove explicit EBC handling

2019-04-14 Thread Ard Biesheuvel
Now that the EBC machine type is no longer classified as a natively supported machine type on the architectures that can support it via the EBC interpreter, the EBC specific handling in DXE core is no longer used and can be removed. Signed-off-by: Ard Biesheuvel Reviewed-by: Michael D Kinney ---

Re: [edk2-devel] [edk2-test] Location of tests for vendor/edk2 specific protocols

2019-04-14 Thread Supreeth Venkatesh
+ Eric Thanks Jeff for bringing this up. As mentioned during our discussion on this topic briefly @ UEFI Plugfest 2019, I definitely like to see these non-standard protocol tests become part of test suite. However, there has been no proposal yet, though there were proposals related to SBBR (Arm'

Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg: Perform post FSP-S process.

2019-04-14 Thread Zeng, Star
Minor comment inline. > -Original Message- > From: Chiu, Chasel > Sent: Friday, April 12, 2019 11:02 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [PATCH] IntelFsp2WrapperPkg: Perform post FSP-S process. > > From: "Chasel, Chiu" > >

Re: [edk2-devel] [PATCH 08/10] OvmfPkg: suppress "Value stored to ... is never read" analyzer warnings

2019-04-14 Thread Jordan Justen
On 2019-04-12 16:31:26, Laszlo Ersek wrote: > RH covscan warns about assignments that it can determine are never > "consumed" later ("dead stores"). The idea behind the warning is > presumably that the programmer forgot to implement a dependent check > somewhere. > > For each such warning that has

Re: [edk2-devel] [PATCH 02/10] MdePkg/PiFirmwareFile: fix undefined behavior in SECTION_SIZE

2019-04-14 Thread Jordan Justen
On 2019-04-12 16:31:20, Laszlo Ersek wrote: > RH covscan justifiedly reports that accessing > "EFI_COMMON_SECTION_HEADER.Size", which is of type UINT8[3], through a > (UINT32*), is undefined behavior: > > > Error: OVERRUN (CWE-119): > > edk2-89910a39dcfd/OvmfPkg/Sec/SecMain.c:178: overrun-local: O