Re: [edk2-devel] [PATCH v2 1/2] UefiCpuPkg/Cpuid.h: Remove duplicated struct definition for leaf 1FH

2019-04-03 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Ni, Ray > Sent: Thursday, April 4, 2019 2:03 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Zeng, Star ; Qin, > Zhiqiang > Subject: [PATCH v2 1/2] UefiCpuPkg/Cpuid.h: Remove duplicated struct > definition for leaf 1FH > > Per SDM CPU

Re: [edk2-devel] [PATCH v2 2/2] UefiCpuPkg/Cpuid: Dump leaf 1FH information correctly

2019-04-03 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ni, > Ray > Sent: Thursday, April 4, 2019 2:03 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Zeng, Star ; Qin, > Zhiqiang > Subject: [edk2-devel] [PATCH v2 2/2] UefiCpuP

[edk2-devel] [PATCH v2 2/2] UefiCpuPkg/Cpuid: Dump leaf 1FH information correctly

2019-04-03 Thread Ni, Ray
Leaf 1FH is very similar to leaf 0BH. Both return the CPU topology information. Leaf 0BH returns 3-level (Package/Core/Thread) CPU topology info. Leaf 1FH returns 6-level (Package/Die/Tile/Module/Core/Thread) CPU topology info. The logic to enumerate the topology info is the same. But today's logi

[edk2-devel] [PATCH v2 1/2] UefiCpuPkg/Cpuid.h: Remove duplicated struct definition for leaf 1FH

2019-04-03 Thread Ni, Ray
Per SDM CPUID.0BH and CPUID.1FH outputs the same format of data in EAX/EBX/ECX/EDX except CPUID.1FH reports more level types such as module, tile, die. The patch removes the unnecessary duplicated structure definitions for CPUID.1FH because when the structure definitions for CPUID.0BH can be used

[edk2-devel] [PATCH v2 0/2] Dump CPUID.1FH information correctly

2019-04-03 Thread Ni, Ray
v2: Removes the duplicated structure definitions introduced for leaf 1FH. Ray Ni (2): UefiCpuPkg/Cpuid.h: Remove duplicated struct definition for leaf 1FH UefiCpuPkg/Cpuid: Dump leaf 1FH information correctly UefiCpuPkg/Application/Cpuid/Cpuid.c | 74 +--- UefiCpuPkg/Include

[edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH v1 3/6] KabylakeOpenBoardPkg/KBLRvp3: Remove unused PCD 'PcdUseHpetTimer'

2019-04-03 Thread Wu, Hao A
For KabylakeRvp3, it is using the HPET timer unconditionally. The PCD 'PcdUseHpetTimer' is not being used. This commit will remove the usage of the above PCD in package DSC files. Cc: Chasel Chiu Cc: Michael Kubacki Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Hao Wu

[edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH v1 1/6] ClevoOpenBoardPkg/N1xxWU: Remove unused PCD 'PcdUseHpetTimer'

2019-04-03 Thread Wu, Hao A
For N1xxWU, it is using the HPET timer unconditionally. The PCD 'PcdUseHpetTimer' is not being used. This commit will remove the usage of the above PCD in package DSC files. Cc: Michael Kubacki Cc: Ankit Sinha Cc: Nate DeSimone Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off

[edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH v1 5/6] KabylakeSiliconPkg: Remove unused PCD 'PcdUseHpetTimer'

2019-04-03 Thread Wu, Hao A
For platforms under KabylakeOpenBoardPkg & ClevoOpenBoardPkg, both of them are using the HPET timer unconditionally. The PCD 'PcdUseHpetTimer' is not being used. This commit will remove the above PCD within KabylakeSiliconPkg. Cc: Chasel Chiu Cc: Michael A Kubacki Contributed-under: TianoCore C

[edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH v1 4/6] KabylakeOpenBoardPkg/KBLRvp3: Remove the consume of 8259-related PCD

2019-04-03 Thread Wu, Hao A
For KabylakeRvp3, none of its consumed modules is using the PCD: gPcAtChipsetPkgTokenSpaceGuid.Pcd8259LegacyModeMask Thus, this commit will remove the PCD consumption in the DSC file. Cc: Chasel Chiu Cc: Michael Kubacki Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Hao

[edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH v1 0/6] Some cleanup for platforms under ClevoOpenBoardPkg & KabylakeOpenBoardPkg

2019-04-03 Thread Wu, Hao A
The series will do the below cleanups for platforms under ClevoOpenBoardPkg and KabylakeOpenBoardPkg: A) Remove unused PCD 'PcdUseHpetTimer'; B) Remove the unnecessary consumption of the 8259-related PCDs; C) Remove the unused duplicated Legacy8259 protocol GUID. Test done for the series: Build

[edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH v1 6/6] KabylakeSiliconPkg/SiPkg.dec: Remove Legacy8259 protocol GUID

2019-04-03 Thread Wu, Hao A
For modules consumed by platforms within KabylakeOpenBoardPkg & ClevoOpenBoardPkg, none of them has the dependency on the Legacy8259 protocol. Thus, this commit will remove the duplicated Legacy8259 protocol GUID within file SiPkg.dec. Cc: Chasel Chiu Cc: Michael A Kubacki Contributed-under: Tia

[edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH v1 2/6] ClevoOpenBoardPkg/N1xxWU: Remove the consume of 8259-related PCD

2019-04-03 Thread Wu, Hao A
For N1xxWU, none of its consumed modules is using the PCD: gPcAtChipsetPkgTokenSpaceGuid.Pcd8259LegacyModeMask Thus, this commit will remove the PCD consumption in the DSC file. Cc: Michael Kubacki Cc: Ankit Sinha Cc: Nate DeSimone Contributed-under: TianoCore Contribution Agreement 1.1 Signed

Re: [edk2-devel] [edk2] [RFC] Plan to delete ShellBinPkg from edk2/master

2019-04-03 Thread Andrew Fish via Groups.Io
> On Apr 3, 2019, at 8:42 PM, Ni, Ray wrote: > > Mike, Laszlo, > It's a good idea to store the shell binaries into the assets of each stable > tag. > > If we go in this way, it means "build" requires network connection to > download the > shell binary from the assets of a certain release. >

Re: [edk2-devel] [edk2] [RFC PATCH v1 0/8] Duplicate 8259/8254 components in OvmfPkg

2019-04-03 Thread Wu, Hao A
> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, April 03, 2019 9:01 PM > To: Wu, Hao A; edk2-de...@lists.01.org > Cc: Justen, Jordan L; David Woodhouse > Subject: Re: [edk2] [RFC PATCH v1 0/8] Duplicate 8259/8254 components in > OvmfPkg > > On 04/03/

Re: [edk2-devel] [edk2] [RFC] Plan to delete ShellBinPkg from edk2/master

2019-04-03 Thread Ni, Ray
Mike, Laszlo, It's a good idea to store the shell binaries into the assets of each stable tag. If we go in this way, it means "build" requires network connection to download the shell binary from the assets of a certain release. Do you think it's acceptable? Or we can separate the binary downloa

Re: [edk2-devel] [edk2] [PATCH] SourceLevelDebugPkg/DebugAgent: Remove AsmFuncs.S in INF

2019-04-03 Thread Zhang, Shenglei
A commit(50cb4b90311fa5353df921fce42de5ad188da658) has been pushed to fix the build failure. Thanks, Shenglei > -Original Message- > From: Gao, Liming > Sent: Wednesday, April 3, 2019 7:31 PM > To: Zhang, Shenglei > Subject: RE: [edk2] [PATCH] SourceLevelDebugPkg/DebugAgent: Remove > As

Re: [edk2-devel] [edk2] [RFC PATCH v1 4/8] OvmfPkg/8259InterruptControllerDxe: Update to make it build for OVMF

2019-04-03 Thread Wu, Hao A
> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Laszlo Ersek > Sent: Wednesday, April 03, 2019 8:47 PM > To: Wu, Hao A; edk2-de...@lists.01.org > Cc: Justen, Jordan L; David Woodhouse > Subject: Re: [edk2] [RFC PATCH v1 4/8] OvmfPkg/8259Interr

Re: [edk2-devel] [edk2] [RFC PATCH v1 3/8] OvmfPkg/OvmfPkg.dec: Add 8259-related PCDs in OVMF DEC file

2019-04-03 Thread Wu, Hao A
> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, April 03, 2019 8:39 PM > To: Wu, Hao A; edk2-de...@lists.01.org > Cc: Justen, Jordan L; David Woodhouse > Subject: Re: [edk2] [RFC PATCH v1 3/8] OvmfPkg/OvmfPkg.dec: Add 8259- > related PCDs in OVMF DEC

Re: [edk2-devel] [edk2] [RFC PATCH v1 2/8] OvmfPkg: Copy Legacy8259 protocol definitions from IntelFrameworkPkg

2019-04-03 Thread Wu, Hao A
> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, April 03, 2019 8:24 PM > To: Wu, Hao A; edk2-de...@lists.01.org > Cc: Justen, Jordan L; David Woodhouse > Subject: Re: [edk2] [RFC PATCH v1 2/8] OvmfPkg: Copy Legacy8259 protocol > definitions from Intel

Re: [edk2-devel] [edk2] [PATCH V2] Change EDK II to BSD+Patent License

2019-04-03 Thread Yao, Jiewen
Resend to the new mail list. > > -Original Message- > > From: Yao, Jiewen [mailto:jiewen@intel.com] > > Sent: Thursday, April 4, 2019 9:54 AM > > To: Kinney, Michael D ; > > edk2-de...@lists.01.org; Kinney, Michael D > > Subject: RE: [edk2] [PATCH V2] Change EDK II to BSD+Patent Licen

Re: [edk2-devel] [edk2-platforms/devel-MinPlatform][Patch] AdvancedFeaturePkg/AcpiDebug: Add new AcpiDebug modules.

2019-04-03 Thread Kubacki, Michael A
/AcpiDebug/AcpiDebug.asl 1. Is "Trigger the SMI to print" meant to be "// Triggle the SMI to print" on line 97? /AdvancedFeaturePkg/AcpiDebug/AcpiDebug.c 1. Correct file description comment in file header " Smbios basic entry point." 2. InitializeAcpiDebugSmm ( ) should return with an er

[edk2-devel] [edk2] [PATCH V3] Change EDK II to BSD+Patent License

2019-04-03 Thread Michael D Kinney
Hello, New in V3 = * Update the base of the patch series from edk2-stable201903 to 7ed72121b7 that is after the file add/remove freeze: https://lists.01.org/pipermail/edk2-devel/2019-April/038574.html * Replace copyright line in License.txt in root with a single copyright for "Tian

Re: [edk2-devel] [Patch] EmulatorPkg/Unix: Rename GdbRun to GdbRun.sh

2019-04-03 Thread Jordan Justen
$ git grep GdbRun EmulatorPkg/Unix/Host/Host.c: // has a break point script to source the GdbRun script. EmulatorPkg/Unix/Xcode/xcode_project32/xcode_project.xcodeproj/default.pbxuser: command = "set gInXcode=1\nsource ../../../../EmulatorPkg/Unix/GdbRun"; EmulatorPkg/Unix/Xcode/xcode_pr

[edk2-devel] [Patch 2/4] ArmPkg: Normalize line endings to CRLF

2019-04-03 Thread Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=1659 Normalize line endings to use CRLF to pass PatchCheck.py Cc: Leif Lindholm Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael D Kinney --- ArmPkg/Library/ArmSmcLibNull/ArmSmcLibNull.c | 44 +++

[edk2-devel] [Patch 1/4] ArmPkg/ArmScmiDxe: Remove non-ASCII character in comment

2019-04-03 Thread Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=1659 Remove non-ASCII character in comment that makes it more challenging to process with python-based scanning tools. Cc: Leif Lindholm Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael D Kinney ---

[edk2-devel] [Patch 4/4] ArmPlatformPkg: Normalize line endings to CRLF

2019-04-03 Thread Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=1659 Normalize line endings to use CRLF to pass PatchCheck.py Cc: Leif Lindholm Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael D Kinney --- ArmPlatformPkg/Scripts/Ds5/profile.py | 668 +++

[edk2-devel] [Patch 3/4] ArmVirtPkg: Normalize line endings to CRLF

2019-04-03 Thread Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=1659 Normalize line endings to use CRLF to pass PatchCheck.py Cc: Laszlo Ersek Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael D Kinney --- ArmVirtPkg/Include/Platform/Hidden.h | 56 ++

[edk2-devel] [Patch 0/4] Normalize line endings to CRLF in ARM packages

2019-04-03 Thread Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=1659 Normalize line endings to use CRLF to pass PatchCheck.py Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael D Kinney Kinney, Michael D (4): ArmPkg/ArmScmiDx

[edk2-devel] [Patch] EmulatorPkg/Unix: Rename GdbRun to GdbRun.sh

2019-04-03 Thread Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=1657 Add .sh file extension to the shell script GdbRun so changes to this file will pass PatchCheck.py. Cc: Jordan Justen Cc: Andrew Fish Cc: Ray Ni Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael D Kinney --- Emul

Re: [edk2-devel] [edk2] [RFC] Plan to delete ShellBinPkg from edk2/master

2019-04-03 Thread Michael D Kinney
Laszlo, A PREBUILD action looks like a good idea. Release artifacts in GitHub are available as an http link, so a python script to download into a path in the build output directory and referenced by DSC/FDF should work. We could even post shell binaries for the past couple edk2-stable tags beca

[edk2-devel] TianoCore Bug Triage - EMEA / NAMO - Mon, 04/08/2019 7:00am-8:00am #cal-reminder

2019-04-03 Thread devel@edk2.groups.io Calendar
"TianoCore Bug Triage - EMEA / NAMO" Reminder When: Monday, 8 April 2019 7:00am to 8:00am (GMT-07:00) America/Los Angeles Where: https://zoom.us/j/670172897 Description: Join Zoom Meeting https://zoom.us/j/670172897 ( https://zoom.us/j/670172897 )   One tap mobile +17207072699