Re: Storage in Gecko

2013-04-26 Thread Kyle Huey
On Fri, Apr 26, 2013 at 11:57 AM, Ryan VanderMeulen wrote: > The current level of flakiness in the IndexedDB test suite (especially on > OSX) makes me concerned about what to expect if it starts getting heavier > use across the various platforms. Of the 24 open intermittent failure bugs in the I

DOM Bindings Meeting - Monday @ 12:30 PM PDT

2013-04-29 Thread Kyle Huey
Our (ostensibly) weekly DOM bindings meetings continue on Monday April 29th at 12:30 PM PDT. Meeting details: * Monday, April 29, 2013, 12:30 PM PDT (3:30 PM EDT/9:30 PM CEST) * Dial-in Info: - Vidyo room: Boris Zbarsky - In office or soft phone: extension 92 - US/INTL: 650-903-0800 or 650-215

Fallibility of NS_DispatchTo[Current|Main]Thread

2013-04-29 Thread Kyle Huey
Is it feasible to make these functions infallible? What work would need to be done? - Kyle ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: Increasing our Aurora and Nightly user populations?

2013-04-29 Thread Kyle Huey
On Mon, Apr 29, 2013 at 12:17 PM, Taras Glek wrote: > What is the problem with current population size? We are not as small as > Android on desktop channels :) We routinely see serious bugs first on Beta or Release ... - Kyle ___ dev-platform mailing

Re: Storage in Gecko

2013-05-02 Thread Kyle Huey
On Thu, May 2, 2013 at 4:36 PM, Gregory Szorc wrote: > We seemed to converge on a (presumably C++-based) storage service that has > named branches/buckets with specific consistency, flushing, etc guarantees. > Clients would obtain a handle on a "branch," and perform basic I/O > operations, includ

Re: smartmake-like functionality has landed in mach

2013-05-03 Thread Kyle Huey
On Fri, May 3, 2013 at 1:37 AM, Mike de Boer wrote: > I think it's much more an issue on Windows; there you need to build > browser each and every time. > Huh? I've been developing on windows for years and haven't seen this. - Kyle ___ dev-platform ma

MozillaBuild 1.7 Release

2013-05-09 Thread Kyle Huey
I am pleased to announce that (thanks to work by Ted) MozillaBuild 1.7 is available at http://ftp.mozilla.org/pub/mozilla.org/mozilla/libraries/win32/MozillaBuildSetup-Latest.exe This release contains: - Support for the 8.0 SDK with MSVC 2010 - Mercurial 2.5.4 - Python 2.7.4 - NSIS 2.22 has been r

No DOM bindings meeting this week

2013-05-13 Thread Kyle Huey
Due to the MoCo meeting the DOM bindings meeting for this week is cancelled. - Kyle ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: [Advance warning] Session Restore is changing, will break add-ons

2013-05-21 Thread Kyle Huey
On Tue, May 21, 2013 at 9:07 PM, David Rajchenbach-Teller < dtel...@mozilla.com> wrote: > As part of project Async, we have been working on refactoring Firefox’ > Session Restore to ensure that it does not block the main thread. Part > of the work has been cleaning up the code and the data structu

Re: Tree Closure for infrastructure work, Saturday June 1 from 1400 PDT to 2000 PDT

2013-05-29 Thread Kyle Huey
Is this happening on Saturday or Sunday? The email says both ... - Kyle On Thu, May 30, 2013 at 10:00 AM, Hal Wine wrote: > Hi. > > As noted below, we will have a tree closing maintenance window this > coming Saturday. The times given below include the time to bring the > trees back online. Mo

DOM Bindings Meeting - Monday @ 12:30 PM PDT

2013-06-17 Thread Kyle Huey
Our (ostensibly) weekly DOM bindings meetings continue on Monday June 17th at 12:30 PM PDT. Meeting details: * Monday, June 17, 2013, 12:30 PM PDT (3:30 PM EDT/9:30 PM CEST) * Conference room 7-N, San Francisco office, 7th floor. * Dial-in Info: - Vidyo room: Boris Zbarsky - In office or soft p

Re: Kyle Huey's Cycle Collector Talk Subtitled in WebVTT

2013-06-20 Thread Kyle Huey
On Thu, Jun 20, 2013 at 5:49 PM, Rick Eyre wrote: > The WebVTT team put together some quick subtitles for the video of Kyle's > cycle collection talk. > > Check it out if your interested at: > > http://rickeyre.ca/2013/06/20/webvtt-cycle-collector-demo.html > > Rick > That's a pretty slick demo.

Re: Making proposal for API exposure official

2013-06-24 Thread Kyle Huey
On Fri, Jun 21, 2013 at 1:45 PM, Andrew Overholt wrote: > Back in November, Henri Sivonen started a thread here entitled "Proposal: > Not shipping prefixed APIs on the release channel" [1]. The policy of not > shipping moz-prefixed APIs in releases was accepted AFAICT. > > I've incorporated that

Re: Code coverage take 2, and other code hygiene tools

2013-06-25 Thread Kyle Huey
On Tue, Jun 25, 2013 at 1:40 PM, L. David Baron wrote: > On Monday 2013-06-24 18:50 -0700, Clint Talbert wrote: > > So, the key things I want to know: > > * Will you support code coverage? Would it be useful to your work to > > have a regularly scheduled code coverage build & test run? > > * Woul

Re: Making proposal for API exposure official

2013-06-26 Thread Kyle Huey
On Wed, Jun 26, 2013 at 8:48 AM, Ehsan Akhgari wrote: > > The other question is, what we're going to do about negative feedback >>> from the API review phase but where the feedback cannot be incorporated >>> because of other concerns? >>> >> >> I was thinking the module owner (or I guess the DOM m

Re: MOZ_NOT_REACHED and JS_NOT_REACHED are now MOZ_ASSUME_UNREACHABLE, and other changes.

2013-06-28 Thread Kyle Huey
On Fri, Jun 28, 2013 at 7:04 PM, Justin Lebar wrote: > tl;dr - Changes from bug 820686: > > 1. We renamed MOZ_NOT_REACHED to MOZ_ASSUME_UNREACHABLE. > 2. In Gecko, please use MOZ_CRASH instead of MOZ_NOT_REACHED unless you > care > about code size or perf. > 3. In JS, we removed JS_NOT_REAC

Re: Replacing Gecko's URL parser

2013-07-04 Thread Kyle Huey
On Thu, Jul 4, 2013 at 1:45 AM, Anne van Kesteren wrote: > On Wed, Jul 3, 2013 at 4:08 PM, Benjamin Smedberg > wrote: > > I don't understand why it matters. chrome: and resource: are both > > gecko-specific extensions and we have no desire to standardize them. > > Chromium uses a different schem

MemShrink meeting: Tuesday July 9 2013 @ 4:00pm PDT

2013-07-09 Thread Kyle Huey
The wiki page for this meeting is at: https://wiki.mozilla.org/Performance/MemShrink Agenda: * Prioritize unprioritized MemShrink bugs. * Discuss how we measure progress. * Discuss approaches to getting more data. Meeting details: * Tue, 9 July, 4:00 PM PDT * Vidyo: SFO 7N Noise Pop * MTV: V

Using C++0x auto

2013-07-13 Thread Kyle Huey
We've dropped support for versions of MSVC prior to 2010, and we're requiring at least GCC 4.4. According to [0] that means we should be able to use *auto*. Anybody know any reasons why we can't start using it? - Kyle [0] http://wiki.apache.org/stdcxx/C%2B%2B0xCompilerSupport __

Re: Shutting off leak tests?

2013-07-15 Thread Kyle Huey
On Mon, Jul 15, 2013 at 3:05 PM, Alex Keybl wrote: > I think we can only make this decision once we know the worst case > scenario these tests are currently preventing, so that we can mitigate or > plan for it. > > -Alex > > On Jul 15, 2013, at 1:45 PM, Chris AtLee wrote: > > > Hi! > > > > Leak

Re: suggested reviewers for bugzilla products and components

2013-07-18 Thread Kyle Huey
On Thu, Jul 18, 2013 at 9:45 AM, Gregory Szorc wrote: > Would people be interested in adding this metadata to the tree? > Chromium has a per-directory OWNERS file. We could steal their setup. - Kyle ___ dev-platform mailing list dev-platform@lists.mo

Re: id2webidl

2013-07-22 Thread Kyle Huey
On Mon, Jul 22, 2013 at 7:45 AM, Andrea Marchesini wrote: > Hi all, > > this is my first email here. wow. > I'm writing this email because I spent several months converting IDL > components to WebIDL. > It's hard to find how many components have been converted, what is still > missing, etc, etc. >

Re: Do you consider to port mp3 support on Windows XP

2013-07-22 Thread Kyle Huey
On Mon, Jul 22, 2013 at 6:45 AM, wrote: > I'm working on a html 5 interactive player that 100% compatible with > Chrome from XP to Window 8. > I Saw that the support of mp3 and mp4 has been introduced in firefox on > v21 for win 7 and v22 for Vista. > > Do you consider to port these formats on Wi

Re: Changes to XPCOM refcounting

2013-07-23 Thread Kyle Huey
On Tue, Jul 23, 2013 at 11:22 AM, Joshua Cranmer 🐧 wrote: > As part of an effort to remove use of the NSPR atomic macros in favor of > mozilla::Atomic, the way that threadsafe reference counting works in XPCOM > has changed. Whereas before, this was done using the macros by saying > NS_IMPL_THREAD

DOM Bindings Meeting - Monday @ 12:30 PM PDT

2013-07-29 Thread Kyle Huey
Our (ostensibly) weekly DOM bindings meetings continue on Monday July 29th at 12:30 PM PDT. Meeting details: * Monday, July 29, 2013, 12:30 PM PDT (3:30 PM EDT/9:30 PM CEST) * Conference room 7-N, San Francisco office, 7th floor. * Dial-in Info: - Vidyo room: Boris Zbarsky - In office or soft p

Re: reminder: content processes (e10s) are now used by desktop Firefox

2013-07-30 Thread Kyle Huey
On Tue, Jul 30, 2013 at 5:05 PM, Tom Schuster wrote: > Do we run JS code in these? I can imagine all sorts of things that > would cause a crash if JS code can invoke random dom apis. I however > very happy that we are testing in a limited > fashion with this. > > Tom > Most of the content-expos

Re: On builds getting slower

2013-08-02 Thread Kyle Huey
On Fri, Aug 2, 2013 at 3:38 PM, Ehsan Akhgari wrote: > # Building faster >> >> One of our Q3 goals is to replace the "export tier" with something more >> efficient. More on tiers at [1]. This should make builds faster, >> especially on pymake. Just earlier this week we made WebIDL and XPIDL >> cod

Re: On builds getting slower

2013-08-02 Thread Kyle Huey
On Fri, Aug 2, 2013 at 8:59 PM, L. David Baron wrote: > khuey was also recently working on something to reduce some pretty > bad #include fanout related to the new DOM bindings generation. > (I'm not sure if it's landed.) > That was bug 887553. I'll land it on Monday. - Kyle __

Re: On builds getting slower

2013-08-02 Thread Kyle Huey
On Fri, Aug 2, 2013 at 9:12 PM, Kyle Huey wrote: > On Fri, Aug 2, 2013 at 8:59 PM, L. David Baron wrote: > >> khuey was also recently working on something to reduce some pretty >> bad #include fanout related to the new DOM bindings generation. >> (I'm not sure if

DOM Bindings Meeting - Monday @ 12:30 PM PDT

2013-08-05 Thread Kyle Huey
Our (ostensibly) weekly DOM bindings meetings continue on Monday August 4th at 12:30 PM PDT. Meeting details: * Monday, August 4, 2013, 12:30 PM PDT (3:30 PM EDT/9:30 PM CEST) * Conference room 7-N, San Francisco office, 7th floor. * Dial-in Info: - Vidyo room: Boris Zbarsky - In office or soft

Re: DOM Bindings Meeting - Monday @ 1:30 PM PDT (Note new time)

2013-08-05 Thread Kyle Huey
We pushed this back an hour due to the MoCo meeting today. Our (ostensibly) weekly DOM bindings meetings continue on Monday August 4th at 1:30 PM PDT. Meeting details: * Monday, August 4, 2013, 12:30 PM PDT (3:30 PM EDT/9:30 PM CEST) * Conference room 7-I, San Francisco office, 7th floor. * Dial

DOM Bindings Meeting - Monday @ 12:30 PM PDT

2013-08-26 Thread Kyle Huey
Our (ostensibly) weekly DOM bindings meetings continue on Monday August 26th at 12:30 PM PDT. Meeting details: * Monday, August 26, 2013, 12:30 PM PDT (3:30 PM EDT/9:30 PM CEST) * Conference room 7-N, San Francisco office, 7th floor. * Dial-in Info: - Vidyo room: Boris Zbarsky - In office or so

Refcounting threadsafety assertions are now fatal in opt builds.

2013-08-30 Thread Kyle Huey
The assertions that we have to catch refcounting objects on the wrong thread are now fatal in opt builds. This change is scoped to the nightly channel to avoid performance penalties on builds that are widely used, and will not propagate to aurora. See bug 907914 for more details. The motivation

MemShrink Meeting - September 3rd @ 4:00 PM PDT

2013-09-03 Thread Kyle Huey
The next MemShrink meeting will be brought to you by bugs 864932 and 894927. The wiki page for this meeting is at: https://wiki.mozilla.org/Performance/MemShrink Agenda: * Prioritize unprioritized MemShrink bugs. * Discuss how we measure progress. * Discuss approaches to getting more data. M

Re: nsTHashtable changes

2013-09-05 Thread Kyle Huey
Did you fix LDAP in comm-central to not use nsInterfaceHashtableMT? That's why I haven't finished Bug 849654. I guess that should get duped to wherever this happened. - Kyle On Thu, Sep 5, 2013 at 3:08 AM, Robert O'Callahan wrote: > nsTHashtable and its subclasses no longer have an Init metho

DOM Bindings Meeting - Monday @ 12:30 PM PDT

2013-09-08 Thread Kyle Huey
Our (ostensibly) weekly DOM bindings meetings continue on Monday September 8th at 12:30 PM PDT. Meeting details: * Monday, September 8, 2013, 12:30 PM PDT (3:30 PM EDT/9:30 PM CEST) * Conference room 7-N, San Francisco office, 7th floor. * Dial-in Info: - Vidyo room: Boris Zbarsky - In office o

Re: MemShrink Meeting - October 1 @ 4:00 PM PDT

2013-09-30 Thread Kyle Huey
We actually decided to cancel this meeting due to summit travel. - Kyle On Tue, Oct 1, 2013 at 6:41 AM, Jet Villegas wrote: > The next MemShrink meeting will be brought to you by bug 771765 > > The wiki page for this meeting is at: > >https://wiki.mozilla.org/Performance/MemShrink > > Agen

Re: Migrating to Win64 rev2 machines

2013-10-09 Thread Kyle Huey
Did we start caring about Win64 again recently? +bsmedberg - Kyle On Wed, Oct 9, 2013 at 7:33 PM, Jet Villegas wrote: > Excellent. > > Now to find willing volunteer(s.) Windows 64 represents a key platform for > us now that we've opened up Firefox for high-performance graphics via WebGL > and

Re: What platform features can we kill?

2013-10-11 Thread Kyle Huey
Are you sure? I thought we killed pluggable decoders a while back. - Kyle On Fri, Oct 11, 2013 at 7:48 PM, Boris Zbarsky wrote: > On 10/11/13 7:42 PM, Zack Weinberg wrote: > >> On 2013-10-11 1:08 PM, Ralph Giles wrote: >> >>> On 2013-10-10 12:28 PM, Steve Fink wrote: >>> >>> It seems like th

Debugging armv6 test failures

2013-10-23 Thread Kyle Huey
Is armv6 a tier 1 platform? Who can help with debugging test failures that only happen on armv6? - Kyle ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: Debugging armv6 test failures

2013-10-23 Thread Kyle Huey
Ok, I guess that changes it from "prefer to gouge my eyeballs out" to "only excruciatingly painful". - Kyle On Wed, Oct 23, 2013 at 6:51 PM, Ted Mielczarek wrote: > On 10/23/2013 3:11 AM, Kyle Huey wrote: > > Is armv6 a tier 1 platform? Who can help with d

Layer Construction for Off Main Thread

2013-10-30 Thread Kyle Huey
One thing that's come up that we're not quite how to deal with for OMT is how to modify GetCanvasLayer. Our problem here is that the context here lives on the worker thread, and presumably we need to construct the layer on the main thread, but creating that layer requires data that also lives on t

Re: Layer Construction for Off Main Thread

2013-10-30 Thread Kyle Huey
On Thu, Oct 31, 2013 at 12:36 PM, Robert O'Callahan wrote: > On Thu, Oct 31, 2013 at 5:28 PM, Kyle Huey wrote: > >> One thing that's come up that we're not quite how to deal with for >> OMT is >> how to modify GetCanvasLayer. Our problem here is that

Re: Patch (PoC) for bug 78414 ((PluginShortcuts) Application shortcut keys (keyboard commands such as f11, ctrl+t, ctrl+r) fail to operate when plug-in (flash, acrobat, quicktime) has focus)

2013-11-05 Thread Kyle Huey
On Tue, Nov 5, 2013 at 5:50 PM, Sergio López wrote: > Hi, > > I tried to attach this patch to bug 78414, but it wasn't possible as > posting new comments is not allowed. > > This proposal is a sensible workaround (as a "complete" solution would > require the collaboration of every single plugin d

Re: Pushes to Backouts on Mozilla Inbound

2013-11-05 Thread Kyle Huey
On Tue, Nov 5, 2013 at 10:44 PM, David Burns wrote: > We appear to be doing 1 backout for every 15 pushes on a rough average[4]. > This number I am sure you can all agree is far too high especially if we > think about the figures that John O'Duinn suggests[5] for the cost of each > push for runni

Re: XULRunner Developer Required

2013-11-30 Thread Kyle Huey
There is a jobs mailing list that this would be more appropriate on. https://lists.mozilla.org/listinfo/jobs - Kyle On Sat, Nov 30, 2013 at 1:23 PM, wrote: > On Saturday, November 30, 2013 6:12:52 PM UTC, Alex Jordan wrote: > hi Alex, > > i am very sorry i did not know where to post, i will t

DOM Bindings Meeting - Monday @ 12:30 PM PST

2013-12-02 Thread Kyle Huey
Our weeklyesque DOM bindings meetings continue on Monday Dec 2 at 12:30 PM PST. http://arewemeetingyet.com/Los%20Angeles/Mon/12:30 /w/DOM%20Bindings%20Meeting Meeting details: * Monday, November 18, 2013, 12:30 PM PST (3:30 PM EDT/9:30 PM CET) * Dial-in Info: - Vidyo room: Boris Zbarsky - Moun

Re: Can we start using C++ STL containers in Mozilla code?

2013-12-10 Thread Kyle Huey
On Tue, Dec 10, 2013 at 1:28 AM, Chris Pearce wrote: > Hi All, > > Can we start using C++ STL containers like std::set, std::map, std::queue > in Mozilla code please? Many of the STL containers are more convenient to > use than our equivalents, and more familiar to new contributors. > > I underst

DOM Bindings Meeting - Monday @ 12:30 PM PST

2013-12-16 Thread Kyle Huey
Our weeklyesque DOM bindings meetings continue on Monday Dec 16 at 12:30 PM PST. http://arewemeetingyet.com/Los%20Angeles/Mon/12:30 /w/DOM%20Bindings%20Meeting Meeting details: * Monday, December 16, 2013, 12:30 PM PST (3:30 PM EST/9:30 PM CET) * Dial-in Info: - Vidyo room: Boris Zbarsky __

Re: W3C Proposed Recommendation: Progress Events

2013-12-16 Thread Kyle Huey
On Mon, Dec 16, 2013 at 8:11 AM, L. David Baron wrote: > W3C recently published the following proposed recommendation (the > stage before W3C's final stage, Recommendation): > > http://www.w3.org/TR/progress-events/ > Progress Events > > There's a call for review to W3C member companies (of w

MemShrink Meeting - Tuesday, 7 January 2014 at 2:00 PM PST

2014-01-07 Thread Kyle Huey
Sorry for the short notice. The wiki page for this meeting is at: https://wiki.mozilla.org/Performance/MemShrink Agenda: * Prioritize unprioritized MemShrink bugs. * Discuss how we measure progress. * Discuss approaches to getting more data. Meeting details: * Tue, 7 January, 2:00 PM PST * h

Re: List of deprecated constructs [was Re: A proposal to reduce the number of styles in Mozilla code]

2014-01-07 Thread Kyle Huey
On Tue, Jan 7, 2014 at 11:29 AM, Benoit Jacob wrote: > For example, if I'm scanning a function for possible early returns (say I'm > debugging a bug where we're forgetting to close or delete a thing before > returning), I now need to scan for NS_ENSURE_SUCCESS in addition to > scanning for return.

DOM Bindings Meeting - Monday @ 12:30 PM PST

2014-01-13 Thread Kyle Huey
Our weeklyesque DOM bindings meetings continue on Monday Jan 13 at 12:30 PM PST. http://arewemeetingyet.com/Los%20Angeles/Mon/12:30 /w/DOM%20Bindings%20Meeting Meeting details: * Monday, January 13, 2014, 12:30 PM PST (3:30 PM EST/9:30 PM CET) * Dial-in Info: - Vidyo room: Boris Zbarsky ___

Re: Toolkit sub-module Preferred Reviewers who are not Toolkit Peers

2014-01-19 Thread Kyle Huey
On Sat, Jan 18, 2014 at 2:03 PM, Ms2ger wrote: > On 01/18/2014 08:51 PM, Matthew N. wrote: > >> Hello, >> >> What does it mean to be a "Preferred Reviewer" (previously called a >> "peer") in a Toolkit sub-module[1] and not be on the list of Toolkit >> Peers[2]? The Toolkit Code Review page[3] doe

Re: A proposal to reduce the number of styles in Mozilla code

2014-01-29 Thread Kyle Huey
On Wed, Jan 29, 2014 at 9:32 AM, Gregory Szorc wrote: > On 1/28/14, 7:15 PM, Anthony Jones wrote: >> >> On 28/01/14 13:08, Nicholas Nethercote wrote: In the meantime, we should wrap up the pending discussions about other changes to the style guide, such as 80/100/infinite columns, >

Presentations from the DOM team work week

2014-02-04 Thread Kyle Huey
The DOM team met in San Francisco last week and two recorded talks were given. Gecko Cycle Collector Intro by Olli Pettay and Andrew McCreight covers the cycle collector and a number of optimizations that we have made to it over the last couple years to trim the graph size. Video at: https://air.m

Re: Proposed W3C Charter: HTML5 Chinese Interest Group

2014-02-11 Thread Kyle Huey
On Wed, Feb 12, 2014 at 3:27 AM, L. David Baron wrote: > W3C is proposing a revised charter for the HTML5 Chinese Interest > Group. For more details, see: > http://www.w3.org/2013/12/html-ig-zh-charter.html > http://lists.w3.org/Archives/Public/public-new-work/2014Jan/0007.html > > Mozilla has th

Re: Non-technical comments in Bugzilla

2014-02-13 Thread Kyle Huey
On Fri, Feb 14, 2014 at 4:01 AM, Kartikaya Gupta wrote: > Hi all, > > Recently I've noted a significant increase in the number of bug comments > that are meta-information and not particularly relevant to the bug itself. > Often these comments are product/planning people moving the bug around > ask

Re: ISomething, nsISomething or mozISomething?

2014-02-17 Thread Kyle Huey
On Mon, Feb 17, 2014 at 6:36 AM, Boris Zbarsky wrote: > On 2/17/14 9:29 AM, Ms2ger wrote: >> >> For C++ interfaces, namespaced IFoo or Foo. > > > namespaced IFoo always makes me search MSDN for information about this > Windows interface we must be using... Why is that form preferable? > > -Boris

PSA: Don't write out multiple Add/RemoveObserver calls manually, iterate over an array instead

2014-02-17 Thread Kyle Huey
If you are observing several topics it's easy to forget to add a Remove call when adding new observer topic. If you instead write an array of topics and iterate over that it's impossible to screw up (e.g. https://hg.mozilla.org/mozilla-central/rev/3a8fe7c942e3). We've seen a couple of leaks cause

MFBT RefCounted and refcount logging

2014-02-18 Thread Kyle Huey
Are there plans to hook MFBT RefCounted/RefPtr/etc up to the refcount logging code in the near future? If not, I want to replace these constructs with our existing infrastructure within Gecko. - Kyle ___ dev-platform mailing list dev-platform@lists.mozi

Re: We live in a memory-constrained world

2014-02-21 Thread Kyle Huey
On Fri, Feb 21, 2014 at 5:07 PM, Jason Duell wrote: > On 02/21/2014 01:38 PM, Nicholas Nethercote wrote: >> >> Greetings, >> >> We now live in a memory-constrained world. By "we", I mean anyone >> working on Mozilla platform code. When desktop Firefox was our only >> product, this wasn't especiall

Re: We live in a memory-constrained world

2014-02-21 Thread Kyle Huey
On Fri, Feb 21, 2014 at 5:28 PM, Till Schneidereit wrote: > Does that mean that bug 964057[1] will automatically cause all self-hosting > state to be shared amongst content processes, too? > > [1]: https://bugzilla.mozilla.org/show_bug.cgi?id=964057 > > > On Sat, Feb 22,

Always brace your ifs

2014-02-22 Thread Kyle Huey
If you needed another reason to follow the style guide: https://www.imperialviolet.org/2014/02/22/applebug.html - Kyle ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: Always brace your ifs

2014-02-22 Thread Kyle Huey
On Sat, Feb 22, 2014 at 3:22 PM, Justin Dolske wrote: > On 2/22/14 7:18 AM, Kyle Huey wrote: >> >> If you needed another reason to follow the style guide: >> https://www.imperialviolet.org/2014/02/22/applebug.html > > > I don't really disagree with bra

Re: Always brace your ifs

2014-02-22 Thread Kyle Huey
On Sat, Feb 22, 2014 at 3:57 PM, Gregory Szorc wrote: > On Feb 22, 2014, at 8:18, Kyle Huey wrote: > >> If you needed another reason to follow the style guide: >> https://www.imperialviolet.org/2014/02/22/applebug.html >> > > Code coverage would have caught this as

Re: Always brace your ifs

2014-02-22 Thread Kyle Huey
On Sat, Feb 22, 2014 at 4:38 PM, Joshua Cranmer 🐧 wrote: > On 2/22/2014 5:22 PM, Justin Dolske wrote: >> >> But really, the best way to fix this would be to use a macro: >> >> err = SSLHashSHA1.update(&hashCtx, &foo); >> SSL_ENSURE_SUCCESS(err, err); >> err = SSLHashSHA1.update(&hashCtx, &ba

Re: Including Adobe CMaps

2014-02-24 Thread Kyle Huey
On Mon, Feb 24, 2014 at 3:01 PM, Andreas Gal wrote: > Is this something we could load dynamically and offline cache? > > Andreas > > Sent from Mobile. > >> On Feb 24, 2014, at 23:41, Brendan Dahl wrote: >> >> PDF.js plans to soon start including and using Adobe CMap files for >> converting chara

DOM Bindings Meeting - Monday @ 12:30 PM PST

2014-03-03 Thread Kyle Huey
Our (ostensibly) weekly DOM bindings meetings continue on Monday March 3rd at 12:30 PM PST. Meeting details: * Monday, March 3, 2014, 12:30 PM PST (3:30 PM EST/9:30 PM CET) * Dial-in Info: - Vidyo room: Boris Zbarsky - In office or soft phone: extension 92 - US/INTL: 650-903-0800 or 650-215-12

Using preferences off the main thread now asserts

2014-03-06 Thread Kyle Huey
It's taken over 3 years, but Bug 619487 is now fixed, and the preferences service will assert (fatally) if you try to use it off the main thread. This is currently disabled on b2g while I track down the last misuses of the pref service in b2g-specific code. After the next train leaves I plan to u

Bindings Meeting - Monday @ 12:30 PM PDT (Note timezone change)

2014-03-10 Thread Kyle Huey
Our (ostensibly) weekly DOM bindings meetings continue on Monday March 10th at 12:30 PM PDT. Note that because California switched to Daylight Saving Time this weekend, the meeting will be an hour earlier in Europe. Meeting details: * Monday, March 3, 2014, 12:30 PM PDT (3:30 PM EDT/8:30 PM CET)

Re: Intent to ship: @counter-style rule

2014-03-12 Thread Kyle Huey
On Wed, Mar 12, 2014 at 7:43 PM, Ehsan Akhgari wrote: > On 2014-03-12, 7:07 PM, Xidorn Quan wrote: >> >> We're planning to ship @counter-style rule and associated API >> CSSCounterStyleRule. >> >> Spec: http://dev.w3.org/csswg/css-counter-styles/ >> Bug: https://bugzilla.mozilla.org/show_bug.cgi?i

Changes to already_AddRefed and getter_AddRefs

2014-03-15 Thread Kyle Huey
I have made changes to already_AddRefed (Bug 967364) and getter_AddRefs (Bug 345123) to eliminate some potential mistakes that can be made with them. For already_AddRefed: - already_AddRefed::get() has been renamed to already_AddRefed::take(), to make the transfer of ownership of the pointer in q

Memory management in features implemented in JS

2014-03-19 Thread Kyle Huey
Followup to dev-platform please. We are discovering a lot of leaks in JS implemented DOM objects. The general pattern seems to be that we have a DOM object that also needs to listen to events from the message manager or notifications from the observer service, which usually hold strong references

Re: Memory management in features implemented in JS

2014-03-19 Thread Kyle Huey
lines a few years ago as a way to fight against leaks of > references to DOM by add-ons. > > On 3/20/14 12:39 AM, Kyle Huey wrote: >> Followup to dev-platform please. > > > -- > David Rajchenbach-Teller, PhD > Performance Team, Mozilla The issue is not leaking

Re: Having more control over when an IPDL message is compressed

2014-03-25 Thread Kyle Huey
On Tue, Mar 25, 2014 at 6:18 AM, Botond Ballo wrote: > Hello dev-platform, > > I recently fixed an APZ bug [1] that was caused by an IPDL message, > PBrowser::UpdateFrame, being compressed when it shouldn't have been. > > I think the compression was correct back when we didn't have subframe > scro

Re: Upcoming changes to automated Windows builds, and why you should consider switching away from pymake soon

2014-03-26 Thread Kyle Huey
On Thu, Mar 27, 2014 at 9:38 AM, Gregory Szorc wrote: > On 3/25/14, 6:21 PM, Mike Hommey wrote: >> >> Hi, >> >> In the coming days and weeks, there are going to be a few changes to how >> we do automated build on Windows, all in the interest of faster build >> times: >> - Shared compilation cache

Re: mozilla::Atomic considered harmful

2014-04-01 Thread Kyle Huey
On Wed, Apr 2, 2014 at 12:12 PM, L. David Baron wrote: > The issue here is whether this particular way of writing threadsafe > code leads people modifying that code to make mistakes because they > don't even notice that it's threadsafe code. I completely agree. And because using the current Atom

Re: New e10s tests on tinderbox

2014-04-08 Thread Kyle Huey
Not yet, because M-e10s is only running on Linux opt, and these test_IPC tests run everywhere in opt and debug. - Kyle On Apr 8, 2014 6:58 PM, "Shih-Chiang Chien" wrote: > Hi Bill, > > Many thanks for working on the M-e10s. Does it means we can remove all > these “test_ipc.html” mochitests? AFAI

Re: Policy for disabling tests which run on TBPL

2014-04-15 Thread Kyle Huey
On Tue, Apr 15, 2014 at 6:21 AM, jmaher wrote: > This policy will define an escalation path for when a single test case is > identified to be leaking or failing and is causing enough disruption on the > trees. Disruption is defined as: > 1) Test case is on the list of top 20 intermittent failure

mozilla::RefCounted/AtomicRefCounted are deprecated in Gecko

2014-04-15 Thread Kyle Huey
Please do not use mozilla::RefCounted/AtomicRefCounted in new code that lives in Gecko. Instead continue to use the NS_INLINE_DECL_REFCOUNTING/NS_INLINE_DECL_THREADSAFE_REFCOUNTING macros. The MFBT versions have a number of drawbacks including incomplete reference count logging, lack of various s

Re: Using rr to track down intermittent test failures

2014-04-16 Thread Kyle Huey
On Tue, Apr 15, 2014 at 4:14 PM, Gijs Kruitbosch wrote: > On 16/04/2014 00:05, Robert O'Callahan wrote: >> >> We just released rr 1.2 and I think this would be a good time for people >> to >> try to use it for one of the tasks it was designed for: debugging >> intermittent test failures. > > > Thi

Re: Landing c-c-breaking changes that remove c-c-only code from m-c

2014-04-17 Thread Kyle Huey
On Thu, Apr 17, 2014 at 12:09 AM, Henri Sivonen wrote: > I am not done preparing the removal patches yet, but with my current > patch queue I can already get 149 KB off of Android ARMv7 optimized > apk size and 138 KB off of Android ARMv7 optimized libxul size. (I'm > not sure what sort of size wi

Re: ASSERTION: bad size recorded: 'aInstanceSize == 0 || entry->GetClassSize() == aInstanceSize

2014-04-18 Thread Kyle Huey
On Fri, Apr 18, 2014 at 4:56 PM, Neil wrote: > L. David Baron wrote: > >> Classes that use the NS_IMPL_ISUPPORTSn or NS_IMPL_ADDREF + >> NS_IMPL_RELEASE macros should use the fully qualified class name and not >> depend on being inside namespace declarations. >> > > One of our compilers complains

Re: nsRefPtr vs RefPtr

2014-05-12 Thread Kyle Huey
On Mon, May 12, 2014 at 3:42 AM, Benoit Jacob wrote: > 2014-05-11 23:40 GMT-04:00 Boris Zbarsky : > >> On 5/11/14, 7:50 PM, Chris Pearce wrote: >> >>> Should we be preferring mozilla::RefPtr in new code? >>> >>> Should we be replacing nsRefPtr with mozilla::RefPtr? >>> >> >> I would err on "no" fo

Re: nsRefPtr vs RefPtr

2014-05-12 Thread Kyle Huey
On Mon, May 12, 2014 at 1:03 PM, Ehsan Akhgari wrote: > On 2014-05-12, 9:36 AM, Kyle Huey wrote: >>> >>> Since bug 806279 <https://bugzilla.mozilla.org/show_bug.cgi?id=806279> >>> it's >>>> >>>> fairly trivial to extend C

Re: Adding a recommendation that one-argument constructors be explicit to the C++ style guide

2014-05-12 Thread Kyle Huey
On Mon, May 12, 2014 at 1:07 PM, Boris Zbarsky wrote: > Background: in C++, one-argument constructors are implicit. > > What this means is that given this class declaration: > > class Foo { > public: > Foo(int arg); > > passAFoo(const Foo& arg); > }; > > This bit of C++: > > Foo fo

Re: nsRefPtr vs RefPtr

2014-05-12 Thread Kyle Huey
On Mon, May 12, 2014 at 2:46 PM, Mike Hommey wrote: > On Mon, May 12, 2014 at 09:36:22AM -0700, Kyle Huey wrote: >> We should get rid of RefPtr, just like we did the MFBT refcounting classes. >> >> The main thing stopping a mechanical search and replace is that the >&

Re: Intent to ship: Hyperlink Auditing ()

2014-05-16 Thread Kyle Huey
On Fri, May 16, 2014 at 6:30 AM, Curtis Koenig wrote: > > On 16 May, 2014, at 09:11 AM, Tim Taubert wrote: > >> I think it really might make sense to remove the >> preferences altogether > > > Given our stance on privacy[1] and commitment to Real Choices, Sensible > Settings and User Control; I

Re: Do we still need Trace Malloc?

2014-05-19 Thread Kyle Huey
On Mon, May 19, 2014 at 7:25 AM, Nicholas Nethercote wrote: > Hi, > > Do we still need Trace Malloc? I suspect it's barely used these days. > For memory profiling, we have about:memory and DMD. For shutdown leak > detection we have ASAN and Valgrind. > > Trace Malloc is documented here: > https://

Re: Firefox 29 users are having problems shutting down the browser

2014-06-09 Thread Kyle Huey
This was bug 1006478, no? - Kyle On Tue, Jun 10, 2014 at 8:20 AM, Vladan Djeric wrote: > User Advocacy reports that users of Firefox 29 are seeing Firefox take a > long time to shut down and that they are getting the "Firefox is already > running" error message (i.e. a locked profile) when they

Re: Intent to implement BackgroundSync API for FirefoxOS

2014-06-11 Thread Kyle Huey
Who is the point of contact on the DOM/WebAPI team for the spec side here? - Kyle On Thu, Jun 12, 2014 at 2:32 AM, Jed Parsons wrote: > Summary: From the explainer document [1], the proposed API "extends Service > Workers with a new onsync event. This is coupled with a new document-side > API >

Re: Intent to implement BackgroundSync API for FirefoxOS

2014-06-12 Thread Kyle Huey
On Thu, Jun 12, 2014 at 5:03 PM, Anne van Kesteren wrote: > On Thu, Jun 12, 2014 at 4:34 AM, Kyle Huey wrote: >> Who is the point of contact on the DOM/WebAPI team for the spec side here? > > I am following the GitHub repository since yesterday. And together > with Jonas discu

Re: Icon fonts in FxOS

2014-06-18 Thread Kyle Huey
On Wed, Jun 18, 2014 at 4:51 AM, Andreas Gal wrote: > > On Jun 18, 2014, at 2:03 AM, Vivien Nicolas wrote: > >> >> On 06/17/2014 09:18 PM, James Burke wrote: >>> On 6/17/14, 10:08 AM, Vivien Nicolas wrote: That's true. Actually there are many other hacks that depends on the fact that a

Re: NSS-for-Firefox build changes

2014-06-27 Thread Kyle Huey
Is #1 something we can backport to b2g-2.0? - Kyle On Fri, Jun 27, 2014 at 8:56 AM, Nathan Froyd wrote: > Hi all, > > Two changes to how NSS is built for Firefox's purposes have landed recently: > > 1. Bug 1018375 changed our build process on Android/B2G such that the > libnss3.so that we build

Re: Intent to implement: navigator.deviceStorage

2014-07-18 Thread Kyle Huey
On Fri, Jul 18, 2014 at 2:49 PM, Ehsan Akhgari wrote: > On 2014-07-18, 5:28 PM, Dave Hylands wrote: >> >> >> >> >> >> *From: *"Ehsan Akhgari" >> *To: *"Dave Hylands" >> *Cc: *"dev-platform" >> *Sent: *Frida

Re: Continued support for ESR

2014-08-01 Thread Kyle Huey
Can we at least adjust the ESR release length so that they fall on even numbered Geckos? Then they'll never end up on a version that is not shared with a b2g branch. - Kyle On Thu, Jul 31, 2014 at 10:18 PM, Lukas Blakk wrote: > Hello, > > When the ESR branch was initially created it was done so

Are StaticAuto/RefPtr good?

2014-08-03 Thread Kyle Huey
I've been trying to get leak testing working on b2g[0] and I've discovered a number of leaks[1][2][3] that are caused by StaticRefPtrs that are never cleared at shutdown. Static*Ptrs are there to avoid static constructors and destructors so they can't clear themselves at shutdown. That means that

Re: Are StaticAuto/RefPtr good?

2014-08-04 Thread Kyle Huey
On Sun, Aug 3, 2014 at 11:01 PM, Nicholas Nethercote wrote: > On Sun, Aug 3, 2014 at 10:18 PM, Kyle Huey wrote: >> Static*Ptrs are there to avoid >> static constructors and destructors so they can't clear themselves at >> shutdown. That means that they behave quite di

Re: Deprecating localstore.rdf

2014-08-04 Thread Kyle Huey
How many of these, if any, are used on b2g? - Kyle On Mon, Aug 4, 2014 at 2:06 PM, Gavin Sharp wrote: > This is certainly a big one, but > https://bugzilla.mozilla.org/showdependencytree.cgi?id=833098&maxdepth=1&hide_resolved=1 > suggests we will still need to worry about mimeTypes.rdf and > ins

<    1   2   3   4   >