Re: Phabricator Update, July 2017

2017-07-13 Thread David Anderson
On Thursday, July 13, 2017 at 1:38:18 PM UTC-7, Joe Hildebrand wrote: > I'm responding at the top of the thread here so that I'm not singling out any > particular response. > > We didn't make clear in this process how much work Mark and his team did > ahead of the decision to gather feedback fro

AsyncPanZoom enabled for one Nightly - 4/22/2015 - Windows E10S only

2015-04-21 Thread David Anderson
To get some feedback on AsyncPanZoom we are enabling it on tonight's nightly, for Windows only. It will be re-disabled in the next nightly. For those unfamiliar, APZ makes scrolling responsive by pre-rendering more content than what is visible in the viewport [1]. This lets us present it asynch

Re: AsyncPanZoom enabled for one Nightly - 4/22/2015 - Windows E10S only

2015-04-22 Thread David Anderson
On Wednesday, April 22, 2015 at 3:58:17 AM UTC-4, James May wrote: > On 22 April 2015 at 12:51, David Anderson <@gmail.com> wrote: > > > To get some feedback on AsyncPanZoom we are enabling it on tonight's > > nightly, for Windows only. It will be re

Re: Proposal to remove `aFoo` prescription from the Mozilla style guide for C and C++

2015-07-07 Thread David Anderson
+1 for removing this. Gecko's use is inconsistent, and outside of Gecko code that does use it, I've never seen it used in any other codebase. I've never gone to another project and thought, "I miss decorating everything in a way that changes capitalization and impairs canonical naming". Reasons

Re: Proposal to remove `aFoo` prescription from the Mozilla style guide for C and C++

2015-07-07 Thread David Anderson
+1 for removing this. Gecko's use is inconsistent, and outside of Gecko code that does use it, I've never seen it used in any other codebase. I've never gone to another project and thought, "I miss decorating everything in a way that changes capitalization and impairs canonical naming". Reasons

Proposal: Remove Linux PGO Testing

2012-10-10 Thread David Anderson
Hi, After being faced with the prospect of debugging Yet Another PGO-only Bug, I propose that we stop testing Linux PGO builds. One of these bugs is causing perma-red on Aurora (bug 799295). The developer cost of figuring out how to reproduce, debug, and fix these problems is quite high, and ev

Re: Proposal: Remove Linux PGO Testing

2012-10-10 Thread David Anderson
> > of Firefox?) But we're not doing mobile Linux PGO builds (that I know > > of), and I don't expect success with desktop PGO is much related to > > success with mobile PGO. > > > > -Justin > > > > On Wed, Oct 10, 2012 at 5:14 PM, David And

Re: Proposal: Remove Linux PGO Testing

2012-10-11 Thread David Anderson
Right, exactly. I am arguing that testing PGO, which is a buggy optimization pass, incurs too much developer cost to justify a "5-20%" talos improvement on select benchmarks. On Linux, which is a very small percentage of our market share, and where distributions make their own builds anyway. Wh

Re: Proposal: Remove Linux PGO Testing

2012-10-11 Thread David Anderson
Keep in mind that debug builds are probably at least an order of magnitude slower (or a large factor), whereas PGO is a very small factor. (After all, we do not PGO on Mac and it doesn't seem to be a problem.) -David On Thursday, October 11, 2012 12:05:35 AM UTC-7, Tim Taubert wrote: > On 10/10

Re: Proposal: Remove Linux PGO Testing

2012-10-11 Thread David Anderson
environment, we're already not supporting their configuration. C++ compilers are twitchy - much more so with PGO. -David On Thursday, October 11, 2012 7:46:00 AM UTC-7, Gervase Markham wrote: > On 11/10/12 08:54, David Anderson wrote: > > > Keep in mind that debug builds are p

Re: Proposal: Remove Linux PGO Testing

2012-10-11 Thread David Anderson
These Dromaeo improvements will in part be because IonMonkey is not fully JIT'ing these paths yet (a regression we're tracking from Firefox 17). -David On Thursday, October 11, 2012 11:26:49 AM UTC-7, Rafael Ávila de Espíndola wrote: > On 10/11/2012 02:33 AM, Mike Hommey wrote: > > > On Wed, O

Re: Proposal: Remove Linux PGO Testing

2012-10-12 Thread David Anderson
On Thursday, October 11, 2012 5:49:07 PM UTC-7, Brian Smith wrote: > I think it is important to give Linux users the fastest browser we can give > them, because: It's still unclear to me what our Linux PGO builds mean. Do distributions use them? If not, are they using the exact same compiler ver

Re: The future of PGO on Windows

2013-01-31 Thread David Anderson
On Thursday, January 31, 2013 8:54:50 AM UTC-8, Ehsan Akhgari wrote: > On 2013-01-31 10:59 AM, ... wrote: > > >> As a historical note, when we first enabled PGO support for Windows our > > >> profiling scenario was "start Firefox, wait 10 seconds, shut down > > >> Firefox". Enabling PGO with thi

Re: The future of PGO on Windows

2013-01-31 Thread David Anderson
On Thursday, January 31, 2013 12:40:13 PM UTC-8, Ehsan Akhgari wrote: > On 2013-01-31 2:49 PM, David Anderson wrote: > > > On Thursday, January 31, 2013 8:54:50 AM UTC-8, Ehsan Akhgari wrote: > > >> On 2013-01-31 10:59 AM, ... wrote: > > >> > > >&g