Using Google styling of #define guards

2019-07-03 Thread Bryce Seager van Dyk
Hi all, I wanted to clarify, and discuss if needed, our styling of #define guards. My understanding is that we are now using Google's style in regards to #define guards (https://google.github.io/styleguide/cppguide.html#The__define_Guard). I believe this would mean for `dom/media/foo/bar.h` I w

Re: Using Google styling of #define guards

2019-07-03 Thread Bryce Seager van Dyk
On Wednesday, July 3, 2019 at 2:27:30 PM UTC-7, Chris Peterson wrote: > On 7/3/2019 11:37 AM, Bryce Seager van Dyk wrote: > > I wanted to clarify, and discuss if needed, our styling of #define guards. > > My understanding is that we are now using Google's style in regards to

Re: precedence of Mozilla, Google, and clang-format styles for C++ code

2019-07-23 Thread Bryce Seager van Dyk
On Sunday, July 21, 2019 at 10:18:02 PM UTC-7, Karl Tomlinson wrote: > Near the top of > https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style > there is > > New code should try to conform to these standards, so it is as > > easy to maintain as existing code. [...] > > > > T

Re: PSA: mozilla::Result is about to understand move semantics

2019-08-12 Thread Bryce Seager van Dyk
On Monday, August 12, 2019 at 8:41:26 AM UTC-7, Emilio Cobos Álvarez wrote: > If you don't use mozilla::Result, then you can stop reading now. > > Result always returned the ok / errors by value. That's fine when the ok > or error values are cheap / small, like integers, but over time we've > be

Re: PSA: mozilla::Result is about to understand move semantics

2019-08-12 Thread Bryce Seager van Dyk
Thanks both for the clarifications. There is a use case that I'd like to clarify the performance + sanity of. I hope discussion here will be useful to others looking to use Result, but please let me know if it's more suitable to take elsewhere. In the Media stack I often want to return a Resu