Re: Adopting the black Python code style

2020-10-15 Thread Andrew Halberstadt
Thanks for driving this Ricky! I'm *very* excited for it. Just want to call out that you can use: $ ./mach lint -wo --fix to reformat all the files you have touched (either in the working directory or outgoing commits). For more usage docs, see: https://firefox-source-docs.mozilla.org/code-quali

sccache issues on Windows MSVC

2020-10-15 Thread Zachary Turner
Hi there, Not sure if this is the right place to ask this question. I'm trying out sccache on a non-Mozilla project and am running into 2 big issues on Windows. First issue is lack of precompiled header support. Without PCH a build with 0 cache hits takes upwards of 20 minutes, whereas with P

Re: sccache issues on Windows MSVC

2020-10-15 Thread Nick Alexander
On Thu, Oct 15, 2020 at 11:05 AM Zachary Turner wrote: > Hi there, > > Not sure if this is the right place to ask this question. I'm trying out > sccache on a non-Mozilla project and am running into 2 big issues on > Windows. > This isn't a good place to discuss this question. I think the best

Re: Adopting the black Python code style

2020-10-15 Thread Mike Hommey
Is black still opiniated about string types and insisting to use double quotes, when we mostly settled on single quotes? On Mon, Oct 12, 2020 at 10:00:56AM -0700, Ricky Stewart wrote: > Hello everyone, > > If you don't write Python code in mozilla-central, you can stop reading now. > > On Octobe