Re: Visual Studio Code integration with `clangd` for C/C++ development

2020-09-16 Thread Andi-Bogdan Postelnicu
> On 16 Sep 2020, at 04:14, Botond Ballo wrote: > > On Tue, Sep 15, 2020 at 6:55 PM Jean-Yves Avenard > wrote: > This broke several features for me (and I use VSCode all the time). One in > particular was the inability to switch between code and header (Ctrl-K > C

Re: Visual Studio Code integration with `clangd` for C/C++ development

2020-09-16 Thread Jean-Yves Avenard
Hi. Started to play with this. I've used VSCode for several years, though multi-process debugging capabilities make it a tad useless as a debugger. Now what we need is something like https://marketplace.visualstudio.com/items?itemName=vsdbgplat.MicrosoftChildProcessDebuggingPowerTool#overview So

Re: A new testing policy for code landing in mozilla-central

2020-09-16 Thread Eric Rescorla
On Tue, Sep 15, 2020 at 9:28 AM Andrew McCreight wrote: > On Tue, Sep 15, 2020 at 8:03 AM Brian Grinstead > wrote: > > > (This is a crosspost from firefox-dev) > > > > Hi all, > > > > We’re rolling out a change to the review process to put more focus on > > automated testing. This will affect yo

Re: A new testing policy for code landing in mozilla-central

2020-09-16 Thread Andrew McCreight
On Wed, Sep 16, 2020 at 5:10 AM Eric Rescorla wrote: > I certainly have some sympathy for this, but I'm not sure that it needs to > be > addressed via tools. What I would generally expect in cases like this is > that the reviewer says "why isn't there a test for X" and the author says > "for reas

Re: A new testing policy for code landing in mozilla-central

2020-09-16 Thread surkov.a...@gmail.com
Better test coverage is the best. Agreed, having a policy to force developers to add tests must be an efficient way to improve test coverage. I worried though it may reduce amount of contributions from the community since it complicates the development process: sometimes you have to spend more t

Re: A new testing policy for code landing in mozilla-central

2020-09-16 Thread Brian Grinstead
> On Sep 16, 2020, at 7:12 AM, surkov.a...@gmail.com > wrote: > > Better test coverage is the best. Agreed, having a policy to force developers > to add tests must be an efficient way to improve test coverage. I worried > though it may reduce amount of contributions from the community since i

Re: Visual Studio Code integration with `clangd` for C/C++ development

2020-09-16 Thread Botond Ballo
On Wed, Sep 16, 2020 at 3:00 AM Andi-Bogdan Postelnicu wrote: > On 16 Sep 2020, at 04:14, Botond Ballo wrote: > > On Tue, Sep 15, 2020 at 6:55 PM Jean-Yves Avenard > wrote: > >> This broke several features for me (and I use VSCode all the time). One in >> particular was the inability to switch