Dogfooding Warp

2020-09-15 Thread Jan de Mooij
Hi all, The SpiderMonkey (JS) team has been working on a significant update to our JITs called WarpBuilder (or just Warp) [0,1]. Before we enable Warp by default in Nightly (hopefully next cycle in 83) we need your help dogfooding it. Warp improves performance by reducing the amount of internal t

Re: Dogfooding Warp

2020-09-15 Thread Jared Wein (Mozilla)
Hi Jan, Thanks for the update and congratulations on reaching this milestone. Would you like to add Warp to the list of experimental features in about:preferences? When a feature is listed there, it will appear in crash stats and about:support, and also give users an easy way to enable/disable. F

A new testing policy for code landing in mozilla-central

2020-09-15 Thread Brian Grinstead
(This is a crosspost from firefox-dev) Hi all, We’re rolling out a change to the review process to put more focus on automated testing. This will affect you if you review code that lands in mozilla-central. ## TLDR Reviewers will now need to add a testing Project Tag in Phabricator when Accep

Re: A new testing policy for code landing in mozilla-central

2020-09-15 Thread Andrew Halberstadt
This change is fantastic, thanks for driving it! Reviewers should not need to feel bad about asking authors to go back and add tests, making this official policy removes that burden of guilt (just like how reviewbot removes the burden of pointing out linting nits). Authors can now grumble at the p

Re: A new testing policy for code landing in mozilla-central

2020-09-15 Thread Jonathan Kew
On 15/09/2020 16:03, Brian Grinstead wrote: > We’re rolling out a change to the review process to put more focus on automated testing. [...] As others have said, it's great that we're setting a clearer policy here - thanks! One thing did strike me as a little surprising, and could perhaps b

Re: A new testing policy for code landing in mozilla-central

2020-09-15 Thread Andrew McCreight
On Tue, Sep 15, 2020 at 8:03 AM Brian Grinstead wrote: > (This is a crosspost from firefox-dev) > > Hi all, > > We’re rolling out a change to the review process to put more focus on > automated testing. This will affect you if you review code that lands in > mozilla-central. > > ## TLDR > > Revie

Re: Intent to implement: Cookie SameSite=lax by default and SameSite=none only if secure

2020-09-15 Thread Daniel Veditz
On Tue, Sep 15, 2020 at 10:13 AM Michael Reeps wrote: > Thank you for the prompt response to my email. I guess I interpreted the > standard to mean only when the cookie was intended for cross-site delivery, > which these are not: > If the bug carries the SameSite=None attribute how could the bro

Re: A new testing policy for code landing in mozilla-central

2020-09-15 Thread Brian Grinstead
> On Sep 15, 2020, at 8:48 AM, Jonathan Kew wrote: > > On 15/09/2020 16:03, Brian Grinstead wrote: > > > We’re rolling out a change to the review process to put more focus on > > automated testing. [...] > > As others have said, it's great that we're setting a clearer policy here - > thanks!

Re: A new testing policy for code landing in mozilla-central

2020-09-15 Thread Andrew Halberstadt
On Tue, Sep 15, 2020 at 12:28 PM Andrew McCreight wrote: > I don't know that tests being an official requirement relieves the burden of guilt of asking for tests, as everybody already knows that tests are good and that you should always write tests I think this is largely true at Mozilla, but we

Re: A new testing policy for code landing in mozilla-central

2020-09-15 Thread Brian Grinstead
> On Sep 15, 2020, at 11:44 AM, Andrew Halberstadt wrote: > > On Tue, Sep 15, 2020 at 12:28 PM Andrew McCreight > wrote: >> I don't know that tests being an official requirement relieves the burden > of guilt of asking for tests, as everybody already knows that tests are > good and that you sh

Re: Visual Studio Code integration with `clangd` for C/C++ development

2020-09-15 Thread Jean-Yves Avenard
Hi. I don't know if that's related, but when recently VSCode started to show clangd as a recommended extension for the project. Which I installed. This broke several features for me (and I use VSCode all the time). One in particular was the inability to switch between code and header (Ctrl-K Ctrl

Re: Visual Studio Code integration with `clangd` for C/C++ development

2020-09-15 Thread Botond Ballo
On Tue, Sep 15, 2020 at 6:55 PM Jean-Yves Avenard wrote: > This broke several features for me (and I use VSCode all the time). One in > particular was the inability to switch between code and header (Ctrl-K > Ctrl-O). > clangd supports this, but it's under a custom command name (as it's not part