Re: Proposal to adjust testing to run on PGO builds only and not test on OPT builds

2019-01-21 Thread Jan de Mooij
On Fri, Jan 18, 2019 at 10:36 PM Joel Maher wrote: > Are there any concerns with this latest proposal? > This proposal sounds great to me. Thank you! Jan On Thu, Jan 17, 2019 at 12:52 PM Jan de Mooij wrote: > >> Hi Joel, >> >> Can you say more about this point in your original email: "3) This

Re: Proposal to adjust testing to run on PGO builds only and not test on OPT builds

2019-01-21 Thread James Graham
On 21/01/2019 10:18, Jan de Mooij wrote: On Fri, Jan 18, 2019 at 10:36 PM Joel Maher wrote: Are there any concerns with this latest proposal? This proposal sounds great to me. Thank you! +1. This seems like the right first step to me. ___ dev-pl

Re: Rust code coverage

2019-01-21 Thread Marco Castelluccio
Il 07/01/19 14:36, Henri Sivonen ha scritto: > On Fri, Jan 4, 2019 at 2:54 PM Marco Castelluccio > wrote: >> Hi everyone, >> we have recently enabled collecting code coverage for Rust code too, > Nice! > >> running Rust tests in coverage builds. > Does this mean running cargo test for each crate

Code Coverage on Phabricator

2019-01-21 Thread Marco Castelluccio
Hi everyone, We have recently implemented a solution to integrate code coverage results into Phabricator. Coverage information is uploaded either automatically for revisions after they are landed in mozilla-central (for example for release managers when looking at uplift requests), or on-demand f

Re: Code Coverage on Phabricator

2019-01-21 Thread mcastelluccio
Of course, sorry for the weird formatting... Here is the right version: Hi everyone, We have recently implemented a solution to integrate code coverage results into Phabricator. Coverage information is uploaded either automatically for revisions after they are landed in mozilla-central (for examp