Following up on this, no breakage whatsoever was reported, so I removed
the pref and the API from the tree in bug 1408301.
Thanks,
-- Emilio
On 3/23/18 7:23 PM, Emilio Cobos Álvarez wrote:
Hi,
Bug 1408301 tracks unshipping CSSStyleDeclaration.getPropertyCSSValue.
This is a non-standard API
Given that you are unshipping this... probably we should uplift a pref switch
to beta to make it unship in 61 directly, and then remove in 62. I think that's
probably safer than not unshipping it in 61 but removing directly in 62.
- Xidorn
On Sat, May 12, 2018, at 7:30 PM, Emilio Cobos Álvarez
Hmm, so my reasoning is that this had already been unshipped during 61
Nightly so that gave us two nightlies + one beta cycle. But unshipping
it in 61 entirely is probably better indeed.
Filed bug 1461092.
-- Emilio
On 5/12/18 1:03 PM, Xidorn Quan wrote:
Given that you are unshipping this..
It seems risky to remove the code (and then have the risk of doing
things that depend on the code being gone) until we've actually
shipped the pref-flip that turns the API off to release. (Or am I
misunderstanding, and that's already happened?) Until we've safely
shipped it to release, we can't r
On 5/12/18 9:26 PM, L. David Baron wrote:
It seems risky to remove the code (and then have the risk of doing
things that depend on the code being gone) until we've actually
shipped the pref-flip that turns the API off to release. (Or am I
misunderstanding, and that's already happened?) Until we
On Fri, May 11, 2018 at 4:06 PM, Gregory Szorc wrote:
> On Wed, May 9, 2018 at 11:01 AM, Ted Mielczarek
> wrote:
>
> > On Wed, May 9, 2018, at 1:11 PM, L. David Baron wrote:
> > > > mozregression won't be able to bisect into inbound branches then,
> but I
> > > > believe we've always been expiri
6 matches
Mail list logo
