[Firefox Desktop] Issues found: February 20th to February 24th

2017-02-27 Thread Cornel Ionce
Hi everyone, Here's the list of new issues found and filed by the Desktop Release QA Team last week, *February 20 - February 24* (week 8). Additional details on the team's priorities last week, as well as the plans for the current week are available at: https://public.etherpad-mozilla.o

Re: Doxygen output?

2017-02-27 Thread Andrew Sutherland
tps://clicky.visophyte.org/examples/searchfox/20170227/static-field-decl-comments.png https://clicky.visophyte.org/examples/searchfox/20170227/static-field-uses.png https://clicky.visophyte.org/examples/searchfox/20170227/method-def-decl-comment.png Andrew ___ dev-platf

PSA: ESLint no-undef rule now enabled for all of toolkit/

2017-02-27 Thread Mark Banner
The "no undefined" eslint rule has now been enabled for all of toolkit/ - this landed last Friday. The devmo page has been updated with further information about the rule and some of the flags that are occasionally necessary. Enabling it f

Re: Editing vendored crates

2017-02-27 Thread Henri Sivonen
On Mon, Feb 27, 2017 at 12:10 AM, Bobby Holley wrote: > Can you elaborate on what goes wrong here? This worked for ted's experiment > mentioned upthread, and for me on at least one occasion in > https://hg.mozilla.org/try/rev/18dc070e0308 (permalink: > https://pastebin.mozilla.org/8980438 ) > > Yo

Re: Please consider whether new APIs/functionality should be disabled by default in sandboxed iframes

2017-02-27 Thread David Bruant
Hi Boris, Did a particular feature triggered your message? Would it make sense to add the question to the "Intent to Implement" email template? https://wiki.mozilla.org/WebAPI/ExposureGuidelines#Intent_to_Implement "Intent to" emails seem like a good time to ask this questions/raise: * the feat

Re: Should cheddar-generated headers be checked in?

2017-02-27 Thread Henri Sivonen
On Mon, Feb 27, 2017 at 1:40 AM, Xidorn Quan wrote: >> When doing a parallel build, I see an interleave of C++ and Rust build >> system output. What guarantees that a build.rs that exports headers >> runs before the C++ compiler wants to see the headers? > > Oh, it's about C++ header generated fro

Re: Please consider whether new APIs/functionality should be disabled by default in sandboxed iframes

2017-02-27 Thread Boris Zbarsky
On 2/27/17 7:07 AM, David Bruant wrote: Did a particular feature triggered your message? No, it was just something I had been thinking about for a bit. Would it make sense to add the question to the "Intent to Implement" email template? https://wiki.mozilla.org/WebAPI/ExposureGuidelines#Inte

Re: Intent to implement: Frames timing functions

2017-02-27 Thread Boris Chiou
OK, sure. I will add a pref to protect it. Thanks for suggestion. On Sat, Feb 25, 2017 at 12:09 AM, wrote: > On Thursday, February 23, 2017 at 9:09:58 AM UTC-6, Boris Chiou wrote: > > *Preference behind which this will be implemented*: I'm not sure. I think > > we don't need it because it is jus

Re: Should cheddar-generated headers be checked in?

2017-02-27 Thread Henri Sivonen
On Mon, Feb 27, 2017 at 2:38 PM, Henri Sivonen wrote: > Is there some way to disable build.rs for a vendored crate (without > making cargo unhappy about the hashes)? (If the header is checked in, > compiling cheddar in order to generate it at build time is useless.) This seems not only relevant f

Re: Visual Studio Code recommended extensions

2017-02-27 Thread Marco Bonardo
On Mon, Feb 27, 2017 at 5:12 PM, Dan Mosedale wrote: > It sounds like you find it better than Atom. If that's true, any chance > you could elaborate on what you find particularly nicer and/or what's > missing? > Personally, I find it faster on common operations (starting up, opening documents)

Re: Editing vendored crates

2017-02-27 Thread Ralph Giles
On Mon, Feb 27, 2017 at 4:03 AM, Henri Sivonen wrote: > I find this level of difficulty (self-inflicted quasi-Tivoization > practically) an unreasonable impediment to practicing trivial Software > Freedom with respect to the vendored crates. I agree we need to fix the ergonomics here, but I don'

Re: Editing vendored crates

2017-02-27 Thread Henri Sivonen
On Mon, Feb 27, 2017 at 7:04 PM, Ralph Giles wrote: > On Mon, Feb 27, 2017 at 4:03 AM, Henri Sivonen wrote: > >> I find this level of difficulty (self-inflicted quasi-Tivoization >> practically) an unreasonable impediment to practicing trivial Software >> Freedom with respect to the vendored crat

Re: Editing vendored crates

2017-02-27 Thread Ted Mielczarek
On Mon, Feb 27, 2017, at 12:32 PM, Henri Sivonen wrote: > On Mon, Feb 27, 2017 at 7:04 PM, Ralph Giles wrote: > > On Mon, Feb 27, 2017 at 4:03 AM, Henri Sivonen wrote: > > > >> I find this level of difficulty (self-inflicted quasi-Tivoization > >> practically) an unreasonable impediment to practi

Re: Editing vendored crates

2017-02-27 Thread Henri Sivonen
On Mon, Feb 27, 2017 at 7:47 PM, Ted Mielczarek wrote: > On Mon, Feb 27, 2017, at 12:32 PM, Henri Sivonen wrote: >> We don't seem to need such change control beyond hg logs for e.g. the >> in-tree ICU or Skia, though. > > As someone who has maintained a vendored upstream C++ project (Breakpad) > f

Re: Editing vendored crates

2017-02-27 Thread Bobby Holley
On Mon, Feb 27, 2017 at 9:56 AM, Henri Sivonen wrote: > On Mon, Feb 27, 2017 at 7:47 PM, Ted Mielczarek > wrote: > > On Mon, Feb 27, 2017, at 12:32 PM, Henri Sivonen wrote: > >> We don't seem to need such change control beyond hg logs for e.g. the > >> in-tree ICU or Skia, though. > > > > As som

Re: Editing vendored crates

2017-02-27 Thread Henri Sivonen
On Mon, Feb 27, 2017 at 8:00 PM, Bobby Holley wrote: > FWIW, |cargo tree| is a very helpful tool to figure out who's pulling in a > crate. Thanks, but what I'm trying to figure out isn't whose pulling it in (the style crate is) but whether it is actually used beyond an always-None Option in a way

Re: Editing vendored crates

2017-02-27 Thread Simon Sapin
On 27/02/17 19:30, Henri Sivonen wrote: On Mon, Feb 27, 2017 at 8:00 PM, Bobby Holley wrote: FWIW, |cargo tree| is a very helpful tool to figure out who's pulling in a crate. Thanks, but what I'm trying to figure out isn't whose pulling it in (the style crate is) but whether it is actually us

Re: Editing vendored crates

2017-02-27 Thread Henri Sivonen
On Mon, Feb 27, 2017 at 8:47 PM, Simon Sapin wrote: > As an aside, I have a plan to remove rust-encoding entirely from Servo > (including Stylo) and use encoding_rs instead. But doing this the way I want > to has a number of prerequisites, and I’d prefer to switch everything at > once to avoid hav

Re: Should cheddar-generated headers be checked in?

2017-02-27 Thread Henri Sivonen
On Mon, Feb 27, 2017 at 5:57 PM, Henri Sivonen wrote: > Maybe having the header generation as part of build.rs is more trouble > than it's worth in the first place... Now that the build.rs in commented out in the crates.io crate and the generated header is shipped in the crates.io crate: Consider

Re: Should cheddar-generated headers be checked in?

2017-02-27 Thread Simon Sapin
On 27/02/17 19:57, Henri Sivonen wrote: On Mon, Feb 27, 2017 at 5:57 PM, Henri Sivonen wrote: Maybe having the header generation as part of build.rs is more trouble than it's worth in the first place... Now that the build.rs in commented out in the crates.io crate and the generated header is

Re: Should cheddar-generated headers be checked in?

2017-02-27 Thread Kartikaya Gupta
On Mon, Feb 27, 2017 at 1:57 PM, Henri Sivonen wrote: > Now that the build.rs in commented out in the crates.io crate and the > generated header is shipped in the crates.io crate: > Considering that editing the vendored crates is not allowed, so I > can't put moz.build files on the path to the hea

Re: Embeddable Browser

2017-02-27 Thread Myk Melez
Rodolpho Porto 2017 February 23 at 10:44 Hello Friend, its a Java SWT application using XulRunner to create the Browser object, setting the xulrunner properties (i.e. org.eclipse.swt.browser.XulRunnerPath), and using a few browser configurations like TLS 1.2