Hi everyone,
Here's the list of new issues found and filed by the Desktop Release QA
team last week, *March 21 - March 25* (week 12).
Additional details on the team's priorities last week, as well as the
plans for the current week are available at:
https://public.etherpad-mozilla.org/p/D
> "Paul" == Paul Adenot writes:
Paul> Do we know whether `set follow-fork-mode child` in gdb would work ? If
Paul> not, can we fix it ? It would be a pretty good experience for most
Paul> developers that only care about the child.
I try it from time to time and file bugs with upstream gdb fo
(Everyone, start your bikesheds.)
The style guidelines at
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style
indicate that #includes are to be sorted. It does not say whether or not
to consider case when doing so (and if so, which case goes first?). That
is, should it be
On Mon, Mar 28, 2016 at 1:28 PM, David Keeler wrote:
> (Everyone, start your bikesheds.)
>
> The style guidelines at
>
> https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style
> indicate that #includes are to be sorted. It does not say whether or not
> to consider case when
We need to be careful with shuffling around #includes as there can be
ordering dependencies that are not obvious at a glance.
Further, I don't think this is something worthwhile until we have a script
that enforces said ordering.
Thanks,
Jared
On Mon, Mar 28, 2016 at 5:20 PM, Nicholas Alexander
On 2016/03/29 7:18, Jared Wein wrote:
> We need to be careful with shuffling around #includes as there can be
> ordering dependencies that are not obvious at a glance.
Especially, #include "Foo.h" should be put first in Foo.cpp regardless
of the alphabetical order to avoid introducing such depende
On Mon, Mar 28, 2016 at 3:31 PM, Masatoshi Kimura
wrote:
> On 2016/03/29 7:18, Jared Wein wrote:
> > We need to be careful with shuffling around #includes as there can be
> > ordering dependencies that are not obvious at a glance.
>
> Especially, #include "Foo.h" should be put first in Foo.cpp re
David Keeler:
> The style guidelines at
> https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style
> indicate that #includes are to be sorted. It does not say whether or not
> to consider case when doing so (and if so, which case goes first?). That
> is, should it be:
>
> #inc
a) It's explained in the style docs:
1. The main header: Foo.h in Foo.cpp
2. Standard library includes: #include
3. Mozilla includes: #include "mozilla/dom/Element.h"
Thus you'd want the second
b) I'm assuming it includes the path. That's what I've seen most of the
code do too and it m
Any reason not to adopt SpiderMonkey's check_spidermonkey_style.py? It
deals almost exclusively with header and include related things, and not
indent levels, line lengths, or other things that gecko style disagrees
with.
https://dxr.mozilla.org/mozilla-central/source/config/check_spidermonkey_sty
10 matches
Mail list logo
