Re: dialog=1 for window.open from content

2015-10-02 Thread Mike Taylor
On 10/2/15 2:53 AM, Ehsan Akhgari wrote: Before I go whole-hog trying to fix bug 1095236, I'm curious to know if we really want to continue supporting dialog=1 from content, or if it's safe to just ignore that feature like the other browser engines (which I think would be the fastest path towar

Re: Disabling C++ tests by default?

2015-10-02 Thread Sylvestre Ledru
Le 02/10/2015 07:10, Gregory Szorc a écrit : > Currently, the Firefox build system builds C++ tests by default. This adds > extra time to builds for something that a significant chunk of developers > don't care about because they don't run them. > > Is disabling building C++ tests by default a re

What is the Mac bundle id of Firefox?

2015-10-02 Thread Frédéric Wang
Hi all, I've recently tried to fix an accessibility bug on Mac (see https://bugzilla.mozilla.org/show_bug.cgi?id=718637). According to Apple developers, VoiceOver must white list Firefox as a "web browser" so that it can react to AXLoadComplete notifications normally. For that purpose, we need to

What is the Mac bundle id of Firefox?

2015-10-02 Thread Frédéric Wang
Hi all, I've recently tried to fix an accessibility bug on Mac (see https://bugzilla.mozilla.org/show_bug.cgi?id=718637). According to Apple developers, VoiceOver must white list Firefox as a "web browser" so that it can react to AXLoadComplete notifications normally. For that purpose, we need to

What is the Mac bundle id of Firefox?

2015-10-02 Thread Frédéric WANG
Hi all, I've recently tried to fix an accessibility bug on Mac (see https://bugzilla.mozilla.org/show_bug.cgi?id=718637). According to Apple developers, VoiceOver must white list Firefox as a "web browser" so that it can react to AXLoadComplete notifications normally. For that purpose, we need to

Re: What is the Mac bundle id of Firefox?

2015-10-02 Thread Gijs Kruitbosch
The source code says: https://dxr.mozilla.org/mozilla-central/search?q=MOZ_APP_DISPLAYNAME+path%3Abranding&redirect=true&case=true&limit=63&offset=0 So for the purposes of OS X, I believe the current list is: Firefox Nightly FirefoxDeveloperEdition B2G (I *think* there is a way to build b2g st

Re: Building js/xul/css from Firefox faster

2015-10-02 Thread Neil
Mike Hommey wrote: ./mach build faster So is this the complete opposite of ./mach build binaries? -- Warning: May contain traces of nuts. ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: What is the Mac bundle id of Firefox?

2015-10-02 Thread Ben Hearsum
This list looks right to me, based on my memories of dealing with code signing changes for 10.10. You can confirm this by downloading Nightly, Aurora, Beta, Release, and ESR and having a look for CFBundleIdentifier in Contents/MacOS/Info.plist in each. On 2015-10-02 07:47 AM, Gijs Kruitbosch wrote

Re: Disabling C++ tests by default?

2015-10-02 Thread Eric Rescorla
On Thu, Oct 1, 2015 at 10:25 PM, Mike Hommey wrote: > On Thu, Oct 01, 2015 at 10:10:39PM -0700, Gregory Szorc wrote: > > Currently, the Firefox build system builds C++ tests by default. This > adds > > extra time to builds for something that a significant chunk of developers > > don't care about

Re: What is the Mac bundle id of Firefox?

2015-10-02 Thread Frédéric WANG
Thank you, I downloaded the Firefox builds on mozilla.org and verified the CFBundleIdentifier. I believe the relevant ids that we should ask Apple to white list are: org.mozilla.firefox (Firefox release and beta) org.mozilla.firefoxdeveloperedition (Firefox Developer Edition) org.mozilla.nightlyd

Re: Disabling C++ tests by default?

2015-10-02 Thread Randell Jesup
>On Thu, Oct 1, 2015 at 10:25 PM, Mike Hommey wrote: > >> On Thu, Oct 01, 2015 at 10:10:39PM -0700, Gregory Szorc wrote: >> > Currently, the Firefox build system builds C++ tests by >> > default. This adds extra time to builds for something that a >> > significant chunk of developers don't care ab

Re: Disabling C++ tests by default?

2015-10-02 Thread Eric Rescorla
On Fri, Oct 2, 2015 at 9:08 AM, Randell Jesup wrote: > >On Thu, Oct 1, 2015 at 10:25 PM, Mike Hommey wrote: > > > >> On Thu, Oct 01, 2015 at 10:10:39PM -0700, Gregory Szorc wrote: > >> > Currently, the Firefox build system builds C++ tests by > >> > default. This adds extra time to builds for so

Re: Building js/xul/css from Firefox faster

2015-10-02 Thread Gregory Szorc
On Fri, Oct 2, 2015 at 5:44 AM, Neil wrote: > Mike Hommey wrote: > > ./mach build faster >> >> So is this the complete opposite of ./mach build binaries? It complements `mach build binaries` and offers a mostly distinct set of tasks, yes. ___ dev-pla

Re: Disabling C++ tests by default?

2015-10-02 Thread Jonas Sicking
It might still mean that we can save time on tryserver if we only build these by default if the user has opted in to running the relevant tests. I agree with Gregory. I really don't see much value in building these binaries by default. For the people that use them often enough that they are worth

Re: Disabling C++ tests by default?

2015-10-02 Thread Gregory Szorc
On Thu, Oct 1, 2015 at 10:12 PM, Kyle Huey wrote: > How much time does it save? > On my MBP, removing all CPP_UNIT_TESTS from moz.builds (which also stops the production of a few static libraries): -141s CPU time (6831s total, so 2%) -16s wall time `mach build binaries` also consumed a fra

Re: Disabling C++ tests by default?

2015-10-02 Thread Ehsan Akhgari
On 2015-10-02 2:42 PM, Jonas Sicking wrote: It might still mean that we can save time on tryserver if we only build these by default if the user has opted in to running the relevant tests. I agree with Gregory. I really don't see much value in building these binaries by default. For the people t

Re: Disabling C++ tests by default?

2015-10-02 Thread Bobby Holley
On Fri, Oct 2, 2015 at 1:03 PM, Ehsan Akhgari wrote: > On 2015-10-02 2:42 PM, Jonas Sicking wrote: > >> It might still mean that we can save time on tryserver if we only >> build these by default if the user has opted in to running the >> relevant tests. >> >> I agree with Gregory. I really don't

Re: Disabling C++ tests by default?

2015-10-02 Thread Gregory Szorc
On Fri, Oct 2, 2015 at 1:40 PM, Bobby Holley wrote: > On Fri, Oct 2, 2015 at 1:03 PM, Ehsan Akhgari > wrote: > >> On 2015-10-02 2:42 PM, Jonas Sicking wrote: >> >>> It might still mean that we can save time on tryserver if we only >>> build these by default if the user has opted in to running th

Re: Disabling C++ tests by default?

2015-10-02 Thread Bobby Holley
Cool - thanks for checking Greg! On Fri, Oct 2, 2015 at 1:57 PM, Gregory Szorc wrote: > On Fri, Oct 2, 2015 at 1:40 PM, Bobby Holley > wrote: > >> On Fri, Oct 2, 2015 at 1:03 PM, Ehsan Akhgari >> wrote: >> >>> On 2015-10-02 2:42 PM, Jonas Sicking wrote: >>> It might still mean that we can

Re: Disabling C++ tests by default?

2015-10-02 Thread Mike Hommey
On Fri, Oct 02, 2015 at 10:01:45AM -0700, Eric Rescorla wrote: > > Because the win is small, it shouldn't be a priority, but requiring > > something like --enable-cpp-tests should be ok to do (and of course > > automation would do that) if/when someone finds time. With the way the build system wor

Re: Disabling C++ tests by default?

2015-10-02 Thread Eric Rescorla
On Fri, Oct 2, 2015 at 3:31 PM, Mike Hommey wrote: > On Fri, Oct 02, 2015 at 10:01:45AM -0700, Eric Rescorla wrote: > > > Because the win is small, it shouldn't be a priority, but requiring > > > something like --enable-cpp-tests should be ok to do (and of course > > > automation would do that) i

Re: Disabling C++ tests by default?

2015-10-02 Thread Ted Mielczarek
On Fri, Oct 2, 2015, at 04:40 PM, Bobby Holley wrote: > On Fri, Oct 2, 2015 at 1:03 PM, Ehsan Akhgari > wrote: > > > On 2015-10-02 2:42 PM, Jonas Sicking wrote: > > > >> It might still mean that we can save time on tryserver if we only > >> build these by default if the user has opted in to runni