Re: PSA: MOZ_OVERRIDE and MOZ_FINAL are gone

2015-03-22 Thread Philip Chee
On 22/03/2015 00:37, Ehsan Akhgari wrote: > I just landed bug 1145631, which removes the MOZ_OVERRIDE and MOZ_FINAL > macros. Please use the override and final keywords from now on. > > Cheers, http://mxr.mozilla.org/comm-central/search?string=MOZ_FINAL Too many hits, displaying the first 1000

Re: PSA: MOZ_OVERRIDE and MOZ_FINAL are gone

2015-03-22 Thread Mike Hommey
On Sun, Mar 22, 2015 at 03:03:32PM +0800, Philip Chee wrote: > On 22/03/2015 00:37, Ehsan Akhgari wrote: > > I just landed bug 1145631, which removes the MOZ_OVERRIDE and > > MOZ_FINAL macros. Please use the override and final keywords from > > now on. > > > > Cheers, > > http://mxr.mozilla.org/

Re: PSA: MOZ_OVERRIDE and MOZ_FINAL are gone

2015-03-22 Thread cpearce
Are the override and final keywords available only in Gecko 39 onwards, or can we assume that these keywords will work in earlier branches? For example, say I have a patch using these keywords that needs to be uplifted to Aurora or Beta, should I use the old macros in the uplifted patch and not

Re: PSA: MOZ_OVERRIDE and MOZ_FINAL are gone

2015-03-22 Thread Bob Owen
On Sun, Mar 22, 2015 at 8:43 AM, wrote: > > Are the override and final keywords available only in Gecko 39 onwards, or can we assume that these keywords will work in earlier branches? > > For example, say I have a patch using these keywords that needs to be uplifted to Aurora or Beta, should I use

Re: PSA: MOZ_OVERRIDE and MOZ_FINAL are gone

2015-03-22 Thread Ehsan Akhgari
On 2015-03-22 3:03 AM, Philip Chee wrote: On 22/03/2015 00:37, Ehsan Akhgari wrote: I just landed bug 1145631, which removes the MOZ_OVERRIDE and MOZ_FINAL macros. Please use the override and final keywords from now on. Cheers, http://mxr.mozilla.org/comm-central/search?string=MOZ_FINAL Too